fix(cli): exclude clip-path-hidden text from inspect layout and contrast audits (#1821)

* fix(cli): exclude clip-path-hidden text from inspect layout and contrast audits

A clip-path can shrink an element's painted region to nothing (a typewriter
span pre-reveal at clip-path: inset(0 100% 0 0), or circle(0px)) while its
layout box, opacity, visibility and display all still read as present. Such
an element paints zero pixels, so the layout audit flagged the visible block
beneath it as a content_overlap, and the contrast auditor measured it as a
meaningless background-on-background ratio (~1:1) and reported a WCAG failure.

Both auditors already filtered opacity:0, visibility:hidden and display:none,
but neither accounted for clip-path. Add a shared check: when a non-none
clip-path is in effect on the element or an ancestor, probe a grid of points
across the element's box with elementFromPoint; if none resolve to the element
or a descendant, it is clipped to nothing and is skipped. The probe runs only
when a clip-path is present, so a genuinely occluded (but unclipped) element is
still measured and still flagged.

Wired at the in-page collection chokepoint so it covers content_overlap,
text_occluded and the contrast auditor consistently. Genuine overlaps between
visible elements remain flagged; data-layout-allow-overlap and
data-layout-ignore are honored unchanged. The two audit scripts and the
layout-audit test are added to the fallow ignore lists: their pre-existing
IIFE-level complexity and per-rule test scaffold re-flag under the line-shift
fingerprint when the small probe helpers are inserted.

* test(cli): cover clip-path audit edge cases

* fix(cli): satisfy clip audit test types
This commit is contained in:
Miguel Ángel
2026-06-30 20:49:07 -07:00
committed by GitHub
parent d1038918bb
commit a7d0ab2d61
4 changed files with 221 additions and 3 deletions
@@ -45,6 +45,45 @@ window.__contrastAudit = async function (imgBase64, time) {
return s[Math.floor(s.length / 2)];
}
function hasClipPath(el) {
for (var ce = el; ce; ce = ce.parentElement) {
var cp = getComputedStyle(ce).clipPath;
if (cp && cp !== "none") return true;
}
return false;
}
var CLIP_PROBE_COLS = [0.05, 0.25, 0.5, 0.75, 0.95];
var CLIP_PROBE_ROWS = [0.25, 0.5, 0.75];
function paintsAnyProbePoint(el, rect) {
// Keep probe resolution aligned with layout-audit.browser.js. Edge strips
// narrower than the nearest probe point are treated as clipped away to
// avoid noisy typewriter pre-reveal contrast reports.
for (var ci = 0; ci < CLIP_PROBE_COLS.length; ci++) {
for (var ri = 0; ri < CLIP_PROBE_ROWS.length; ri++) {
var x = rect.left + rect.width * CLIP_PROBE_COLS[ci];
var y = rect.top + rect.height * CLIP_PROBE_ROWS[ri];
var hit = document.elementFromPoint(x, y);
if (hit === el || el.contains(hit)) return true;
}
}
return false;
}
// A clip-path can shrink an element's painted region to nothing (a typewriter
// span pre-reveal at `inset(0 100% 0 0)`, or `circle(0px)`) while its box and
// colours read normally; it then paints zero pixels and measures a meaningless
// background-on-background ratio. clip-path drives hit-testing, so a fully
// clipped element is unreachable by elementFromPoint across its box. Probe only
// when a clip-path is in effect (self or ancestor) so genuinely-occluded but
// unclipped text is not skipped.
function isClippedAway(el, rect) {
if (typeof document.elementFromPoint !== "function") return false;
if (!hasClipPath(el)) return false;
return !paintsAnyProbePoint(el, rect);
}
// Decode screenshot into canvas pixel data
var img = new Image();
await new Promise(function (resolve) {
@@ -110,6 +149,7 @@ window.__contrastAudit = async function (imgBase64, time) {
var rect = el.getBoundingClientRect();
if (rect.width < 8 || rect.height < 8) continue;
if (rect.right <= 0 || rect.bottom <= 0 || rect.left >= w || rect.top >= h) continue;
if (isClippedAway(el, rect)) continue;
var fg = parseColor(cs.color);
if (fg[3] <= 0.01) continue;