ext/hyperframes
2
0
Fork 0
mirror of https://github.com/heygen-com/hyperframes.git synced 2026-09-07 10:06:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(studio): half-lit group solo compares bare DOM ids too

Browse Source 
A fifth face of the id-space mismatch, not in the review's list.
TimelineGroupRow built its member list from `el.key ?? el.id` and handed
it to isGroupHalfLitUnderSolo, which compares against the soloed set —
bare DOM ids now that the header pushes them that way. Soloing a member
lit nothing on its group, the one signal that says "some of what is
under here still plays".

Found by auditing every consumer of `soloed` rather than trusting the
handoff's claim that this call site "happens to pass the bare id" — it
passes a bare id for the GROUP and store keys for its MEMBERS.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Vance Ingalls
2026-08-20 16:39:34 -07:00
co-authored by Claude Opus 5
parent 5850a0c978
commit a8d27820ba
2 changed files with 24 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/studio/src/player/components/TimelineGroupRow.tsx
+5 -1
View File
@@ -1,6 +1,7 @@
import type { TimelineElement } from "../store/playerStore";
import { usePlayerStore } from "../store/playerStore";
import { isGroupHalfLitUnderSolo } from "../store/audioSoloSlice";
import { runtimeAudioId } from "../lib/timelineElementHelpers";
import {
HF_AUDIO_FX_ATTR,
serializeAudioFxChain,
@@ -65,7 +66,10 @@ export function TimelineGroupRow({
const domEditActions = useDomEditActionsContextOptional();
const soloed = usePlayerStore((s) => s.soloed);
const toggleSolo = usePlayerStore((s) => s.toggleSolo);
const memberIds = memberElements.map((el) => el.key ?? el.id);
// Bare DOM ids: this list is compared against the `soloed` set, which the
// runtime matches on `el.id` (see `runtimeAudioId`). Store keys here made the
// half-lit state unreachable — soloing a member lit nothing on its group.
const memberIds = memberElements.map(runtimeAudioId).filter((id): id is string => id !== null);
const writeGroupFxChain = (next: HfAudioFxChain, live: boolean) => {
const value = next.nodes.length ? serializeAudioFxChain(next) : null;
if (live) onSetAudioGroupAttributeLive?.(group.id, HF_AUDIO_FX_ATTR, value);