mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-19 11:26:02 +00:00
fix(cli): no auto-update across 0.x minors; install skills at the CLI's release tag (#7013)
* fix(cli): no auto-update across 0.x minors; install skills at the CLI's release tag - autoUpdate: before 1.0 a minor bump counts as a major one, so 0.8.x -> 0.9.x is a notice, not a silent background install. From 1.0 on, the major alone. - skills: `skills update` / bare `skills` / `init` install from heygen-com/hyperframes#v<VERSION>, and `skills check` plus the background freshness nudge read the manifest at the same tag. A build the repo has no tag for (dev build) falls back to main, as before. - skills: run the upstream installer as `npx skills@1.7.4` instead of an unpinned `npx skills`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cli): keep the comment share of the touched files from rising Comment ratchet: trim the comments added in the previous commit. No code change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cli): pass the CLI version into the skills check instead of importing it scripts/clawhub-unlist-retired.mjs loads skillsManifest.ts from source under plain node, which cannot resolve a relative `../version.js` import. Callers now pass `cliVersion` (and skillsSourceRef takes it as an argument), so the module keeps importing only node builtins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cli): read skills at the CLI's tag without a probe; pin skills@1.5.13 - A release build reads the manifest at its own tag directly (publish pushes the tag before npm publish). Only a 404 for that manifest falls back to main; a timeout, missing git or proxy error now surfaces instead of quietly comparing against main, so the background nudge can't cache a false "outdated" count. - checkSkills returns the ref it read, and skills update installs from that same ref, so check and install can't disagree within one run. - Pin skills@1.5.13 (it parses `#<ref>` too) so the pin matches the version agentDirs.generated.ts and the lock-path notes were checked against. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(cli): split the tag and main manifest fetches Fallow flagged fetchRemoteManifest's CRAP score (31.6 > 30). The tag fetch (404 is the only fallback to main) and the SHA-pinned main fetch are now their own functions. No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cli): never auto-upgrade a Homebrew install `brew upgrade hyperframes` installs whatever formula the tap holds, so a background run scheduled for an allowed patch could still cross a 0.x minor. Homebrew installs now only get the update notice naming `brew upgrade`. A new test drives the scheduler through the real installer detection and installer script: no spawn on Homebrew, a versioned npm install for a patch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
35753f3821
commit
b2acef5869
@@ -0,0 +1,108 @@
|
||||
import { afterEach, expect, it, vi } from "vitest";
|
||||
|
||||
// Drives scheduleBackgroundInstall through the real installer detection, argv helper and installer
|
||||
// script; only the entry path, the settings file and spawn itself are stubbed.
|
||||
const BREW_ENTRY =
|
||||
"/opt/homebrew/Cellar/hyperframes/0.8.231/libexec/lib/node_modules/hyperframes/dist/cli.js";
|
||||
const NPM_ENTRY = "/usr/local/lib/node_modules/hyperframes/dist/cli.js";
|
||||
|
||||
const originalArgv = [...process.argv];
|
||||
const originalEnv = { ...process.env };
|
||||
const originalTTY = process.stderr.isTTY;
|
||||
const originalWrite = process.stderr.write.bind(process.stderr);
|
||||
|
||||
afterEach(() => {
|
||||
process.argv = [...originalArgv];
|
||||
process.env = { ...originalEnv };
|
||||
Object.defineProperty(process.stderr, "isTTY", { value: originalTTY, configurable: true });
|
||||
process.stderr.write = originalWrite;
|
||||
vi.resetModules();
|
||||
vi.doUnmock("../telemetry/config.js");
|
||||
vi.doUnmock("../version.js");
|
||||
vi.doUnmock("./env.js");
|
||||
vi.doUnmock("./attendedTerminal.js");
|
||||
vi.doUnmock("node:child_process");
|
||||
vi.doUnmock("node:fs");
|
||||
});
|
||||
|
||||
/** A 0.8.231 install at `entry` whose cached latest is the allowed patch 0.8.232. */
|
||||
async function patchAvailableAt(entry: string) {
|
||||
vi.resetModules();
|
||||
const config: Record<string, unknown> = { latestVersion: "0.8.232" };
|
||||
vi.doMock("../telemetry/config.js", () => ({
|
||||
readConfig: () => ({ ...config }),
|
||||
readConfigFresh: () => ({ ...config }),
|
||||
writeConfig: (next: Record<string, unknown>) => {
|
||||
for (const key of Object.keys(config)) delete config[key];
|
||||
Object.assign(config, next);
|
||||
return true;
|
||||
},
|
||||
}));
|
||||
vi.doMock("../version.js", async (importOriginal) => ({
|
||||
...(await importOriginal<typeof import("../version.js")>()),
|
||||
VERSION: "0.8.231",
|
||||
}));
|
||||
vi.doMock("./env.js", () => ({ isDevMode: () => false }));
|
||||
vi.doMock("./attendedTerminal.js", async (importOriginal) => ({
|
||||
...(await importOriginal<typeof import("./attendedTerminal.js")>()),
|
||||
isUnattended: () => false,
|
||||
}));
|
||||
const spawn = vi.fn((_bin: string, _args: readonly string[]) => ({ pid: 42, unref: () => {} }));
|
||||
vi.doMock("node:child_process", async (importOriginal) => ({
|
||||
...(await importOriginal<typeof import("node:child_process")>()),
|
||||
spawn,
|
||||
}));
|
||||
vi.doMock("node:fs", async (importOriginal) => ({
|
||||
...(await importOriginal<typeof import("node:fs")>()),
|
||||
mkdirSync: () => {},
|
||||
openSync: () => 99,
|
||||
appendFileSync: () => {},
|
||||
}));
|
||||
|
||||
process.argv = [process.argv[0] ?? "node", entry];
|
||||
for (const name of ["CI", "HYPERFRAMES_NO_AUTO_INSTALL", "HYPERFRAMES_NO_UPDATE_CHECK"]) {
|
||||
delete process.env[name];
|
||||
}
|
||||
Object.defineProperty(process.stderr, "isTTY", { value: true, configurable: true });
|
||||
const stderr: string[] = [];
|
||||
process.stderr.write = ((chunk: unknown) => {
|
||||
stderr.push(String(chunk));
|
||||
return true;
|
||||
}) as typeof process.stderr.write;
|
||||
|
||||
const { scheduleBackgroundInstall } = await import("./autoUpdate.js");
|
||||
const { printUpdateNotice } = await import("./updateCheck.js");
|
||||
const scheduled = scheduleBackgroundInstall("0.8.232", "0.8.231");
|
||||
printUpdateNotice();
|
||||
return { scheduled, spawn, config, notice: stderr.join("") };
|
||||
}
|
||||
|
||||
/** The bin and argv the spawned installer script would execFile. */
|
||||
function installerArgv(spawn: { mock: { calls: [string, readonly string[]][] } }) {
|
||||
const script = spawn.mock.calls[0]?.[1][1] ?? "";
|
||||
const bin = /const BIN = (.*);/.exec(script)?.[1];
|
||||
const args = /const ARGS = (.*);/.exec(script)?.[1];
|
||||
return { bin: bin && JSON.parse(bin), args: args && JSON.parse(args) };
|
||||
}
|
||||
|
||||
it("never launches an upgrade on Homebrew, whose upgrade cannot be held to the patch", async () => {
|
||||
const { scheduled, spawn, config, notice } = await patchAvailableAt(BREW_ENTRY);
|
||||
|
||||
expect(scheduled).toBe(false);
|
||||
expect(spawn).not.toHaveBeenCalled();
|
||||
expect(config["pendingUpdate"]).toBeUndefined();
|
||||
expect(notice).toContain("Update available: 0.8.231 → 0.8.232");
|
||||
expect(notice).toContain("Run: brew upgrade hyperframes");
|
||||
});
|
||||
|
||||
it("still installs an allowed patch on npm at that exact version", async () => {
|
||||
const { scheduled, spawn, notice } = await patchAvailableAt(NPM_ENTRY);
|
||||
|
||||
expect(scheduled).toBe(true);
|
||||
expect(spawn).toHaveBeenCalledOnce();
|
||||
expect(installerArgv(spawn)).toEqual({
|
||||
bin: "npm",
|
||||
args: ["install", "-g", "hyperframes@0.8.232"],
|
||||
});
|
||||
expect(notice).toBe("");
|
||||
});
|
||||
Reference in New Issue
Block a user