mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-19 00:18:27 +00:00
fix(cli): no auto-update across 0.x minors; install skills at the CLI's release tag (#7013)
* fix(cli): no auto-update across 0.x minors; install skills at the CLI's release tag - autoUpdate: before 1.0 a minor bump counts as a major one, so 0.8.x -> 0.9.x is a notice, not a silent background install. From 1.0 on, the major alone. - skills: `skills update` / bare `skills` / `init` install from heygen-com/hyperframes#v<VERSION>, and `skills check` plus the background freshness nudge read the manifest at the same tag. A build the repo has no tag for (dev build) falls back to main, as before. - skills: run the upstream installer as `npx skills@1.7.4` instead of an unpinned `npx skills`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cli): keep the comment share of the touched files from rising Comment ratchet: trim the comments added in the previous commit. No code change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cli): pass the CLI version into the skills check instead of importing it scripts/clawhub-unlist-retired.mjs loads skillsManifest.ts from source under plain node, which cannot resolve a relative `../version.js` import. Callers now pass `cliVersion` (and skillsSourceRef takes it as an argument), so the module keeps importing only node builtins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cli): read skills at the CLI's tag without a probe; pin skills@1.5.13 - A release build reads the manifest at its own tag directly (publish pushes the tag before npm publish). Only a 404 for that manifest falls back to main; a timeout, missing git or proxy error now surfaces instead of quietly comparing against main, so the background nudge can't cache a false "outdated" count. - checkSkills returns the ref it read, and skills update installs from that same ref, so check and install can't disagree within one run. - Pin skills@1.5.13 (it parses `#<ref>` too) so the pin matches the version agentDirs.generated.ts and the lock-path notes were checked against. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(cli): split the tag and main manifest fetches Fallow flagged fetchRemoteManifest's CRAP score (31.6 > 30). The tag fetch (404 is the only fallback to main) and the SHA-pinned main fetch are now their own functions. No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cli): never auto-upgrade a Homebrew install `brew upgrade hyperframes` installs whatever formula the tap holds, so a background run scheduled for an allowed patch could still cross a 0.x minor. Homebrew installs now only get the update notice naming `brew upgrade`. A new test drives the scheduler through the real installer detection and installer script: no spawn on Homebrew, a versioned npm install for a patch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
35753f3821
commit
b2acef5869
@@ -150,6 +150,42 @@ describe("scheduleBackgroundInstall", () => {
|
||||
expect(spawnSpy).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
// Before 1.0 a minor bump may break (semver), so 0.8.x -> 0.9.x is a "major"
|
||||
// jump: notify only. Comparing the first number alone auto-installed it.
|
||||
it("does NOT schedule across a 0.x minor jump", async () => {
|
||||
const { spawnSpy, config } = setupMocks({
|
||||
installer: { kind: "npm", command: "npm install -g hyperframes@0.9.3" },
|
||||
});
|
||||
const { scheduleBackgroundInstall } = await import("./autoUpdate.js");
|
||||
|
||||
expect(scheduleBackgroundInstall("0.9.3", "0.8.231")).toBe(false);
|
||||
expect(spawnSpy).not.toHaveBeenCalled();
|
||||
expect(config.pendingUpdate).toBeUndefined();
|
||||
});
|
||||
|
||||
it.each([
|
||||
["0.8.232", "0.8.231"],
|
||||
["1.3.0", "1.2.5"],
|
||||
])("still schedules %s over %s (same breaking line)", async (latest, current) => {
|
||||
const { spawnSpy } = setupMocks({
|
||||
installer: { kind: "npm", command: `npm install -g hyperframes@${latest}` },
|
||||
});
|
||||
const { scheduleBackgroundInstall } = await import("./autoUpdate.js");
|
||||
|
||||
expect(scheduleBackgroundInstall(latest, current)).toBe(true);
|
||||
expect(spawnSpy).toHaveBeenCalledOnce();
|
||||
});
|
||||
|
||||
it("does NOT schedule across a major jump from 1.0 on", async () => {
|
||||
const { spawnSpy } = setupMocks({
|
||||
installer: { kind: "npm", command: "npm install -g hyperframes@2.0.0" },
|
||||
});
|
||||
const { scheduleBackgroundInstall } = await import("./autoUpdate.js");
|
||||
|
||||
expect(scheduleBackgroundInstall("2.0.0", "1.9.4")).toBe(false);
|
||||
expect(spawnSpy).not.toHaveBeenCalled();
|
||||
});
|
||||
|
||||
it("skips in dev mode", async () => {
|
||||
const { spawnSpy } = setupMocks({
|
||||
installer: { kind: "npm", command: "npm install -g hyperframes@0.4.4" },
|
||||
|
||||
Reference in New Issue
Block a user