ext/hyperframes
2
0
Fork 0
mirror of https://github.com/heygen-com/hyperframes.git synced 2026-09-03 04:38:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(producer): stop coupling the hdr disk-headroom gate's control flow to error-string matching

Browse Source 
Addresses non-blocking review feedback on #2256: the previous shape used
err.message.includes(...) inside a catch to distinguish a real headroom
violation from a statfsSync failure — a future message tweak would silently
fail open (statfs-unsupported and headroom-violation would take the same
code path). Now statfsSync failure returns early (skip the gate) and the
headroom check/throw happens in plain control flow outside any try/catch.
This commit is contained in:
Vance Ingalls
2026-07-11 14:14:09 -07:00
parent 9a1afce43c
commit c20e20235b
1 changed files with 21 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/producer/src/services/render/stages/captureHdrResources.ts
+21 -19
View File
@@ -204,27 +204,29 @@ function assertHdrExtractionDiskHeadroom(
log: ProducerLogger,
): void {
const estimatedBytes = estimateHdrExtractionBytes(plannedVideos, fps);
let freeBytes: number;
try {
const stat = statfsSync(framesDir);
const freeBytes = stat.bavail * stat.bsize;
const estimatedGb = (estimatedBytes / 1e9).toFixed(1);
if (estimatedBytes > freeBytes * HDR_EXTRACTION_HEADROOM_FRACTION) {
throw new Error(
`HDR pre-extraction needs ~${estimatedGb} GB of raw 16-bit frames but only ` +
`${(freeBytes / 1e9).toFixed(1)} GB is free at ${framesDir}. ` +
`If the composition doesn't need HDR output, re-run with --sdr; ` +
`otherwise free up disk space and retry.`,
);
}
if (estimatedBytes > HDR_EXTRACTION_WARN_BYTES) {
log.warn(
`HDR pre-extraction will write ~${estimatedGb} GB of raw 16-bit frames ` +
`(pass --sdr to skip if HDR output isn't needed)`,
{ estimatedBytes, freeBytes },
);
}
} catch (err) {
if (err instanceof Error && err.message.includes("HDR pre-extraction needs")) throw err;
freeBytes = stat.bavail * stat.bsize;
} catch {
// statfs unsupported on this platform/filesystem — skip the gate.
return;
}
const estimatedGb = (estimatedBytes / 1e9).toFixed(1);
if (estimatedBytes > freeBytes * HDR_EXTRACTION_HEADROOM_FRACTION) {
throw new Error(
`HDR pre-extraction needs ~${estimatedGb} GB of raw 16-bit frames but only ` +
`${(freeBytes / 1e9).toFixed(1)} GB is free at ${framesDir}. ` +
`If the composition doesn't need HDR output, re-run with --sdr; ` +
`otherwise free up disk space and retry.`,
);
}
if (estimatedBytes > HDR_EXTRACTION_WARN_BYTES) {
log.warn(
`HDR pre-extraction will write ~${estimatedGb} GB of raw 16-bit frames ` +
`(pass --sdr to skip if HDR output isn't needed)`,
{ estimatedBytes, freeBytes },
);
}
}