From c414625d1cdd46de186bf6564c2f3f581ed627ac Mon Sep 17 00:00:00 2001 From: Miguel Angel Simon Sierra Date: Sat, 19 Sep 2026 22:35:01 -0400 Subject: [PATCH] fix(studio): gate timeline drop writes Route asset, file, and composition drops through the shared edit permission gate before any side effect. --- .../hooks/useTimelineAssetDropOps.test.tsx | 66 +++++++++++++++++-- .../src/hooks/useTimelineAssetDropOps.ts | 43 +++++++++++- .../studio/src/hooks/useTimelineEditing.ts | 1 + 3 files changed, 103 insertions(+), 7 deletions(-) diff --git a/packages/studio/src/hooks/useTimelineAssetDropOps.test.tsx b/packages/studio/src/hooks/useTimelineAssetDropOps.test.tsx index c1ae287345..c322059e70 100644 --- a/packages/studio/src/hooks/useTimelineAssetDropOps.test.tsx +++ b/packages/studio/src/hooks/useTimelineAssetDropOps.test.tsx @@ -16,19 +16,29 @@ afterEach(() => { }); type DropFn = ReturnType["handleTimelineAssetDrop"]; +type FileDropFn = ReturnType["handleTimelineFileDrop"]; +type CompositionDropFn = ReturnType< + typeof useTimelineAssetDropOps +>["handleTimelineCompositionDrop"]; function renderDropHook( sourceContent: string, writeProjectFile: (path: string, content: string, expectedContent?: string) => Promise, timelineElements: TimelineElement[] = [], + checkEditable?: (targets: readonly TimelineElement[]) => boolean, + uploadProjectFiles: (files: Iterable, dir?: string) => Promise = vi + .fn() + .mockResolvedValue([]), ) { vi.stubGlobal( "fetch", vi.fn().mockResolvedValue({ ok: true, json: async () => ({ content: sourceContent }) }), ); let drop: DropFn | null = null; + let fileDrop: FileDropFn | null = null; + let compositionDrop: CompositionDropFn | null = null; function Harness() { - const { handleTimelineAssetDrop } = useTimelineAssetDropOps({ + const handlers = useTimelineAssetDropOps({ projectIdRef: { current: "project" }, activeCompPath: "index.html", timelineElements, @@ -36,13 +46,19 @@ function renderDropHook( writeProjectFile, recordEdit: vi.fn().mockResolvedValue(undefined), reloadPreview: vi.fn(), - uploadProjectFiles: vi.fn().mockResolvedValue([]), + uploadProjectFiles, + checkEditable, }); - drop = handleTimelineAssetDrop; + drop = handlers.handleTimelineAssetDrop; + fileDrop = handlers.handleTimelineFileDrop; + compositionDrop = handlers.handleTimelineCompositionDrop; return null; } mountReactHarness(); - return () => drop!; + return Object.assign(() => drop!, { + file: () => fileDrop!, + composition: () => compositionDrop!, + }); } describe("useTimelineAssetDropOps handleTimelineAssetDrop", () => { @@ -124,4 +140,46 @@ describe("useTimelineAssetDropOps handleTimelineAssetDrop", () => { expect(written).toContain('id="hidden" data-start="0" data-track-index="1"'); expect(written).toMatch(/