mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-03 04:38:33 +00:00
fix(render): surface structured outcomes (#2153)
This commit is contained in:
@@ -267,6 +267,12 @@ export default defineCommand({
|
||||
"Write full render diagnostics and keep intermediate artifacts under the producer .debug directory.",
|
||||
default: false,
|
||||
},
|
||||
"best-effort": {
|
||||
type: "boolean",
|
||||
description:
|
||||
"Allow output with structured capture-readiness warnings (default). Use --no-best-effort to fail on missing or unready media.",
|
||||
default: true,
|
||||
},
|
||||
strict: {
|
||||
type: "boolean",
|
||||
description: "Fail render on lint errors",
|
||||
@@ -622,6 +628,7 @@ export default defineCommand({
|
||||
const browserGpuMode = resolveBrowserGpuForCli(useDocker, browserGpuArg);
|
||||
const quiet = args.quiet ?? false;
|
||||
const debug = args.debug ?? false;
|
||||
const bestEffort = args["best-effort"] ?? true;
|
||||
const batchJson = args.json ?? false;
|
||||
const effectiveQuiet = quiet || (batchPath != null && batchJson);
|
||||
const strictAll = args["strict-all"] ?? false;
|
||||
@@ -902,6 +909,7 @@ export default defineCommand({
|
||||
protocolTimeout,
|
||||
playerReadyTimeout,
|
||||
debug,
|
||||
bestEffort,
|
||||
exitAfterComplete: false,
|
||||
throwOnError: true,
|
||||
skipFeedback: true,
|
||||
@@ -960,6 +968,7 @@ export default defineCommand({
|
||||
videoFrameFormat,
|
||||
quiet,
|
||||
debug,
|
||||
bestEffort,
|
||||
variables,
|
||||
entryFile,
|
||||
outputResolution,
|
||||
@@ -988,6 +997,7 @@ export default defineCommand({
|
||||
quiet,
|
||||
browserPath,
|
||||
debug,
|
||||
bestEffort,
|
||||
variables,
|
||||
entryFile,
|
||||
outputResolution,
|
||||
@@ -1006,6 +1016,8 @@ export default defineCommand({
|
||||
export interface SingleRenderResult {
|
||||
durationMs?: number;
|
||||
renderTimeMs: number;
|
||||
outcome?: "completed" | "completed_with_warnings";
|
||||
warnings?: Array<{ code: string; message: string }>;
|
||||
}
|
||||
|
||||
export function renderLintContinuationHint(strictErrors: boolean): string {
|
||||
@@ -1036,6 +1048,7 @@ interface RenderOptions {
|
||||
videoFrameFormat?: VideoFrameFormat;
|
||||
quiet: boolean;
|
||||
debug?: boolean;
|
||||
bestEffort?: boolean;
|
||||
browserPath?: string;
|
||||
variables?: Record<string, unknown>;
|
||||
entryFile?: string;
|
||||
@@ -1370,6 +1383,7 @@ async function renderDocker(
|
||||
outputResolution: options.outputResolution,
|
||||
pageSideCompositing: options.pageSideCompositing,
|
||||
debug: options.debug,
|
||||
bestEffort: options.bestEffort,
|
||||
experimentalFastCapture: options.experimentalFastCapture,
|
||||
pageNavigationTimeoutMs: options.pageNavigationTimeoutMs,
|
||||
},
|
||||
@@ -1490,6 +1504,7 @@ export async function renderLocal(
|
||||
entryFile: options.entryFile,
|
||||
outputResolution: options.outputResolution,
|
||||
debug: options.debug,
|
||||
strictness: options.bestEffort === false ? "strict" : "best-effort",
|
||||
});
|
||||
|
||||
const onProgress = options.quiet
|
||||
@@ -1515,6 +1530,11 @@ export async function renderLocal(
|
||||
|
||||
maybeConsumeDeParallelRouterTrial(deParallelRouterTrialArmed, job, options.quiet);
|
||||
const elapsed = Date.now() - startTime;
|
||||
if (job.outcome === "completed_with_warnings") {
|
||||
for (const warning of job.warnings) {
|
||||
console.warn(c.warn(` [${warning.code}] ${warning.message}`));
|
||||
}
|
||||
}
|
||||
trackRenderMetrics(job, elapsed, options, false);
|
||||
printRenderComplete(
|
||||
outputPath,
|
||||
@@ -1534,7 +1554,14 @@ export async function renderLocal(
|
||||
const durationMs = job.perfSummary
|
||||
? Math.round(job.perfSummary.compositionDurationSeconds * 1000)
|
||||
: undefined;
|
||||
return { renderTimeMs: elapsed, durationMs };
|
||||
const outcome =
|
||||
job.outcome === "completed_with_warnings" ? "completed_with_warnings" : "completed";
|
||||
return {
|
||||
renderTimeMs: elapsed,
|
||||
durationMs,
|
||||
outcome,
|
||||
warnings: job.warnings.map((warning) => ({ code: warning.code, message: warning.message })),
|
||||
};
|
||||
}
|
||||
|
||||
type UnrefableTimer = {
|
||||
|
||||
Reference in New Issue
Block a user