diff --git a/packages/studio/src/App.tsx b/packages/studio/src/App.tsx index 7921f28e9..24b69e88d 100644 --- a/packages/studio/src/App.tsx +++ b/packages/studio/src/App.tsx @@ -43,7 +43,6 @@ import { import type { DomEditSelection } from "./components/editor/domEditing"; import { StudioHeader } from "./components/StudioHeader"; import { useGestureCommit } from "./hooks/useGestureCommit"; -import { STUDIO_KEYFRAMES_ENABLED } from "./components/editor/manualEditingAvailability"; import { GestureTrailOverlay } from "./components/editor/GestureTrailOverlay"; import { StudioLeftSidebar } from "./components/StudioLeftSidebar"; import { EditorShell } from "./components/EditorShell"; @@ -263,9 +262,7 @@ export function StudioApp() { onUngroupSelection: () => domEditSessionRef.current.handleUngroupSelection(), activeCompPath, forceReloadSdkSession: sdkHandle.forceReload, - onToggleRecording: STUDIO_KEYFRAMES_ENABLED - ? () => handleToggleRecordingRef.current() - : undefined, + onToggleRecording: () => handleToggleRecordingRef.current(), }); const sidebarTabRef = useRef({ select: (t: SidebarTab) => leftSidebarRef.current?.selectTab(t), @@ -367,7 +364,7 @@ export function StudioApp() { isGestureRecordingRef, }); handleToggleRecordingRef.current = handleToggleRecording; - const recordingToggle = STUDIO_KEYFRAMES_ENABLED ? handleToggleRecording : undefined; + const recordingToggle = handleToggleRecording; const canvasRectRef = useRef(null); useLayoutEffect(() => { if (gestureState !== "recording" || !previewIframe) { diff --git a/packages/studio/src/components/StudioHeader.tsx b/packages/studio/src/components/StudioHeader.tsx index f6110cd9f..6154a4d33 100644 --- a/packages/studio/src/components/StudioHeader.tsx +++ b/packages/studio/src/components/StudioHeader.tsx @@ -1,9 +1,5 @@ import { useRef, type MouseEvent } from "react"; import { RotateCcw, RotateCw, Camera } from "../icons/SystemIcons"; -import { - STUDIO_INSPECTOR_PANELS_ENABLED, - STUDIO_MANUAL_EDITING_DISABLED_TITLE, -} from "./editor/manualEditingAvailability"; import { getHistoryShortcutLabel } from "../utils/studioHelpers"; import { useStudioShellContext } from "../contexts/StudioContext"; import { usePanelLayoutContext } from "../contexts/PanelLayoutContext"; @@ -328,16 +324,10 @@ export function StudioHeader({ {capturing ? "Capturing…" : "Capture"} - + - - - - - {/* Divider: tool-mode | editing-actions */} - - {STUDIO_KEYFRAMES_ENABLED && gsapAnimId && ( + {gsapAnimId && ( commitManualSize("width", next)} /> - {STUDIO_KEYFRAMES_ENABLED && gsapAnimId && ( + {gsapAnimId && ( commitManualSize("height", next)} /> - {STUDIO_KEYFRAMES_ENABLED && gsapAnimId && ( + {gsapAnimId && ( commitManualRotation(next.replace("°", ""))} /> - {STUDIO_KEYFRAMES_ENABLED && gsapAnimId && ( + {gsapAnimId && ( )} - {STUDIO_GSAP_PANEL_ENABLED && - onUpdateGsapProperty && + {onUpdateGsapProperty && onUpdateGsapMeta && onDeleteGsapAnimation && onAddGsapProperty && diff --git a/packages/studio/src/components/editor/PropertyPanelFlat.tsx b/packages/studio/src/components/editor/PropertyPanelFlat.tsx index 7b9447949..278dceafa 100644 --- a/packages/studio/src/components/editor/PropertyPanelFlat.tsx +++ b/packages/studio/src/components/editor/PropertyPanelFlat.tsx @@ -16,7 +16,6 @@ import { FlatMediaSection } from "./propertyPanelFlatMediaSection"; import { deriveElementTiming } from "./propertyPanelFlatTimingDerivation"; import { createGsapLivePreview } from "./gsapLivePreview"; import { formatTextFieldPreview } from "./propertyPanelSections"; -import { STUDIO_GSAP_PANEL_ENABLED } from "./manualEditingAvailability"; import { useColorGradingController } from "./useColorGradingController"; import { usePlayerStore } from "../../player"; import { @@ -224,7 +223,6 @@ export function PropertyPanelFlat({ // Match the legacy Motion gate while preserving TypeScript narrowing. const showMotionTiming = Boolean(sections.timing); const gsapEffectHandlers = - STUDIO_GSAP_PANEL_ENABLED && onUpdateGsapProperty && onUpdateGsapMeta && onDeleteGsapAnimation && diff --git a/packages/studio/src/components/editor/manualEditingAvailability.test.ts b/packages/studio/src/components/editor/manualEditingAvailability.test.ts index 5bc29cc43..b661d1f2f 100644 --- a/packages/studio/src/components/editor/manualEditingAvailability.test.ts +++ b/packages/studio/src/components/editor/manualEditingAvailability.test.ts @@ -16,35 +16,18 @@ describe("manual editing availability", () => { vi.resetModules(); }); - it("enables inspector selection and manual dragging by default", async () => { - const availability = await loadAvailabilityWithEnv({}); - - expect(availability.STUDIO_PREVIEW_MANUAL_EDITING_ENABLED).toBe(true); - expect(availability.STUDIO_PREVIEW_SELECTION_ENABLED).toBe(true); - expect(availability.STUDIO_INSPECTOR_PANELS_ENABLED).toBe(true); - }); - - it("disables preview selection when the inspector panel flag is explicitly off", async () => { - const availability = await loadAvailabilityWithEnv({ - VITE_STUDIO_ENABLE_INSPECTOR_PANELS: "0", - }); - - expect(availability.STUDIO_INSPECTOR_PANELS_ENABLED).toBe(false); - expect(availability.STUDIO_PREVIEW_SELECTION_ENABLED).toBe(false); - }); - it("enables feature flags with explicit truthy env values", () => { expect( resolveStudioBooleanEnvFlag( - { VITE_STUDIO_ENABLE_PREVIEW_MANUAL_DRAGGING: "true" }, - ["VITE_STUDIO_ENABLE_PREVIEW_MANUAL_DRAGGING"], + { VITE_STUDIO_ENABLE_FLAT_INSPECTOR: "true" }, + ["VITE_STUDIO_ENABLE_FLAT_INSPECTOR"], false, ), ).toBe(true); expect( resolveStudioBooleanEnvFlag( - { VITE_STUDIO_ENABLE_MOTION_PANEL: "1" }, - ["VITE_STUDIO_ENABLE_MOTION_PANEL"], + { VITE_STUDIO_SDK_CUTOVER_ENABLED: "1" }, + ["VITE_STUDIO_SDK_CUTOVER_ENABLED"], false, ), ).toBe(true); @@ -53,15 +36,15 @@ describe("manual editing availability", () => { it("disables feature flags with explicit falsy env values", () => { expect( resolveStudioBooleanEnvFlag( - { VITE_STUDIO_ENABLE_PREVIEW_MANUAL_DRAGGING: "off" }, - ["VITE_STUDIO_ENABLE_PREVIEW_MANUAL_DRAGGING"], + { VITE_STUDIO_ENABLE_FLAT_INSPECTOR: "off" }, + ["VITE_STUDIO_ENABLE_FLAT_INSPECTOR"], true, ), ).toBe(false); expect( resolveStudioBooleanEnvFlag( - { VITE_STUDIO_ENABLE_MOTION_PANEL: "0" }, - ["VITE_STUDIO_ENABLE_MOTION_PANEL"], + { VITE_STUDIO_SDK_CUTOVER_ENABLED: "0" }, + ["VITE_STUDIO_SDK_CUTOVER_ENABLED"], true, ), ).toBe(false); @@ -70,18 +53,8 @@ describe("manual editing availability", () => { it("supports legacy flag aliases after the preferred name", () => { expect( resolveStudioBooleanEnvFlag( - { VITE_STUDIO_PREVIEW_MANUAL_EDITING_ENABLED: "yes" }, - [ - "VITE_STUDIO_ENABLE_PREVIEW_MANUAL_DRAGGING", - "VITE_STUDIO_PREVIEW_MANUAL_EDITING_ENABLED", - ], - false, - ), - ).toBe(true); - expect( - resolveStudioBooleanEnvFlag( - { VITE_STUDIO_MOTION_PANEL_ENABLED: "enabled" }, - ["VITE_STUDIO_ENABLE_MOTION_PANEL", "VITE_STUDIO_MOTION_PANEL_ENABLED"], + { VITE_STUDIO_FLAT_INSPECTOR_ENABLED: "yes" }, + ["VITE_STUDIO_ENABLE_FLAT_INSPECTOR", "VITE_STUDIO_FLAT_INSPECTOR_ENABLED"], false, ), ).toBe(true); @@ -91,10 +64,10 @@ describe("manual editing availability", () => { expect( resolveStudioBooleanEnvFlag( { - VITE_STUDIO_ENABLE_INSPECTOR_PANELS: "off", - VITE_STUDIO_INSPECTOR_PANELS_ENABLED: "on", + VITE_STUDIO_ENABLE_FLAT_INSPECTOR: "off", + VITE_STUDIO_FLAT_INSPECTOR_ENABLED: "on", }, - ["VITE_STUDIO_ENABLE_INSPECTOR_PANELS", "VITE_STUDIO_INSPECTOR_PANELS_ENABLED"], + ["VITE_STUDIO_ENABLE_FLAT_INSPECTOR", "VITE_STUDIO_FLAT_INSPECTOR_ENABLED"], true, ), ).toBe(false); diff --git a/packages/studio/src/components/editor/manualEditingAvailability.ts b/packages/studio/src/components/editor/manualEditingAvailability.ts index 04eea93b6..d156bf694 100644 --- a/packages/studio/src/components/editor/manualEditingAvailability.ts +++ b/packages/studio/src/components/editor/manualEditingAvailability.ts @@ -1,7 +1,5 @@ export type StudioFeatureFlagEnv = Record; -const STUDIO_PREVIEW_MANUAL_DRAGGING_ENV = "VITE_STUDIO_ENABLE_PREVIEW_MANUAL_DRAGGING"; -const STUDIO_INSPECTOR_PANELS_ENV = "VITE_STUDIO_ENABLE_INSPECTOR_PANELS"; const TRUTHY_ENV_VALUES = new Set(["1", "true", "yes", "on", "enabled"]); const FALSY_ENV_VALUES = new Set(["0", "false", "no", "off", "disabled"]); @@ -40,44 +38,6 @@ const runtimeEnv = : {}; const env = { ...(import.meta.env ?? {}), ...runtimeEnv } as StudioFeatureFlagEnv; -export const STUDIO_PREVIEW_MANUAL_EDITING_ENABLED = resolveStudioBooleanEnvFlag( - env, - [STUDIO_PREVIEW_MANUAL_DRAGGING_ENV, "VITE_STUDIO_PREVIEW_MANUAL_EDITING_ENABLED"], - true, -); - -export const STUDIO_INSPECTOR_PANELS_ENABLED = resolveStudioBooleanEnvFlag( - env, - [STUDIO_INSPECTOR_PANELS_ENV, "VITE_STUDIO_INSPECTOR_PANELS_ENABLED"], - true, -); - -export const STUDIO_BLOCKS_PANEL_ENABLED = resolveStudioBooleanEnvFlag( - env, - ["VITE_STUDIO_ENABLE_BLOCKS_PANEL", "VITE_STUDIO_BLOCKS_PANEL_ENABLED"], - true, -); - -export const STUDIO_GSAP_PANEL_ENABLED = resolveStudioBooleanEnvFlag( - env, - ["VITE_STUDIO_ENABLE_GSAP_PANEL", "VITE_STUDIO_GSAP_PANEL_ENABLED"], - true, -); - -export const STUDIO_KEYFRAMES_ENABLED = resolveStudioBooleanEnvFlag( - env, - ["VITE_STUDIO_ENABLE_KEYFRAMES", "VITE_STUDIO_KEYFRAMES_ENABLED"], - true, -); - -export const STUDIO_RAZOR_TOOL_ENABLED = resolveStudioBooleanEnvFlag( - env, - ["VITE_STUDIO_ENABLE_RAZOR_TOOL", "VITE_STUDIO_RAZOR_TOOL_ENABLED"], - true, -); - -export const STUDIO_PREVIEW_SELECTION_ENABLED = STUDIO_INSPECTOR_PANELS_ENABLED; - // Stage 7 Step 3c: SDK cutover — routes inline-style ops through SDK dispatch // instead of the server patch-element API. Default false; enable via // VITE_STUDIO_SDK_CUTOVER_ENABLED=true. Requires SDK session to be open. @@ -114,5 +74,4 @@ export const STUDIO_FLAT_INSPECTOR_ENABLED = resolveStudioBooleanEnvFlag( true, ); -export const STUDIO_MANUAL_EDITING_DISABLED_TITLE = "Manual editing is temporarily disabled"; import { resolveEnabledSdkFamilies } from "../../utils/sdkCutoverPolicy"; diff --git a/packages/studio/src/components/editor/propertyPanel3dTransform.tsx b/packages/studio/src/components/editor/propertyPanel3dTransform.tsx index a74ebc9bc..e38cc58ee 100644 --- a/packages/studio/src/components/editor/propertyPanel3dTransform.tsx +++ b/packages/studio/src/components/editor/propertyPanel3dTransform.tsx @@ -1,6 +1,5 @@ import { useState } from "react"; import type { DomEditSelection } from "./domEditingTypes"; -import { STUDIO_KEYFRAMES_ENABLED } from "./manualEditingAvailability"; import { MetricField } from "./propertyPanelPrimitives"; import { KeyframeNavigation } from "./KeyframeNavigation"; import { formatPxMetricValue, parsePxMetricValue, RESPONSIVE_GRID } from "./propertyPanelHelpers"; @@ -259,7 +258,7 @@ function Transform3dField({ }} /> - {STUDIO_KEYFRAMES_ENABLED && (gsapAnimId || onCommitAnimatedProperty) && ( + {(gsapAnimId || onCommitAnimatedProperty) && ( ) { const track = useTrackDesignInput(); - if (!STUDIO_KEYFRAMES_ENABLED || !gsapAnimId) return null; + if (!gsapAnimId) return null; const hasKeyframesOnProp = Boolean(navKeyframes?.some((kf) => property in kf.properties)); return ( diff --git a/packages/studio/src/components/nle/PreviewOverlays.tsx b/packages/studio/src/components/nle/PreviewOverlays.tsx index 77781d993..d16a98f5d 100644 --- a/packages/studio/src/components/nle/PreviewOverlays.tsx +++ b/packages/studio/src/components/nle/PreviewOverlays.tsx @@ -4,12 +4,6 @@ import { DomEditOverlay } from "../editor/DomEditOverlay"; import { MotionPathOverlay } from "../editor/MotionPathOverlay"; import { SnapToolbar } from "../editor/SnapToolbar"; import { useCompositionDimensions } from "../../hooks/useCompositionDimensions"; -import { - STUDIO_INSPECTOR_PANELS_ENABLED, - STUDIO_KEYFRAMES_ENABLED, - STUDIO_PREVIEW_MANUAL_EDITING_ENABLED, - STUDIO_PREVIEW_SELECTION_ENABLED, -} from "../editor/manualEditingAvailability"; import { useStudioPlaybackContext, useStudioShellContext } from "../../contexts/StudioContext"; import { useDomEditActionsContext, @@ -203,21 +197,17 @@ export function PreviewOverlays({ return ; } - if (!STUDIO_INSPECTOR_PANELS_ENABLED) return null; - return ( <> - {STUDIO_KEYFRAMES_ENABLED && ( - - )} + {gestureOverlay} ); diff --git a/packages/studio/src/components/sidebar/LeftSidebar.tsx b/packages/studio/src/components/sidebar/LeftSidebar.tsx index 1b3d20824..b27edfb20 100644 --- a/packages/studio/src/components/sidebar/LeftSidebar.tsx +++ b/packages/studio/src/components/sidebar/LeftSidebar.tsx @@ -12,7 +12,6 @@ import { AssetsTab } from "./AssetsTab"; import { trackStudioEvent } from "../../utils/studioTelemetry"; import { BlocksTab, type BlockPreviewInfo } from "./BlocksTab"; import { FileTree } from "../editor/FileTree"; -import { STUDIO_BLOCKS_PANEL_ENABLED } from "../editor/manualEditingAvailability"; import { Tooltip } from "../ui"; export type SidebarTab = "compositions" | "assets" | "code" | "blocks"; @@ -127,11 +126,7 @@ export const LeftSidebar = memo(
- - )} + + +
{onToggleCollapse && (