mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-16 06:19:21 +00:00
refactor(studio): split the FX node row out of FxSection
Clears the health findings the FX stack left behind: the chain-node render callback was a 70-line closure over half of FxSection's state, and the two reorder arrows were the same button written twice. Also drops two exports with no consumers, and registers the audio FX runtime stub as an entry point — it is bundled by file path, so nothing imports it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
cfc1215f8a
commit
cfafa224b4
@@ -9,7 +9,7 @@
|
||||
* Kept as a source string so it can be registered from a Blob URL without a
|
||||
* separate bundled asset, which keeps the studio's build unchanged.
|
||||
*/
|
||||
export const AUDIO_FX_WORKLET_SOURCE = `
|
||||
const AUDIO_FX_WORKLET_SOURCE = `
|
||||
const dbToLin = (db) => Math.pow(10, db / 20);
|
||||
|
||||
/**
|
||||
|
||||
@@ -184,5 +184,3 @@ export function FxParams({ def, params, onChange, onCommit, disabled }: FxParams
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
export const __testables = { toSlider, fromSlider, display };
|
||||
|
||||
@@ -34,6 +34,160 @@ export interface AudioTrackOption {
|
||||
label: string;
|
||||
}
|
||||
|
||||
interface FxNodeRowProps {
|
||||
node: HfAudioFxNode;
|
||||
index: number;
|
||||
open: boolean;
|
||||
/** Last in the chain, so it cannot move further down. */
|
||||
last: boolean;
|
||||
disabled?: boolean;
|
||||
onToggleOpen(): void;
|
||||
onUpdate(index: number, patch: Partial<HfAudioFxNode>): void;
|
||||
onMove(index: number, delta: number): void;
|
||||
onRemove(index: number): void;
|
||||
onPreview(index: number, params: HfAudioFxParamValues): void;
|
||||
}
|
||||
|
||||
/** Reorder arrow. Disabled at the end of the chain it would move past. */
|
||||
function FxMoveButton({
|
||||
label,
|
||||
glyph,
|
||||
disabled,
|
||||
onClick,
|
||||
}: {
|
||||
label: string;
|
||||
glyph: string;
|
||||
disabled: boolean;
|
||||
onClick(): void;
|
||||
}) {
|
||||
return (
|
||||
<button
|
||||
type="button"
|
||||
className="hf-fx-move px-1 font-mono text-[10px] text-panel-text-4 hover:text-panel-text-0 disabled:opacity-25"
|
||||
title={label}
|
||||
disabled={disabled}
|
||||
onClick={onClick}
|
||||
>
|
||||
{glyph}
|
||||
</button>
|
||||
);
|
||||
}
|
||||
|
||||
/** Name, bypass, reorder and remove for one effect. */
|
||||
function FxNodeHeader({
|
||||
label,
|
||||
open,
|
||||
bypassed,
|
||||
first,
|
||||
last,
|
||||
disabled,
|
||||
onToggleOpen,
|
||||
onToggleBypass,
|
||||
onMove,
|
||||
onRemove,
|
||||
}: {
|
||||
label: string;
|
||||
open: boolean;
|
||||
bypassed: boolean;
|
||||
first: boolean;
|
||||
last: boolean;
|
||||
disabled?: boolean;
|
||||
onToggleOpen(): void;
|
||||
onToggleBypass(): void;
|
||||
onMove(delta: number): void;
|
||||
onRemove(): void;
|
||||
}) {
|
||||
return (
|
||||
<div className="hf-fx-node-head flex min-h-7 items-center gap-1 px-1.5">
|
||||
<button
|
||||
type="button"
|
||||
className="hf-fx-node-name flex-1 truncate text-left text-[11px] font-semibold text-panel-text-1 hover:text-panel-text-0"
|
||||
aria-expanded={open}
|
||||
onClick={onToggleOpen}
|
||||
>
|
||||
{label}
|
||||
</button>
|
||||
<button
|
||||
type="button"
|
||||
className="hf-fx-bypass rounded-[3px] border border-panel-border-input px-1.5 py-0.5 font-mono text-[9px] text-panel-text-4 hover:text-panel-text-0 disabled:opacity-40"
|
||||
aria-pressed={bypassed}
|
||||
title={bypassed ? "Enable" : "Bypass"}
|
||||
disabled={disabled}
|
||||
onClick={onToggleBypass}
|
||||
>
|
||||
{bypassed ? "Off" : "On"}
|
||||
</button>
|
||||
<FxMoveButton
|
||||
label="Move up"
|
||||
glyph="↑"
|
||||
disabled={Boolean(disabled) || first}
|
||||
onClick={() => onMove(-1)}
|
||||
/>
|
||||
<FxMoveButton
|
||||
label="Move down"
|
||||
glyph="↓"
|
||||
disabled={Boolean(disabled) || last}
|
||||
onClick={() => onMove(1)}
|
||||
/>
|
||||
<button
|
||||
type="button"
|
||||
className="hf-fx-remove px-1 font-mono text-[11px] text-panel-text-4 hover:text-red-400 disabled:opacity-40"
|
||||
title="Remove"
|
||||
disabled={disabled}
|
||||
onClick={onRemove}
|
||||
>
|
||||
×
|
||||
</button>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
/** One effect in the chain: its header controls, and its knobs when open. */
|
||||
function FxNodeRow({
|
||||
node,
|
||||
index,
|
||||
open,
|
||||
last,
|
||||
disabled,
|
||||
onToggleOpen,
|
||||
onUpdate,
|
||||
onMove,
|
||||
onRemove,
|
||||
onPreview,
|
||||
}: FxNodeRowProps) {
|
||||
const def = getAudioFxDef(node.type);
|
||||
if (!def) return null;
|
||||
const bypassed = node.enabled === false;
|
||||
return (
|
||||
<div
|
||||
className={`hf-fx-node rounded-[4px] border border-panel-border-input${bypassed ? " opacity-50" : ""}`}
|
||||
data-fx-node={node.type}
|
||||
>
|
||||
<FxNodeHeader
|
||||
label={def.label}
|
||||
open={open}
|
||||
bypassed={bypassed}
|
||||
first={index === 0}
|
||||
last={last}
|
||||
disabled={disabled}
|
||||
onToggleOpen={onToggleOpen}
|
||||
onToggleBypass={() => onUpdate(index, { enabled: bypassed })}
|
||||
onMove={(delta) => onMove(index, delta)}
|
||||
onRemove={() => onRemove(index)}
|
||||
/>
|
||||
{open ? (
|
||||
<FxParams
|
||||
def={def}
|
||||
params={node.params ?? defaultAudioFxParams(node.type)}
|
||||
disabled={disabled || bypassed}
|
||||
onChange={(params: HfAudioFxParamValues) => onPreview(index, params)}
|
||||
onCommit={(params: HfAudioFxParamValues) => onUpdate(index, { params })}
|
||||
/>
|
||||
) : null}
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
export interface FxSectionProps {
|
||||
chain: HfAudioFxChain;
|
||||
/** Structural edits and gesture-end writes; this is the one that persists. */
|
||||
@@ -128,76 +282,21 @@ export function FxSection({
|
||||
No effects on this track.
|
||||
</p>
|
||||
) : (
|
||||
chain.nodes.map((node, i) => {
|
||||
const def = getAudioFxDef(node.type);
|
||||
if (!def) return null;
|
||||
const bypassed = node.enabled === false;
|
||||
const open = openNode === i;
|
||||
return (
|
||||
<div
|
||||
key={`${node.type}-${i}`}
|
||||
className={`hf-fx-node rounded-[4px] border border-panel-border-input${bypassed ? " opacity-50" : ""}`}
|
||||
data-fx-node={node.type}
|
||||
>
|
||||
<div className="hf-fx-node-head flex min-h-7 items-center gap-1 px-1.5">
|
||||
<button
|
||||
type="button"
|
||||
className="hf-fx-node-name flex-1 truncate text-left text-[11px] font-semibold text-panel-text-1 hover:text-panel-text-0"
|
||||
aria-expanded={open}
|
||||
onClick={() => setOpenNode(open ? null : i)}
|
||||
>
|
||||
{def.label}
|
||||
</button>
|
||||
<button
|
||||
type="button"
|
||||
className="hf-fx-bypass rounded-[3px] border border-panel-border-input px-1.5 py-0.5 font-mono text-[9px] text-panel-text-4 hover:text-panel-text-0 disabled:opacity-40"
|
||||
aria-pressed={bypassed}
|
||||
title={bypassed ? "Enable" : "Bypass"}
|
||||
disabled={disabled}
|
||||
onClick={() => updateNode(i, { enabled: bypassed })}
|
||||
>
|
||||
{bypassed ? "Off" : "On"}
|
||||
</button>
|
||||
<button
|
||||
type="button"
|
||||
className="hf-fx-move px-1 font-mono text-[10px] text-panel-text-4 hover:text-panel-text-0 disabled:opacity-25"
|
||||
title="Move up"
|
||||
disabled={disabled || i === 0}
|
||||
onClick={() => moveNode(i, -1)}
|
||||
>
|
||||
↑
|
||||
</button>
|
||||
<button
|
||||
type="button"
|
||||
className="hf-fx-move px-1 font-mono text-[10px] text-panel-text-4 hover:text-panel-text-0 disabled:opacity-25"
|
||||
title="Move down"
|
||||
disabled={disabled || i === chain.nodes.length - 1}
|
||||
onClick={() => moveNode(i, 1)}
|
||||
>
|
||||
↓
|
||||
</button>
|
||||
<button
|
||||
type="button"
|
||||
className="hf-fx-remove px-1 font-mono text-[11px] text-panel-text-4 hover:text-red-400 disabled:opacity-40"
|
||||
title="Remove"
|
||||
disabled={disabled}
|
||||
onClick={() => removeNode(i)}
|
||||
>
|
||||
×
|
||||
</button>
|
||||
</div>
|
||||
{open ? (
|
||||
<FxParams
|
||||
def={def}
|
||||
params={node.params ?? defaultAudioFxParams(node.type)}
|
||||
disabled={disabled || bypassed}
|
||||
onChange={(params: HfAudioFxParamValues) => previewNode(i, params)}
|
||||
onCommit={(params: HfAudioFxParamValues) => updateNode(i, { params })}
|
||||
/>
|
||||
) : null}
|
||||
</div>
|
||||
);
|
||||
})
|
||||
chain.nodes.map((node, i) => (
|
||||
<FxNodeRow
|
||||
key={`${node.type}-${i}`}
|
||||
node={node}
|
||||
index={i}
|
||||
open={openNode === i}
|
||||
last={i === chain.nodes.length - 1}
|
||||
disabled={disabled}
|
||||
onToggleOpen={() => setOpenNode(openNode === i ? null : i)}
|
||||
onUpdate={updateNode}
|
||||
onMove={moveNode}
|
||||
onRemove={removeNode}
|
||||
onPreview={previewNode}
|
||||
/>
|
||||
))
|
||||
)}
|
||||
</div>
|
||||
|
||||
|
||||
Reference in New Issue
Block a user