From d872853874ffd5ff4f6deb28f7421d081774e897 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20=C3=81ngel?= Date: Tue, 17 Nov 2026 21:58:39 +0000 Subject: [PATCH] fix(studio): analytics send path and selector facts, not the paths and selectors (#8109) * fix(studio): analytics send path and selector facts, not the paths and selectors Both Studio transports now shape every event's values in one place before they leave the machine: a file path becomes its extension, kind, depth and a per-install salted hash; a selector becomes its kind and the same hash; any other value that reads as a path or selector is dropped and named in dropped_fields. Save failures send the error class, a fixed error key and the server's fixed refusal code instead of the error's words. Session fields can no longer be overwritten by a caller. * fix(studio): save failures keep their dedupe and no selector leaves in shadow mismatches The editor's failure dedupe keys on the error's own text again, locally. The resolver shadow's animation_not_found no longer repeats the animation id inside mismatches. Error keys and path kinds read from tables; the server's full refusal list is known. * fix(studio): a paused save queue reports codes, not the save error's words save_queue_paused spreads the save failure's fixed codes again; its handler lives outside the persistence hook. --- .../components/nle/CompositionBreadcrumb.tsx | 7 +- .../src/hooks/useDomEditCommits.test.tsx | 2 +- packages/studio/src/hooks/useEditorSave.ts | 3 +- .../studio/src/hooks/usePreviewPersistence.ts | 29 ++-- packages/studio/src/telemetry/client.ts | 6 +- .../studio/src/telemetry/eventShape.test.ts | 110 +++++++++++++++ packages/studio/src/telemetry/eventShape.ts | 133 ++++++++++++++++++ .../studio/src/utils/domEditSaveQueue.test.ts | 14 +- packages/studio/src/utils/domEditSaveQueue.ts | 8 +- .../studio/src/utils/sdkResolverShadow.ts | 4 +- .../src/utils/studioSaveDiagnostics.test.ts | 24 +++- .../studio/src/utils/studioSaveDiagnostics.ts | 77 +++++++++- packages/studio/src/utils/studioTelemetry.ts | 7 +- 13 files changed, 385 insertions(+), 39 deletions(-) create mode 100644 packages/studio/src/telemetry/eventShape.test.ts create mode 100644 packages/studio/src/telemetry/eventShape.ts diff --git a/packages/studio/src/components/nle/CompositionBreadcrumb.tsx b/packages/studio/src/components/nle/CompositionBreadcrumb.tsx index 84d376fa0c..e6ea014dfb 100644 --- a/packages/studio/src/components/nle/CompositionBreadcrumb.tsx +++ b/packages/studio/src/components/nle/CompositionBreadcrumb.tsx @@ -27,10 +27,7 @@ export function CompositionBreadcrumb({ stack, onNavigate }: CompositionBreadcru