From d94aa5e3094d352ee27a11a407746e8ba2369da4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20=C3=81ngel?= Date: Tue, 17 Nov 2026 23:34:46 +0000 Subject: [PATCH] docs(ci): say the npm-publish environment needs a reviewer's approval (#8123) --- .github/workflows/publish.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index efa567e0ed..d5b30f596f 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -467,8 +467,8 @@ jobs: concurrency: group: publish-${{ needs.release-source.outputs.version }} cancel-in-progress: false - # npm's trusted publishers name this environment, so every trigger uses it. It has no approval step: - # stable releases come from reviewed release PRs, and only repository admins may push v*-* tags. + # npm's trusted publishers name this environment, so every trigger uses it. A required reviewer + # approves each run, on top of the reviewed release PR; only repository admins may push v*-* tags. environment: npm-publish # This job holds the release credentials, so it runs no code from the # release commit: no install, no build, no repo scripts. It checks the