From e477ec254b962c5037c3504e8c5d6a46cc53db1f Mon Sep 17 00:00:00 2001 From: Vance Ingalls Date: Mon, 10 Aug 2026 08:08:46 -0700 Subject: [PATCH] feat(studio): draw the rack as the signal path it is MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The last of the schematic direction, translated to a one-column panel rather than the wide diagram the review page draws. **Both ends named.** IN — this track, OUT — to mix. Two lines, and they change what the rack is: without them the order reads as a list, and a list is the one reading that makes "move up" look cosmetic. It is the most consequential control in the panel — chain order is audible. **Every step numbered**, counted over what the rack SHOWS rather than over the chain. The carve's filters and an EQ's bands live inside their own modules, so counting raw nodes would leave the visible rack jumping from 02 to 07, and the numbers would read as a bug rather than a position. **A preset draws as one thing.** Applying one used to drop five loose rows in with nothing saying they arrived together — the same failure the carve module exists to fix, one level down. Consecutive nodes only: a preset pulled apart by a reorder is no longer a unit, and a bracket around the gap would claim an adjacency the signal path does not have. Falsified: numbering by chain index fails the path test, and grouping a preset's nodes regardless of adjacency fails the run test. studio 3695 passing, 18 todo. --- .../editor/propertyPanelFxNodeRow.tsx | 14 ++++ .../editor/propertyPanelFxSection.test.tsx | 54 ++++++++++++++++ .../editor/propertyPanelFxSection.tsx | 64 ++++++++++++++++++- 3 files changed, 130 insertions(+), 2 deletions(-) diff --git a/packages/studio/src/components/editor/propertyPanelFxNodeRow.tsx b/packages/studio/src/components/editor/propertyPanelFxNodeRow.tsx index 3c032a4bd9..b7d7e7515b 100644 --- a/packages/studio/src/components/editor/propertyPanelFxNodeRow.tsx +++ b/packages/studio/src/components/editor/propertyPanelFxNodeRow.tsx @@ -73,6 +73,8 @@ function plainDef(def: HfAudioFxDef): HfAudioFxDef { interface FxNodeRowProps { node: HfAudioFxNode; index: number; + /** Where it sits in the signal path, as the rack counts it. Absent means unnumbered. */ + position?: number; automatedTargets?: ReadonlySet; liveAutomationValues?: ReadonlyMap; onAutomateParam?(nodeId: string, paramKey: string): void; @@ -117,6 +119,7 @@ function FxMoveButton({ function FxNodeHeader({ label, family, + position, open, bypassed, first, @@ -130,6 +133,7 @@ function FxNodeHeader({ label: string; /** How this family letters, so the KIND reads before the word does. */ family: string; + position?: number; open: boolean; bypassed: boolean; first: boolean; @@ -142,6 +146,14 @@ function FxNodeHeader({ }) { return (
+ {/* Two digits, because a rack reads as a path when its steps are numbered + and as a list when they are not — and the difference decides whether an + author thinks the order matters. It does; it is audible. */} + {position !== undefined ? ( + + {String(position).padStart(2, "0")} + + ) : null}