From e87f5a6af9acddaf3abf37bff7dc570e89e98393 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20=C3=81ngel?= Date: Mon, 27 Apr 2026 10:10:31 -0400 Subject: [PATCH] fix(producer): use composition metadata for video period detection MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Replaces GSAP visibility probe with composition.videos array for determining which time ranges have active video. The GSAP probe missed subcomposition videos entirely — hf-video-0 was detected as 26-42s when it's actually 0-49.8s. composition.videos has reliable start/end from data-start/data-end attributes, including all subcomposition videos. --- .../src/services/renderOrchestrator.ts | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/packages/producer/src/services/renderOrchestrator.ts b/packages/producer/src/services/renderOrchestrator.ts index 9a1cf2acb2..124ef35893 100644 --- a/packages/producer/src/services/renderOrchestrator.ts +++ b/packages/producer/src/services/renderOrchestrator.ts @@ -1909,12 +1909,24 @@ export async function executeRenderJob( // ── Adaptive state capture ────────────────────────────────────── // pixel-perfect: per-frame CDP during video periods, sparse otherwise // fast (default): sparse states + baked video overlay - const videoRanges = videoOverlays.map((v) => ({ - start: v.dataStart, - end: v.dataEnd, + // + // Use composition.videos (ALL videos including subcompositions) for + // video period detection — more reliable than GSAP visibility probe + // which can miss subcomposition videos. + const videoRanges = composition.videos.map((v) => ({ + id: v.id, + start: v.start, + end: v.end, })); const isInVideoRange = (t: number) => videoRanges.some((r) => t >= r.start && t < r.end); + if (pixelPerfectMode) { + log.info("Video ranges from composition metadata", { + count: videoRanges.length, + ranges: videoRanges.map((r) => `${r.id}[${r.start.toFixed(1)}-${r.end.toFixed(1)}]`), + }); + } + const stateTimes: number[] = []; if (pixelPerfectMode) {