From e976fdbfa1f118e761d5268905e3a667644f8b8c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20=C3=81ngel?= Date: Thu, 5 Nov 2026 04:46:11 +0000 Subject: [PATCH] fix(lint): a video gets no timing from its wrapper, and the docs and hints stop implying it (#7210) --- packages/lint/src/rules/media.test.ts | 16 ++++++++++++++++ packages/lint/src/rules/media.ts | 4 ++-- skills-manifest.json | 2 +- skills/hyperframes/SKILL.md | 2 +- skills/hyperframes/references/format.md | 2 +- 5 files changed, 21 insertions(+), 5 deletions(-) diff --git a/packages/lint/src/rules/media.test.ts b/packages/lint/src/rules/media.test.ts index 908e05491d..aac27a0e67 100644 --- a/packages/lint/src/rules/media.test.ts +++ b/packages/lint/src/rules/media.test.ts @@ -354,6 +354,7 @@ describe("media rules", () => { expect(hint).toContain('id="wrap"'); expect(hint).toContain('data-start="2"'); expect(hint).not.toContain('data-start="0"'); + expect(hint).toContain("takes no timing from it"); // The hint's one step: the video leaves the wrapper and takes its timing. const followed = await codes( @@ -552,6 +553,21 @@ describe("media rules", () => { expect(found).toContain("video_audio_double_source"); }); + it("says a timed video inside a timed wrapper gets no timing from the wrapper, so the wrapper stays untimed", async () => { + const result = await lintHyperframeHtml(` + +
+
+ +
+
+ +`); + const hint = result.findings.find((f) => f.code === "video_nested_in_timed_element")?.fixHint; + expect(hint).toContain("takes no timing from its wrapper"); + expect(hint).not.toContain("wrapper OR the video"); + }); + it("does NOT flag