ext/hyperframes
2
0
Fork 0
mirror of https://github.com/heygen-com/hyperframes.git synced 2026-09-04 16:42:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(engine): reuse HyperFrames browser cache (#2459)

Browse Source 
* fix(engine): reuse HyperFrames browser cache

* test(engine): isolate browser cache home on Windows
This commit is contained in:
Miguel Ángel
2026-07-16 18:20:21 -04:00
committed by GitHub
parent 428e571914
commit f0aee28551
2 changed files with 117 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/engine/src/services/browserManager.test.ts
+60
View File
@@ -1,4 +1,8 @@
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
import { execFileSync } from "node:child_process";
import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
import type { Browser, PuppeteerNode } from "puppeteer-core";
@@ -241,10 +245,13 @@ describe("resolveBrowserGpuMode", () => {
describe("resolveHeadlessShellPath", () => {
const originalHeadlessShellPath = process.env.PRODUCER_HEADLESS_SHELL_PATH;
const originalHyperframesBrowserPath = process.env.HYPERFRAMES_BROWSER_PATH;
afterEach(() => {
if (originalHeadlessShellPath === undefined) delete process.env.PRODUCER_HEADLESS_SHELL_PATH;
else process.env.PRODUCER_HEADLESS_SHELL_PATH = originalHeadlessShellPath;
if (originalHyperframesBrowserPath === undefined) delete process.env.HYPERFRAMES_BROWSER_PATH;
else process.env.HYPERFRAMES_BROWSER_PATH = originalHyperframesBrowserPath;
});
it("throws a clear error when PRODUCER_HEADLESS_SHELL_PATH points at a missing binary", () => {
@@ -254,6 +261,59 @@ describe("resolveHeadlessShellPath", () => {
/Chrome binary not found at PRODUCER_HEADLESS_SHELL_PATH/,
);
});
it("uses HYPERFRAMES_BROWSER_PATH when the CLI resolved a browser explicitly", () => {
const dir = mkdtempSync(join(tmpdir(), "hyperframes-engine-browser-env-"));
try {
const binary = join(dir, "chrome-headless-shell");
writeFileSync(binary, "");
delete process.env.PRODUCER_HEADLESS_SHELL_PATH;
process.env.HYPERFRAMES_BROWSER_PATH = binary;
expect(resolveHeadlessShellPath({})).toBe(binary);
} finally {
rmSync(dir, { recursive: true, force: true });
}
});
it("reuses chrome-headless-shell from the HyperFrames-managed cache", () => {
const home = mkdtempSync(join(tmpdir(), "hyperframes-engine-browser-cache-"));
try {
const binary = join(
home,
".cache",
"hyperframes",
"chrome",
"chrome-headless-shell",
"linux-152.0.7928.2",
"chrome-headless-shell-linux64",
"chrome-headless-shell",
);
mkdirSync(join(binary, ".."), { recursive: true });
writeFileSync(binary, "");
const olderBinary = binary.replace("linux-152.0.7928.2", "linux-99.0.1.1");
mkdirSync(join(olderBinary, ".."), { recursive: true });
writeFileSync(olderBinary, "");
// os.homedir() reads HOME on POSIX and USERPROFILE on Windows.
const env = { ...process.env, HOME: home, USERPROFILE: home };
delete env.PRODUCER_HEADLESS_SHELL_PATH;
delete env.HYPERFRAMES_BROWSER_PATH;
const moduleUrl = new URL("./browserManager.ts", import.meta.url).href;
const stdout = execFileSync(
"bun",
[
"--eval",
`import(${JSON.stringify(moduleUrl)}).then(({ resolveHeadlessShellPath }) => process.stdout.write(resolveHeadlessShellPath({}) ?? ""))`,
],
{ encoding: "utf8", env },
);
expect(stdout).toBe(binary);
} finally {
rmSync(home, { recursive: true, force: true });
}
});
});
describe("forceReleaseBrowser", () => {