mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-10 22:20:14 +00:00
fix(studio): keyframe bug fixes — gate delete hooks, fix value corruption, gesture recording (#1314)
- Gate stripStudioEditsFromTarget/bakeVisibilityOnDelete behind a stripStudioEdits flag on the delete mutation type so they only fire on user-initiated deletes, not on internal delete-then-recreate drags. - Add bakeVisibilityOnDelete to the remove-all-keyframes handler so elements with CSS opacity:0 stay visible after collapsing keyframes. - Fix integer rounding in readAllAnimatedProperties: use 3-decimal precision for visual properties (opacity, scale, rotation) instead of Math.round which corrupted mid-fade values to 0. - Guard VISUAL_BASELINE against cross-tween contamination by querying __timelines for properties animated by other tweens on the same element. - Harden bakeVisibilityOnDelete: reverse-scan keyframes for the last one containing opacity, guard against relative values (+=/-=/*=), and add Number.isFinite check. - Fix falsy-zero doubling in drag commit: replace || fallback with Number.isFinite so a base GSAP position of 0 is correctly preserved. - Fix gesture recording sign inversion: remove pointerElementOffset subtraction from dx/dy formula and instead apply it once to basePosition so the element center tracks the pointer. - Fix TypeScript build errors in gsapSoftReload.ts (6 double-casts). - Strip all diagnostic logs from production code.
This commit is contained in:
@@ -138,9 +138,6 @@ export function useLayerDrag({
|
||||
const container = scrollContainerRef.current;
|
||||
if (!container) return;
|
||||
|
||||
e.preventDefault();
|
||||
container.setPointerCapture(e.pointerId);
|
||||
|
||||
dragRef.current = {
|
||||
pointerId: e.pointerId,
|
||||
startY: e.clientY,
|
||||
@@ -163,6 +160,12 @@ export function useLayerDrag({
|
||||
if (!drag.activated) {
|
||||
if (Math.abs(e.clientY - drag.startY) < DRAG_THRESHOLD_PX) return;
|
||||
drag.activated = true;
|
||||
const container = scrollContainerRef.current;
|
||||
if (container && drag.pointerId != null) {
|
||||
try {
|
||||
container.setPointerCapture(drag.pointerId);
|
||||
} catch {}
|
||||
}
|
||||
setDragKey(visibleLayers[drag.dragLayerIndex]?.key ?? null);
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user