mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-03 12:54:29 +00:00
feat: CLI observability + fix studio save failures on JS-created elements (#1091)
* feat(core): add probeElementInSource for source-existence checks
* feat(core): add probe-element endpoint for source-existence checks
* feat(studio): gate editing capabilities on source existence
* fix(studio): enrich save_failure telemetry with target details
* feat(studio): async selection resolution with source probe
Make `resolveDomEditSelection` async and wire a `probeSourceElement` call
into the selection path so elements generated by scripts (not present in the
source HTML) are detected early and have all edit capabilities disabled with
a clear reason message ("This element is generated by a script and cannot be
edited visually.").
Part A – core probe logic:
- `domEditingLayers.ts`: `resolveDomEditSelection` is now async; calls
`probeSourceElement` (POST /api/projects/:id/file-mutations/probe-element/:file)
when `projectId` is supplied and the element has a stable id/selector.
`existsInSource: false` flows into `resolveDomEditCapabilities`, which
disables all write capabilities with the appropriate reason.
- `domEditingLayers.ts`: `refreshDomEditSelection` promoted to async.
- `files.ts`: new `probe-element` route; extracted `resolveProjectPath`,
`resolveFileMutationContext`, `writeIfChanged`, and `parseMutationBody`
helpers to eliminate repeated boilerplate across remove/patch/probe handlers.
Part B – caller propagation (all eight consumer sites):
- `useDomSelection.ts`: `buildDomSelectionFromTarget`,
`resolveDomSelectionFromPreviewPoint`,
`buildDomSelectionForTimelineElement`, `handleTimelineElementSelect`,
`refreshDomEditSelectionFromPreview`, and
`refreshDomEditGroupSelectionsFromPreview` all made async; `projectId`
forwarded into `resolveDomEditSelection`.
- `useDomEditCommits.ts`, `useDomEditTextCommits.ts`: updated
`buildDomSelectionFromTarget` parameter type; added `await` at call sites.
- `useDomEditSession.ts`: inner `syncSelectionFromDocument` made async; fire
with `void` to satisfy the surrounding effect.
- `usePreviewInteraction.ts`: `handlePreviewCanvasMouseDown` and
`handlePreviewCanvasPointerMove` made async (React ignores handler return
values, so this is safe).
- `useStudioUrlState.ts`: deferred `buildDomSelectionFromTarget` call
converted to `.then()` chain with `void` prefix so the effect stays sync.
- `LayersPanel.tsx`: `seekToLayer`, `handleSelectLayer`, and
`handleLayerHover` made async.
- `DomEditOverlay.tsx` / `useDomEditOverlayGestures.ts`: `onCanvasPointerMove`
return type widened to `Promise<DomEditSelection | null>`; pointer-down
handler falls back to `hoverSelectionRef.current` (always populated by a
prior hover) instead of awaiting the async move callback inline.
Part C – test and tooling fixes:
- `lefthook.yml`: filesize hook shell loop explicitly skips `*.test.ts/tsx`
files as a guard against a lefthook v2.1.6 bug where `exclude` patterns are
not applied to `{staged_files}` in shell scripts.
- `domEditing.test.ts`: all `it()` blocks calling `resolveDomEditSelection`
made async with `await`.
- `DomEditOverlay.test.ts`: mock updated to return `Promise.resolve(selection)`
and `hoverSelection` pre-seeded so pointer-down test works with the new
hover-first path.
- `studioUrlState.test.ts`: `buildDomSelectionFromTarget` mocks wrapped in
`Promise.resolve()`; seek/selection hydration test made async with
`await act(async () => { await Promise.resolve(); })` to flush microtasks.
* feat(cli): add global error handlers for crash telemetry
Register process-level uncaughtException and unhandledRejection handlers
that fire trackCliError so unhandled crashes are captured in telemetry.
Add the trackCliError function to events.ts and re-export it from the
telemetry barrel.
* feat(cli): track per-command success/failure and duration
* test(core): add integration test for JS-created element probe scenario
* fix: address PR review feedback
- uncaughtException handler now calls process.exit(1) after flushing
- cli_command_result uses real exit code from process "exit" event
- drop stack_trace from cli_error (contains filesystem paths)
- skip source probe during hover — only probe on click/selection
- format .fallowrc.jsonc
* fix(cli): restore stack_trace in cli_error telemetry
* fix(cli): use captured module refs in exit handlers instead of dead import()
This commit is contained in:
+55
-2
@@ -148,12 +148,26 @@ const hasJsonFlag = process.argv.includes("--json");
|
||||
// exit handler is synchronous-only).
|
||||
let _flush: (() => Promise<void>) | undefined;
|
||||
let _flushSync: (() => void) | undefined;
|
||||
let _trackCliError:
|
||||
| ((props: {
|
||||
error_name: string;
|
||||
error_message: string;
|
||||
stack_trace?: string;
|
||||
command?: string;
|
||||
kind: "uncaught_exception" | "unhandled_rejection" | "command_error";
|
||||
}) => void)
|
||||
| undefined;
|
||||
let _trackCommandResult:
|
||||
| ((props: { command: string; success: boolean; exitCode: number; durationMs: number }) => void)
|
||||
| undefined;
|
||||
let _printUpdateNotice: (() => void) | undefined;
|
||||
|
||||
if (!isHelp && command !== "telemetry" && command !== "unknown") {
|
||||
import("./telemetry/index.js").then((mod) => {
|
||||
_flush = mod.flush;
|
||||
_flushSync = mod.flushSync;
|
||||
_trackCliError = mod.trackCliError;
|
||||
_trackCommandResult = mod.trackCommandResult;
|
||||
mod.showTelemetryNotice();
|
||||
mod.trackCommand(command);
|
||||
if (mod.shouldTrack()) mod.incrementCommandCount();
|
||||
@@ -176,17 +190,56 @@ if (!isHelp && !hasJsonFlag && command !== "upgrade") {
|
||||
});
|
||||
}
|
||||
|
||||
const commandStart = Date.now();
|
||||
let commandFailed = false;
|
||||
|
||||
// Async flush for normal exit (beforeExit fires when the event loop drains)
|
||||
process.on("beforeExit", () => {
|
||||
_flush?.().catch(() => {});
|
||||
if (!hasJsonFlag) _printUpdateNotice?.();
|
||||
});
|
||||
|
||||
// Sync flush for process.exit() calls (exit event only allows synchronous code)
|
||||
process.on("exit", () => {
|
||||
// Sync-only: exit handlers cannot await promises or drain microtasks.
|
||||
// _trackCommandResult / _trackCliError are captured references resolved
|
||||
// at init time, so they're callable synchronously here.
|
||||
process.on("exit", (code) => {
|
||||
_trackCommandResult?.({
|
||||
command,
|
||||
success: code === 0 && !commandFailed,
|
||||
exitCode: code,
|
||||
durationMs: Date.now() - commandStart,
|
||||
});
|
||||
_flushSync?.();
|
||||
});
|
||||
|
||||
process.on("uncaughtException", (error) => {
|
||||
commandFailed = true;
|
||||
_trackCliError?.({
|
||||
error_name: error.name,
|
||||
error_message: error.message,
|
||||
stack_trace: error.stack,
|
||||
command,
|
||||
kind: "uncaught_exception",
|
||||
});
|
||||
_flushSync?.();
|
||||
process.exit(1);
|
||||
});
|
||||
|
||||
// unhandledRejection does not call process.exit() — Node may continue
|
||||
// running if the rejection is non-fatal (e.g. a fire-and-forget promise).
|
||||
// The exit handler above will still fire with the real exit code.
|
||||
process.on("unhandledRejection", (reason) => {
|
||||
commandFailed = true;
|
||||
const error = reason instanceof Error ? reason : new Error(String(reason));
|
||||
_trackCliError?.({
|
||||
error_name: error.name,
|
||||
error_message: error.message,
|
||||
stack_trace: error.stack,
|
||||
command,
|
||||
kind: "unhandled_rejection",
|
||||
});
|
||||
});
|
||||
|
||||
// Lazy-load help renderer — avoids allocating help data on non-help invocations
|
||||
async function showUsage<T extends ArgsDef>(
|
||||
cmd: CommandDef<T>,
|
||||
|
||||
Reference in New Issue
Block a user