mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-19 11:26:02 +00:00
fix: refuse media paths that ffmpeg's image2 demuxer would read as a pattern (#8047)
* fix: refuse media paths that ffmpeg's image2 demuxer would read as a pattern ffmpeg's image2 demuxer reads %d, %03d, %% and a % before a wildcard in an input path as a pattern of other files, folders included. Every project, private-file and received-file check approves the literal path, so a composition could name a placeholder whose pattern reaches images outside the project and get them back as video frames. Every ffmpeg and ffprobe input built from a project file now goes through assertLiteralMediaInput, which refuses such a local path before ffmpeg runs. The engine's urlInputArgs, the parsers' mediaInputFormatArgs and the studio-server's new mediaInputArgs all take the input path, so the CLI snapshot and cloud offload, lint, core grade analysis and studio-server callers are covered too. URLs and other percent signs, such as %20, are read as before. * build(parsers): declare the literal-media-input subpath * build: raise the parsers packed-size budget for the literal-media-input subpath The new subpath adds its own built entry, type file and export map rows, about 2.7 KB packed. It is a separate module so test suites that mock ff-binaries still run the real path check. * test(parsers): a harmless name shaped like a pattern is refused too
This commit is contained in:
@@ -36,7 +36,7 @@ import { bytesMatchExtension } from "./offloadSniff.js";
|
||||
import {
|
||||
AUDIO_EXTS,
|
||||
CONVERTIBLE_IMAGE_EXTS,
|
||||
MEDIA_INPUT_ARGS,
|
||||
mediaInputArgs,
|
||||
startsAsMediaPlaylist,
|
||||
VIDEO_EXTS,
|
||||
} from "@hyperframes/studio-server/outside-file";
|
||||
@@ -246,7 +246,7 @@ async function probeVideo(path: string): Promise<VideoProbe> {
|
||||
"stream=codec_name,pix_fmt,color_primaries,color_transfer,color_space:stream_tags",
|
||||
"-of",
|
||||
"json",
|
||||
...MEDIA_INPUT_ARGS,
|
||||
...mediaInputArgs(path),
|
||||
"--",
|
||||
path,
|
||||
]);
|
||||
@@ -295,13 +295,13 @@ async function segmentArgs(
|
||||
segments: PlayedSegment[] | undefined,
|
||||
media: "audio" | "image" | "video",
|
||||
): Promise<string[]> {
|
||||
if (media === "image") return [...decoder, ...MEDIA_INPUT_ARGS, "-i", sourcePath];
|
||||
if (media === "image") return [...decoder, ...mediaInputArgs(sourcePath), "-i", sourcePath];
|
||||
const audio = await keptAudio(sourcePath, media);
|
||||
const cuts = segments?.length ? segments : [undefined];
|
||||
const inputs = cuts.flatMap((s) => [
|
||||
...decoder,
|
||||
...seekArgs(s),
|
||||
...MEDIA_INPUT_ARGS,
|
||||
...mediaInputArgs(sourcePath),
|
||||
"-i",
|
||||
sourcePath,
|
||||
]);
|
||||
@@ -313,7 +313,7 @@ async function segmentArgs(
|
||||
}
|
||||
|
||||
async function keptAudio(sourcePath: string, media: "audio" | "video"): Promise<number | null> {
|
||||
const audio = (await probeAudio(sourcePath, MEDIA_INPUT_ARGS))?.audioStream ?? null;
|
||||
const audio = (await probeAudio(sourcePath, mediaInputArgs(sourcePath)))?.audioStream ?? null;
|
||||
if (media === "audio" && audio === null) {
|
||||
throw new Error("the file has no audio track ffmpeg can decode");
|
||||
}
|
||||
@@ -374,7 +374,7 @@ async function durationSeconds(sourcePath: string): Promise<number | null> {
|
||||
"format=duration",
|
||||
"-of",
|
||||
"csv=p=0",
|
||||
...MEDIA_INPUT_ARGS,
|
||||
...mediaInputArgs(sourcePath),
|
||||
"--",
|
||||
sourcePath,
|
||||
]);
|
||||
@@ -466,7 +466,7 @@ async function isAnimatedImage(path: string): Promise<boolean> {
|
||||
"stream=nb_frames",
|
||||
"-of",
|
||||
"csv=p=0",
|
||||
...MEDIA_INPUT_ARGS,
|
||||
...mediaInputArgs(path),
|
||||
"--",
|
||||
path,
|
||||
]);
|
||||
@@ -491,7 +491,7 @@ async function trimGrid(sourcePath: string, kind: MediaKind): Promise<number | n
|
||||
"stream=r_frame_rate,avg_frame_rate",
|
||||
"-of",
|
||||
"csv=p=0",
|
||||
...MEDIA_INPUT_ARGS,
|
||||
...mediaInputArgs(sourcePath),
|
||||
"--",
|
||||
sourcePath,
|
||||
]);
|
||||
@@ -517,7 +517,7 @@ async function hasVideoStream(sourcePath: string): Promise<boolean> {
|
||||
"stream=codec_type",
|
||||
"-of",
|
||||
"csv=p=0",
|
||||
...MEDIA_INPUT_ARGS,
|
||||
...mediaInputArgs(sourcePath),
|
||||
"--",
|
||||
sourcePath,
|
||||
]);
|
||||
|
||||
Reference in New Issue
Block a user