Commit Graph
9 Commits
Author SHA1 Message Date
Vance IngallsandClaude Fable 5.1 7b65cb98e7 fix(producer): concat directly on a full segmented resume and document the retry surface
Review follow-ups on the R3 hardening PR:

- A resume that finds every segment complete no longer opens a browser: the
  stage closes the probe it was handed, concatenates the plan's segment list
  and returns success. A stage test asserts the session factory is never
  called on that path.
- retryAfterTargetLoss notes that its recycle also resets the worker's
  cadence counter (intended: the fresh browser is as new as a cadence restart).
- The long-form README gains a Known cost section on the narrower retry
  surface of segmented capture versus plain streaming, and an operational
  note that renders/.hf-segments/<planHash>/ persists after failure by design
  and that the plan hash now covers GPU encoder, output resolution and motion
  blur.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-18 20:53:13 -07:00
Vance IngallsandClaude Fable 5.1 072750168d docs(long-form): point the fixture README at the ticket, not a plans path
Spec and planning docs are not committed to this repo.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-18 20:53:13 -07:00
Vance IngallsandClaude Fable 5.1 17cf030b93 docs(long-form): fault-injection validation of the R3 retry paths
Four renders on the 60 s fixture, one injected failure each: ffmpeg killed
mid-stream, one worker's Chrome killed, the same under the manual
HF_DE_PARALLEL_STREAM opt-in, and one worker frozen with SIGSTOP under a 5 s
stall window. All four retried on one worker and delivered all 1800 frames;
the worker death surfaced its own error in 0.9 s instead of a 60 s stall
relabel, and the opt-in cohort retried at one worker instead of N. Records
the one caveat: a frozen renderer cannot observe the pool abort, so that
retry waits for the pool to settle.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-18 20:53:13 -07:00
Vance IngallsandClaude Fable 5.1 77dd1da8da docs(long-form): gate the R3 route on the PRINFRA-694 fixture, record the hardening
- tests/long-form/README: the two-clip in-flow fixture, the per-frame luma
  check over clip B, the 2026-09-18 matrix (branch -w 1 / -w 2 disk / -w 2
  streaming / absolute CSS / published 0.8.44 all 0 of 100 black; 0.8.35 and
  0.8.36 99 of 100 as the positive control; fixed in 0.8.37 by #3893), and
  why the multi-worker trace's captureMode was not the engine's mode.
- HANDOFF: R3 row now reads "hardening built"; new section 4a lists the
  guards, the 694 gate result and what the flip still needs; counts refreshed.
- cli.mdx: the parallel-stream paragraph says the opt-in path now retries a
  stalled pool or a mid-stream encoder exit on a fresh single-worker session.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-18 20:53:12 -07:00
Vance IngallsandClaude Opus 5 c4ccd9d6a2 docs(cli): document segmented capture and record the Phase 2d gate
Three workers produced a byte-identical file to the single-worker segmented
render at 1.6x the speed, which is the property the gate exists to check:
segments finish out of order, so a mismatch would mean the concat list had
picked up completion order instead of the plan.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-18 20:53:08 -07:00
Vance IngallsandClaude Opus 5 79a4b02d78 test(producer): record the Phase 2c gate result
Recycling the browser on every segment produced a byte-identical file to
the single-session render, which is what makes the target-loss retry safe:
a segment re-captured on a fresh session is indistinguishable from one that
never failed. Five launches cost ~5 s, and each recycle reported a renderer
RSS peak of ~1.4 GB being returned.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-18 20:53:06 -07:00
Vance IngallsandClaude Opus 5 ae6aedf1ca fix(cli): pass the segmented resume flags from the plan into render options
execute.ts is where the plan becomes RenderOptions, and it dropped both new
flags, so --keep-segments deleted the segment directory anyway and --resume
never resumed. Nothing failed: the render just silently re-captured
everything. Caught by the Phase 2b gate, which is the only check that spans
plan -> options -> request -> config; the gate doc now says so.

Gate result recorded: killed at 2 of 6 segments, resume skipped both,
finished in 3m32 against 5m13, and the output was byte-identical to the
uninterrupted render.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-18 20:53:04 -07:00
Vance IngallsandClaude Opus 5 7000e32942 test(producer): record the Phase 2a gate result and its real pass criteria
The spec's "PSNR >= 45 dB vs the single-encoder output" reads as a failure
on a healthy render: the measured average is 44.4 dB because segmented
capture forces a closed GOP with scene-cut detection off, and two CRF
encodes of identical frames differ regardless. The boundary frames are the
HIGHEST-PSNR frames in the series (48-62 dB forced IDRs), which is what the
gate should actually assert.

Also records the cost this buys nothing back on: the segmented stage runs
the plain capture loop rather than the depth-2 worker-encode pipeline, so
the same fixture takes 5m16 against streaming's 2m43.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-18 20:53:02 -07:00
Vance IngallsandClaude Opus 5 ac946ef11b test(producer): add long-form render fixture generator and manual gate notes
The §8 fixtures every phase's manual gate renders against: one 300 s video
spanning the whole composition, and the same source cut into 60 clips.
Committed as a generator rather than fixtures because the source alone is
~600 MB.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-09-17 17:03:40 -07:00