2 Commits

Include renames

Author	SHA1	Message	Date
Vance IngallsandClaude Opus 4.8	dd6fad6bb2	fix(sdk): code-review follow-ups (WS-B/C/3.C, #1569/#1570/#1572) (#1588) ... Addresses the still-outstanding review concerns from merged PRs #1569 / #1570 / #1572 not already hoisted into #1573. WS-B (#1569): - validateVariables requires discriminant fields for object-valued font/image ({name,source} / {url}); a {name:42} font or {foo:42} image previously passed runtime validation and surfaced as a bogus font-family / missing image. - Dropped ImageValue's [key:string]:unknown index signature (let any {url}-shaped object through, swallowed typos); explicit alt?/fit? instead. - Documented the OverrideSet widening for SDK consumers. WS-C (#1570): - getElementTimings caches parsed GSAP labels by exact script text (avoids a full acorn re-parse per read; content-key invalidates on edit). - Documented end-inclusive label window + best-effort extractGsapLabels catch. WS-3.C (#1572): - Added typed Composition.addWithKeyframes / replaceWithKeyframes (was asymmetric with addGsapTween; Studio had to use raw dispatch). - Extracted shared KeyframeSpec type; documented position as seconds/number-only. Gates: build + core 18/18 + sdk 19/19 + oxlint + oxfmt + fallow + typecheck all green. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-19 00:07:53 -07:00
3 people	5ecaac1fcb	feat(sdk): can() returns CanResult; T4 dispatch-boundary tests (#1426) ... * feat(sdk): can() returns CanResult; T4 dispatch-boundary tests * fix(sdk): 8 code-review correctness fixes - setGsapScript: remove element when newScript="" (fixes undo/redo duplicate-script bug) - parseDeclarations: track quotes so ; inside CSS values (data URIs) doesn't split - handleRemoveGsapKeyframe: guard against duplicate-percentage ambiguity (return EMPTY) - resolveKeyframe: return kfs so callers can check uniqueness - handleSetClassStyle: emit op:"add" (not "replace") when no prior <style> element - FsAdapter listVersions: Number(f.split("_")[0]) — was NaN due to underscore in key - FsAdapter doWrite: split try/catch so appendVersion failure doesn't fire error handlers - FileAdapter playground: add content:"" field to satisfy PersistVersionEntry contract Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(sdk): export CanResult from package root so callers can switch on result.code Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Miguel Ángel <miguel07alm@protonmail.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com> Co-authored-by: Miguel Ángel <miguel07alm@protonmail.com>	2026-06-15 02:02:37 -07:00