Commit Graph
3144 Commits
Author SHA1 Message Date
Vance Ingalls ad6bfdd9bd chore: merge in the PropertyPanel timeout fix 2026-08-13 00:50:00 -07:00
Vance Ingalls d02190a395 chore: merge in the PropertyPanel timeout fix 2026-08-13 00:49:59 -07:00
Vance Ingalls 2ea9b382d0 chore: merge in the PropertyPanel timeout fix 2026-08-13 00:49:57 -07:00
Vance Ingalls aa4c87501f chore: merge in the PropertyPanel timeout fix 2026-08-13 00:49:56 -07:00
Vance Ingalls 011a9f0a8d chore: merge in the PropertyPanel timeout fix 2026-08-13 00:49:55 -07:00
Vance Ingalls 4efaa33764 chore: merge in the PropertyPanel timeout fix 2026-08-13 00:49:54 -07:00
Vance Ingalls cfd5551dd5 chore: merge in the PropertyPanel timeout fix 2026-08-13 00:49:53 -07:00
Vance Ingalls a81b6522d1 chore: merge in the PropertyPanel timeout fix 2026-08-13 00:49:52 -07:00
Vance Ingalls 93c7abf0ff chore: merge in the PropertyPanel timeout fix 2026-08-13 00:49:51 -07:00
Vance Ingalls 06aff52cea fix(studio): widen PropertyPanel's resetModules render timeout again
The 20s margin (already once widened for the same reason) is timing out in
CI's full-monorepo Test run — the resetModules()+fresh-import render this
test needs is uncached and competes with every other package's test suite
for the same worker pool, and the same test passes in well under 2s
standalone. Went to 45s rather than re-tuning to whatever number happens to
clear the current CI load, since that number moves every time CI gains a
package.
2026-08-13 00:49:31 -07:00
Vance Ingalls 64eccec643 chore: merge in the carve regex+overlap fix 2026-08-13 00:46:30 -07:00
Vance Ingalls 009fb88239 fix(core): stop \b from missing underscore-separated names, guard clipsOverlap's negative duration
\b treats `_` as a word character, so \bbed\b never matched bed_01,
music_bed_loop, or theme_song, and \bvo\b/\bvox\b/\btts\b had the same gap —
an underscore-separated bed classified as "unknown" and could end up offered
as its own carve source. Replaced the short hints with a boundary that
actually excludes letters and digits on both sides.

clipsOverlap computed end = start + duration without guarding sign, so a
negative duration put end before start — an interval that does not describe
anything, and one specific case showed it silently dropping a real overlap
(a shorter, earlier broken end rejected a clip that genuinely contained the
point). Duration clamps to zero instead: a clip cannot un-play time, and a
zero-length clip at its start is the sane reading of "duration nobody wrote
down as positive."

Review by Miga (PR #3212).
2026-08-13 00:42:18 -07:00
Vance Ingalls 06588304a5 chore: merge in the waveform cache key fix 2026-08-13 00:27:54 -07:00
Vance Ingalls a5478a06c3 chore: merge in the waveform cache key fix 2026-08-13 00:27:52 -07:00
Vance Ingalls 9d0b75b5aa chore: merge in the waveform cache key fix 2026-08-13 00:27:51 -07:00
Vance Ingalls bed05ba791 chore: merge in the waveform cache key fix 2026-08-13 00:27:49 -07:00
Vance Ingalls 3722f9c17c chore: merge in the waveform cache key fix 2026-08-13 00:27:48 -07:00
Vance Ingalls 32598dd902 chore: merge in the waveform cache key fix 2026-08-13 00:27:47 -07:00
Vance Ingalls 248fd701f4 chore: merge in the waveform cache key fix 2026-08-13 00:27:46 -07:00
Vance Ingalls f6fc7e90a3 fix(studio-server): fingerprint the proactive waveform cache key too
The route already keys the waveform cache on the asset's size and mtime as
well as its path, so a rebuilt-in-place file gets fresh peaks instead of
stale ones. generateWaveformCache — the proactive path that runs on upload —
still called buildWaveformCacheKey with the path alone, so it wrote to a
different key than the route reads from (making the pre-generated cache
never found) and kept the exact collision bug this fingerprint exists to fix
on its own path.

Review by Miga (PR #3211).
2026-08-13 00:27:34 -07:00
Vance Ingalls ddaae3ef59 chore: merge in the via-conic NaN fix 2026-08-13 00:19:01 -07:00
Vance Ingalls f790a7fc6c chore: merge in the via-conic NaN fix 2026-08-13 00:19:00 -07:00
Vance Ingalls 70c3191edb chore: merge in the via-conic NaN fix 2026-08-13 00:18:59 -07:00
Vance Ingalls 9fc52ee266 chore: merge in the via-conic NaN fix 2026-08-13 00:18:58 -07:00
Vance Ingalls f21d4d15eb chore: merge in the via-conic NaN fix 2026-08-13 00:18:57 -07:00
Vance Ingalls 4ceeb6ffff chore: merge in the via-conic NaN fix 2026-08-13 00:18:56 -07:00
Vance Ingalls 024470cdef chore: merge in the via-conic NaN fix 2026-08-13 00:18:55 -07:00
Vance Ingalls adbc910c7b chore: merge in the via-conic NaN fix 2026-08-13 00:18:54 -07:00
Vance Ingalls 36b63cc6b4 chore: merge in the via-conic NaN fix 2026-08-13 00:18:52 -07:00
Vance Ingalls 9e828a0d32 fix(core): cap the via conic's weight so an edge-clamped via point can't NaN
A via point pulled out past the segment (viaX: 5, viaY: -3) clamps to
(0.999, 0.001) — exactly on the steady region's edge, where edge - viaX is 0.
viaConic divided by that zero to get an infinite weight, and shapeVia turned
Infinity into NaN a few steps later (Infinity - Infinity in the quadratic
coefficient). NaN reaching setValueCurveAtTime silences the automated
parameter for the rest of the render.

Capped the weight at 1e6 instead of leaving it unbounded — past that point
the arc already reads as touching the via point, so nothing visible is lost.
Also hardened shapeVia's existing denominator guard (`<= 0`) to `!(> 0)`,
since NaN fails the original comparison and fell through it.

Review by Miga (PR #3208).
2026-08-13 00:18:25 -07:00
Vance Ingalls e0a510edba chore: merge in the wa-18b-reschedule fallow/typecheck fix 2026-08-13 00:07:27 -07:00
Vance Ingalls 51f144c857 chore: merge in the wa-18b-reschedule fallow/typecheck fix 2026-08-13 00:07:27 -07:00
Vance Ingalls 577002a9ad chore: merge in the wa-18b-reschedule fallow/typecheck fix 2026-08-13 00:07:27 -07:00
Vance Ingalls 67bcf88a84 chore: merge in the wa-18b-reschedule fallow/typecheck fix 2026-08-13 00:07:27 -07:00
Vance Ingalls 00d0b2a9a4 chore: merge in the wa-18b-reschedule fallow/typecheck fix
Drops export from automationLaneCountOf/trackAutomationLaneCount, whose
only external caller (TimelineTrackHeader.tsx's old resolveAutomationRows
path) this merge replaces with wa-18h's own groupAutomationLanes-based
automationRows.
2026-08-13 00:07:27 -07:00
Vance Ingalls d99328497c chore: merge in the wa-18b-reschedule fallow/typecheck fix 2026-08-13 00:07:27 -07:00
Vance Ingalls aed1e7bf02 chore: merge in the wa-18b-reschedule fallow/typecheck fix 2026-08-13 00:07:27 -07:00
Vance Ingalls 252b1c2fe2 chore: merge in the wa-18b-reschedule fallow/typecheck fix 2026-08-13 00:07:27 -07:00
Vance Ingalls 32d4918e5d merge: pull in the wa-18b-reschedule fallow/typecheck fix
Also re-exports formatHz, which propertyPanelFxSection.tsx here imports
externally — wa-18b-reschedule's own fallow fix had dropped the export
since it was only used internally there.
2026-08-13 00:07:26 -07:00
Vance IngallsandClaude Opus 5 4dacf2842e fix(studio): close the typecheck and fallow gaps wa-18b-reschedule opened
useAutomationLanes.ts's write() assumed gesture-scoped coalescing and a
preview-only commit that useDomEditAttributeCommits.ts never grew — backported
that option support from its own later commit so the two sides of the API
agree. The paste path and its tests were missing the box selection's v0/v1
bounds a sibling commit added to AutomationSelection. The FX panel's carve
controls still edited the six mechanism numbers (maxCutDb, bands,
intelligibilityBias) after carveProfile() collapsed authoring to one Strength
knob, so those fields no longer existed on HfCarveSettings; UI now edits
strength, and analyseCarveBands is called with carveProfile(strength).

Also closes fallow's complexity, dead-code and duplication findings on this
PR's diff: extracted automationLaneDragMath.ts (pure group/point-move math)
and useAutomationRangeDrag.ts (the marquee-select gesture) out of
useAutomationLaneGestures.ts, pulled a couple of render-loop ternaries and a
resolver into named functions, dropped an export nothing outside its file
used, and shared a step-simplifier between audioCarve's two envelope
builders.

The edge-stretch vs. box-select priority test in TimelineAutomationLane.test
was still pinning the pre-box-select rule (edge wins over a point sitting on
it) that a sibling commit deliberately reversed — a point inside the box is
now selected content, so grabbing it drags the group instead. Updated the
test to the shipped rule instead of the old one.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-12 23:30:27 -07:00
Vance Ingalls 059cbeff69 merge: pull in the PR #3208 conflict fix 2026-08-12 22:42:06 -07:00
Vance Ingalls 2313aec3b5 merge: pull in the PR #3208 conflict fix 2026-08-12 22:42:05 -07:00
Vance Ingalls 6c8c2b1860 merge: pull in the PR #3208 conflict fix 2026-08-12 22:42:04 -07:00
Vance Ingalls 9f3963d026 merge: pull in the PR #3208 conflict fix 2026-08-12 22:42:03 -07:00
Vance Ingalls de04d9fd85 merge: pull in the PR #3208 conflict fix 2026-08-12 22:42:02 -07:00
Vance Ingalls 0122e1bce4 merge: pull in the PR #3208 conflict fix 2026-08-12 22:42:01 -07:00
Vance Ingalls bcc37475cb merge: pull in the PR #3208 conflict fix 2026-08-12 22:41:44 -07:00
Vance Ingalls 1befa91447 merge: pull in the PR #3208 conflict fix 2026-08-12 22:41:43 -07:00
Vance Ingalls 8e748ac1e7 merge: pull in the PR #3208 conflict fix 2026-08-12 22:41:43 -07:00
Vance Ingalls ea18fb5f55 Merge remote-tracking branch 'origin/main' into wa-18b-reschedule 2026-08-12 22:38:02 -07:00