Commit Graph
8 Commits
Author SHA1 Message Date
Michael Wang 3e788fb15a fix(cli): show control characters in printed names as visible escapes (#8008)
* fix(cli): project folder names print control characters as visible escapes

check, info, compositions, benchmark, play, present and preview printed the
project folder name, and in places the project path, straight to the
terminal. A folder name can hold escape bytes on Linux and macOS, so a
received project could move the cursor, rewrite earlier lines, set the
window title or write the clipboard. Those lines now go through
terminalText(), as validate, snapshot, layout and lint already do. This
covers the preview summary, --status, --stop, --list and --kill-all lines,
and the check report path. The CLI's own colours stay, and --json output is
unchanged.

The play page also HTML-escapes the name in its title and footer, as the
present page does.

* fix(cli): preview --selection and --context print Studio text as visible escapes

The human output of preview --selection and --context printed the selected
element's label, source file, target and thumbnail URL, and the preview
server's project name, straight to the terminal. These come from the
composition or from whichever preview server answers, so control characters
in them could move the cursor, rewrite earlier lines, set the window title
or write the clipboard. They now go through terminalText(), as do the
failure messages these commands print. The CLI's own colours stay, and
--json output is unchanged.

* fix(cli): cloud get, list and delete print server fields as visible escapes

The human output of cloud get printed render fields from the server, such
as the failure message, title, composition and URLs, straight to the
terminal. A failure message can quote text from the rendered project, so
control characters in it could move the cursor, rewrite earlier lines, set
the window title or write the clipboard. cloud get, cloud list (rows and
the next-page token) and cloud delete now pass those fields through
terminalText(). The CLI's own colours stay, and --json output is unchanged.

* fix(inspector): the live inspection stamp gives the page only the generation id

prepareLiveInspection wrote the project's absolute path into the preview
page as window.__hfLiveInspection.project. Nothing in the page reads it, but
any composition script on that page could, which told it the account name
and folder layout. The page now gets only the generation id; the project
path stays with the host that prepared the page.

* fix(skills): locate.mjs keeps its grid font in a private per-run folder

locate.mjs drew its grid labels with a font at the fixed shared path
/tmp/locate-font.ttf. It used whatever file was already there and copied a
system font onto that path otherwise, following any link in its place. On a
machine shared with other accounts, someone else could plant that file
first, so the grid showed wrong numbers, a file appeared where they chose,
or every run failed.

The font is now copied into a folder made with mkdtemp (mode 0700) for each
run and removed when the run ends, so no file another account can create is
read or written. The skills manifest hash is regenerated.

* fix: escape the check report path and lint warnings, and harden locate.mjs font cleanup

check's report path notice and its not-recorded warning, and preview's
"Lint did not finish" warning, now print control characters as visible
escapes, like the other lines that carry the project path.

locate.mjs escapes the font path for ffmpeg's filter syntax, so a temp
folder with ':', ',', quotes or brackets in its name still works, and it
removes its font folder when the run is stopped by SIGINT or SIGTERM before
re-raising the signal.

play and present share one HTML escape helper.

* refactor(cli): keep the shared HTML escape helper within the comment budget

* fix: one HTML escape helper for the CLI, and locate.mjs escapes its font path in one pass

The sign-in callback page uses the shared escapeHtml helper, which now also
escapes single quotes.

locate.mjs escapes the font path for ffmpeg's option list and filtergraph
in a single replacement with the same result as before, and removes its
font folder on SIGHUP as well as SIGINT and SIGTERM.

* fix(cli): escape render output paths and cloud upload names

A finished render printed its output path and the desktop app hint raw.
The default output path sits under the project folder and is named after
it, so the folder name reached the terminal on every render. Batch renders
printed row output paths and the manifest path raw, and cloud render
printed the archive name in its upload progress lines and walked file
names in its left-out warnings raw. These lines now go through
terminalText() or terminalLines(). --json output is unchanged.
2026-11-18 09:30:01 +00:00
Miguel Ángel cf44c60cda fix(cli): batch outputs from a template that starts with a placeholder stay in the working folder (#7868)
* fix(cli): batch outputs from a template that starts with a placeholder stay in the working folder

* fix(cli): the bare {path} template is named, not commented
2026-11-16 03:32:25 +00:00
Michael WangandClaude Opus 5.5 c4d60c347f fix: Studio media routes refuse cross-site load, CLI escapes terminal text, batch outputs stay in their folder (#7779)
* fix(cli): batch render outputs stay inside the --output folder

A row value may still name a subfolder of the folder written before the
template's first placeholder, but a value that resolves outside it stops
the batch before any folder is made or file is written.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): project text shows control characters as visible escapes

compositions, lint, snapshot and info --media print composition ids, sources,
element ids, lint messages and media paths through one helper that writes
C0, DEL and C1 control characters out as \xNN, so they reach the terminal as
text. The CLI's own colors are unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(studio-server): waveform and peaks key one cache entry per file and refuse other sites

Both caches are keyed on the resolved project-relative path, so another
spelling of the same file (a doubled or trailing slash) reads the cached
peaks instead of decoding again. Waveform and peaks requests that another
site makes are refused the way thumbnail requests already are; the Studio
page asks for both as itself.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(studio-server): preview stills run at most four at a time

A video's stand-in still is made through a small job queue: four at once,
32 more waiting, and a 503 with Retry-After beyond that. A waiting request
whose client goes away leaves the queue without starting ffmpeg.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): batch output folder check keeps backslash names and row-named paths

A trailing backslash counts as a separator only where it is one, and the
check compares path segments. A template that starts with a placeholder names
no folder, so each row's value is the whole output path as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): lint header shows control characters in file names as escapes

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(studio-server): a finished or in-progress still never waits for a still slot

Only a still that is neither on disk nor already being made takes one of
the four slots, through a hook resolveStill gives the route. Waiters queue
without a cap and nothing answers 503, since a poster is never asked for
again. A waiter whose client leaves still never starts ffmpeg; a request
that shared that waiter's still tries again on its own.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* chore: raise the studio-server packed budget to 172000

main already packs about 170 KB against a 168500 budget; the request guards,
still slots and cache-key change here add about 550 bytes.

* fix(core,studio-server): a preview served to another site offers no editing port

When the Studio server answers a preview document to another site's
request, it now marks the document, and the runtime's editing agent
ignores every connect in a marked document. The Studio's own frames,
which load the preview from the same origin, keep the editing port.
The marked copy carries no ETag, so it is never revalidated in place of
the unmarked one.

* fix(studio-server): a media still stops when no request waits on it

Each still job now counts the requests waiting on it. A request whose
connection closes leaves the job, and when the last one leaves, the
job's ffmpeg is killed and the job is forgotten, so the next request
starts afresh. A caller that passes no signal keeps the job running,
and a request that has already closed starts nothing.

* test(studio-server): group the still cancellation tests after the real-ffmpeg still test

* fix(studio-server): a preview framed by another site is never revalidated

A frame load of a preview from another site now drops If-None-Match and
If-Modified-Since before the route answers, so it always gets a fresh,
marked document instead of a 304 that could reuse the unmarked copy a
browser cached for the Studio's own page on the same site. Subresource
loads keep their validators.

* fix(cli): check findings and keyframes headers show control characters as escapes

check prints each finding's message, source file, selector and fix hint, and
keyframes prints each composition's name and source, through terminalText.

* test(studio-server): a request sharing an abandoned still waiter gets its still

* chore(studio-server): raise the unpacked size budget for the still job slots and cross-site guards

* fix(cli): layout and contrast lines in check show control characters as escapes

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-15 08:57:32 +00:00
Jerrai 58b9ec0eff feat(cli): print the render's reference_background as an @hf-result line and in batch manifest rows (#7203)
A piped, non-quiet local render now writes one versioned @hf-result JSON line
after success. Batch manifest rows carry the same reference_background value.
2026-11-05 02:19:38 +00:00
Akshar Patel 4cabfd18a2 fix(cli): render batches read PowerShell JSON files (#6605) 2026-10-30 16:03:54 +00:00
Abdullah M. Nazif d94a9d7aab fix(cli): protect batch input from generated manifest (#5294) 2026-10-24 04:10:14 +00:00
James 3222f1f31d refactor(cli): decompose render phases 2026-07-20 10:34:06 -07:00
Matt Van HornandMatt Van Horn e5a78ef6a2 feat(cli): batch rendering — one output per variables row with manifest (#1336)
Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
2026-06-13 01:58:58 -04:00