mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-18 07:50:13 +00:00
be67089a80b59be945d84e09d400a4ece254daef
137
Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
be67089a80 |
feat(studio): layers panel and marquee read an opaque preview over its channel (#7639)
* feat(studio): layers panel and marquee read an opaque preview over its channel The runtime answers a new layers request with the Layers walk: each layer's handle, depth, child count, z-index and kind, by the rules Studio walks a scriptable frame with, which move to core. On an opaque frame the Layers panel lists, selects and drills in from it, and the marquee measures its candidates over the channel and selects from their descriptions. An opaque selection maps to a timeline clip known only by its clip id, so a marquee's picks survive the timeline sync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): opaque preview hover, layers drill-in, marquee paging and delete path Review follow-ups for the opaque-preview Layers panel and marquee: - Delete on an opaque selection runs the DOM delete again. The clip-id match that lets a selection find a row known only by its clip id is now opt-in (`clipIdScope`), passed only by selection sync and the Layers seek, never by delete or group commits, which need a patch target that row lacks. A row with no file reads as in the open composition, as the forward lookup does. - The runtime's `layers` reports a drill-in group it no longer has (`missingGroup`) and lists nothing, so the panel leaves the drill-in after a reload as the same-origin branch does, rather than list the whole page. - `layers` takes an `offset`, and the marquee pages through every layer, so elements past one reply's 2,048 cap still band-select. - A Layers refresh that lands while an opaque read is in flight runs once more when it settles, instead of being dropped. - A hover resolved for a pointer move that a leave or newer move superseded is dropped. - `pointer-targets` reads the hit stack once per request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(core): keep the layers paging test inside the Windows runner's timeout The paging test walked the 2,051-layer page three times with every row mapped, which ran past 5 s on windows-latest. It now maps only the last page's rows and has its own 20 s timeout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
7e04f3cce8 |
feat(studio): canvas click, hover and timeline select read an opaque preview over its channel (#7637)
* feat(studio): canvas click, hover and timeline select read an opaque preview over its channel The runtime answers a new pointer-targets request with the canvas pick and its cycle stack; the hit-test moves to core so Studio picks by the same rule on a frame it can script. A data: value under the description limit now arrives whole, so a small data: image is selectable on an opaque frame. Drill-in, hover, timeline clips known only by clip id, and the stand-in attribute reads in double-click, ungroup, path-offset and the agent selection context work there too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(core): raise the core unpacked size budget for the pointer-targets hit-test The hit-test moves from Studio into core's editing runtime, which core ships in its runtime bundles; CI measured the unpacked tarball at 4,329,030 bytes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
faff4e16a8 |
feat(studio): read overlay geometry from an opaque preview over its channel (#7628)
* feat(studio): read overlay geometry from an opaque preview over its channel The runtime's editing channel gains a `geometry` request: per element handle its client rect, the corners it paints at when rotated, whether it renders, its clip-path, its source boundary's size, a group wrapper's member rects, and optionally one element's descendant boxes. On a preview frame Studio cannot script, the selection, child, group and hover boxes, the root scale (from the mirrored stage size) and a press held across a preview change read that geometry, with one read in flight at a time. Same-origin frames keep reading the DOM directly; the measuring code they use now lives in core so both paths share one rule. Also from the review of #7613: opaque selections carry `hasAudio` and `src` read off the description, a description with a cut attribute or inline style builds no selection, a failed computed-styles or root read builds none either, and the group refresh threads its frame and leaves a group the user changed meanwhile. `findClosestByAttribute`, left without a caller by #7613, is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(producer): raise the packed size budget for the runtime's geometry read The producer ships the preview runtime, which now carries the editing channel's `geometry` request and the measuring code it shares with Studio. The packed tarball measured 888,810 bytes in CI against an 880,000 budget. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
aed4c18feb |
feat(studio): timeline select and selection refresh read an opaque preview over its channel (#7613)
* feat(studio): timeline select and selection refresh read an opaque preview over its channel On a preview frame Studio cannot script, timeline select, a selection refresh and a group refresh build the selection from the runtime's element descriptions. The rules that pick the element (group capture and drill-in, the clip ancestor, the walk to an addressable element, timeline-locked, the lookups and the master-view root fallback) move to a pure module over an ancestor chain, used by both paths, so both select the same element. Same-origin frames keep their direct reads. The editing port gains `ancestors` (each handle's chain, parent first) and `query` (a selector's matches with their source facts), and `computed-styles` also names its element by handle. An opaque selection carries the element's handle; its `element` is a tag-only stand-in in a document with no window. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(studio): keep the selection rules' comment share at the package's Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
e1ddb2e162 |
feat(core): runtime element handles for the editing channel (#7603)
* feat(core): runtime element handles for the editing channel The runtime gives each element a numeric handle for one page load and answers two new editing-port requests: `elements-at-point` (the stack under a viewport point) and `describe` (handles to plain-data descriptions). Each description carries the element's stable selector, the source facts Studio resolves to a file, earlier class-selector matches counted per source, attributes, inline styles, text, child handles and its client rect. The stable-selector rule and source-attribute read move to core so Studio and the runtime address elements one way; Studio re-exports them and resolves a description's source file and selector index with its own map. Studio adds `PreviewElement` (a checked description) and client helpers. Every channel read now gives up after the agent probe when the frame's runtime has no editing agent, as the seek wait already did. `computed-styles` accepts custom property names with any case or `_`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(core): per-load element handles and a light elements-at-point reply Handles are now "<load>:<n>" strings, where the load id is random per page load, so a handle from an earlier load reads as null like a removed element. `describe` checks the exact format. `elements-at-point` returns only {handle, tag, rect}; callers describe the one they keep. Descriptions cap each attribute and inline-style value, keep only a `data:` value's header, leave <script> and <style> text out, and say when anything was cut. A handle's entry goes once its element is collected or found disconnected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(core): draw the element-handle load id on first use A render seeds crypto.getRandomValues from virtual time, so drawing the load id when the runtime loads shifted every random value the composition drew after it, and the random-stagger-workers render no longer matched its baseline. The id is now drawn the first time a handle is made, which a render never does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(core): keep a parked element's handle, and cut data: headers only from values A scene the preview parks and puts back keeps its element handles: an entry now goes only once its element is garbage-collected. Text that starts with "data:" is no longer cut to a header; that rule applies to attribute and inline-style values. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
01618d504a |
feat(studio): picker styles and composition size read an opaque preview over its channel (#7602)
First slice of moving Studio's selection and overlay readers off the preview frame's DOM. Same-origin frames keep their direct reads; only a frame Studio cannot script takes the new paths. - Runtime editing port: a validated computed-styles request, answered with the same logical opacity Studio reads (moved to core). - Element picker: on an opaque frame, the picked element's computed styles come from the runtime. Picker posts are taken only from an origin the posting frame can have. - Composition rect: an opaque frame's declared size comes from the runtime's stage-size post, mirrored only for registered frames and their origins. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
940963afaa |
feat(studio): playback and timeline reads go over the preview's message channel (#7561)
* fix(core): a later connect from the preview parent gets a fresh editing port A parent that disposes its editing client and creates a new one for the same frame (a remount that keeps the iframe) used to wait forever: the runtime handed its port over once per page load. Each valid connect from the parent now closes the previous port and hands over a new one. Connects from any other sender are still ignored. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(studio): playback and timeline reads go over the preview's message channel Prepares Studio's preview to run on an opaque origin, where the parent cannot read the frame's window. - previewChannel: one editing-port client per frame load, plus the loop start, seek-painted and clip-manifest reads over it. - bridgePlayback: a playback adapter that sends play, pause and seek as control-bridge messages and mirrors the runtime's state and timeline posts. It is used only for a frame Studio cannot script; a same-origin frame keeps the direct adapter. - The loop start and the state-tick manifest recovery now always use the editing port. The shadow reload's seek-painted wait uses it for a frame Studio cannot script. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(core,studio): trim comments back under each file's comment share Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): keep the direct loop-start and manifest reads for frames Studio can script A host can pair this Studio with a runtime older than the editing port. The loop start and the state-tick manifest recovery now read a same-origin frame directly, exactly as before; only a frame Studio cannot script uses the port. previewFrameOpaque replaces previewFrameScriptable and treats a frame with no window as not opaque, so a detached frame keeps its old no-op path too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(core,studio): keep every editing port the parent receives working on an opaque preview The runtime posts ready before it installs its editing agent, so a client can connect twice and receive two ports. Closing the earlier port on each connect left a client that took the first one with a dead channel for the rest of the frame load. The agent now keeps earlier ports open (a disposed client closes its own end) and closes all of them on teardown. For an opaque preview: - the restore-seek wait gives up after a 1 s probe when no editing port arrives, so a runtime without the agent no longer holds a reload for 15 s; - the bridge playback mirror keeps a seek until the runtime confirms it, so a state posted before the seek cannot undo a quick frame step; - sceneSwapFor returns no swap instead of reading the frame's window, so a reload falls back to a full reload. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): call a frame opaque only when its window refuses a read previewFrameOpaque treated any frame whose contentDocument was null as opaque. A same-origin window can still report a null contentDocument (an iframe that is not in the document), and that sent it down the opaque path. A frame is opaque now only when reading its window's document throws, as it does across origins. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): mirror playback only from preview frames Studio built, at frame precision The bridge playback mirror took a state or timeline post from any window and made a mirror for it. It now takes a post only from a frame Player registered (watchPreviewFrame, called before the frame loads, so the boot-time timeline is not missed), and only when the post's origin is one that frame can have: null for an opaque sandbox or a data: URL, the parent's origin for srcdoc, about: or no src, else the origin of its src. A pending seek now counts as confirmed by the frame the runtime lands it on, the frame at or before it, rather than by a 1 ms match. An off-grid seek used to drop every state post for 500 ms, freezing the playhead and its play state. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(studio): keep the editing-client tests' fake frame detached from the document Main's test harness now attaches its fake iframe, and happy-dom then fires that frame's about:blank load on its own, which ends the editing client's frame load mid-test. These tests build their own detached frame instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(studio): share the detached fake frame with the manifest router test The manifest router test had the same race: the attached harness frame's own about:blank load ended the editing client before the port answered, which lost on the slower Windows runner. The harness now exports detachedFakeIframe, which makeFakeIframe builds on, and both opaque-frame test files use it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
3151fd2133 |
fix(studio): bound recovery and verify full-quality playback (#7393)
* fix(studio): bound recovery and verify full-quality playback * fix(studio): compare preview pixels with captured HTML clock |
||
|
|
b7157bdabb |
feat(studio): scrub full-quality video with decoded preview frames (#7379)
* feat(studio): scrub full-quality video with decoded preview frames * fix(studio): release scrub decoders before native playback * fix(studio): bound paused fallback and tolerate decoder load failure * fix(studio): recover stalled native preview handoffs * fix(runtime): recognize cross-realm preview video elements * fix(studio): bound Play handoffs and drain transparent preview samples * fix(preview): recover retained video without chasing playback clock * fix(studio): drain finite alpha queries before disposing readers |
||
|
|
3a28ef41ae |
perf(studio): a long film's media durations write the store once per file, not once per clip (#6745)
* fix(studio): a film that cuts one file into many clips plays smoothly while their durations load * test(studio): the metadata test counts one store write per file |
||
|
|
9fa02badfc |
feat(studio): every editor and player shortcut is remappable (#6966)
* feat(studio): shortcut combos in the key resolver * feat(studio): every editor shortcut is a remappable combo * refactor(studio): playback keys dispatch through one table * fix(studio): combo parsing without backtracking, symbol keys match, fewer comments * style(studio): format the shortcut files * chore(studio): drop a doc comment the ratchet counts * chore(studio): drop a doc comment the ratchet counts * fix(studio): modifier combos fire for playback keys, caption guard and held stop key follow the map |
||
|
|
57d23598a7 |
feat(studio): hosts can remap Studio's single-key shortcuts (#6957)
* feat(studio): hosts can remap Studio's single-key shortcuts * fix(studio): razor exit key and jump-to-in stay live when remapped |
||
|
|
d83f276743 |
perf(studio): films with thousands of timed clips stop re-reading every clip each frame (#6805)
* perf(studio): films with thousands of timed clips stop re-reading every clip each frame * perf(studio): drop the added comment lines the ratchet counts |
||
|
|
348971c222 |
fix(studio): a tab's save keeps the newer video version another tab recorded (#6682)
* fix(studio): a tab's save keeps the newer video version another tab recorded The thumbnail index merge let this tab's ETags win for every source, including ones it only read at startup, so another tab's move to a new version was undone by this tab's next save: the next session validated the old ETag, missed the disk and decoded once more. Now another tab's ETag wins except for sources this tab recorded a new version of since its last save. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): the ETag merge says whose moves it keeps in its names, not comments Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(studio): the stored-thumbnail reset forgets this tab's drops and moves too Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
e38585ef5f |
perf(studio): timeline thumbnails come back from disk in the next session (#6676)
* perf(studio): timeline thumbnails come back from disk in the next session Reopening a project re-read every video's index and re-decoded every strip: the frame cache and the source facts lived in memory, keyed by the session. Now each source's facts (aspect, duration) and every decoded frame are kept in Cache Storage under the file's ETag, the version the server says it is. A new session checks each source once with a conditional one-byte read: a 304 means the stored frames are still that file's, and a strip they cover paints without opening a reader. A new ETag drops what was stored for the old one. Sources are dropped whole, least recently used first, past 256 MiB. A store that is missing or fails (private window, quota) warns once and the strip decodes as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): a reopened project checks its videos again, and the disk index counts a frame once The stored version a session validated was kept per video for the whole page, so reopening a project after one of its videos was replaced at the same path painted the old file's frames until a full reload. It is now kept per video and project open (its contentVersion): each open re-validates once. The index now counts a frame stored again under its name once, and merges with what other tabs saved before writing, keeping caches this tab dropped out, so the 256 MiB budget holds across tabs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
a88751d9d6 |
fix(studio): a thumbnail reader forgets a start's failures after a minute (#6642)
* fix(studio): a thumbnail reader forgets a start's failures after a minute A pooled thumbnail reader lives for as long as clips keep asking it, and each start byte has a retry budget of two. That budget never reset, so two transient failures at one start early in a session made a third, twenty minutes later after the cache evicted it, give up at once: the reader retired and the clip showed an error. A start's failures now count for a minute. One bout of retries (8 s stalls, 0.5 s and 1 s waits) fits inside it, so a start that keeps failing still gives up; one met again much later starts afresh. Clearing the count when a read from that start delivers bytes would not do: a server that ignores Range sends bytes 0 onward again before it breaks at the same byte, and would retry forever. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): the start-failure window says what it is in its name, not a comment Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): a start's retry budget resets when a read from it ends cleanly, not after a minute The one-minute window only held while each attempt took under a minute. An attempt has no limit before its answer, and a body that keeps sending never stalls, so a server that ignores Range, sends slowly and breaks past a minute re-downloaded from 0 forever. A start's failures are now forgotten when a read from it ends cleanly: its body finishes, or mediabunny cancels it at its target. A server that breaks before the target never ends a read cleanly, so its budget still runs out, however slowly it fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): a read mediabunny stops at its target ends cleanly and resets its start's budget mediabunny's UrlSource never cancels the body: once a read reaches its target, _runWorker aborts the signal it passed in, and the pending pull fails with an AbortError. So the reset on cancel never fired, and any open bytes=N- read stopped at its target kept its start's failures. The request now listens on its own signal, which follows mediabunny's and is unlinked once the read ends: an abort while live counts as a clean end only when mediabunny's signal is the one aborted, never a stall or a dispose. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
fa137cdfef |
fix(studio): a slow thumbnail job keeps a reader that other clips still decode from (#6643)
* fix(studio): a slow thumbnail job keeps a reader that other clips still decode from A job that timed out judged the reader by its own progress only. A poster job that got an already-open reader while a sibling was decoding on it, and took more than its budget to reach its one frame (a slow link, Chrome's six connections held), logged a timeout and retired a healthy reader, so the next clip re-read the index. The pooled reader now counts the frames every job decodes from it, and a timed-out job retires it only when no frame came from it while the job held it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): the reader's frame count says whose frames it counts in its name, not a comment Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
a54921e0f6 |
perf(studio): share video sources and keep frames for timeline thumbnails (#6629)
* perf(studio): keep released timeline video frames for scroll-back A video thumbnail frame was revoked the moment no mounted strip held it, so scrolling back past the scheduler's cache decoded every clip again: 80 decode passes for 40 clips on a 44-minute source, the whole first pass repeated. Released frames now stay shared in a least-recently-released list capped by the new sharedFrameCacheBytes budget (32 MiB of JPEG, about 11 frames for each of a 473-clip episode's clips). Object URLs are revoked only on eviction, and a frame any strip still shows is never evicted. Which frame a strip shows is unchanged: the acceptance window is the same predicate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * perf(studio): open each video source once for all its timeline clips Every clip's thumbnail job opened its own mediabunny Input on the source URL, so 40 clips cut from one 44-minute source opened it 80 times, re-reading and re-parsing its 1.44 MB index each time (behind a 304, at 13-30 ms an open). Jobs now share one pooled reader per source: the Input, its primary video track and the track's size and duration, reference-counted and disposed thumbnailSourceIdleMs (10 s) after the last job ends, or at once when the source's contentVersion changes. Each job keeps its own CanvasSink: the sink reuses one pooled canvas and a job blanks the canvases it saw on release, so sharing one across jobs would corrupt a neighbour's frames. A failed open leaves the pool at once, and a job that fails for any reason but cancellation retires its reader, so the next clip opens afresh. Retries are still counted per reader, as mediaUrlSourceOptions has done since #6477: two jobs reading through one reader cannot tell whose read failed, and retiring a reader whose retries are spent keeps that budget per reader rather than letting a spent count fail later clips at once. The pool also owns the one import("mediabunny"), which the decoder now takes from the opened source. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * perf(studio): start no timeline video decodes while the preview plays A playing preview shares the machine's video decoder with timeline thumbnails, and a long many-clip timeline queues hundreds of thumbnail decodes. While the player store reports isPlaying, the scheduler now starts no new visible or overscan video decode; a scrub's interaction request still starts, decodes already running finish, and pausing drains the queue. Image, composition and waveform work is unaffected. The new thumbnailPlaybackHold module subscribes to the store's state rather than wrapping setIsPlaying, so a reset or a project switch, which write isPlaying: false directly, also release the held work. VideoThumbnail binds it to the app's scheduler where video thumbnails load, which is also the path HyperFrames Desktop runs (it embeds StudioApp, not Studio's main.tsx). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * perf(studio): bound thumbnail range reads and their read cache mediabunny reads a URL with open-ended `Range: bytes=N-` requests and cancels each once it has the bytes it wanted, by when a local server has streamed megabytes past them: about 4 MB sent for each thumbnail frame decoded. The thumbnail reader's fetch now asks for at most 512 KiB from N; a shorter answer than mediabunny wanted makes it ask again from where it stopped (its worker resumes a capped response when the file size is known, which the first 206's Content-Range supplies). Closed ranges and the probe reader are untouched, and so is Studio's playback, which does not read through mediaUrlSourceOptions. Measured on two 44-minute 1080p sources, 40 clips each (a poster and a 4-frame strip per clip), against the same branch unbounded: bytes sent fall 13-22% one decode at a time and 33% two at a time; first-pass wall time falls 4-20%. The frames decoded are byte-identical. Most of what remains is real: a strip slot whose keyframe is outside its window decodes from that keyframe forward through its GOP. A pooled reader also now caches at most 16 MiB of what it read, not mediabunny's default 64 MiB, since it outlives its clip by up to thumbnailSourceIdleMs. 8 MiB cost requests when a clip's poster and strip decode together; 16 MiB measured the same as 64. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): bound thumbnail ranges only once Content-Range is readable A thumbnail reader bounded even its first range request to 512 KiB. When the answer's Content-Range cannot be read, mediabunny sizes the file as the request start plus the answer's Content-Length, assuming the answer runs to the end of the file, so a bounded first answer made a 10 MB file end at 512 KiB. Browsers hide Content-Range cross-origin unless the server lists it in Access-Control-Expose-Headers, and Studio reads remote https sources such as HeyGen's gen-os-static bucket, which does not. With the header hidden, every format failed: faststart and fragmented MP4 decoded 1 of 12 thumbnails, and moov-at-end MP4, MOV and WebM none ("no decodable video track"). A reader now bounds its ranges only after an answer of its own was a 206 whose Content-Range it could read and that starts where the request asked; its first request stays open-ended, as before the bound. Any answer without such a Content-Range, a whole-file 200 included, keeps that reader unbounded for good. Same-origin readers, where Content-Range is readable, still bound. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): count a thumbnail reader's read failures consecutively A reader's retry budget (two retries, from #6477) counted every failure over the reader's life. Pooled, a reader serves every clip of its source, so the third transient failure anywhere on the source failed a clip with no retry. The count now resets whenever a read delivers bytes, so a long-lived reader keeps the per-clip tolerance a reader had when each clip opened its own, and three failures in a row still give up. Bytes, not an ok status: a body that breaks on its first read must still use up the budget. A reader that gives up is retired, as before, so the next clip opens a fresh one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): a read stalled mid-response no longer hangs its video source The thumbnail job's signal reached only the source's open: keyframe lookups and the decode loop ignore it, so a job whose response stalled mid-body never ended and never released its pooled reader. The reader was never idle, so never closed, and every later clip that needed the same bytes waited on the same stalled read for the rest of the session. Before pooling, each clip had its own reader, so only the stalled clip hung. The scheduler's timeout now aborts with a TimeoutError reason. A job that times out drops its reader at once; a job cancelled any other way that has still not ended a load timeout later drops it then; a cancel the job answers, a scroll away, leaves the reader pooled. Dropping disposes the reader whoever still uses it, which fails their pending reads too. Disposing a mediabunny Input does not end a read already waiting on a stalled body (its orchestrator only flags the worker, which never wakes), so mediaUrlSourceOptions gains cancelReads(), which aborts every fetch the reader has in flight; the worker's read then fails and mediabunny rejects the reads waiting on it. Measured in Chromium with a server that stalls one response: the stalled clip settles at its timeout, and the same clip asked again, now and after 11 s idle, decodes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): a clip's own failed result keeps its source's reader A thumbnail job that failed for any reason but a cancel retired its pooled reader, so one clip whose frames all failed to decode, or whose canvas would not encode, made the next clip re-read and re-parse the source's index. Those two failures are now a ClipResultError, which leaves the reader pooled; fetch, demux and decoder failures still retire it. Also pins four pool behaviours mutation testing found unguarded: a reader closed after sitting idle has left the pool, so the next clip opens a live one; a version change closes the old reader only once the job still decoding on it ends; a job cancelled while the track is read stops the open there; and a scroll-away cancel keeps the reader (the last landed with the stall fix). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): keep a thumbnail reader's retry budget per start byte ff16aed98 reset a pooled reader's retry count whenever any read delivered bytes. That broke the #6477 give-up in two ways, both measured with real mediabunny: - A server that ignores Range answers 200 from byte 0, so mediabunny resumes at the bytes it got and is sent byte 0 again. With a body that breaks after 64 KiB, those bytes reset the count every time: 61 fetches in 30 s and the read still pending. - mediabunny reads with two workers. A healthy stream in one region kept forgiving a region that always answered 503: 41 fetches in 20 s, pending. Failures are now counted per start byte, with no reset. A resume after progress asks for a new start and gets its own two retries; asking for the same start again uses them up whatever else the reader reads meanwhile. The start is the byte the answer began at: the asked start for a 206 or a failed request, 0 for a 200. Traced for the 200 case: requests at 0, 65536 and 65536 are all keyed 0, so the third failure gives up. Both repros now give up after 3 fetches ("network TypeError after 2 retries", "HTTP 503 after 2 retries"), and failures at different starts, one per clip, never add up. The fetch and the answer's typing move into typedFetch and typedResponse, so fetchFn stays under the complexity gate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): fail a stalled thumbnail read on silence, not on a timeout dbd820706 dropped a reader when the job using it timed out, but only once the reader had opened: a timeout during the shared open released the job and left the stalled open pooled, so every clip of that source joined it and timed out in turn while clips kept arriving. Dropping on a timeout was also wrong when bytes were still coming (a slow link's 25 s open threw its parsed index away), and dropping a reader other clips were using failed them with "Media reads cancelled", leaving them on "no preview" until they remounted. A thumbnail read now fails only on silence. A request waiting 8 s for its answer, or for its next bytes, is aborted and fails as a MediaFetchError "stalled", which mediabunny retries like any read failure: a resume after progress asks for a new start and continues, and three silent waits at one start (8 + 0.5 + 8 + 1 + 8 = 25.5 s, inside the 30 s load timeout) give up, which retires the reader. This covers the open and the decode alike, keeps a reader whose bytes are still arriving, and never disposes a reader another clip is using, so the job-level abandon and the scheduler's TimeoutError reason are removed. Measured in Chromium against a stalling server: - one-shot stall in the open: the clip decodes at 8.7 s (was: it and the next clip both timed out at 30 s); - one-shot stall mid-decode: decodes at 8.7 s (main: hangs); - a source that never sends a byte: each clip fails typed at 25.5 s and the next opens a fresh reader. Each request gets its own AbortController, which follows mediabunny's signal and the reader's cancel without AbortSignal.any; every way a request ends unlinks it from the reader's long-lived cancel signal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(studio): pin the thumbnail behaviours mutation testing left unguarded - A bounded answer's Content-Range keeps the reader bounded: a closed-range pattern that matched only open ranges flipped it unbounded after the first bounded request, undoing cf8f4554e. - A frame that will not encode, through toBlob or OffscreenCanvas convertToBlob, is the clip's failure and keeps its reader. The convertToBlob rejection is now a ClipResultError too; it escaped as the browser's own error and retired the reader. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(studio): pin the stall watchdog's guarantees about its own requests Four guarantees of the thumbnail reader's per-request watchdog had no test; each mutant that broke one passed the suite: - a silent body fails as "stalled" and aborts the fetch under it, so the stalled connection is not left open; - every way a request ends unlinks it from mediabunny's signal: an answered body, a rejected fetch, a 503, no body, a broken body, a cancel; - a probe reader's body is never timed, however slow; - a request made after the reader's reads were cancelled starts aborted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): time a thumbnail read's silence only once its answer has started The 8 s stall rule also timed the wait for a response's headers, and that wait includes Chrome's queue for one of six HTTP/1.1 connections per host. Desktop serves all media from one loopback host, where Studio's event stream and streaming previews hold connections. Measured in Chromium against a healthy server: with five of six connections held and 20 cancel/re-ask bursts over the 40-clip pass, no false stall; with all six held for 40 s, two clips failed as "stalled". The watchdog now times only a started body. A server that never answers is now caught at the job's own timeout. The scheduler's timeout again aborts with a TimeoutError reason. A job that timed out without progress in its whole run (its source never finished opening, or it decoded no frame) failed because of its source: a source that never answers, or one that trickles bytes and never finishes. It logs one typed MediaFetchError line ("network timeout") and retires its reader. A job that waited for an open that finished, or decoded a frame, timed out on a slow link and keeps the reader and its parsed index. Bytes alone are not progress, or a trickling source would keep its reader for good. An aborted job also ends its claim on the reader at the abort, rather than when it settles: a job stuck in a read that ignores its signal no longer keeps the reader open. A retired reader still waits for the clips decoding on it. Measured in Chromium: a source that never answers fails each clip with one typed line at 30 s and the next opens a fresh reader; with all six connections held for 40 s, the two starved clips fail typed, none as a stall. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(studio): move the thumbnail reader's explanations into names The comment ratchet (scripts/comment-ratchet.mjs) fails a source file whose share of comment lines rises over its merge-base, and a new file above its package's share. Five files of this branch did. The reasoning they carried is in the commit messages and the PR description; what stays in code is named: SILENT_BODY_STALL_MS, POOLED_READER_CACHE_BYTES, failuresByStart, inFlightReads, decodedByJob, timeoutWithoutProgress and madeProgress. No behaviour changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
75bee42919 |
fix(core): paused preview seeks land on the composition's own frame rate (#6460)
* fix(core): preview seeks land on the composition's own frame rate * fix(studio): frame step, frame readout and ruler use the composition's frame rate * fix(studio): an end trim previews the clip's last frame at the composition's frame rate * refactor(studio): ruler labels follow the ticks' frame rate and fps parsing splits by form * style(studio): format the ruler label helper and its test * chore(inspector): raise the package size budget to the measured size plus headroom |
||
|
|
dfd2028f16 |
fix(studio): a clip that cannot be read gives up after two retries with one typed line (#6477)
* fix(studio): a clip that cannot be read gives up after two retries with one typed line * fix(studio): a clip whose stream breaks mid-read also fails with the typed line |
||
|
|
e48c8a0614 | perf(studio): a settled timeline's composition check scans only its hosts, not the whole preview (#5880) | ||
|
|
9763b68a33 |
fix(studio): scrubbing never auditions a track the music row did not name (#6310)
The last fallback took whatever audio came first in the preview, which is usually the voiceover, whenever the music row's own element was momentarily absent. |
||
|
|
e1925d4317 |
feat(audio): composition master bus (data-fx-chain on the root) (#5420)
* feat(audio): composition master bus (data-fx-chain on the root) A clip can belong to only one audio group, so there was no way to put one effect, such as a limiter, across the whole mix. The data-fx-chain on the top-level composition root now runs once over the sum of every clip and every group, after each group's own chain and fader. No new attribute: a sub-composition root's data-fx-chain was never applied to anything and still is not. Render: when a master chain exists, mixAudioTracks writes a float WAV instead of AAC, applyAudioFxChain runs the chain over it, and ffmpeg encodes AAC last, so the chain reads unclipped samples. An unreadable chain is a mix failure, as for a group. Preview: the transport splices the chain between the clips' sum and the monitor, re-anchored per play generation and watched for edits. Only the top-level root is read. No master automation: the root's data-automation is not read as the bus's. No lint rule: data-fx-chain is valid on clips, groups and roots, and the one place it does nothing (a sub-composition root) has always been silent. — Jerrai * fix(core): preview routes every audible video through the master bus A root data-fx-chain is attached only inside the Web Audio graph, but a plainly audible <video> joined that graph only for its own chain, group, automation or a volume over 1. So preview limited the music and left the talking head dry, and a composition whose only audio is video got no master chain at all, while export sums every audible element into the master. A master chain on the top-level composition root is now a reason to join, the same as a video's own chain. Elements under a root with no chain keep native output. Sub-composition roots are still ignored. — Jerrai * fix(audio): master bus review round 2 (temp dir, tests, docs, Studio meter) - audioMixer: a fatal FX error in the master pass or a group bus left the work directory (the full float sum, about 1.4 GB an hour) on disk. The final mix now runs in try/finally and the group rethrow removes it first. - Tests: the "once over the sum" case now uses a limiter then a gain, so a per-clip chain (-10.4) and a doubled one (-18) both fail it; a new case proves the sum stays float until the chain reads it; the fader case uses a group volume of 0.5 so the fader's position is exercised; the work-dir removal is covered for both paths. - Docs: "Three rules exist" (the master-bus lint rule is gone), a bad master chain stops the render with audio_processing_failed, a sub-composition file opened on its own has its root chain as the master bus, and a seek clears a group or master limiter. - Studio: TimelineElement.masterChain carries the root's data-fx-chain, so the program meter shows for a video-only composition whose only audio routing is the master chain, as preview now plays it. - Comment blocks over four lines cut; webAudioTransport.setRate split so its CRAP score is under the Fallow threshold. — Jerrai * fix(audio): master chain reaches tracks the render adds; honest plain-limiter copy - Master chain: it was carried on each parsed AudioElement, so a track the producer adds itself (appendAutoDetectedVideoAudio, the browser-discovered audio in probeStage) never had it, and a composition whose only audio was such a track exported with no master chain, no ceiling and no warning. It is now a composition property: parseMasterFxChain(html) at compile, carried on CompiledComposition and CompositionMetadata, passed to processCompositionAudio by runAudioStage (in-process and distributed plan). AudioElement.masterFxChain is removed so there is one source. Each forward (compile stage, local orchestrator, distributed plan) has a test that fails when it is dropped. - Plain limiter: it follows the level with no lookahead and Level after is applied past the ceiling, so it cannot promise "nothing gets past" or "never clips". Studio copy (description, panel text, knob label, summary) and the hyperframes-audio skill now say a fast or inter-sample peak can pass it and point to the true-peak limiter for a delivery limit. A copy test guards it. — Jerrai * fix(producer): keep master bus comments within the ratchet; run the plan test with the ffmpeg tests Drop three one-line field comments that raised their files' comment share, and list plan.masterBus.test.ts with the integration tests because plan() reads the ffmpeg version. — Jerrai * chore(ci): repin the producer test-classification source in the reachability map The reachability map pins the hash of test-classification.mjs, which now lists one more integration test. The map's producer lane command already covers every test under src, in both the unit and integration matrix lanes. — Jerrai |
||
|
|
9825614d91 |
fix(studio): Studio's own text reads without em or en dashes (#5414)
* fix(studio): text in Studio reads without em or en dashes * fix(studio): the dash check also catches HTML entities, and peak reads Unavailable * test(studio): the dash check test covers every entity form * fix(studio): messages Studio shows from lint, sdk, core and the renderer drop dashes too * fix(producer): the gate check stops early on the engine's new fallback wording |
||
|
|
d93b769763 |
fix(studio): a stalled font or asset no longer leaves the preview empty or drops reloads (#5370)
* fix(studio): a stalled font or asset no longer leaves the preview empty or drops reloads * fix(studio): a page's own late load no longer counts as replaced content * refactor(studio): one announcement owns when a preview page has loaded * fix(studio): let hosts with their own player announce a new preview page * fix(studio): a late ready from the replaced preview page no longer claims the new page * refactor(studio): keep the Player doc comment on Player |
||
|
|
621ddd4693 |
fix(studio): stop file names with %, apostrophes or $ from breaking Studio (#5156)
* fix(studio): serve files whose name has a bare percent sign A browser sends src="100%.png" with the % unescaped, and decoding the whole path threw, so Studio answered 500. Only well-formed escapes are decoded now. * fix(cli): serve files with a bare percent sign from the check and snapshot server One shared decode rule for request paths; the image thumbnail route's malformed-escape 400 could no longer fire, so a name that is not a file is a 404. * fix(cli): name a failed file with a bare percent sign in check * fix(studio): keep apostrophes and dollar signs in file names when editing attributes An attribute value is matched by its own quote kind, so src="it's.png" is replaced instead of duplicated, and every insert uses a function replacer, so $1 or $& in a file name is written as is. * fix(studio): rename references spelled with %20 or & and read quoted media sources WIP: not yet tested; see the resume note. * fix(studio): match whole attribute names when editing media sources * fix(studio): compare decoded names and escape replacement references * fix(studio): preserve file references across URL and string consumers * docs: clarify raw file references and URL fields * fix(studio): keep raw path identity distinct from URL spelling * fix: share attribute grammar and decode media URLs at their readers * fix: preserve local filename identity in HTML URL output * fix: decode entity references before rename candidate matching * style: format rename entity handling and regressions * fix: preserve platform file identity when renaming references * fix(core): decode CSS escapes before rebasing asset URLs * fix(core): consume CSS continuations before URL encoding * fix(core): preserve CSS URL identity and escape rebased suffixes * fix(core): express CSS suffix controls with Unicode categories * fix(core): preserve URL backslash identity while rebasing * test(core): respect platform backslash filename semantics * fix(studio): a dropped file with %, # or ? in its name loads, and an encoded reference renames * fix(studio): read an authored src as a URL so dropped files with spaces, %, # or ? load * fix(studio): media routes find files named with ? or #, and the probe reads a src as a URL * fix(studio-server): one rule for request file paths, so loudness finds files named with %, # or ? * chore: drop the design note from the change * fix(core): rename replaced clips whose src is URL-encoded |
||
|
|
042ec2ebd0 |
fix(studio): restore overscan and publish the zoom viewport (#5151)
* fix(studio): restore the timeline overscan budget * test(studio): align window witnesses with the restored budget * fix(studio): publish the viewport when a zoom anchor lands * fix(studio): publish the viewport when a zoom-out ends at its laid-out scale An eased zoom-out that ends at the scale already laid out only moves the scroll position, so the timeline drew from the old position until the next scroll event. The zoom input now publishes that scroll through the same callback the zoom anchor uses. * fix(studio): a pan at the laid-out scale publishes its scroll before paint The same-scale ending of a zoom ran outside React, so its scroll publish rendered on the next task, after the browser painted the old window. It now flushes like the scale change beside it, and its test pans at the laid-out scale instead of changing it. * test(studio): a same-scale pan must render its scroll before paint Reads the render window outside act, so unwrapping the flush fails it, and records each published scroll at call time instead of reading the live element afterwards. |
||
|
|
b66e8a195e |
perf(studio): preview decodes hard-to-play videos at the size they are shown (#5184)
* perf(studio): preview decodes hard-to-play videos at the size they are shown Studio's copy of an HEVC or ProRes clip was made at the source's full size, so a 4K clip was decoded at 4K inside a preview a few hundred pixels wide, and back-to-back 4K clips flashed the background at their cuts. The player now reports how large it shows the composition, the runtime asks for a copy sized to the shown video (on a ladder of sizes, never above the source), and Studio stops pre-warming source-size copies. CLI play, static serving, publish and renders keep the source-size copy. * fix(studio): sized preview copies follow zoom, hover previews and the newest size Studio reports the preview's on-screen scale when a zoom settles and for composition hover previews, which no player measures. The runtime loads only the newest size asked for, regrows a first copy made while the frame grew, and never replaces a copy with one smaller on either side. The player's scale is measured against the frame's own layout width. * fix(studio): keep comment shares and file sizes within the repo ratchets * test(studio-server): end the sizing test's ffprobe options before its input * fix(studio): hover previews report their size once their runtime is ready |
||
|
|
9f09861d2e |
perf(studio): zooming a long timeline re-decodes and redraws less (#5142)
* perf(studio): reuse filmstrip frames when a zoom changes a strip's width A zoom that changed a strip's frame count decoded the whole strip again on the main thread, and showed the clip's single poster frame until it landed. Frames are now sampled at each slice's left edge, so a strip twice as long holds every frame of the shorter one; decoded frames are shared per source and time, so zooming out decodes nothing and zooming in decodes only the new half. The strip on screen stays until the new width is ready. * perf(studio): redraw only the waveforms on or near the screen after a zoom A zoom resizes every mounted clip, and every mounted waveform redrew in that same frame, on screen or not. A waveform now draws only while it is on or near the screen (one shared observer, a screen of margin each side) and draws when it comes near if a zoom changed it meanwhile. * perf(studio): never start a beat-analysis stage while the timeline zooms Analyzing a long music track runs for over a second on the main thread, and when it started late it landed inside a zoom. The analysis now awaits an optional pause before each long stage; Studio's waits for the timeline to rest and the browser to go idle. Results are unchanged. The tempo detector's stage is one call, so a zoom that starts inside it still waits for it. * fix(studio): reuse a filmstrip frame only where its own strip would show it A shared frame was keyed by the time a strip asked for, not the time it was decoded at, so a coarse strip's keyframe-early frame could land in a finer strip and run its frames backwards. A frame now carries its decoded time and is reused only when the strip would have accepted that keyframe itself. The frame-count ladder now tops out at a power of two (32), so its top step shares frames with the one below instead of none. * feat(studio): show the clip's last frame at the end of every filmstrip Left-edge sampling never showed a clip's final slice, so an end card or a fade-out was missing from its strip. Each strip now also decodes the clip's last frame (at its own time, never an earlier keyframe), shared across zoom steps like the others, and the last tile shows it. The strip on screen is now held per clip and range, not per props: a clip crossing between on and off screen keeps it, and a clip narrowed to one frame lets it go, so widening again never re-decodes a dropped width. * docs(studio): keep the filmstrip files at or under main's comment share The comment ratchet allows no file a higher share of comment lines than on main; the added explanations move to the PR description. * fix(studio): keep a held filmstrip leased so a full cache cannot evict it mid-zoom The hold leased the strip on screen only once a new width was requested, so for one commit it had no lease; with the cache over budget it was evicted, the poster showed, and the old width decoded again. The strip on screen is now leased for as long as it is the clip's, and shown only while held. A frame that fails to decode takes the frame before it, so every slot keeps its time and the last tile still shows the end. * refactor(studio): one owner for which clip a held filmstrip belongs to The hold checked the clip twice, in its lease and again before showing it; the lease alone decides now, and the cross-clip test pins it. A test now also pins that a filled frame is not charged to the cache. * fix(core): hold the tempo detector until idle after a slow import * fix(studio): scope shared video frames to timeline sessions * chore(core): keep beat analysis comments within the ratchet |
||
|
|
eee0c5101c |
perf(studio): smooth timeline zoom on long projects (#5109)
* perf(studio): coalesce timeline zoom to one write per frame and zoom to a range * perf(studio): coalesce timeline zoom to one write per frame and zoom to a range Every zoom input goes through one owner that writes the store once per frame. zoomTimelineToRange eases to a time range; the zoom buttons use it. * feat(studio): zoom-to-range reports done or cancelled and is not a person zoom * perf(studio): place clips in percent of a one-second layer so zoom restyles nothing A zoom step rewrites one width per row; clip thumbnails start decoding at rest. * perf(studio): a zoom step re-renders only clips whose drawing it changes Clip handlers read the lane callbacks when pressed, so a skipped clip never acts on a stale zoom. * refactor(studio): move at-rest waveform and thumbnail work to its own change * perf(studio): draw waveforms and decode thumbnails when the timeline rests Waveforms draw only the visible span of a clip. A zoom or scroll step stretches what is drawn until the timeline rests. * test(studio): fade handles measure the clip only while they show * test(studio): waveforms draw their visible span and redraw at rest * feat(studio): export currentTimelineRange, the inverse of zoomTimelineToRange * perf(studio): zoom gestures scale the drawn timeline and lay it out once at rest No layout or render per gesture frame; past 0.67x or 2x the preview is laid out and continues. * perf(studio): rebase a zoom preview only past 0.5x or 4x Clips stay mounted half a viewport each side, so a zoom-out preview to 0.5x shows no gaps. * fix(studio): keep the zoom readout, edges and Fit right during a preview The slider and its percent follow a zoom while it is previewed. A zoom in from below Fit no longer jumps when it lands: the preview now uses the width the timeline will really have. A zoom-out lays out as soon as it would show time with no clips mounted, so edges never show empty strips. Fit, a press or a scroll on the timeline end a pending zoom first. An older abort no longer cancels a newer zoom-to-range, and an instant one lands on the next frame instead of inside its caller. Range selection and gap tints scale with the preview. * fix(studio): keep a pending zoom when the timeline re-registers its view The timeline registers its scroll view again whenever clips are added or removed, which used to drop a zoom still waiting to be laid out. Now only a real unmount drops it, and unmounting one timeline leaves a newer timeline's registration alone. * refactor(studio): share the zoom geometry helpers the timeline already has Zoom scales come from getTimelinePixelsPerSecond, the range margins from one helper, and a zoom step starts from the same playhead anchor every zoom uses. The clip minimum width is named and shared with the drag ghost. * fix(studio): keep a zoom preview through scrolls and past the content end A scroll during a zoom preview, including the one a laid-out zoom makes itself, used to lay the next preview out at once, so a pinch or eased zoom fell back to a full layout every frame. A scroll now only rescales what it mounted. Zooming out also lays out before the preview shows past where the ruler and beat lines are drawn, not only past the mounted clips. * fix(studio): keep a moved audio clip's waveform drawn where it shows A waveform now draws the stretch of its clip that the shared strip tracker reports near the screen, the tracker the filmstrip already uses. It follows scrolls, resizes and moves (a drag or ripple that shifts the clip), so a moved clip no longer shows a blank stretch, and a zoom redraws it once. * perf(studio): lay a zoom-out step out once, at its start An eased zoom-out (a Zoom out click, or zooming out to a range) used to lay out partway, once the shrinking preview reached time with nothing mounted, and again at the end. It now lays the target out first and eases by scaling that layout down from the old view, so each click lays out once. Each eased frame also draws its preview in that frame. * fix(studio): keep previewing a zoom at the content's end and over new rows The preview now lays out only once it would show past the window the timeline draws clips, ruler ticks and beat lines in, with two pixels of slack, so rounding at the content's end no longer lays out every frame. Rows mounted into the timeline during a preview are scaled before they paint. * fix(studio): redraw a waveform when its clip's width changes or it moves A waveform drawn whole kept its old bars, stretched, after a zoom changed its clip's width; it now redraws on any resize. A long clip also marks its undrawn ends for the strip tracker, so a move without a scroll (a ripple, a drop, an undo) re-measures it instead of leaving a blank stretch. * perf(studio): skip the layout when a zoom preview ends on its own scale An eased zoom-out lays its target out first, so its preview ends on the scale already laid out. Landing it now only sets the scroll, instead of writing the same zoom again and counting the person's zoom twice. * fix(studio): measure filmstrips and waveforms after a zoom preview ends The strip tracker measured clip boxes while a zoom preview scaled them, so after a Zoom out click a long clip's filmstrip or waveform could stay blank across part of the screen. Reads during a preview now wait, and the tracker re-measures every strip once the preview ends. A zoom-out lays its target out in its first frame rather than inside the caller, and only when the new view holds the old one. * perf(studio): watch a waveform's undrawn ends only when it has some A clip drawn whole has no undrawn ends, so it no longer mounts the two empty markers the strip tracker watches; with hundreds of short audio clips that saved an observer entry each. * fix(studio): measure strips each time a zoom preview is laid out A zoom-out lays its target out partway into the ease, after which the strip tracker kept the stretch it measured before the zoom, so a long filmstrip or waveform went partly blank near the end of the ease. Every layout of a preview now re-measures the strips. * docs(studio): keep the zoom-to-range doc comment within four lines * docs(studio): keep the zoom files' comment share at or under main's The comment ratchet failed on ten files this branch touches. Comments are cut or folded into one line; no code changes. |
||
|
|
e8cfd6b73e |
perf(studio): parse saved HTML once when syncing timeline length (#5092)
* perf(studio): parse the saved file once to sync the composition length after a timeline edit * perf(studio): keep empty duration updates free of parsing * test(studio): pin one parse for rootless moves and the delete length readout * test(studio): check the delete's length readout before its save lands |
||
|
|
b9e511a768 |
fix(studio): a timeline jump no longer starts thumbnail loads it is about to cancel (#5085)
* fix(studio): a timeline jump no longer starts thumbnail loads it is about to cancel * fix(studio): pump inline after the release batch, and pin the synchronous slot free |
||
|
|
6bb85af18b |
feat(studio): a host can hold playback so nothing starts while it is held (#5060)
* feat(studio): a host can hold playback so nothing starts while it is held * feat(studio): a held player seeks without scrub audio * fix(studio): a held player neither loops nor changes speed on J and L * fix(studio): pause clears playing even before the preview has a player * chore(studio): keep the play hold's comment share flat * refactor(studio): keep the play hold out of seek's and the subscription's branches * test(studio): a timeline reset keeps the host's play hold |
||
|
|
b45818f69d |
fix(studio): the motion path draws on every load, not only when the layer's node is the frame's own (#4957)
* fix(studio): the motion path draws on every load, not only when the layer's node is the frame's own useMotionPathData found the selected layer with `instanceof` against the preview frame's HTMLElement. In the Studio preview the body's nodes often carry the editor window's prototypes (see core's runtime/domRealm.ts), so the check failed, the path never got its anchor and drew nothing. Core's realm-free isHtmlElement owns that question; both motion-path call sites now use it. * fix(studio): every preview node check asks what a node is, not which window built it Studio checked preview nodes against their document window's own constructors in seek reapply, studio motion, timeline z-order commits, the manual offset drag and the z-order menu. On loads where body nodes carry the editor window's prototypes those checks fail silently, as the motion path did. They now use core's realm-free predicates, and a source test fails on a new window-bound check. * fix(studio): the webmcp preview helper asks what a node is, and both realm tests stub the frame * fix(studio): the last preview node checks ask what a node is, and the guard sees any constructor read The selector walk read ancestor ids only from editor-realm nodes and the audio group observer never saw a group the preview added. Both use core's predicates now. The guard flags any DOM interface read off an object, the spellings it missed included, and the window gates the old constructor needed are gone. * test(studio): cover the main seek filter across windows and split member reads * fix(studio): a press on the motion path's line inside the selected layer moves the layer * fix(studio): a press inside the selected layer moves it, and path nodes sit where the layer is * refactor(studio): one helper places a path point, for keyframes and the start * fix(studio): a handle over a path node takes its press; nodes sit right on centred layers * fix(studio): reading a layer's path anchor leaves its CSS translate alone * chore(studio): keep the motion path home file under the comment share * fix(studio): a new motion path ends where you click on a CSS-centred layer * fix(studio): a path made on a transform-centred layer ends where you click * style(studio): keep a motion path test comment within 120 columns |
||
|
|
7859c0f003 |
fix(studio): trimming keeps the playhead still; clips snap to the ruler grid (#4986)
* fix(studio): trimming keeps the playhead still; clips snap to the ruler grid * fix(studio): an edge frame never becomes the playhead time; grid snaps where clips save * ci(studio): run the trim and grid snap walk with the other Studio browser checks * fix(studio): snap guides only where the clip saves; play keeps an explicit rewind * fix(studio): a snap guide shows only where the saved clip lands; preview frame gets its own store * fix(studio): judge a moved clip's guide by the duration the move keeps * chore(studio): trim comments the names already say |
||
|
|
7dea1e581f |
fix(studio): playhead keyframe edits keep their ease, undo names its edit and never waits on videos (#4889)
* fix(studio): an edit on a GSAP-animated layer writes its value at the playhead into the file's tween
* fix(studio): undo pressed while an edit saves undoes that edit, not one started after the key
* fix(studio): an edit stays saved when the history reply after it cannot be read
* feat(studio): export ColorField and GradientField; a session style commit takes a map
* refactor(studio): name the map form instead of commenting it
* feat(studio): a host can move layers by exact film px, one undo per call
handleDomGroupMoveBy(moves) on useDomEditSession and DomEditValue moves each
selection by its delta in composition px, for Desktop's align and distribute.
It reuses the group drag's own path: a drag member per element (press-time
route, measured offset map), the delta carried to screen px through the
preview frames, then handleGsapAwareGroupPathOffsetCommit, so one shared
coalesce key gives one undo entry and GSAP members take the GSAP write.
A member that can't move refuses the call before anything is written; the
refusal rejects with its reason and shows no Studio toast (the group commit
takes refusalToast: false; telemetry stays). Zero deltas are skipped.
Tests: a pre-offset element and one under a half-scale parent move by exactly
{10,0} and {0,-5} under one group key; a half-scale parent with a 30 deg
rotated ancestor lands within the 0.001 px a translate is written with; a
GSAP member goes through the GSAP write; three refusal kinds write nothing,
leave the boxes where they were, show no toast and leave no gesture mark,
while a canvas group drag still toasts; the session hands the call to the
group commit with refusalToast: false. Each mutation (no frame mapping, no
zero skip, no restore, no teardown, no capability check, toast on refusal)
fails at least one of them.
* fix(studio): an outside change during a drag waits for the drop to show
While a gesture mark is live in the preview, refreshPlayer takes the shadow load instead of
swapping scenes in place. A swap replaced the node under the pointer mid-drag; the shadow load
is then held by the existing gesture hold and, if the drop saved, reloaded fresh by the stale
rule, so this adds no second "released" signal.
Test: an outside change during a live drag on a preview that can swap scenes leaves the dragged
node in place, shows nothing under the pointer, and after the drop loads fresh with the dropped
position. It fails on the parent without the condition ("swapped under the pointer").
Cost case, measured in a real headless preview on the edit-accuracy bench's per-frame teleport
check. Every GSAP instant patch was forced to miss and fall back to reloadPreview during its own
commit; move and rotate of a held element (gsap.set and tl.set holds), px and xPercent
placement, r0 and r30, root and nested, at 100%:
- The gesture mark was live when the fallback asked for the reload, but had always ended by the
time refreshPlayer ran (refreshKey is consumed in an effect after the commit settles). So the
new condition never fired there: root previews offer no scene swap and load shadow on both
builds, and nested previews swap on both builds.
- Worst post-release frame offset, 32 cases on this build and 32 on the parent: 0.00 px over
76-106 frames each (release to settle). No frame was off by more than 0.5 px.
- Sensitivity: a 3 px nudge injected 50 ms after the fallback reads back as 3.00 px.
* fix(studio): an edit no longer reopens the live-updates stream, and thumbnails ask one at a time
* fix(studio): an undo no longer waits behind paused preview videos for a connection
* feat(studio): a host whose API needs same-origin cookies can have Studio send them
* docs(studio-server): a host on same-origin cookies sets the Studio credentials opt-out
* test(studio): an undo is not held up by the preview's paused videos
* fix(studio): a resize inside one gesture writes a mixed tween once, in place, never beside it
* chore(studio): keep the carried fixes inside the comment ratchet; telemetry posts through studioApiFetch
* test(studio): a drag on a mixed tween is one write under the gesture key
* fix(studio): freeze-frame, loudness and peak-map requests go through studioApiFetch too
* fix(studio): an undo with no project open reloads in full instead of skipping nested files
* refactor(studio): drop the soft reload's reparse seeding, the held-element sweep covers it
* test(studio): keep the undo-restore browser test off the network and inside its timeout
* test(studio): nested composition reads expect the cookie-free request studioApiFetch sends
* fix(studio): an edit at the playhead rewrites its tween in place, so later tweens keep their times
* fix(studio): a rotate on a tween that turns another axis holds its angle and never turns early
* fix(studio): plan every group member before the first write so one refusal moves none
A group drag or nudge preflighted each member against the move refusal rule only. The value-at-playhead planner ran later, in the commit loop, after earlier members were already flushed to disk, so a tween with extras, eased keyframes or an unknown ease left the group half moved.
The group preflight now runs the commit's own route and keyframe plan for every member with its real offset, so any refusal refuses the whole group with nothing written and one toast attributed to the refusing member. The plan is not reused in the commit: earlier members' writes change the file under it, so each member re-plans against the fresh tween, from the same planValueEdit.
* chore(studio): the fetch lint rule also catches window.fetch, globalThis.fetch and self.fetch
* docs(studio-server): set the credentials flag before Studio loads; a mounting host injects it
* test(studio): the undo socket test needs six pinned videos under Vite and checks each undo restores
* fix(studio): Studio leaves cookies out of its requests only when served from loopback
* fix(studio): undo takes back the first edit, and the first save never waits on media
* fix(studio): undo of a move whose save failed stays undone and steps back no older edit
* fix(studio): a style set by its JavaScript name saves under its CSS name
* test(studio): the undo socket test holds round 0 to a full restore too
* fix(studio): the host revert keeps returning what shows the edit again
* fix(studio): an entrance rewritten at the playhead still shows its start state before it starts
* fix(studio): undo takes back the edit pending at the key even after a later edit claims
* chore(studio): lift the late-write quarantine now that undo never waits on videos; format
* test(studio): pin an entrance's start render on the written tween, not a happy-dom GSAP run
* revert(studio): leave entrances as on main, immediateRender does not render a keyframed start
This reverts commit
|
||
|
|
ada4e0d289 |
fix(studio): show each timeline row its own layer instead of a flat bar (#4917)
* fix(studio): show each timeline row its own layer instead of a grey bar A row got a frame only if it spanned under 92% of the film and its id did not look like a backdrop; every other row drew a plain grey bar. Every element row now gets its frame, and the capture fades the row element's siblings first, so the frame shows that layer and not the whole film. Studio's dev server and the CLI share one capture helper; Studio's own copy is gone. * fix(studio): read timeline rows from any realm so each keeps its selector * refactor(studio-server): always isolate the element in a thumbnail clip * fix(cli): undo a thumbnail's isolation before its page takes the next capture * chore(core): generate the dom-realm export and trim thumbnail clip comments * fix(studio-server): restore sibling opacity after a clip, hash selectors in cache keys * fix(studio-server): keep faded siblings in a page-owned list so restore is exact * feat(studio): draw a text layer row as its own live text instead of a captured picture * refactor(studio): move timeline text reading into its own module * fix(studio): keep text rows readable and current, and leave painted layers as pictures * fix(studio): refresh a canvas-edited text row by its own identity and source file * fix(studio): refresh a canvas-edited text row known only by its data-hf-id |
||
|
|
67dbcf7bdb |
feat(studio): preview timeline track insertion (#4907)
* feat(studio): preview new tracks at drop boundaries * fix(studio): preserve group ownership across overlapping moves * refactor(studio): share timeline drop decisions and fixtures * fix(studio): open an empty audio zone below visual tracks * fix(studio): cancel thumbnails when project pages leave * refactor(studio): share thumbnail regression setup * test(studio): gate thumbnail socket release in browser CI * chore(studio): keep optimistic revision comments within ratchet * fix(studio): pin regression proxy requests to its backend * test(studio): bound the proxy origin probe * test(studio): probe proxy origin through the ready document |
||
|
|
30ed3cd124 |
fix(studio): a saved clip volume reaches the timeline store (#4883)
* fix(studio): a clip's saved volume reaches the timeline store, and undo reads it back * fix(studio): drop the comments the volume helpers do not need * refactor(studio): the stored volume reader lives in its own file, under the helpers' size limit * fix(studio): drop the doc line that put the volume reader over its comment share |
||
|
|
45b8e171e2 |
feat(studio): sync origin, out-of-sync repair, linked selection toggle and grouped clip menu (7/8) (#4820)
* feat(studio): order the clip menu into time, sound, picture and delete groups Split and Freeze frame; Normalize, Voice, link items and Duck; Look and Crop; then Delete beside Delete this clip only. Each item file renders its pieces separately, empty groups collapse, and the viewport clamp uses the measured menu height instead of a row-count estimate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio-server): mint freeze-frame right-half links with the shared lk-N helper Freeze frame now calls core relinkSplitHalves, so split halves and freeze halves share one link-id convention instead of L -> L-2. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(studio): apply speed edits to every data-link member in one undo step The inspector speed slider, rate lane edits and ramp presets on a linked clip now commit once, writing the selection and, via expandToLinkedMembers, each partner from its own current value. Unlinked clips keep their usual path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(studio): drop the audio parent tick in favour of the data-link chain badge A linked clip now shows one link indicator: the chain badge driven by data-link. The waveform no longer draws its 1px parent tick. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): follow late clip-menu rows and target link partners like S2 The menu height follows a ResizeObserver so rows that read the live preview after mount still clamp inside the viewport. Speed fan-out builds partner targets with buildPatchTarget, matching the link edit plan. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): show the sound strip and audio menu items without studio's shell The audible-video waveform strip drops AudioWaveform's 16px label band, which left a 0px canvas on short lanes. Normalize loudness and Duck under voice fall back to the timeline session's project, the live preview iframe store and a new onNotice edit callback when no StudioShellProvider is mounted. usePreviewIframeStore is exported so a host can publish its preview. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): show duck under voice only when a voice overlaps The item now appears only when an overlapping voice exists or the bed is already ducked. Its check mark moves to the right edge so unchecked rows align with siblings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(studio): name the partner in the clip menu link and unlink items Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): clip menu stops offering unlink once the clips are unlinked The timeline skipped store updates when only data-link changed, so the menu kept reading the stale link. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(core): sync origin, offset math and move/slip into sync for linked pairs data-sync-origin survives Unlink; split gives right halves a fresh origin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio-server): split re-mints the sync origin of unlinked pairs too Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(studio): detach, link and keep-sound cutout write a sync origin that unlink keeps TimelineElement.syncOrigin is read on both parse paths; merge back drops it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(studio): expect sync-origin on keep-sound cutout write Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(studio): linked selection toggle in the timeline toolbar, on by default Off: a click selects one clip; drag, trim, razor, speed and delete stay on it (delete unlinks the survivor). Alt-click still selects one half when on. Right-click holds the out-of-sync indicator preference. Both persist in UI prefs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(studio): link groups share a label colour; out-of-sync badges with move and slip Red badge on both halves of a sync-origin pair that drifted (frames, s:ff past a second); hidden when rates differ or the preference is off. The whole badge opens Move / Slip into Sync; each edits that clip alone in one undo step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): take link label colours from theme tokens Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(sdk): syncOffset, moveIntoSync and slipIntoSync for sync-origin pairs Core gains findSyncPartner, the DOM pairing shared by the SDK and the CLI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(cli): timeline rows report syncOffsetFrames and print out-of-sync Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(cli): the timeline row fixture carries syncOffsetFrames Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(skills): data-sync-origin in hyperframes-core Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(core,sdk): keep a one-sided cut's sync origin and slip the in-point playback reads relinkSplitHalves reminted the right half's sync origin even when only one member of an unlinked source pair was cut, so the uncut partner kept the old origin and the new half lost its badge. The origin is now reminted only when both the video and the audio were cut. Slip into Sync wrote data-media-start whenever it existed, but playback reads data-playback-start first, so a clip carrying both never moved. The link timing reader now uses playback's precedence and the slip writes the attribute that wins; lint compares the same field. A sync partner is also looked up only in the clip's own composition (core) or source file (Studio). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): flip the out-of-sync menu above the pointer near the bottom edge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor: trim comments the sync-origin layer added Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(core): split the scoped candidate lookup out of findSyncPartner Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(core,studio): find sync partners inside the link scope findSyncPartner and Studio's syncPartnerOf now scope by the same rule as link groups: the nearest data-composition-id or data-composition-file ancestor, plus the row's compositionScope in Studio. An origin reused in a file host or an inline composition no longer pairs across it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
0559be0b13 |
feat(studio): link a video and its audio with data-link (6/8) (#4818)
* feat(core): add data-link media link helpers Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(lint): warn on out-of-sync and orphaned linked clips Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(studio): select, drag and trim linked clips together Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(studio): detach, merge, link and unlink source transforms Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(studio): link-aware split, delete, alt-edit unlink and link edit actions Split and delete fan out to link partners. Alt drag/trim edits one member and unlinks it. onLinkEdit runs unlink, link, detach and merge as one undo step each. Single-clip timing edits of a linked clip skip the SDK path so its linked default cannot move the partner behind the store. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(studio-server): give split right halves of a linked pair their own link Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(studio): clip menu detach, unlink, link, merge back and delete-one items Items live in clipMenuLinkItems.tsx with a one-line hook in ClipContextMenu; the same resolver drives the Cmd+L, Opt+Shift+D and Opt+Delete shortcuts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(sdk): setTiming applies to data-link partners by default { linked: false } edits one member and unlinks it, matching Studio's Alt-edit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(skills): document data-link linked clips in hyperframes-core Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * chore(studio): keep comment share at or below base in link plumbing Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(studio): audio pill link follows data-link, not a shared file name Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): alt-click selects one linked member even inside the pair selection Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(lint): drop the rule-list comment for the linked clip rules Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(sdk,lint): keep a link group inside its own composition Link ids are minted per file, so lk-1 is normal in the root and in a child composition. The SDK's linked-timing query descended into nested hosts and addressed every match with the initiating scope, so moving a root clip moved the child's pair too; lint grouped them into one drifting group. Both now group only members of the same composition scope. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): match linked media by full asset path, scope links, keep hidden sound silent Merge and Link compared only a lowercased basename, so assets/one/talk.mp4 and assets/two/talk.mp4 enabled a destructive Merge. Clips now compare the src resolved against each clip's own source file, and Merge re-checks the two srcs in the source before it runs. Link membership in the timeline (linked members, gesture expansion, unlink orphans) is scoped to a source file. Detach and the keep-sound cutout carry a hidden video's data-hidden to its audio, and Merge refuses when only one member is hidden. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(studio): move the timeline move-edits handler into its adapter App.tsx sat at 600 lines on this layer and 602 once merged with main. useTimelineMoveEditsHandler now lives beside persistTimelineMoveEditsAtomically, same callback and dependencies, bringing App.tsx to 592. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(sdk,studio,lint): keep link groups inside inline compositions A link group now stays inside the nearest data-composition-id or data-composition-file ancestor. The SDK used to recognise only file hosts, and Studio compared only sourceFile, so an inline child composition that reused a link id was edited together with the root group. core/media-link linkScopeOf is the shared rule for the SDK and Studio. Lint cannot import core, so it uses the same two attributes directly. Studio rows record their compositionScope, and link and merge refuse pairs that cross it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(sdk): refuse a link edit whose partner address names another clip A partner addressed in the caller's scope can resolve to a different element when an inline composition reuses a root clip's data-hf-id. setTiming now checks that each partner's address resolves back to that partner and throws before mutating when it does not, instead of editing the root clip. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): a remote media url keeps its query when matching an asset Two different videos at one remote path with different queries were treated as the same file, so Merge could delete the audio and use the wrong video's sound. Project-local srcs still drop query and hash. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * fix(studio): keep a remote url's query exactly as written when matching assets Decoding the whole url folded %26 into & so two different media urls matched. Decode only the path; the query is compared as authored. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * fix(studio): compare a remote url as serialized, decode only local paths A remote pathname with an encoded reserved character (%3F) matched the same path with a literal ?, though they can return different media. Remote urls keep origin, path and query exactly; local srcs are still decoded and stripped of query and hash. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
3c299acc7f |
feat(core): audible videos in preview web audio, audio groups, meters and carve (2/8) (#4814)
* feat(core): add isAudibleVideoElement predicate and audible media selector Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(runtime): route processed audible videos through web audio in preview An audible <video> joins the Web Audio schedule, hidden-toggle and group-capture passes when it needs a gain el.volume cannot express: a boost above unity, an fx chain, automation, or an audio group. A plain audible video at unity stays on native output. The clock master stays audio-only; a video whose capture fails stays on native output (never decoded, never failed closed). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(audio): let audible videos join audio groups in preview and render resolveAudioGroups, audioGroupOf, group render ids, the engine mixer and the audio_group_no_members lint rule accept an audible <video>. A hidden group drops its video members from the mix; muted videos stay inert. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(editing): offer the audio fx section on audible videos EditableElementFacts gains hasAudio; studio and sdk derive it from muted and data-has-audio. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(studio): show audio meters when a project has an audible video Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(studio): offer audible videos as carve voices Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(studio): let audible video clips join audio groups Drops the video refusal; grouping and group audition count audible videos. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(engine): honor hidden audio groups for auto-detected video audio Muted videos that declare data-has-audio are no longer mixed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): keep authored src, loop and honest status when keeping cutout sound Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(core): treat only data-has-audio=true as audible in runtime and lint Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(core): trim the web audio route and group-key comments Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(runtime): capture ramped clips so a group's bus carries them in preview A rate lane skipped Web Audio entirely, so a ramped video or audio clip in a group played native output without the group's fader, mute or FX while the export applied them. Only the decoded-buffer fallback cannot follow a rate curve; the media-element capture can, so the skip now guards that fallback. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): show meters only for videos Web Audio carries A plain audible video at unity stays on native output, which the meters cannot read, so it no longer advertises them. The runtime's join rule and the meter gate now share audibleVideoNeedsWebAudio (core/audible-video). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> |
||
|
|
37f30b1d06 |
feat: keep a video's sound on the clip by default (1/8) (#4813)
* feat(cli): one owner for init media placeholders, audio stays on the video Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * feat(cli): init keeps a video's sound on the clip; silent files scaffold muted Supersedes the patchVideoSrc changes in #3977 and #3942 and carries their tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: miga-heygen <miga-heygen@users.noreply.github.com> Co-Authored-By: kapelame <kapelame@users.noreply.github.com> * feat(registry): example templates keep the a-roll's sound on the video Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(lint): video audio rules recommend keeping sound on the video Update video_missing_muted and video_audio_double_source message and fixHint text to recommend the new default: keep audio on the video with data-has-audio="true" (not muted). Tests verify the new wording is in place. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(parsers): a video is either audible (data-has-audio) or muted, never both Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): follow the compiler's audio rule in the audio-track toggle Confirm before background removal drops a video's sound. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(skills): hyperframes-core teaches sound on the video by default Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(skills): workflows and scaffold guidance keep a video's sound on the clip Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: footage with sound keeps it on the video clip Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cli): init from-file a-roll is timed, muted strip is attribute-exact The from-file a-roll video gets data-start="0" so a scaffold lints clean, and the orphaned audio-only slot comment is dropped. setVideoAudio now walks the tag attribute by attribute, so a class value containing the word muted survives. The ffprobe-missing warning says the video is assumed to have sound and how to switch to muted, and DEFAULT_META notes the failure surfaces at render until lint support lands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): keep has-audio in step with the muted toggle, test cutout confirm Muting a video now clears has-audio and unmuting sets it to true, in both the Design and flat media panels, matching the Has audio track toggle. Audio elements are unchanged. Adds coverage for both panels plus the cutout window.confirm guard: declined leaves src alone, accepted swaps src and mutes, a silent video never prompts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(parsers): updateElementInHtml hasAudio only applies to videos, true or false An audio element or an undefined hasAudio no longer picks up a muted attribute; only an explicit false on a video writes muted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs: video_missing_muted rule text, silent-footage notes, consistent audible examples lint.mdx and cli.mdx describe the current video_missing_muted rule instead of the retired unmuted-video wording. The editing recipes say how to adapt for silent footage and require the outgoing clip's sound to end at a J-cut. The Remotion media example shows the audible mapping consistently, data-attributes states that has-audio is required unless muted, and the hairline frame note no longer claims the video is muted. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cli): encode init media filenames and probe --audio duration Function replacers stop dollar-sign pattern expansion in filenames; src is percent-encoded. --audio now passes the probed track length as the composition duration in both init paths. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(lint): audio-state-aware media rules and time-aware double-source check video_missing_muted honors any explicit data-has-audio. video_audio_double_source only considers audible videos and only fires when the same-src clips overlap in time. duplicate_audio_track now covers audible videos. audio_file_without_element no longer claims silence when an audible video carries the sound. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * docs(skills): audio-stream check for remotion ports, followable J-cut recipe Remotion Video maps to data-has-audio only when the file has an audio stream. The J/L-cut recipe now shows both shots with muted pictures and separate audio. embedded-captions removes the audio.mp3 scratch file it extracts. skills-manifest.json regenerated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * refactor(lint): trim comments to satisfy the comment ratchet Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): atomic muted edits, cutout keeps sound on a linked audio Muted and Has audio track commit one batched write (one persist, one undo entry) and remove data-has-audio instead of writing an empty marker. Unmuting a video probes its src: audible -> true, silent -> false, probe failed -> absent. Remove background on an audible video inserts a linked sibling <audio> with the original sound in the same write, replacing the drop-the-sound confirm. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(producer): skip hidden videos when auto-adding video audio A video hidden in Studio is dropped by the mixer, so its src never reached existingAudioSrcs and the render re-added it at full volume. The video parser now records the shared hidden predicate and the auto-detect step skips hidden videos. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(studio): keep useDomEditSession under the 600-line cap Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: miga-heygen <miga-heygen@users.noreply.github.com> Co-authored-by: kapelame <kapelame@users.noreply.github.com> |
||
|
|
21a29c2ac7 |
fix(studio): the timeline scroll gate catches dropped frames in the virtualized view (#4855)
* fix(studio): the timeline scroll gate catches dropped frames in the virtualized view * fix(studio): the timeline scroll gate measures a failed arm once more before failing * fix(studio): the virtualized timeline gate holds interactions to 58.3 ms |
||
|
|
a59d93a027 |
fix(studio): a focused video or audio player keeps its arrow and play keys (#4854)
* fix(studio): a focused video or audio player keeps its arrow and play keys * fix(studio): every remaining shortcut asks the shared typing check |
||
|
|
07af05c816 |
feat(studio): fade handles ride the fade's end and the waveform shows the fade (#4844)
* feat(studio): fade handles ride the fade's end and the waveform shows the fade * refactor(studio): read fade handle keys from one lookup * fix(studio): fade handle keys stay with the handle and snap past the clip's own edges * fix(studio): Cmd shortcuts keep working on a focused slider and fade boxes stay on their tabs * fix(studio): keep a fade handle while it is in use and restore the viewport gate's Chrome path * fix(studio): a fade's draft clears with its own save and grow drags never shrink it * fix(studio): saved fades reach the timeline store so the handle stays where it was dropped * fix(studio): a fade longer than its clip starts a drag or key from the clip's end * fix(studio): fade comments state the rule, not its history |
||
|
|
c20934a720 |
fix(studio): the timeline viewport gate judges p95 over every measured scroll step (#4847)
* fix(studio): the timeline viewport gate judges p95 over every measured scroll step * fix(studio): format the pooled p95 lines in the timeline viewport gate * test(studio): pin the timeline viewport gate's pooled verdict with tests * refactor(studio): share one Chrome launcher across the timeline and fade-handle gates |
||
|
|
d0404b450c |
fix(studio): undo and redo are no longer held behind thumbnail renders (#4842)
* fix(studio): undo and redo are no longer held behind thumbnail renders * test(studio): composition card tests share one mount, and the bench's 2 s undo rule is tested * fix(studio): a composition card and its timeline clip share one thumbnail render * test(studio): bank opening a film at 15 thumbnail requests, one per composition * fix(studio): composition cards load near the viewport and keep their last frame until the next * fix(studio): a composition card keeps its last frame under cache pressure, and loads 200 px early |
||
|
|
14e87005d9 |
fix(studio): name a repeated section by its authored id in the Design panel (#4768)
* fix(studio): name a repeated section by its authored id in the Design panel * fix(studio): the timeline's page-read fallback also names a repeated section by its authored id |
||
|
|
ae8d1780ff |
fix(studio): undoing an agent's build takes its sections off the timeline too (#4757)
* fix(studio): undoing an agent's build takes its sections off the timeline too * fix(studio): a reloaded preview's timeline is read from the new document, sections included * fix(studio): a section still in the preview stays on the timeline, and trims are unchanged |