Commit Graph
5 Commits
Author SHA1 Message Date
James RussoandClaude Opus 5.5 e2430edecf fix(cli): one trusted PATH rule for the engine and CLI; say why a project copy was skipped (#7801)
* fix(cli): one trusted PATH rule for the engine and CLI; say why a project copy was skipped

The Windows PATH rules (quoted entries, the %SystemRoot% folders) now live in
the parsers' trustedPathDirs, so engine helper lookups and the CLI's PATH
rewrite apply the same rule.

When sam, aws, gcloud, docker, git or npx is not found but a copy sits in a
project folder the rule skipped, the message names that copy by its path
relative to the project and says why it was not used. cloudrun now reports a
missing gcloud or docker as not found instead of "exited with null".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(cli): join a simulated Windows PATH with the Windows separator

The shared trusted-folder rule now splits PATH on ';' whenever the platform
is win32, as Windows does. Two tests that pretend to be Windows on Linux
built PATH with ':', so the rule saw one folder instead of two.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): name skipped copies above the working folder; pin Windows PATH to the shared rule

The not-found hint now names any copy the trusted PATH rule skipped,
relative to the working folder, including ../node_modules/.bin when an
npm or pnpm script runs from a subfolder. A Windows test pins that quoted
PATH entries still go through the shared rule, so the project root's and
ancestors' node_modules/.bin stay skipped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* chore(cli): trim projectCopyHint comments to the package's comment share

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-15 21:38:30 +00:00
Michael Wang 7184b6694e fix(parsers): helper lookups skip the project above the working folder, not only the folder (#7854)
* fix(parsers): helper lookups skip the project above the working folder, not only the folder

* fix(parsers): compare a missing PATH folder by its nearest real parent, so Windows short names match
2026-11-15 19:12:04 +00:00
Miguel Ángel 96cc8cb852 fix(parsers): helper programs never come from the project a subfolder sits in (#7845)
* fix(parsers): helper programs never come from the project a subfolder sits in

Run from a subfolder, the trusted PATH check skipped only folders inside the
working directory, so the project's own node_modules/.bin, which npm run puts
on PATH from every ancestor, still supplied helpers. The check now skips every
folder inside the outermost ancestor that marks a project (.git, package.json,
node_modules, hyperframes.json), below the home folder.

A CLI test also runs a real bare-name spawn of an executable planted in the
project folder: it runs under the raw PATH and is not found after the PATH trim.

* fix(parsers): keep the trusted lookup's comment share at main's level
2026-11-15 17:58:02 +00:00
James RussoandClaude Opus 5.5 83eae240fb fix(cli): start helper programs only from trusted PATH folders on every platform (#7787)
* fix(cli): start helper programs only from trusted PATH folders on every platform

At startup the CLI and its worker entry points rewrite their own PATH to
absolute folders outside the working directory, on every platform, so a
program planted in the project (a relative or empty PATH entry,
node_modules/.bin, or any folder inside the cwd) is never run by name.
Child processes inherit the trimmed PATH. media-use reuses the same helper
instead of its private copy.

doctor resolves docker with findTrustedExecutable and runs it by absolute
path with execFileSync, no shell. A docker found only in the project's
node_modules/.bin is reported as not found, with a hint that it was skipped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): keep stale-install detection and Windows system folders after PATH trim

The stale hyperframes check for reverse start reads the PATH the process
started with, so an older copy in the project's node_modules/.bin is still
reported. It only reads the filesystem and never runs that copy.

On Windows the trim now keeps %SystemRoot%, System32, System32\Wbem and
the WindowsPowerShell folder even when the CLI starts inside them, so an
elevated prompt in C:\Windows\System32 can still run cmd, taskkill,
tasklist, powershell and tar. PATH entries wrapped in double quotes are
unquoted before the check instead of being dropped. PATH order is kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): resolve the empty-PATH placeholder only when it is needed

Computing it at import threw in test environments where import.meta.url is not a file URL.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-15 01:24:20 +00:00
Michael WangandClaude Opus 5.5 84c7d02a19 fix(cli): keep project folders from choosing the programs and config the CLI runs (#7511)
* fix(cli): resolve helper programs from PATH, never the working directory

On Windows a bare command name is looked up in the working directory before
PATH. The CLI now sets NoDefaultCurrentDirectoryInExePath at startup, which
Node's spawn and cmd.exe both honor and child processes inherit, so tools
such as powershell.exe, taskkill and npx.cmd always come from PATH.

The shared ffmpeg/ffprobe resolver no longer scans the working directory on
Windows and skips relative PATH entries.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): keep Python helpers from importing files in the working directory

`python -c` and `python -m` put the working directory first on sys.path, so
a file in the project named like a probed module ran instead of the
installed package. Inline helper code now drops that entry before any
import, and `-m` helpers (pip) run through runpy after the same step. Paths
and arguments are unchanged.

On Windows, findPython also skips a `where` match in the working directory.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): run the skills installer and nested CLI calls independent of the project

The global skills install ran `npx skills@<pin>` in the current folder, so
npm could take the package or registry from that project's node_modules or
.npmrc. It now runs from the home folder; the install is global either way.

When the CLI starts the media-use engine it hands over its own entry file.
The local voice fallback and the audio helpers then run that same CLI with
the same Node instead of resolving `npx hyperframes` from the project.
Without a handed-over entry they behave as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(media-use): load only provider keys from a project .env

The audio scripts copied every key of a project .env into their environment
except two. They now take the same kind of short allowlist the CLI uses:
HeyGen, ElevenLabs and Gemini API keys plus a few harmless settings. Program
overrides, runtime options, credential files and the credential store path
come only from the person's own environment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): build whisper.cpp only from a pinned, verified release

The source-build fallback cloned the upstream default branch. It now clones
the v1.9.5 release tag and refuses to build unless the checkout is the
reviewed commit for that tag.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): keep registry caches apart and refuse config install targets

Registry cache file names now include a digest of the exact registry URL,
and each entry records the URL it came from, so one registry's cached
manifest is never read for another. Entries from older versions are
refetched once.

Registry installs refuse targets inside .git or any hidden directory, hidden
configuration files, and package.json, hyperframes.json and
hyperframes.lock.json. An example installed by `init` may still bring its
own package.json and .gitignore.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(capture): keep page text to one line in agent files and validate Vertex keys

Capture writes AGENTS.md, CLAUDE.md and .cursorrules from the page's title,
font names and colours. Page text is now flattened to one short line and
colours must be hex values. Existing agent files that capture did not write
are kept, with a warning.

HYPERFRAMES_VERTEX_SERVICE_ACCOUNT must now be a plain service-account key
with a Google token endpoint; other credential types skip captioning with a
warning.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(cli): find the digest-named registry cache and trim a new file's comment

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): match registry targets as Windows names them; skills install without HOME

Windows drops trailing dots and spaces from a path segment and reads name:stream as
name, so package.json. or .git./hooks reached the files the target rules refuse.
The global skills install now falls back to the temp folder when HOME does not exist.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): turn off the Windows working-directory lookup in every program entry

The warm-check server and client are their own tsup entries and copied the
environment before cli.js set NoDefaultCurrentDirectoryInExePath, so the server
spawned a bare powershell.exe that Windows could take from the project folder.
Every entry that hides child consoles now also loads windowsExeSearch first.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(cli): refuse Windows short-name registry targets

A segment like CLAUDE~1 or PACKAG~1.JSO opens the long name on NTFS, so it
reached the files the target rules refuse. The trailing-dot and stream-name
normalization is removed: publication already rejects those segments.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-10 20:01:19 +00:00