Commit Graph
2073 Commits
Author SHA1 Message Date
Miguel Angel Simon Sierra f705328022 Merge branch 'fix/studio-stroke-commit-reliability' into fix/studio-interaction-consolidation 2026-07-15 20:58:21 -04:00
Miguel Angel Simon Sierra bbe1774549 Merge branch 'fix/studio-sfx-u16' into fix/studio-ui-audit-fixes 2026-07-15 20:42:18 -04:00
Miguel Angel Simon Sierra 369740d76b fix(studio): timeline clip selection reveals the inspector like the legacy path 2026-07-15 20:42:13 -04:00
Miguel Angel Simon Sierra 8c4b5c72cd Merge branch 'fix/studio-sfx-u16' into fix/studio-ui-audit-fixes 2026-07-15 20:32:00 -04:00
Miguel Angel Simon Sierra 262936b41c fix(studio): timeline selection mirror must not clear canvas-originated selections 2026-07-15 20:31:12 -04:00
Miguel Angel Simon Sierra bd88e11abe Merge branch 'fix/studio-sfx-u19' into fix/studio-ui-audit-fixes 2026-07-15 20:09:15 -04:00
Miguel Angel Simon Sierra b02ce90d3f fix(studio): gate storyboard mode on storyboard presence 2026-07-15 20:08:24 -04:00
Miguel Angel Simon Sierra 444b0203d7 Merge branch 'fix/studio-sfx-u18' into fix/studio-ui-audit-fixes 2026-07-15 19:55:38 -04:00
Miguel Angel Simon Sierra 4524cebb07 Merge branch 'fix/studio-sfx-u16' into fix/studio-ui-audit-fixes
# Conflicts:
#	packages/studio/src/player/components/TimelineLanes.test.tsx
#	packages/studio/src/player/components/TimelineLanes.tsx
2026-07-15 19:55:32 -04:00
Miguel Angel Simon Sierra 85a4077491 fix(studio): undo groups nudges and drags by interaction boundaries 2026-07-15 19:52:00 -04:00
Miguel Angel Simon Sierra 52f14a52c2 refactor(studio): single timeline-to-preview selection sync path 2026-07-15 19:51:01 -04:00
Miguel Angel Simon Sierra 7b4e93c7c8 Merge branch 'fix/studio-sfx-u17' into fix/studio-ui-audit-fixes 2026-07-15 19:50:11 -04:00
Miguel Angel Simon Sierra 80a7fc64e4 Merge branch 'fix/studio-sfx-u15' into fix/studio-ui-audit-fixes 2026-07-15 19:49:52 -04:00
Miguel Angel Simon Sierra 4e712e27d9 fix(studio): usable keyframe diamonds at narrow widths, one-gesture drag, beat-snapped retime 2026-07-15 19:49:26 -04:00
Miguel Angel Simon Sierra e1945d4c42 refactor(studio): serialize view mode through the project hash state 2026-07-15 19:49:12 -04:00
Miguel Angel Simon Sierra 67aaad5790 refactor(studio): route all export entry points through one render action 2026-07-15 19:47:40 -04:00
Miguel Angel Simon Sierra d7057de255 Merge branch 'fix/studio-sfx-u13' into fix/studio-ui-audit-fixes 2026-07-15 19:32:24 -04:00
Miguel Angel Simon Sierra 8dca863e44 Merge branch 'fix/studio-sfx-u12' into fix/studio-ui-audit-fixes 2026-07-15 19:32:24 -04:00
Miguel Angel Simon Sierra 8f9556ace9 Merge branch 'fix/studio-sfx-u11' into fix/studio-ui-audit-fixes 2026-07-15 19:32:23 -04:00
Miguel Angel Simon Sierra 532cf24b94 Merge branch 'fix/studio-sfx-u10' into fix/studio-ui-audit-fixes 2026-07-15 19:32:23 -04:00
Miguel Angel Simon Sierra 88449ede9b Merge branch 'fix/studio-sfx-u9' into fix/studio-ui-audit-fixes 2026-07-15 19:32:22 -04:00
Miguel Angel Simon Sierra fda68f08bb Merge branch 'fix/studio-sfx-u8' into fix/studio-ui-audit-fixes 2026-07-15 19:32:22 -04:00
Miguel Angel Simon Sierra 683e30fb96 Merge branch 'fix/studio-sfx-u7' into fix/studio-ui-audit-fixes 2026-07-15 19:32:21 -04:00
Miguel Angel Simon Sierra 96719df0f5 Merge branch 'fix/studio-sfx-u6' into fix/studio-ui-audit-fixes 2026-07-15 19:32:20 -04:00
Miguel Angel Simon Sierra f5adff8a15 fix(studio): honest empty states and inline file operation errors 2026-07-15 19:31:34 -04:00
Miguel Angel Simon Sierra 783403f510 fix(studio): keep errors visible in toasts, render queue, and header 2026-07-15 19:30:26 -04:00
Miguel Angel Simon Sierra 4c5d4ea277 fix(studio): clarify canvas affordances for indicators, crop, and snapping 2026-07-15 19:26:28 -04:00
Miguel Angel Simon Sierra 1cc1a2e121 fix(studio): remove trap options and wrong defaults from the inspector 2026-07-15 19:24:35 -04:00
Miguel Angel Simon Sierra 7f0ed63abd fix(studio): stop feedback bar layout shift and add caption-mode exit 2026-07-15 19:23:10 -04:00
Miguel Angel Simon Sierra 6a51a2f9f1 fix(studio): keep timeline clip selected on reclick and clear keyframes on Escape 2026-07-15 19:22:39 -04:00
Miguel Angel Simon Sierra 562d721324 fix(studio): explain disabled inspector controls 2026-07-15 19:21:49 -04:00
Miguel Angel Simon Sierra b514982fe9 fix(studio): resolve source-probe truth before committing cycled selections 2026-07-15 18:54:49 -04:00
Miguel Angel Simon Sierra c427ab9656 fix(studio): correct inspector input commit and edit behaviors 2026-07-15 18:43:34 -04:00
Miguel Angel Simon Sierra 37fbc91bbc fix(studio): persist panel sizes and guard layout minimums 2026-07-15 18:42:34 -04:00
Miguel Angel Simon Sierra 3b1ac73dfa fix(studio): apply optimistic style commits to the selection snapshot 2026-07-15 18:41:41 -04:00
Miguel Angel Simon Sierra ce60b85738 Merge branch 'fix/studio-sfx-u4' into fix/studio-ui-audit-fixes 2026-07-15 18:25:51 -04:00
Miguel Angel Simon Sierra c0dfd0354f Merge branch 'fix/studio-sfx-u3' into fix/studio-ui-audit-fixes 2026-07-15 18:25:51 -04:00
Miguel Angel Simon Sierra 17e4807efd Merge branch 'fix/studio-sfx-u2' into fix/studio-ui-audit-fixes 2026-07-15 18:25:50 -04:00
Miguel Angel Simon Sierra 2e0789b546 refactor(studio): consolidate easing selection into the curve editor
Remove the redundant Speed select from AnimationCard; EaseCurveSection
is the single ease surface. The picker now renders even for eases with
no bezier representation (previously the whole section vanished), and a
More-eases select keeps all 31 supported ease values reachable.
2026-07-15 18:25:12 -04:00
Miguel Angel Simon Sierra 5fe9870835 fix(studio): serialize style persistence through the dom-edit save queue
Style, text-field style, and attribute commits called persistDomEditOperations
directly, bypassing the existing save queue that position patches already use.
The server's patch-element route is last-write-wins with no version check, so
an older in-flight commit could land after a newer one and silently overwrite
it (the edit "vanishes on reload").

Wrap the persist closure for these commit paths in queueDomEditSave so writes
reach the server strictly in commit order. Optimistic apply() stays outside
the queue so the UI remains instant, and a queued persist failure (including
the save-queue circuit breaker) still reverts and toasts through the existing
error path.
2026-07-15 18:20:44 -04:00
Miguel Angel Simon Sierra 0d15cfcb3c refactor(studio): remove dead BlockParamsPanel 2026-07-15 18:19:30 -04:00
Miguel Angel Simon Sierra 15cd697ab9 refactor(studio): remove dead inspector/overlay plumbing
Remove Section.icon dead prop and all callers, unused
copiedAgentPrompt/onAskAgent PropertyPanel pass-through, dead
recordingState/onToggleRecording tunnel through DomEditOverlay and
PreviewOverlays, and unused GestureRecordBadge export.

The useDomEditContext migration for MotionPathOverlay was skipped:
the combined hook still has live consumers (StudioRightPanel,
LayersPanel, VariablesPanel), so it is not dead code.
2026-07-15 18:18:23 -04:00
Miguel Angel Simon Sierra 7abad62050 refactor(studio): unify ask-agent prompt modals
Parameterize AskAgentModal (title, subtitle, initialValue) and route
the Blocks prompt preview through it; delete the bespoke
PromptPreviewModal. Copy uses the shared clipboard util and both call
sites get the same dirty-draft close guard and copy confirmation.
2026-07-15 18:16:34 -04:00
Xuanru Li 7f4eaeb568 feat(cli): coordinate-frame layout findings in check (#2354)
* feat(cli): coordinate-frame layout findings in check

Four production compositions shipped with 100-600px layout drift, each a
different coordinate-frame confusion the check graded info or missed
entirely: viewport pixels written as container left/top, gsap x/y
treated as absolute position, a -350px margin fighting flex centering,
and stage-relative path coords drawn into a nested SVG.

Three new layout findings close the class:
- positioned_out_of_parent: an absolute/fixed element rendering mostly
  outside its positioning ancestor (warning) — the parent needs no
  overflow clipping, which is what let container_overflow miss it.
- box_out_of_canvas: a painted panel breaching the canvas (warning) —
  text is canvas_overflow's, media is frame_out_of_frame's, painted
  boxes were nobody's.
- connector_detached: a connector path whose endpoints land far from
  every anchorable element (warning) — measured coordinates drawn into
  an SVG with a different origin.

canvas_overflow additionally promotes from info to warning when held
across samples AND the breach exceeds 5% of the canvas.

All three are persistence-tiered and respect data-layout-allow-overflow.
Verified against the four incident compositions: every one now surfaces
its drift as held warnings (previously: info or silence).

* fix(cli): harden coordinate-frame findings against review false positives

Reworks all three findings after two-lens review (adversarial FP hunt in
real Chrome + maintainer pass):

- escaped_container (was positioned_out_of_parent): uses offsetParent
  (transform-aware, skips fixed-as-canvas), exempts fully-detached
  callouts within an attachment allowance while still flagging
  touching-but-mostly-outside drift.
- panel_out_of_canvas (was box_out_of_canvas): paint alone qualifies
  (flat solid panels were a false negative), fully off-canvas rects are
  parked entrances and stay silent, pointer-events:none marks decorative
  layers, hero-sized breaches warn while small bleeds stay info.
- connector_detached: endpoints via getPointAtLength + getScreenCTM
  (viewBox, preserveAspectRatio, group transforms, every command type),
  defs/marker/clipPath subtrees skipped, word-boundary connector naming,
  containment tier limited to opaque non-ancestor targets (a text-bearing
  wrapper contains its own diagram's endpoints).
- canvas_overflow promotion requires partial visibility — a fully
  off-canvas rect is a parked entrance, not drift.

Verified: the four incident compositions still surface their drift as
held warnings; the review's false-positive repros (fixed HUD, callout,
parked entrance, corner bleed, marker arrowheads, g-transform and
viewBox-scaled connectors) are clean at warning level. Docs and the CLI
skill reference now describe the coordinate-frame findings.

* fix(cli): panel ownership is geometric — direct-text panels were a silent false negative

A painted panel whose direct text stays in-bounds while its box breaches
the canvas produced neither finding: canvas_overflow measures the text
range and panel_out_of_canvas skipped every own-text element. Skip the
panel finding only when the element's own text ALSO breaches (that
geometry belongs to canvas_overflow); pin the message/fixHint wording of
all three findings with positive assertions; document the SVG-internal
anchor blind spot.

* fix(cli): classify panel decoration by paint kind, not pointer-events

pointer-events:none exempted the framed-painting incident's gold frame
layers — hero content that happens to disable hit-testing. Decoration is
now gradient-only paint (spotlights, textures, vignettes); url() images,
solid fills and borders are content regardless of pointer-events.

* fix(cli): add fixHint to the test-local AuditIssue shape

* fix(cli): gradient stops decide content vs decoration; ownership matches canvas_overflow's tolerance

A gradient with any solid stop (alpha >= 0.6) is content — heroes and
cards painted with linear-gradient were invisible under the blanket
gradient exemption; all-translucent stops (spotlights, vignettes) stay
decoration. The text-ownership check now uses the audit tolerance that
canvas_overflow itself fires at, making the contract strict-mutex: any
text breach past that tolerance cedes the element, so a shallow 20px
text breach no longer double-reports.
2026-07-13 15:35:03 -07:00
Miguel Ángel 8e50e8477f fix(cli): skip contrast for intentionally covered text (#2366) 2026-07-13 18:22:30 -04:00
Miguel Ángel 74fb4dbcc3 docs(cli): sync SRT upload docs from EF (#2364) 2026-07-13 17:51:25 -04:00
Vance Ingalls 9b71bc2103 Merge pull request #2361 from heygen-com/via/flake-fix-manager-progress-notice
test(cli): stabilize flaky install-lock wait-notice test with fake timers
2026-07-13 14:37:40 -07:00
Vance Ingalls e47af77c5a test(cli): stabilize flaky install-lock wait-notice test with fake timers
Adopt the fake-timer pattern the sibling "recovers when a crashed reclaimer
leaves both lock directories" test in the same file already uses. Without
fake timers, if the dynamic `import("./manager.js")` beat between
`installFsMocks({ initialMtimeMs: Date.now() })` and the `withInstallLock`
call exceeds `staleMs` (50 ms on a busy shared runner with `vi.resetModules()`
per beforeEach), the new immediate-stale short-circuit added in #2328 fires
on iteration 1, breaks out before `waitedMs` reaches `waitNoticeMs=20`, and
no "Waiting for another hyperframes process" warn ever emits — the assertion
at `manager.test.ts:428` (`expected false to be true`) then fails.

Under fake timers, `Date.now()` is frozen at the mtime seed, so the lock
stays non-stale across the dynamic import and the wait-notice branch
observes real polling; `vi.advanceTimersByTimeAsync(staleMs + pollMs * 5)`
then drives the loop past both the wait-notice threshold and the stale
deadline so the reclaim + acquisition still resolves.

Test-only change; no production-code diff. Verified 27/27 in
`packages/cli/src/browser/manager.test.ts` under `vitest run`.
2026-07-13 21:30:44 +00:00
Xuanru LiandClaude Fable 5 3e3b37d37f fix(cli): occlusion-probe false positives — pointer-events blindness, low-alpha gradients, not-yet-entered text (#2357)
* fix(cli): three occlusion-probe false-positive sources in text_occluded

- pointer-events:none text is invisible to elementFromPoint, so the probe
  always hit whatever paints beneath and misread visible text as buried;
  restore hit-testing on the element for the duration of the probe
- a backgroundImage counted as opaque regardless of alpha, so a 4%-alpha
  grid/scrim gradient qualified as an occluder; gradients now occlude only
  when their colours reach alpha > 0.6 (url() images unchanged)
- a visible container whose every text-bearing descendant is still at
  opacity 0 (entrance not started) was probed anyway; skip when no text
  ink is on screen

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(cli): address review — document-wide hit-testing restore, gradient compositing, whitespace ink

- restore hit-testing for ALL pointer-events:none elements during the text
  audit pass (not just the probed text): an occluder that itself carries
  pointer-events:none is invisible to elementFromPoint, which made truly
  buried text read as clean once the text alone became hittable
- hasVisibleTextInk ignores whitespace-only text nodes (indented markup
  defeated the gate) and uses a 0.05 floor so mid-fade text keeps its
  persistence occurrences
- hasOpaqueBackground composites gradient alpha with background-color
  (two 0.5-alpha layers paint at ~0.75); gradientMaxAlpha returns opaque
  for any colour function it cannot score (oklch/lab/...); percentage
  alpha values now parse as fractions

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(cli): walk the elementsFromPoint stack in occluderAt

A transparent layer that becomes hittable (pointer-events restored) must
not mask an opaque occluder painting beneath it — single-point
elementFromPoint returned the transparent top and dropped two genuinely
buried cases in the census acceptance run; the stack walk keeps 10/10.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(cli): composite stacked background-image layers when judging occluder opacity

Two 0.5-alpha gradient layers paint at 0.75 combined; taking the max
color-stop alpha across the whole declaration under-counted them and
suppressed real text_occluded findings. Split layers at top-level commas
(paren-aware), score each, composite as 1-prod(1-a_i). Also pins the
0.05 text-ink floor with a boundary test (review feedback on #2357).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(cli): keep walking the occlusion stack past pair-specific exemptions

sharedPreserve3d and isCrossSceneTransitionOverlap excuse one hit, not
the whole probe; returning null let a transparent decorative layer in
the text's 3D context mask a real occluder below it (review feedback).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-13 14:27:39 -07:00
Miguel Ángel 3df59fc0a4 fix(engine): support current FFmpeg filter scripts (#2324) 2026-07-13 16:52:15 -04:00