import { EventEmitter } from "node:events"; import type { ChildProcess } from "node:child_process"; import { afterEach, describe, expect, it, vi } from "vitest"; import { ManagedChildProcess } from "./managedChildProcess.js"; function childProcess() { const child = new EventEmitter() as EventEmitter & { stderr: EventEmitter; kill: ReturnType; }; child.stderr = new EventEmitter(); child.kill = vi.fn().mockReturnValue(true); return child as unknown as ChildProcess & { stderr: EventEmitter; kill: ReturnType; }; } describe("ManagedChildProcess", () => { afterEach(() => { vi.useRealTimers(); }); it("returns a typed natural exit and bounded stderr tail", async () => { const child = childProcess(); const managed = new ManagedChildProcess(child, { stderrMaxBytes: 5 }); child.stderr.emit("data", Buffer.from("123456789")); child.emit("close", 0, null); await expect(managed.wait()).resolves.toMatchObject({ reason: "exit", exitCode: 0, stderr: "56789", }); }); it("keeps no part of a signed URL's query when the tail cut lands inside it", async () => { const child = childProcess(); const managed = new ManagedChildProcess(child, { stderrMaxBytes: 40 }); child.stderr.emit( "data", Buffer.from("Error opening https://b.s3.amazonaws.com/v.mp4?X-Amz-Sig"), ); child.stderr.emit( "data", Buffer.from("nature=supersecret&X-Amz-Credential=AKIDEXAMPLE -t 0.5"), ); child.emit("close", 1, null); const { stderr } = await managed.wait(); expect(stderr).toBe(" -t 0.5"); for (const leaked of ["secret", "AKID"]) expect(stderr).not.toContain(leaked); }); it.each([ ["inside the signature value", 66, 64], ["right after the query mark", 48, 64], ["after a cut severed the URL's head", 66, 30], ])("keeps no part of a signature split across chunks %s", async (_where, at, maxBytes) => { const child = childProcess(); const managed = new ManagedChildProcess(child, { stderrMaxBytes: maxBytes }); const line = "Error opening https://b.s3.amazonaws.com/v.mp4?X-Amz-Signature=abcdef1234 -t 0.5\n"; child.stderr.emit("data", Buffer.from(line.slice(0, at))); child.stderr.emit("data", Buffer.from(line.slice(at))); child.emit("close", 1, null); const { stderr } = await managed.wait(); expect(stderr).toContain(" -t 0.5"); for (const leaked of ["abc", "def1234", "1234"]) expect(stderr).not.toContain(leaked); }); it("keeps no signature fragment when the kept tail itself starts inside one", async () => { const child = childProcess(); const managed = new ManagedChildProcess(child, { stderrMaxBytes: 16 }); const signature = `${"a".repeat(30)}0123456789`; child.stderr.emit( "data", Buffer.from(`x https://b.s3.amazonaws.com/v.mp4?X-Amz-Signature=${signature} -t 0.5\n`), ); child.emit("close", 1, null); const { stderr } = await managed.wait(); expect(stderr).toContain(" -t 0.5"); for (const leaked of ["aaa", "6789"]) expect(stderr).not.toContain(leaked); }); it("escalates abort from SIGTERM to SIGKILL and resolves only after close", async () => { vi.useFakeTimers(); const child = childProcess(); const controller = new AbortController(); const managed = new ManagedChildProcess(child, { signal: controller.signal, terminationGraceMs: 50, }); controller.abort(); expect(child.kill).toHaveBeenCalledWith("SIGTERM"); await vi.advanceTimersByTimeAsync(50); expect(child.kill).toHaveBeenCalledWith("SIGKILL"); let reaped = false; void managed.wait().then(() => { reaped = true; }); await Promise.resolve(); expect(reaped).toBe(false); child.emit("close", null, "SIGKILL"); await expect(managed.wait()).resolves.toMatchObject({ reason: "abort", signal: "SIGKILL" }); }); it("keeps escalation and reaping active after a post-spawn error", async () => { vi.useFakeTimers(); const child = childProcess(); const controller = new AbortController(); const managed = new ManagedChildProcess(child, { signal: controller.signal, terminationGraceMs: 50, }); child.emit("spawn"); controller.abort(); child.emit("error", new Error("kill EPERM")); let reaped = false; void managed.wait().then(() => { reaped = true; }); await Promise.resolve(); expect(reaped).toBe(false); await vi.advanceTimersByTimeAsync(50); expect(child.kill).toHaveBeenNthCalledWith(1, "SIGTERM"); expect(child.kill).toHaveBeenNthCalledWith(2, "SIGKILL"); child.emit("error", new Error("kill EPERM")); expect(reaped).toBe(false); child.emit("close", null, "SIGKILL"); await expect(managed.wait()).resolves.toMatchObject({ reason: "abort", signal: "SIGKILL" }); }); it("distinguishes deadline from inactivity and refreshes activity", async () => { vi.useFakeTimers(); const deadlineChild = childProcess(); const deadline = new ManagedChildProcess(deadlineChild, { deadlineAtMs: Date.now() + 100, terminationGraceMs: 1_000, }); await vi.advanceTimersByTimeAsync(100); expect(deadlineChild.kill).toHaveBeenCalledWith("SIGTERM"); deadlineChild.emit("close", null, "SIGTERM"); await expect(deadline.wait()).resolves.toMatchObject({ reason: "deadline" }); const inactiveChild = childProcess(); const inactive = new ManagedChildProcess(inactiveChild, { inactivityTimeoutMs: 100, terminationGraceMs: 1_000, }); await vi.advanceTimersByTimeAsync(75); inactive.markActivity(); await vi.advanceTimersByTimeAsync(75); expect(inactiveChild.kill).not.toHaveBeenCalled(); await vi.advanceTimersByTimeAsync(25); expect(inactiveChild.kill).toHaveBeenCalledWith("SIGTERM"); inactiveChild.emit("close", null, "SIGTERM"); await expect(inactive.wait()).resolves.toMatchObject({ reason: "inactivity" }); }); it("settles a spawn failure and removes cancellation listeners", async () => { const child = childProcess(); const controller = new AbortController(); const managed = new ManagedChildProcess(child, { signal: controller.signal }); child.emit("error", new Error("spawn ENOENT")); controller.abort(); await expect(managed.wait()).resolves.toMatchObject({ reason: "spawn_error", exitCode: null, stderr: "spawn ENOENT", }); expect(child.kill).not.toHaveBeenCalled(); }); });