mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-01 19:42:03 +00:00
Remaining review follow-ups:
- killProcessTree now escalates to SIGKILL after 500ms if SIGTERM
doesn't kill the process (same pattern as killTrackedProcesses).
Covers orphan cleanup and dev/local mode tree kill.
- Added unit tests for both new modules:
- processTracker.test.ts (6 tests): track/remove on exit/error,
kill running processes, SIGKILL escalation for SIGTERM-resistant
processes, idempotency.
- orphanCleanup.test.ts (5 tests): tree kill with children,
SIGKILL escalation, non-existent PID handling, orphan detection
returns 0 when clean.
56 lines
1.9 KiB
TypeScript
56 lines
1.9 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import { spawn } from "node:child_process";
|
|
import { killProcessTree, killOrphanedProcesses } from "./orphanCleanup.js";
|
|
|
|
const IS_UNIX = process.platform !== "win32";
|
|
|
|
describe.skipIf(!IS_UNIX)("killProcessTree", () => {
|
|
it("kills a process and all its children", async () => {
|
|
// Spawn a parent that spawns two sleeping children
|
|
const parent = spawn("bash", ["-c", "sleep 60 & sleep 60 & wait"], { stdio: "ignore" });
|
|
// Let children spawn
|
|
await new Promise((r) => setTimeout(r, 200));
|
|
|
|
const exitPromise = new Promise<void>((resolve) => parent.on("close", resolve));
|
|
killProcessTree(parent.pid!);
|
|
|
|
await exitPromise;
|
|
|
|
// Verify parent is dead
|
|
expect(() => process.kill(parent.pid!, 0)).toThrow();
|
|
}, 5000);
|
|
|
|
it("handles non-existent PID gracefully", () => {
|
|
// Should not throw for a PID that doesn't exist
|
|
killProcessTree(999999999);
|
|
});
|
|
|
|
it("escalates to SIGKILL after grace period", async () => {
|
|
// Spawn a process that traps SIGTERM
|
|
const proc = spawn("bash", ["-c", "trap '' TERM; sleep 60"], { stdio: "ignore" });
|
|
await new Promise((r) => setTimeout(r, 100));
|
|
|
|
const exitPromise = new Promise<void>((resolve) => proc.on("close", resolve));
|
|
killProcessTree(proc.pid!);
|
|
|
|
// Should die within 1s (500ms SIGKILL grace + buffer)
|
|
await exitPromise;
|
|
expect(() => process.kill(proc.pid!, 0)).toThrow();
|
|
}, 5000);
|
|
});
|
|
|
|
describe.skipIf(!IS_UNIX)("killOrphanedProcesses", () => {
|
|
it("returns 0 when no orphans exist", () => {
|
|
const killed = killOrphanedProcesses();
|
|
expect(killed).toBe(0);
|
|
});
|
|
|
|
it("does not kill non-orphaned Chrome processes", () => {
|
|
// Our current process is not an orphan (PPID !== 1), so any
|
|
// chrome-headless-shell processes we'd find with our PID as
|
|
// ancestor wouldn't be killed.
|
|
const killed = killOrphanedProcesses();
|
|
expect(killed).toBe(0);
|
|
});
|
|
});
|