mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-14 21:29:34 +00:00
Vance Ingalls
20be2ea1c2
## Summary - Run `oxfmt .` across the entire codebase to establish formatted baseline - 299 files changed — mechanical formatting only, no logic changes - Double quotes, semicolons, 2-space indent, trailing commas, 100 print width Part 3/4 of [VA-851](https://linear.app/heygen/issue/VA-851/pre-migration-configure-eslint-prettier-and-conventional-commits) ## Test plan - [x] `pnpm format:check` — all 426 files pass - [x] `pnpm -r typecheck` — all packages pass - [x] `pnpm build` — all packages build - [x] All 348 tests pass
2.3 KiB
2.3 KiB
HyperFrame Schema Compliance Review
Executive Summary
- Total files reviewed: 3
- Critical issues: 0
- Overall compliance status: PASS
Critical Issues
None. The composition follows the HyperFrame schema correctly.
Compliance Checklist
- All compositions have
data-widthanddata-heightattributes - All timelines are finite with duration > 0
- All compositions registered in
window.__timelines - No use of
Math.random(),Date.now(), or non-deterministic code - Primitive clips have required data attributes (
id,data-start,data-track-index) data-durationspecified for all<img>clips (N/A - no images)- No manual media playback control (
video.play(),audio.pause(), etc.) - No manual clip mounting/unmounting in scripts
- Relative timing references are valid (N/A - absolute timing used)
- Clips on same track don't overlap in time
- Reusable compositions in separate HTML files (N/A - single composition)
- Composition files use
<template>tags (N/A - root composition) - External compositions loaded via
data-composition-src(N/A) - All script-animated content wrapped in compositions
- No infinite or zero-duration timelines
index.html
Status: COMPLIANT
Issues Found:
- None. The root composition is correctly defined with
data-composition-id,data-width,data-height,data-start, anddata-track-index. - Audio clips are correctly defined with
id,data-start,data-duration, anddata-track-index. - Tracks are used correctly to avoid overlap for audio clips.
script.js
Status: COMPLIANT
Issues Found:
- Determinism: The script uses a deterministic approach for particle generation (lines 47, 51) instead of
Math.random(). This is excellent and follows the "CRITICAL: Deterministic Behavior Required" rule. - Timeline Registration: The timeline is correctly registered in
window.__timelines["magic-cut-intro"]. - Framework Alignment: The script focuses on visual animations (opacity, scale, particles) and does not attempt to control audio playback or clip lifecycle, which is correct.
style.css
Status: COMPLIANT
Issues Found:
- The dimensions match the requested Portrait (9:16) orientation (1080x1920).
- Layout is handled via CSS, which is the correct approach.