Files
hyperframes/scripts/catalog-payload-assets.test.ts
Miguel ÁngelandMiguel Angel Simon Sierra 1ae2067b8d feat(catalog): put the variables panel back, on payloads (#3199)
* feat(catalog): put the variables panel back, on payloads

The panel drove its preview by loading an .html from docs/public, a type the
host does not publish, so it showed an empty frame in production and was
parked when the catalog was re-landed.

It now mounts the same JSON payload the plain player uses and re-mounts it as
values change, injecting them as window.__hfVariables into the composition head
before any of its scripts run, which is where the runtime reads overrides from.
Doing it in the markup rather than after load is what stops the composition
initialising with the wrong values first.

172 items with variables get the panel back; the playhead carries across a
change so a tweak mid-shot does not jump back to frame zero.

* fix(docs): drop the unused url form and the needless escapes

* fix(docs): the panel cannot reference a binding beside the export

* feat(catalog): make importing an SVG the obvious move

A reader arrives at this control with a shape, not with path data, and the
panel asked for the coordinates first. Import is now the primary action in a
drop target you can see is a drop target, and the raw path sits behind a
disclosure for anyone who wants it.

* feat(cli): let a fruitless catalog search report the gap

An agent that searches by meaning and finds nothing worth installing knows
something we do not: the name of a move the catalog is missing. There was no
way to tell us, so that knowledge was lost at the end of every run.

hyperframes feedback --search-miss "<query>" --wanted "<the move>" records it.
It carries no rating, so it never lands in the rating metric, and it is a
separate deliberate command rather than something catalog --query does on its
own: plain search still sends nothing, which is what the CLI promises.

--rating stops being required at the arg level, since a miss has no rating to
give. The check moved into the run body, where an absent one is now handled
rather than crashing on undefined.

* feat(cli): carry tuned variable values into the install snippet

Someone who tunes a block on its catalog page had no way to keep those values:
the install command was the same one everybody gets, and the tuning stayed on
the page.

hyperframes add <item> --vars '<json>' now prints a mount element carrying
data-variable-values, so the values land where the block is used.

They ride on the host rather than being written into the installed file. That
keeps the composition on disk byte-identical to the registry's, so a later
reinstall can still tell an edit from an update, and it lets two mounts of the
same block carry different values.

* fix(catalog): serve the item's own directory so runtime paths resolve

Some compositions assemble their asset URLs at run time —
"compositions/components/" + texture + ".png" for the texture masks, a font the
compiler pulled into _remote_media — and no scan of the markup can see a string
that does not exist until a script concatenates it. Those items either rendered
black or were dropped to a video that had never been uploaded.

Each item that needs it now has its prepared directory published, and its
payload carries a <base> pointing at it, so any relative path the composition
invents resolves. caption-texture renders its masks again, and
variable-font-flex has a preview at all for the first time: its MP4 and poster
are both 403.

Both layouts are published, because which one a composition asks for differs
per item, and a directory only earns that if it is under 2 MB. The 12 MB
texture sheet keeps the recorded video it already had.

* fix(catalog): let the variables panel actually drive the composition

Every control on the panel was inert. The values reached the composition and
nothing repainted, because the payload had already been compiled: compiling
inlines a mounted component and resolves its variables into the markup and CSS,
so by the time a reader turns a knob there is nothing left to change.

An item that declares variables now ships uncompiled, keeping the mount the
runtime loads at run time, which is the only state where data-variable-values
still means anything. The component travels inline as a data URI rather than a
sibling file, because .html is the one type the docs host will not publish. The
demo's own pinned values come off, so the reader's choices reach the mount
instead of losing to the values the demo picked to show itself off.

Measured on the rendered frame rather than the DOM: green rgb(98,207,144),
blue rgb(6,6,199), violet rgb(177,147,230), and back to green.

docs/public/catalog drops from 48 MB to 35 MB along the way, since an
uncompiled payload carries far less than an inlined one.

* feat(catalog): keep variable changes in the url

A reader who tuned a piece lost it on reload, and had nothing to send anyone.
The values now live in the query string, scoped by composition id so two links
never read each other,and only the ones that differ from the defaults are
written, so changing one knob gives a short URL rather than every variable
spelled out.

replaceState rather than pushState: dragging a slider should not leave a trail
of history entries. An unreadable value is ignored rather than thrown, so a
truncated or hand-edited link opens the piece at its defaults.

* fix(catalog): only rewrite the url when a value actually changed

* refactor(catalog): memoise the declared defaults on their content

* feat(catalog): offer an install command carrying the tuned values

The Install block is generated before anyone touches a knob, so it can only
ever print the plain command. Someone who spent a minute tuning a piece copied
it and got the defaults back.

The panel now carries its own command in the Snippet tab, with --vars holding
exactly the values that differ. An untouched piece still offers the same short
command, so nothing gets noisier for the common case.

* fix(catalog): a piece with nothing to render is a skip, not a failure

caption-blend-difference is a stylesheet and a paragraph of prose — a class you
add to your own captions, with no standalone scene to show. The generator
treated that as a build failure, so every run ended by reporting something
broken when nothing was.

It now reports the shape it is and keeps its recorded video, which is the only
honest preview such an item has. A genuine render failure still throws.

* fix(catalog): restore variables from the url on a cold load

A shared link opened at the defaults. The first render happens on the server,
where there is no window to read the query string from, and React then hydrates
against that markup and never revisits it — so the values only appeared once you
touched a control.

The URL is read again after mount, which is the first moment it exists. The
value is also escaped once now rather than twice: URLSearchParams already
decodes on the way out, and decoding a second time turned an SVG path full of
percent-escapes into something that no longer parsed, besides doubling the
length of every link.

* fix(catalog): mount the preview with the values a link carried

The frame was built from the declared defaults and the shared values were
posted to it afterwards, which is too late for anything the composition reads
once at init: a path arrived after the mark had already been drawn from the
default one, so a link looked right in the panel and wrong on screen.

* feat(catalog): the install command follows the values you tuned

Copying the Install line gave the plain command back, because that block is
generated before anyone touches a knob and had no way to know what changed. The
tuned command only existed in the panel Snippet tab, which is not where anyone
looks for it.

The line now reads the same query string the panel writes, so the two agree
without either component knowing the other exists, and a shared link carries the
right command too. replaceState fires no event, so the panel announces its own
writes.

* fix(catalog): send a text variable to the preview once it is finished

Every other control in the explorer reports a whole value on every event: a
slider at any position is a position, a swatch is a colour. A text field is
not. Typing v3 into a badge posted v first, so the preview remounted and
rendered a composition built from half a word.

The post now waits while a text field has focus and goes out when the edit is
committed, with Enter or by clicking away. The field itself is unchanged and
still tracks every keystroke.

---------

Co-authored-by: Miguel Angel Simon Sierra <miguelangelsi07@gmail.com>
2026-08-10 22:40:01 -04:00

292 lines
11 KiB
TypeScript

import assert from "node:assert/strict";
import { existsSync, mkdirSync, mkdtempSync, readdirSync, writeFileSync } from "node:fs";
import { tmpdir } from "node:os";
import { join } from "node:path";
import { describe, it } from "node:test";
import {
externalizeDataUris,
hostItemDirectory,
localReferences,
probableReferences,
processAssets,
withBaseHref,
} from "./catalog-payload-assets.ts";
function project(files: Record<string, string | Buffer>): string {
const dir = mkdtempSync(join(tmpdir(), "hf-payload-assets-"));
for (const [name, contents] of Object.entries(files)) {
const path = join(dir, name);
mkdirSync(join(path, ".."), { recursive: true });
writeFileSync(path, contents);
}
return dir;
}
function target() {
return { dir: mkdtempSync(join(tmpdir(), "hf-payload-out-")), urlBase: "/public/catalog/assets" };
}
describe("localReferences", () => {
it("finds files referenced by attribute and by CSS url()", () => {
const html = `<img src="assets/logo.png"><style>@font-face{src:url('fonts/inter.woff2')}</style>`;
assert.deepEqual(localReferences(html).sort(), ["assets/logo.png", "fonts/inter.woff2"]);
});
it("ignores a shader source assigned to a variable ending in src", () => {
// The whole reason the pattern demands a non-identifier character first.
const html = `<script>var vertSrc = "attribute vec2 a_pos; void main(){}";</script>`;
assert.deepEqual(localReferences(html), []);
});
it("ignores in-document fragment references, encoded or not", () => {
const html = `<rect filter="url(#noise)"></rect><rect filter="url(%23grain)"></rect>`;
assert.deepEqual(localReferences(html), []);
});
it("ignores anything already addressable by the browser", () => {
const html = `<img src="https://cdn.example.com/a.png"><img src="data:image/png;base64,AA">`;
assert.deepEqual(localReferences(html), []);
});
it("ignores a path assigned to an identifier, which is code and not markup", () => {
// `configSrc` names a file the composition fetches at runtime and parses.
// Rewriting it would corrupt the script, so the leading non-identifier
// character in the pattern is what keeps this out.
const html = `<script>var configSrc = "config.json";</script>`;
assert.deepEqual(localReferences(html), []);
});
it("still finds a property assignment, where the dot is not an identifier char", () => {
const html = `<script>img.src = "assets/hero.png";</script>`;
assert.deepEqual(localReferences(html), ["assets/hero.png"]);
});
it("ignores references with no known extension", () => {
const html = `<a href="/docs/guide">guide</a><div style="background:url(gradient)"></div>`;
assert.deepEqual(localReferences(html), []);
});
});
describe("processAssets", () => {
it("writes a publishable asset once and links to it", () => {
const dir = project({ "assets/logo.png": Buffer.from([0x89, 0x50]) });
const out = target();
const result = processAssets(`<img src="assets/logo.png">`, dir, out);
assert.equal(result.hosted, 1);
assert.equal(result.inlined, 0);
assert.deepEqual(result.unresolved, []);
assert.match(result.html, /^<img src="\/public\/catalog\/assets\/[0-9a-f]{16}\.png">$/);
assert.equal(readdirSync(out.dir).length, 1);
});
it("stores one copy when two items share a byte-identical font", () => {
// The reason for content addressing: the catalog's fonts were being
// base64'd into a hundred payloads apiece.
const font = Buffer.from("a-font-file");
const one = project({ "a.woff2": font });
const two = project({ "nested/b.woff2": font });
const out = target();
const first = processAssets(`<style>@font-face{src:url(a.woff2)}</style>`, one, out);
const second = processAssets(`<style>@font-face{src:url(nested/b.woff2)}</style>`, two, out);
assert.equal(readdirSync(out.dir).length, 1);
const url = /\/public\/catalog\/assets\/[0-9a-f]{16}\.woff2/;
assert.equal(first.html.match(url)?.[0], second.html.match(url)?.[0]);
});
it("inlines a type the host will not publish", () => {
// `.glb` returns 404 from the docs host, so a link would break the preview.
const dir = project({ "scene.glb": Buffer.from([0x67, 0x6c]) });
const out = target();
const result = processAssets(`<model-viewer src="scene.glb">`, dir, out);
assert.equal(result.inlined, 1);
assert.equal(result.hosted, 0);
assert.match(result.html, /data:model\/gltf-binary;base64,/);
assert.ok(!existsSync(join(out.dir, "scene.glb")));
});
it("gives the same output twice, so regeneration writes no new bytes", () => {
const dir = project({ "a.png": Buffer.from([0x01]) });
const first = processAssets(`<img src="a.png">`, dir, target());
const second = processAssets(`<img src="a.png">`, dir, target());
assert.equal(first.html, second.html);
});
it("replaces every occurrence of the same reference", () => {
const dir = project({ "a.png": Buffer.from([0x01]) });
const result = processAssets(`<img src="a.png"><img src="a.png">`, dir, target());
assert.equal(result.html.match(/\/public\/catalog\/assets\//g)?.length, 2);
});
it("reports a reference whose file is missing rather than dropping it", () => {
// A runtime-built path such as `masks/${slug}.png` lands here, and the item
// has to keep its video instead of shipping a preview with holes in it.
const result = processAssets(`<img src="masks/gone.png">`, project({}), target());
assert.deepEqual(result.unresolved, ["masks/gone.png"]);
});
it("refuses a reference that climbs out of the project directory", () => {
const dir = project({ "keep.png": Buffer.from([0x01]) });
const result = processAssets(`<img src="../../etc/passwd.png">`, dir, target());
assert.deepEqual(result.unresolved, ["../../etc/passwd.png"]);
assert.equal(result.hosted, 0);
});
it("leaves a composition with no local references untouched", () => {
const html = `<div data-composition-id="x"></div>`;
const result = processAssets(html, project({}), target());
assert.deepEqual(result, { html, hosted: 0, inlined: 0, unresolved: [] });
});
});
describe("externalizeDataUris", () => {
const font = (n: number) => Buffer.alloc(n, 7).toString("base64");
it("pulls an embedded font out into a shared file", () => {
// Compositions arrive with fonts already embedded, which is where the bulk
// of the catalog's payload weight came from.
const out = target();
const result = externalizeDataUris(
`<style>@font-face{src:url(data:font/woff2;base64,${font(8000)})}</style>`,
out,
);
assert.equal(result.externalized, 1);
assert.match(result.html, /url\(\/public\/catalog\/assets\/[0-9a-f]{16}\.woff2\)/);
assert.equal(readdirSync(out.dir).length, 1);
});
it("stores one copy when two payloads embed the same font", () => {
const out = target();
const blob = font(8000);
externalizeDataUris(`<style>src:url(data:font/woff2;base64,${blob})</style>`, out);
externalizeDataUris(
`<b>other item</b><style>src:url(data:font/woff2;base64,${blob})</style>`,
out,
);
assert.equal(readdirSync(out.dir).length, 1);
});
it("leaves a small blob alone, where a request costs more than the bytes", () => {
const out = target();
const result = externalizeDataUris(`<img src="data:image/png;base64,${font(64)}">`, out);
assert.equal(result.externalized, 0);
assert.ok(!existsSync(out.dir) || readdirSync(out.dir).length === 0);
});
it("leaves a type the host will not publish embedded", () => {
const out = target();
const result = externalizeDataUris(
`<a href="data:model/gltf-binary;base64,${font(8000)}">`,
out,
);
assert.equal(result.externalized, 0);
assert.match(result.html, /data:model\/gltf-binary/);
});
});
describe("probableReferences", () => {
it("finds a model a script loads by name", () => {
// `loader.load("models/iphone.glb")` is how the 3D blocks fetch their
// model, and no attribute or url() pattern can see it.
const html = `<script>loader.load("models/iphone.glb", cb);</script>`;
assert.deepEqual(probableReferences(html), ["models/iphone.glb"]);
});
it("does not repeat a reference an attribute already covers", () => {
const html = `<img src="a.png"><script>preload("a.png")</script>`;
assert.deepEqual(probableReferences(html), []);
});
});
describe("processAssets with script-loaded files", () => {
it("inlines a model loaded by name, since the host will not publish glb", () => {
const dir = project({ "models/iphone.glb": Buffer.alloc(64, 3) });
const result = processAssets(
`<script>loader.load("models/iphone.glb")</script>`,
dir,
target(),
);
assert.equal(result.inlined, 1);
assert.match(result.html, /data:model\/gltf-binary;base64,/);
assert.deepEqual(result.unresolved, []);
});
it("ignores a name that is not a file, rather than failing the item", () => {
// An ordinary string that happens to look like a filename must not push an
// item onto the video fallback.
const result = processAssets(
`<script>track("checkout.step.png")</script>`,
project({}),
target(),
);
assert.deepEqual(result.unresolved, []);
assert.equal(result.hosted + result.inlined, 0);
});
it("still fails an item whose markup points at a missing file", () => {
const result = processAssets(`<img src="gone.png">`, project({}), target());
assert.deepEqual(result.unresolved, ["gone.png"]);
});
});
describe("hostItemDirectory", () => {
it("publishes the item's files at the paths it will ask for", () => {
// The texture blocks build `compositions/components/<name>.png` at run
// time, so the layout has to survive, not just the files.
const dir = project({ "compositions/components/lava.png": Buffer.from([1]), "demo.html": "x" });
const out = target();
const base = hostItemDirectory(dir, out.dir, "/public/catalog/items/x/");
assert.equal(base, "/public/catalog/items/x/");
assert.ok(existsSync(join(out.dir, "compositions/components/lava.png")));
});
it("mirrors _downloads to the root, where the compiler's references point", () => {
const dir = project({ "_downloads/_remote_media/f.woff2": Buffer.from([2]) });
const out = target();
hostItemDirectory(dir, out.dir, "/base/");
assert.ok(existsSync(join(out.dir, "_remote_media/f.woff2")));
});
it("skips a type the host will not publish", () => {
const dir = project({ "scene.glb": Buffer.from([3]) });
const out = target();
assert.equal(hostItemDirectory(dir, out.dir, "/base/"), "");
});
});
describe("withBaseHref", () => {
it("puts the base first in the head, ahead of anything that resolves a URL", () => {
const html = withBaseHref("<html><head><link href='a.css'></head><body></body></html>", "/b/");
assert.ok(html.indexOf('<base href="/b/">') < html.indexOf("<link"));
});
it("gives a headless document a head to put it in", () => {
assert.ok(
withBaseHref("<html><body>x</body></html>", "/b/").includes('<head><base href="/b/"></head>'),
);
});
it("changes nothing when there is nothing to serve", () => {
const html = "<html><head></head></html>";
assert.equal(withBaseHref(html, ""), html);
});
});