Files
hyperframes/packages/parsers/src/htmlAttributeSpans.ts
Miguel Ángel 621ddd4693 fix(studio): stop file names with %, apostrophes or $ from breaking Studio (#5156)
* fix(studio): serve files whose name has a bare percent sign

A browser sends src="100%.png" with the % unescaped, and decoding the whole path threw, so Studio answered 500. Only well-formed escapes are decoded now.

* fix(cli): serve files with a bare percent sign from the check and snapshot server

One shared decode rule for request paths; the image thumbnail route's malformed-escape 400 could no longer fire, so a name that is not a file is a 404.

* fix(cli): name a failed file with a bare percent sign in check

* fix(studio): keep apostrophes and dollar signs in file names when editing attributes

An attribute value is matched by its own quote kind, so src="it's.png" is replaced instead of duplicated, and every insert uses a function replacer, so $1 or $& in a file name is written as is.

* fix(studio): rename references spelled with %20 or & and read quoted media sources

WIP: not yet tested; see the resume note.

* fix(studio): match whole attribute names when editing media sources

* fix(studio): compare decoded names and escape replacement references

* fix(studio): preserve file references across URL and string consumers

* docs: clarify raw file references and URL fields

* fix(studio): keep raw path identity distinct from URL spelling

* fix: share attribute grammar and decode media URLs at their readers

* fix: preserve local filename identity in HTML URL output

* fix: decode entity references before rename candidate matching

* style: format rename entity handling and regressions

* fix: preserve platform file identity when renaming references

* fix(core): decode CSS escapes before rebasing asset URLs

* fix(core): consume CSS continuations before URL encoding

* fix(core): preserve CSS URL identity and escape rebased suffixes

* fix(core): express CSS suffix controls with Unicode categories

* fix(core): preserve URL backslash identity while rebasing

* test(core): respect platform backslash filename semantics

* fix(studio): a dropped file with %, # or ? in its name loads, and an encoded reference renames

* fix(studio): read an authored src as a URL so dropped files with spaces, %, # or ? load

* fix(studio): media routes find files named with ? or #, and the probe reads a src as a URL

* fix(studio-server): one rule for request file paths, so loudness finds files named with %, # or ?

* chore: drop the design note from the change

* fix(core): rename replaced clips whose src is URL-encoded
2026-10-08 16:37:49 +00:00

120 lines
3.4 KiB
TypeScript

import { decodeHTMLAttribute } from "entities/decode";
export type HtmlAttributeSpan = {
name: string;
start: number;
end: number;
} & (
| { kind: "boolean" }
| { kind: "value"; value: string; valueStart: number; valueEnd: number; quote: string }
);
export interface HtmlOpeningTagSpan {
name: string;
start: number;
end: number;
bodyEnd: number;
closed: boolean;
rawTextEnd: number | null;
attributes: HtmlAttributeSpan[];
}
function readAttributeValue(html: string, at: number) {
while (/[\t\n\f\r ]/.test(html.charAt(at))) at++;
const quote = ['"', "'"].includes(html.charAt(at)) ? html.charAt(at) : "";
if (quote) at++;
const valueStart = at;
if (quote) {
const closing = html.indexOf(quote, at);
at = closing === -1 ? html.length : closing;
} else {
while (at < html.length && !/[\t\n\f\r >]/.test(html[at]!)) at++;
}
const valueEnd = at;
const end = quote ? Math.min(valueEnd + 1, html.length) : valueEnd;
return { value: html.slice(valueStart, valueEnd), valueStart, valueEnd, quote, end };
}
function readAttribute(html: string, start: number): HtmlAttributeSpan | null {
let at = start;
while (at < html.length && !/[\t\n\f\r =/>]/.test(html[at]!)) at++;
if (at === start) return null;
const name = html.slice(start, at).toLowerCase();
const nameEnd = at;
while (/[\t\n\f\r ]/.test(html[at] ?? "")) at++;
if (html[at] !== "=") return { kind: "boolean", name, start, end: nameEnd };
return { kind: "value", name, start, ...readAttributeValue(html, at + 1) };
}
function readOpeningTag(html: string, start: number, name: string, at: number): HtmlOpeningTagSpan {
const attributes: HtmlAttributeSpan[] = [];
while (at < html.length) {
while (/[\t\n\f\r /]/.test(html[at] ?? "")) at++;
if (at >= html.length || html[at] === ">") break;
const attribute = readAttribute(html, at);
if (attribute === null) {
at++;
continue;
}
attributes.push(attribute);
at = attribute.end;
}
const closed = html[at] === ">";
return {
name: name.toLowerCase(),
start,
bodyEnd: at,
end: closed ? at + 1 : at,
closed,
rawTextEnd: null,
attributes,
};
}
export function scanHtmlOpeningTags(html: string): HtmlOpeningTagSpan[] {
const tags: HtmlOpeningTagSpan[] = [];
const opening = /<!--[\s\S]*?(?:--!?>|$)|<([a-z][^\t\n\f\r />]*)/gi;
let match: RegExpExecArray | null;
while ((match = opening.exec(html)) !== null) {
if (!match[1]) continue;
const tag = readOpeningTag(html, match.index, match[1], opening.lastIndex);
tags.push(tag);
opening.lastIndex = tag.end;
if (
[
"script",
"style",
"textarea",
"title",
"xmp",
"iframe",
"noembed",
"noframes",
"plaintext",
].includes(tag.name)
) {
if (tag.name === "plaintext") {
tag.rawTextEnd = html.length;
break;
}
const closing = new RegExp(`</${tag.name}(?=[\\t\\n\\f\\r />])`, "gi");
closing.lastIndex = tag.end;
const end = closing.exec(html);
tag.rawTextEnd = end?.index ?? html.length;
opening.lastIndex = tag.rawTextEnd;
}
}
return tags;
}
export const HTML_ATTRIBUTE_ENTITIES: Record<string, readonly string[]> = {
"&": ["&amp;"],
'"': ["&quot;"],
"'": ["&#39;", "&apos;"],
"<": ["&lt;"],
">": ["&gt;"],
};
export function decodeAuthoredAttribute(value: string): string {
return decodeHTMLAttribute(value);
}