mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-01 19:42:03 +00:00
## What Part 2 of the GSAP seek-safety rules (stacks on #2611): the two rules that touch existing catalog content and required reconciliation with an existing rule. - `gsap_relative_value_second_writer` (error) — a relative var value (`y: "-=15"`) on a property whose target has another writer **active at the relative tween's start**. The relative base is captured at tween init, which reads a different partial state per seek path: sequential seek inits it mid-entrance, a cold render worker inits it at the entrance's end state, and the element teleports at chunk boundaries (production case: all scene nodes jumping ~20px mid-scene). Writers that complete strictly before the start are safe (children render in start-time order within a seek pass — verified against gsap 3.15.0) and are not flagged; neither are single-writer relatives, `from()`/`fromTo()`, build-time `gsap.set`, or relative position parameters (`"+=0.5"`). Selector resolution bails on combinators and cross-composition scoping rather than guessing. Findings aggregate per tween pair and report the overlap window. - `gsap_timeline_set_initial_hide` (warning) — initial-state hiding via `tl.set(target, vars, 0)` on a paused timeline is not rendered while the playhead sits at exactly 0, so frame 0 shows the unhidden state (verified against gsap 3.15.0: opacity stays 1 after `tl.time(0)`, applies only past 0). Exempt when the target is already hidden by authored CSS/inline styles or a standalone `gsap.set()`, and only sets preceding every tween in source order qualify (mutated position variables resolve to their initial binding in the parser — outro hard-kills don't masquerade as position-0 sets). - Reconciliation: `gsap_fullscreen_overlay_starts_visible`'s fixHint previously recommended exactly the flagged `tl.set(sel, {opacity:0}, 0)` pattern; it now recommends authored CSS hiding or immediate `gsap.set()`. - Docs for the full rule family in `docs/packages/lint.mdx`. ## Corpus impact (the reason this is its own PR) These two rules are the ones that fire on repo-shipped content: - `gsap_relative_value_second_writer`: 4 errors in `gooey-metaball`, all genuine overlaps. Measured with gsap 3.15.0: ballD diverges **3.31 xPercent / 1.99 yPercent (~8px/5px at 240px ball size)** between sequential and cold seek — a permanent base offset that appears as a teleport at a chunk boundary. Real but modest; happy to fix the block in a follow-up (start the drift at the entrance's end, or use absolute `fromTo`). - `gsap_timeline_set_initial_hide`: 10 warnings across the catalog after the CSS-hidden exemption (down from 54 pre-narrowing); spot-checked as genuine frame-0 pops with no authored hide (e.g. `vfx-text-cursor` `#phrase-b`). Adversarially reviewed the same way as #2611 (393-composition corpus + gsap semantics experiments); FP classes fixed and locked as negative tests: precede-only second writers, descendant/cross-composition selector mis-joins, CSS-hidden re-assertions, mutated position variables. ## Tests Full `packages/lint` suite green at 440 tests including multi-composition roots; `tsc`, oxlint, fallow audit clean.
145 lines
5.9 KiB
Plaintext
145 lines
5.9 KiB
Plaintext
---
|
|
title: "@hyperframes/lint"
|
|
description: "The composition linter as a standalone library — lint a directory or a single HTML file without the CLI."
|
|
---
|
|
|
|
The lint package is the composition linter extracted from core into a dedicated, independently-installable package. It's the **single source of truth** for linting: both the CLI's `hyperframes lint` command and the render-time render-gate consume the same rule engine from here.
|
|
|
|
```bash
|
|
npm install @hyperframes/lint
|
|
```
|
|
|
|
## When to Use
|
|
|
|
<Tip>
|
|
This package is the payoff of running validation **as a library** instead of shelling out to the CLI. A Node app (an agent harness, a CI step, an editor plugin) can `import { lintProject } from '@hyperframes/lint'` and lint a composition directory directly — no `npx hyperframes lint` subprocess, no stdout parsing.
|
|
</Tip>
|
|
|
|
**Use `@hyperframes/lint` when you need to:**
|
|
- Lint a composition project (an index + sub-compositions) from Node
|
|
- Lint a single HTML string programmatically
|
|
- Gate a render on lint findings (`shouldBlockRender`)
|
|
- Surface lint findings in your own UI or CI annotations
|
|
|
|
<Info>
|
|
`@hyperframes/core/lint` still resolves (via a back-compat re-export stub), so existing imports keep working. New code should import from `@hyperframes/lint` directly.
|
|
</Info>
|
|
|
|
## Package Exports
|
|
|
|
The lint package has a single entry point:
|
|
|
|
```typescript
|
|
import {
|
|
lintHyperframeHtml,
|
|
lintMediaUrls,
|
|
lintProject,
|
|
shouldBlockRender,
|
|
} from '@hyperframes/lint';
|
|
import type {
|
|
HyperframeLintResult,
|
|
HyperframeLintFinding,
|
|
HyperframeLintSeverity, // "error" | "warning" | "info"
|
|
HyperframeLinterOptions,
|
|
ProjectLintResult,
|
|
} from '@hyperframes/lint';
|
|
```
|
|
|
|
## Linting a Single Composition
|
|
|
|
```typescript
|
|
import { lintHyperframeHtml, lintMediaUrls } from '@hyperframes/lint';
|
|
|
|
const result = lintHyperframeHtml(html, { filePath: 'index.html' });
|
|
// result.ok, result.errorCount, result.warningCount, result.findings
|
|
|
|
for (const finding of result.findings) {
|
|
console.log(finding.severity, finding.code, finding.message);
|
|
// finding.file, finding.selector, finding.elementId, finding.fixHint, finding.snippet
|
|
}
|
|
|
|
// Additional media URL validation
|
|
const mediaFindings = lintMediaUrls(result.findings);
|
|
```
|
|
|
|
## Linting a Project
|
|
|
|
`lintProject` walks a composition directory — the index plus any sub-compositions — and returns aggregated findings. It takes a **directory path string**, so it's callable from any Node context with nothing but a path:
|
|
|
|
```typescript
|
|
import { lintProject, shouldBlockRender } from '@hyperframes/lint';
|
|
import type { ProjectLintResult } from '@hyperframes/lint';
|
|
|
|
const result: ProjectLintResult = await lintProject('./my-composition');
|
|
// result.totalErrors, result.totalWarnings, result.results[]
|
|
// each result entry: { file, result: HyperframeLintResult }
|
|
|
|
if (shouldBlockRender(false, false, result.totalErrors, result.totalWarnings)) {
|
|
throw new Error(`Lint found ${result.totalErrors} blocking error(s)`);
|
|
}
|
|
```
|
|
|
|
## Browser usage
|
|
|
|
The rule engine runs **fully client-side** — no Node.js, no filesystem, no server round-trip. Import from the `@hyperframes/lint/browser` entry to validate composition HTML directly in a browser-only editor or tool:
|
|
|
|
```typescript
|
|
import { lintHyperframeHtml, shouldBlockRender } from '@hyperframes/lint/browser';
|
|
|
|
const result = await lintHyperframeHtml(htmlString, { filePath: 'index.html' });
|
|
if (!result.ok) {
|
|
for (const f of result.findings) console.warn(f.code, f.message);
|
|
}
|
|
```
|
|
|
|
The browser entry exposes `lintHyperframeHtml`, `lintMediaUrls`, and `shouldBlockRender` — everything that operates on an HTML string. It is built with a browser target and contains **zero `node:` builtins**, so it bundles cleanly for the client (verified at build time).
|
|
|
|
<Info>
|
|
`lintProject` (which walks a project **directory**) is filesystem-based and is **not** part of the browser entry — import it from the main `@hyperframes/lint` entry in Node.
|
|
</Info>
|
|
|
|
## What the Linter Catches
|
|
|
|
Detected issues include:
|
|
|
|
- Missing timeline registration (`window.__timelines`)
|
|
- Unmuted video elements (causes autoplay failures)
|
|
- Missing `class="clip"` on timed visible elements
|
|
- Deprecated attribute names
|
|
- Missing composition dimensions (`data-width`, `data-height`)
|
|
- Invalid `data-start` references to nonexistent clip IDs
|
|
- Seek-order hazards that render differently on cold render workers: relative tween
|
|
values (`"+=..."`) whose property has a second concurrent writer
|
|
(`gsap_relative_value_second_writer`), `repeatRefresh` combined with relative values
|
|
(`gsap_repeat_refresh_relative_value`), function-valued tween vars that measure the
|
|
DOM or misuse the index parameter (`gsap_function_value_hazard`), DOM measurement
|
|
reachable from timeline callbacks (`gsap_callback_dom_measurement`), and
|
|
non-deterministic values like `gsap.utils.random()` / `"random(...)"`
|
|
(`non_deterministic_code`)
|
|
- SVG draw-on pitfalls: GSAP `strokeDasharray` writes on elements whose CSS declares a
|
|
multi-component `stroke-dasharray` (`svg_drawon_css_dasharray_conflict`),
|
|
`getTotalLength()` on paths with no `d` yet (`svg_measure_before_path_d`), and
|
|
initial-state hides via `tl.set(..., 0)` that never render on frame 0
|
|
(`gsap_timeline_set_initial_hide`)
|
|
|
|
<Info>
|
|
For a full list of what the linter catches and how to fix each issue, see [Common Mistakes](/guides/common-mistakes) and [Troubleshooting](/guides/troubleshooting).
|
|
</Info>
|
|
|
|
## Related Packages
|
|
|
|
<CardGroup cols={2}>
|
|
<Card title="@hyperframes/parsers" icon="code" href="/packages/parsers">
|
|
The HTML + GSAP parsing layer the linter builds on.
|
|
</Card>
|
|
<Card title="@hyperframes/core" icon="cube" href="/packages/core">
|
|
Types and runtime; re-exports the linter for back-compat.
|
|
</Card>
|
|
<Card title="CLI" icon="terminal" href="/packages/cli">
|
|
`npx hyperframes lint` wraps this package.
|
|
</Card>
|
|
<Card title="Studio" icon="palette" href="/packages/studio">
|
|
Surfaces lint findings in the editor.
|
|
</Card>
|
|
</CardGroup>
|