Files
JamesandClaude Opus 4.7 0f624f59fe fix(aws-lambda): surface sparticuz wedge as typed non-retryable error
Repeated Sandbox.Timedout chunks can leave @sparticuz/chromium
returning a falsy/empty path on subsequent invocations — warm
instances on the same execution environment never re-extract
chromium. The downstream puppeteer-core assertion about needing an
executablePath or channel buries the actionable cause; a cost-
analysis sweep took ~30 min to root-cause from that trace.

Guard the resolver: if mod.executablePath() returns a non-string,
empty string, or a path that does not exist on disk, throw a typed
ChromeBinaryUnavailableError whose message points at the recycle
remedy (env-var bump or redeploy). Add the error name to the three
NON_RETRYABLE lists so SFN short-circuits instead of burning four
15-min retries on a function that won't recover.

Same typed-error contract for the chrome-headless-shell fallback so
both sources fail consistently. Tests pin the wedge path (empty
string + non-existent file) and the carried metadata (source +
resolvedPath).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-22 16:52:41 -04:00

171 lines
7.0 KiB
TypeScript

/**
* Lambda-runtime Chrome resolver.
*
* `renderChunk()` (the only primitive that needs a browser) launches Chrome
* via the engine's `BrowserManager`. In Lambda we can't ship the full
* Puppeteer-managed Chrome download — Puppeteer's Chrome binary is ~330 MB
* unzipped, well over Lambda's 250 MB ZIP-deploy ceiling.
*
* Two valid runtime sources:
*
* 1. `@sparticuz/chromium` (primary). Decompresses a Lambda-optimised
* `chrome-headless-shell` build into `/tmp` at runtime. ~70 MB
* compressed; the same binary the rest of the ecosystem uses for
* headless-Chrome-in-Lambda. CDP-level BeginFrame works because the
* command lives in the protocol, not the binary; the
* `scripts/probe-beginframe.ts` regression guard pins this.
*
* 2. A bundled `chrome-headless-shell` binary (fallback). If
* `@sparticuz/chromium`'s build ever drops `HeadlessExperimental`
* support, we fall back to the same `chrome-headless-shell` build
* the K8s deploy uses. The fallback raises the ZIP from ~70 MB
* Chrome to ~140 MB Chrome — still well under 250 MB.
*
* The runtime path is selected by the `HYPERFRAMES_LAMBDA_CHROME_SOURCE`
* env var (set by `build-zip.ts`):
*
* "sparticuz" → use `@sparticuz/chromium.executablePath()`
* "chrome-headless-shell" → use `process.env.HYPERFRAMES_LAMBDA_CHROME_PATH`
*
* Adapters that bundle this package can override
* `HYPERFRAMES_LAMBDA_CHROME_PATH` directly when running outside Lambda
* (e.g. the SAM-local RIE smoke).
*/
import { existsSync } from "node:fs";
/** Discriminator for the two supported Chrome sources. */
export type ChromeSource = "sparticuz" | "chrome-headless-shell";
/**
* Thrown when the Chrome binary resolver can't produce a usable path.
* The class name is the SFN `Retry: { ErrorEquals: [...] }` discriminator —
* see {@link HyperframesRenderStack}'s NON_RETRYABLE_* lists.
*/
export class ChromeBinaryUnavailableError extends Error {
// Lambda's runtime serializes the error envelope's `errorType` from
// `err.name`; this class-field override sets it across the structured
// clone. Read indirectly; fallow can't follow.
// fallow-ignore-next-line unused-class-member
override readonly name = "ChromeBinaryUnavailableError";
readonly source: ChromeSource;
readonly resolvedPath: string | null;
constructor(source: ChromeSource, resolvedPath: string | null, hint: string) {
super(`[chromium] Chrome binary unavailable (source=${source}): ${hint}`);
this.source = source;
this.resolvedPath = resolvedPath;
}
}
const SPARTICUZ_WEDGE_HINT =
"@sparticuz/chromium.executablePath() returned a falsy value or a path that doesn't exist on disk. " +
"This typically happens after a chunk hits `Sandbox.Timedout` mid-extraction and leaves /tmp in a " +
"wedged state — subsequent invocations land on the same warm instance and never re-extract. " +
"Recycle the function (e.g. `aws lambda update-function-configuration ... --environment ...` with a " +
"bumped marker var, or redeploy via `hyperframes lambda deploy --skip-build`) to force fresh " +
"execution environments. Tracking: investigate the upstream wedge so this auto-recovers.";
/**
* Read which Chrome source the bundled ZIP was built against. Defaults to
* `"sparticuz"` so a fresh build with no env override picks the primary
* path.
*/
export function resolveChromeSource(): ChromeSource {
const raw = process.env.HYPERFRAMES_LAMBDA_CHROME_SOURCE?.toLowerCase();
if (raw === "chrome-headless-shell" || raw === "shell") return "chrome-headless-shell";
return "sparticuz";
}
/**
* Resolve the absolute path to a Chrome binary suitable for BeginFrame.
*
* For `"sparticuz"`: dynamically import `@sparticuz/chromium` and call
* `chromium.executablePath()`. The module is dynamic so a build-zip that
* never reaches the import (because the fallback Chrome is bundled) can
* tree-shake it out.
*
* For `"chrome-headless-shell"`: read the path from
* `HYPERFRAMES_LAMBDA_CHROME_PATH`. Throws if absent or non-existent so a
* misconfigured deploy fails loudly at boot rather than at first frame.
*/
// fallow-ignore-next-line complexity
export async function resolveChromeExecutablePath(): Promise<string> {
const source = resolveChromeSource();
if (source === "sparticuz") {
const mod = await loadSparticuzChromium();
const path = await mod.executablePath();
// Guard against the wedge described in ChromeBinaryUnavailableError.
// sparticuz's contract is "return the path to a usable binary" — when
// it returns null/undefined/"" we can't hand that to puppeteer-core
// (which will throw an unrelated-looking assertion). Same when the
// returned path doesn't exist (extraction failed but the function
// call returned).
if (!path || typeof path !== "string") {
throw new ChromeBinaryUnavailableError(source, null, SPARTICUZ_WEDGE_HINT);
}
if (!existsSync(path)) {
throw new ChromeBinaryUnavailableError(source, path, SPARTICUZ_WEDGE_HINT);
}
return path;
}
const explicit = process.env.HYPERFRAMES_LAMBDA_CHROME_PATH;
if (!explicit) {
throw new ChromeBinaryUnavailableError(
source,
null,
"HYPERFRAMES_LAMBDA_CHROME_SOURCE=chrome-headless-shell requires " +
"HYPERFRAMES_LAMBDA_CHROME_PATH to be set to the absolute path of the bundled binary.",
);
}
if (!existsSync(explicit)) {
throw new ChromeBinaryUnavailableError(
source,
explicit,
`HYPERFRAMES_LAMBDA_CHROME_PATH=${JSON.stringify(explicit)} does not exist on disk.`,
);
}
return explicit;
}
/**
* Resolve the Chromium launch args for the selected source. For
* `@sparticuz/chromium` we forward `chromium.args` (Lambda-tuned defaults
* — single-process, no-sandbox, /tmp paths). For the shell fallback the
* engine's own arg builder owns it; we return an empty array so the
* engine's defaults apply.
*/
export async function resolveChromeArgs(): Promise<string[]> {
if (resolveChromeSource() !== "sparticuz") return [];
const mod = await loadSparticuzChromium();
return mod.args;
}
/**
* Dynamic import wrapper isolated so unit tests can stub the module without
* jest-style module mocking gymnastics. The narrow type here pins the
* subset of `@sparticuz/chromium`'s surface this package depends on; if
* the upstream module ever changes shape the type error here surfaces
* before runtime.
*/
interface SparticuzChromiumModule {
args: string[];
executablePath(): Promise<string>;
}
let cachedSparticuz: SparticuzChromiumModule | null = null;
async function loadSparticuzChromium(): Promise<SparticuzChromiumModule> {
if (cachedSparticuz) return cachedSparticuz;
const mod = (await import("@sparticuz/chromium")) as
| SparticuzChromiumModule
| { default: SparticuzChromiumModule };
const resolved = "default" in mod ? mod.default : mod;
cachedSparticuz = resolved;
return resolved;
}
/** Test-only seam: replace the cached `@sparticuz/chromium` module. */
export function _setSparticuzChromiumForTests(mod: SparticuzChromiumModule | null): void {
cachedSparticuz = mod;
}