mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-03 12:54:29 +00:00
* fix(cli): invalidate the skills nudge cache after a successful install/update/check The passive "N skills out of date or missing" nudge reads a 24h config cache that only the background check (on non-skills commands) ever wrote. The skills commands themselves are excluded from the nudge pipeline, so a successful `skills update`/install/check never refreshed or dropped the cached verdict — the pre-install count kept printing on every other command for up to 24h. Reconcile commands now drop the cached verdict (counts + timestamp) so the next command's background check re-runs for real. The offline presence-only path deliberately keeps the cache: that run learned nothing about freshness. * fix(skills): win32-safe npx spawns in media-use + accurate whisper wording The Whisper transcribe fallback and the Kokoro local-TTS delegation both spawned a bare "npx" via execFileSync — on Windows npx is npx.cmd, which spawn cannot exec, so both paths died with `spawnSync npx ENOENT`. Route them through the skill's existing resolveSpawnCommand (node + npx-cli.js on win32, no shell:true), same as the audio engine's TTS spawns. Also corrects the "bundled with the hyperframes CLI" claim about whisper.cpp: it is resolved from PATH / installed via Homebrew / built from source with git+cmake on first use, and models download from HuggingFace — nothing whisper is shipped in the package. * feat(skills): canonical fully-silent marker + auth status exit-code docs product-launch's Step 3.1 gate said "or the project is marked silent" but nothing defined how to mark one, and audio.mjs unconditionally retrieved BGM. Define the canonical marker — `music: none` in the storyboard's top YAML block, plus no SCRIPT.md — and honor it: audio generate produces nothing (removing stale audio_meta.json, since absence is what assemble treats as silent), and `music: none` with narration keeps TTS while turning BGM off. Also documents the `auth status` exit-code contract (exit 1 while signed out is the normal offline state, not a failure) in the product-launch Step 0 note and the CLI skill's cloud reference. * fix(skills): transient-init retry for standalone animation-map and contrast-report The standalone helpers called initializeSession exactly once, so a valid modular project — whose sub-composition timelines register asynchronously — could hit the readiness deadline and die with the transient "zero duration / Runtime ready: false" diagnostic the render pipeline retries (probeStage). Add initializeSessionWithRetry to the shared package-loader (both byte-identical copies): close the crashed session and retry once with a fresh browser, gated by the engine's canonical isTransientBrowserError — now re-exported from @hyperframes/producer, with a frozen fallback pattern list for older published packages. The "Runtime ready: true" fast-fail (a genuine authoring bug) still fails without a retry. * feat(skills): extend the fully-silent marker to faceless-explainer and pr-to-video Both workflows reuse product-launch's audio model — their Step 3.1 gates carried the same undefined "marked silent" phrase, and their (intentionally identical) audio.mjs copies had the same unconditional BGM retrieve. Port the `music: none` marker handling into both copies, define the marker in their SKILL.md Step 3.1 and story-design references, and turn the copies' "intentionally identical" header claim into a byte-identity pin test so the next fix can't silently miss one of them. * test(cli): reset the prune mock explicitly instead of relying on restoreAllMocks The converge test's toHaveBeenCalledTimes(1) held only because vitest 3's vi.restoreAllMocks() clears vi.fn() call state; vitest 4 restores spies only, so the count would accumulate across tests and fail. Reset pruneOrphanedLockEntries in beforeEach like the other manifest mocks — passes under both vitest 3.2.4 (pinned) and vitest 4. * test(skills): close review findings — package-loader pin, whisper win32 parity, quoted-none Review follow-ups on #2476: - package-loader.mjs byte-identity pin (the elevated concern): the two copies now carry initializeSessionWithRetry + FALLBACK_TRANSIENT_PATTERNS, exactly the shared-logic shape a future fix could land in one copy and miss in the other — same enforcement as the audio.mjs pin. - whisper win32 call-site parity: runWhisper's npx resolution lifted into lib/npx-sync.mjs (resolveNpxInvocation, injectable params matching the localTtsGenerate idiom) with the same three-branch coverage as the Kokoro site — plus the hard-fail contract (throws actionably, since the whisper fallback has no next provider to fall through to). - quoted music: "none" pin: the vendored storyboard parser strips matching quotes at parse time (stripQuotes), so the silent marker already accepts the quoted spelling — pinned so that stays true.
92 lines
3.9 KiB
JavaScript
92 lines
3.9 KiB
JavaScript
import assert from "node:assert/strict";
|
|
import { existsSync, mkdtempSync, readFileSync, writeFileSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import { join } from "node:path";
|
|
import { spawnSync } from "node:child_process";
|
|
import test from "node:test";
|
|
|
|
const script = new URL("./audio.mjs", import.meta.url).pathname;
|
|
|
|
// The header of this adapter declares it "intentionally identical across the
|
|
// reusing skills" — pin that contract so a fix landing in one copy can't
|
|
// silently miss the other (the fully-silent marker bug did exactly that).
|
|
test("audio.mjs is byte-identical to pr-to-video's copy (the stated contract)", () => {
|
|
const here = readFileSync(script, "utf8");
|
|
const sibling = readFileSync(
|
|
new URL("../../pr-to-video/scripts/audio.mjs", import.meta.url),
|
|
"utf8",
|
|
);
|
|
assert.equal(here, sibling);
|
|
});
|
|
|
|
// ── the canonical fully-silent marker (SKILL.md Step 3.1) ────────────────────
|
|
// Same contract as product-launch (see its audio.test.mjs): `music: none` in
|
|
// the storyboard's top YAML block + no SCRIPT.md ⇒ generate nothing; with
|
|
// narration ⇒ TTS runs, BGM off.
|
|
|
|
function runAudioRaw({ storyboard, scriptMd = null, preexistingMeta = null }) {
|
|
const dir = mkdtempSync(join(tmpdir(), "faceless-audio-"));
|
|
const engine = join(dir, "engine.mjs");
|
|
writeFileSync(join(dir, "STORYBOARD.md"), storyboard);
|
|
if (scriptMd != null) writeFileSync(join(dir, "SCRIPT.md"), scriptMd);
|
|
if (preexistingMeta != null) writeFileSync(join(dir, "audio_meta.json"), preexistingMeta);
|
|
writeFileSync(
|
|
engine,
|
|
`import { readFileSync, writeFileSync } from "node:fs";
|
|
const argv = process.argv.slice(2);
|
|
const flag = (name) => argv[argv.indexOf(name) + 1];
|
|
const request = JSON.parse(readFileSync(flag("--request"), "utf8"));
|
|
writeFileSync(new URL("request.json", import.meta.url), JSON.stringify(request));
|
|
writeFileSync(flag("--out"), JSON.stringify({ voices: [], bgm: null, sfx: [] }));
|
|
`,
|
|
);
|
|
const result = spawnSync(
|
|
process.execPath,
|
|
[script, "--hyperframes", dir, "--storyboard", join(dir, "STORYBOARD.md")],
|
|
{ encoding: "utf8", env: { ...process.env, HF_MEDIA_ENGINE: engine } },
|
|
);
|
|
return { dir, result };
|
|
}
|
|
|
|
test("music: none + no SCRIPT.md = fully silent: no engine run, no audio_meta.json", () => {
|
|
const { dir, result } = runAudioRaw({ storyboard: "---\nmessage: Test\nmusic: none\n---\n" });
|
|
|
|
assert.equal(result.status, 0, result.stderr);
|
|
assert.match(result.stdout, /marked silent/);
|
|
assert.equal(existsSync(join(dir, "request.json")), false);
|
|
assert.equal(existsSync(join(dir, "audio_meta.json")), false);
|
|
});
|
|
|
|
test("fully-silent run removes stale audio_meta.json from a previous non-silent run", () => {
|
|
const { dir, result } = runAudioRaw({
|
|
storyboard: "---\nmessage: Test\nmusic: none\n---\n",
|
|
preexistingMeta: JSON.stringify({ bgm: { path: "old.mp3" }, voices: [], sfx: [] }),
|
|
});
|
|
|
|
assert.equal(result.status, 0, result.stderr);
|
|
assert.equal(existsSync(join(dir, "audio_meta.json")), false);
|
|
});
|
|
|
|
test("music: none with narration keeps TTS but turns BGM off (not fully silent)", () => {
|
|
const { dir, result } = runAudioRaw({
|
|
storyboard: "---\nmessage: Test\nmusic: none\n---\n",
|
|
scriptMd: "## Hook (Frame 1)\n\n Spoken line for frame one.\n",
|
|
});
|
|
|
|
assert.equal(result.status, 0, result.stderr);
|
|
const request = JSON.parse(readFileSync(join(dir, "request.json"), "utf8"));
|
|
assert.equal(request.bgm.mode, "none");
|
|
assert.equal(request.lines.length, 1);
|
|
});
|
|
|
|
test("a storyboard music mood still retrieves BGM (marker is exact, not fuzzy)", () => {
|
|
const { dir, result } = runAudioRaw({
|
|
storyboard: "---\nmessage: Test\nmusic: upbeat synthwave with heavy drums\n---\n",
|
|
});
|
|
|
|
assert.equal(result.status, 0, result.stderr);
|
|
const request = JSON.parse(readFileSync(join(dir, "request.json"), "utf8"));
|
|
assert.equal(request.bgm.mode, "retrieve");
|
|
assert.equal(request.bgm.query, "upbeat synthwave with heavy drums");
|
|
});
|