mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-03 12:54:29 +00:00
Miguel Ángel
98d0bdd73c
* refactor: extract @hyperframes/lint package from core Moves all lint rules, hyperframeLinter, lintProject, and related types from packages/core/src/lint/ into a new standalone packages/lint package. Core keeps a thin re-export stub at @hyperframes/core/lint for backward compatibility. Consumer imports (cli lint command, producer hyperframeLint) are updated to import from @hyperframes/lint directly. Depends on @hyperframes/parsers (PR #1755). * fix: restore postcss-selector-parser in core (sourceMutation.ts still uses it) * fix(ci): add parsers+lint to Dockerfile and build before preview tests * chore: update bun.lock after restoring postcss-selector-parser dep * test(cli): update lintProject test for string-dir signature from @hyperframes/lint * refactor(core): single-source the lint engine in @hyperframes/lint Delete core's byte-identical copy of the lint rule engine and re-point staticGuard at @hyperframes/lint, so the render-time render-gate and the studio preview share one rule engine instead of two copies that could silently diverge. Back-compat preserved via the @hyperframes/core/lint stub. Addresses review feedback on the dual-copy footgun.
125 lines
4.6 KiB
TypeScript
125 lines
4.6 KiB
TypeScript
import { describe, it, expect } from "vitest";
|
|
import { lintHyperframeHtml } from "./hyperframeLinter.js";
|
|
|
|
describe("lintHyperframeHtml — orchestrator", () => {
|
|
const validComposition = `
|
|
<html>
|
|
<body>
|
|
<div id="root" data-composition-id="comp-1" data-width="1920" data-height="1080" data-start="0">
|
|
<div id="stage"></div>
|
|
</div>
|
|
<script src="https://cdn.gsap.com/gsap.min.js"></script>
|
|
<script>
|
|
window.__timelines = window.__timelines || {};
|
|
const tl = gsap.timeline({ paused: true });
|
|
tl.to("#stage", { opacity: 1, duration: 1 }, 0);
|
|
window.__timelines["comp-1"] = tl;
|
|
</script>
|
|
</body>
|
|
</html>`;
|
|
|
|
it("reports no errors for a valid composition", async () => {
|
|
const result = await lintHyperframeHtml(validComposition);
|
|
expect(result.ok).toBe(true);
|
|
expect(result.errorCount).toBe(0);
|
|
});
|
|
|
|
it("attaches filePath to findings when option is set", async () => {
|
|
const html = "<html><body><div></div></body></html>";
|
|
const result = await lintHyperframeHtml(html, { filePath: "test.html" });
|
|
for (const finding of result.findings) {
|
|
expect(finding.file).toBe("test.html");
|
|
}
|
|
});
|
|
|
|
it("deduplicates identical findings", async () => {
|
|
const html = `
|
|
<html><body>
|
|
<div id="root"></div>
|
|
<script>const tl = gsap.timeline();</script>
|
|
</body></html>`;
|
|
const result = await lintHyperframeHtml(html);
|
|
const codes = result.findings.map((f) => `${f.code}|${f.message}`);
|
|
const uniqueCodes = [...new Set(codes)];
|
|
expect(codes.length).toBe(uniqueCodes.length);
|
|
});
|
|
|
|
it("strips <template> wrapper before linting composition files", async () => {
|
|
const html = `<template id="my-comp-template">
|
|
<div data-composition-id="my-comp" data-width="1920" data-height="1080"
|
|
style="position:relative;width:1920px;height:1080px;">
|
|
<div id="stage"></div>
|
|
</div>
|
|
<script>
|
|
window.__timelines = window.__timelines || {};
|
|
const tl = gsap.timeline({ paused: true });
|
|
tl.to("#stage", { opacity: 1, duration: 1 }, 0);
|
|
window.__timelines["my-comp"] = tl;
|
|
</script>
|
|
</template>`;
|
|
const result = await lintHyperframeHtml(html, { filePath: "compositions/my-comp.html" });
|
|
const missing = result.findings.filter(
|
|
(f) => f.code === "missing-composition-id" || f.code === "missing-dimensions",
|
|
);
|
|
expect(missing).toHaveLength(0);
|
|
});
|
|
|
|
it("ignores comments that mention template tags before the real template", async () => {
|
|
const html = `<!doctype html>
|
|
<html>
|
|
<head>
|
|
<!-- Authoring note: styles and scripts live inside <template>. -->
|
|
</head>
|
|
<body>
|
|
<template id="my-comp-template">
|
|
<style>#root { width: 1920px; height: 1080px; }</style>
|
|
<div data-composition-id="my-comp" data-width="1920" data-height="1080">
|
|
<div id="stage"></div>
|
|
</div>
|
|
<script>
|
|
window.__timelines = window.__timelines || {};
|
|
const tl = gsap.timeline({ paused: true });
|
|
tl.to("#stage", { opacity: 1, duration: 1 }, 0);
|
|
window.__timelines["my-comp"] = tl;
|
|
</script>
|
|
</template>
|
|
</body>
|
|
</html>`;
|
|
const result = await lintHyperframeHtml(html, { filePath: "compositions/my-comp.html" });
|
|
const rootFindings = result.findings.filter(
|
|
(f) => f.code === "root_missing_composition_id" || f.code === "root_missing_dimensions",
|
|
);
|
|
expect(rootFindings).toHaveLength(0);
|
|
});
|
|
|
|
it("strips comments whose markers re-form after one pass (no decoy template survives)", async () => {
|
|
// Adjacent comment markers: removing the inner `<!-- -->` in a single pass
|
|
// re-joins `<` + `!-- … -->` into a fresh, complete `<!-- … -->` that a lone
|
|
// global replace leaves behind — surfacing a decoy <template> with no
|
|
// composition-id. A fixpoint strip removes it; this guards that behavior.
|
|
const html = `<!doctype html>
|
|
<html>
|
|
<body>
|
|
<<!-- -->!-- <template id="decoy-template"></template> -->
|
|
<template id="my-comp-template">
|
|
<style>#root { width: 1920px; height: 1080px; }</style>
|
|
<div data-composition-id="my-comp" data-width="1920" data-height="1080">
|
|
<div id="stage"></div>
|
|
</div>
|
|
<script>
|
|
window.__timelines = window.__timelines || {};
|
|
const tl = gsap.timeline({ paused: true });
|
|
tl.to("#stage", { opacity: 1, duration: 1 }, 0);
|
|
window.__timelines["my-comp"] = tl;
|
|
</script>
|
|
</template>
|
|
</body>
|
|
</html>`;
|
|
const result = await lintHyperframeHtml(html, { filePath: "compositions/my-comp.html" });
|
|
const rootFindings = result.findings.filter(
|
|
(f) => f.code === "root_missing_composition_id" || f.code === "root_missing_dimensions",
|
|
);
|
|
expect(rootFindings).toHaveLength(0);
|
|
});
|
|
});
|