Files
hyperframes/packages
Vance IngallsandClaude Sonnet 5 12f3626fd8 fix(engine): hard-fail processCompositionAudio on VST chain errors
A missing VST plugin or chain file was caught by the per-element try/catch
shared with every soft-degrading failure mode (missing source asset,
download failure, etc): the track was silently dropped and MixResult.success
stayed true, so a render with a missing plugin completed successfully with
no visible error anywhere.

Introduce VstChainProcessingError to mark VST-specific failures and let the
per-element catch rethrow it instead of swallowing it into the warnings
list. The rethrow escapes the Promise.all and rejects
processCompositionAudio itself, which (traced through audioStage.ts's
uncaught await and observability.ts's observeRenderStage, which rethrows)
surfaces as a real render failure through the CLI's existing error-handling
path — the same one every other hard pipeline failure already uses. Every
non-VST failure mode is untouched.

Fixed the two "hard-fails" tests to assert the promise actually rejects
(rejects.toThrow) instead of only checking tracksProcessed/error on an
still-resolved, still-successful result — the previous assertions would
have passed even with the bug present.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-07-16 18:49:17 -07:00
..
2026-07-16 05:26:57 +00:00
2026-07-16 05:26:57 +00:00
2026-07-16 05:26:57 +00:00