Files
hyperframes/packages/studio/src/components/editor/audioFxTelemetry.ts
T
Vance IngallsandClaude Sonnet 5 d6c4774ef4 feat(studio): instrument the audio FX rack, including work an agent did (#3229)
* fix(studio): close the typecheck and fallow gaps wa-18b-reschedule opened

useAutomationLanes.ts's write() assumed gesture-scoped coalescing and a
preview-only commit that useDomEditAttributeCommits.ts never grew — backported
that option support from its own later commit so the two sides of the API
agree. The paste path and its tests were missing the box selection's v0/v1
bounds a sibling commit added to AutomationSelection. The FX panel's carve
controls still edited the six mechanism numbers (maxCutDb, bands,
intelligibilityBias) after carveProfile() collapsed authoring to one Strength
knob, so those fields no longer existed on HfCarveSettings; UI now edits
strength, and analyseCarveBands is called with carveProfile(strength).

Also closes fallow's complexity, dead-code and duplication findings on this
PR's diff: extracted automationLaneDragMath.ts (pure group/point-move math)
and useAutomationRangeDrag.ts (the marquee-select gesture) out of
useAutomationLaneGestures.ts, pulled a couple of render-loop ternaries and a
resolver into named functions, dropped an export nothing outside its file
used, and shared a step-simplifier between audioCarve's two envelope
builders.

The edge-stretch vs. box-select priority test in TimelineAutomationLane.test
was still pinning the pre-box-select rule (edge wins over a point sitting on
it) that a sibling commit deliberately reversed — a point inside the box is
now selected content, so grabbing it drags the group instead. Updated the
test to the shipped rule instead of the old one.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(core): cap the via conic's weight so an edge-clamped via point can't NaN

A via point pulled out past the segment (viaX: 5, viaY: -3) clamps to
(0.999, 0.001) — exactly on the steady region's edge, where edge - viaX is 0.
viaConic divided by that zero to get an infinite weight, and shapeVia turned
Infinity into NaN a few steps later (Infinity - Infinity in the quadratic
coefficient). NaN reaching setValueCurveAtTime silences the automated
parameter for the rest of the render.

Capped the weight at 1e6 instead of leaving it unbounded — past that point
the arc already reads as touching the via point, so nothing visible is lost.
Also hardened shapeVia's existing denominator guard (`<= 0`) to `!(> 0)`,
since NaN fails the original comparison and fell through it.

Review by Miga (PR #3208).

* fix(studio-server): fingerprint the proactive waveform cache key too

The route already keys the waveform cache on the asset's size and mtime as
well as its path, so a rebuilt-in-place file gets fresh peaks instead of
stale ones. generateWaveformCache — the proactive path that runs on upload —
still called buildWaveformCacheKey with the path alone, so it wrote to a
different key than the route reads from (making the pre-generated cache
never found) and kept the exact collision bug this fingerprint exists to fix
on its own path.

Review by Miga (PR #3211).

* style(docs): run oxfmt on the /hyperframes-audio skill docs

Table column widths had drifted out of alignment with oxfmt's own rules,
failing format:check and blocking the Preflight gate every downstream
branch inherits. Whitespace only, no content change.

* fix(core): stop \b from missing underscore-separated names, guard clipsOverlap's negative duration

\b treats `_` as a word character, so \bbed\b never matched bed_01,
music_bed_loop, or theme_song, and \bvo\b/\bvox\b/\btts\b had the same gap —
an underscore-separated bed classified as "unknown" and could end up offered
as its own carve source. Replaced the short hints with a boundary that
actually excludes letters and digits on both sides.

clipsOverlap computed end = start + duration without guarding sign, so a
negative duration put end before start — an interval that does not describe
anything, and one specific case showed it silently dropping a real overlap
(a shorter, earlier broken end rejected a clip that genuinely contained the
point). Duration clamps to zero instead: a clip cannot un-play time, and a
zero-length clip at its start is the sane reading of "duration nobody wrote
down as positive."

Review by Miga (PR #3212).

* fix(studio): widen PropertyPanel's resetModules render timeout again

The 20s margin (already once widened for the same reason) is timing out in
CI's full-monorepo Test run — the resetModules()+fresh-import render this
test needs is uncached and competes with every other package's test suite
for the same worker pool, and the same test passes in well under 2s
standalone. Went to 45s rather than re-tuning to whatever number happens to
clear the current CI load, since that number moves every time CI gains a
package.

* fix(studio): stop the single-candidate auto-apply carve firing twice

Two auto-apply effects both fire when sourceOptions.length === 1: the
multi-candidate effect only guards length === 0, so a single candidate
passes it too, and the single-candidate effect passes its own guard right
after — both compute the same sources list and both call setCarve, so the
common case (one narrator, one bed) triggered two decodes, two FFT runs, and
two concurrent attribute writes for one decision.

The multi-candidate effect now defers to its sibling for exactly one
candidate, which already has its own detailed handling for that case.

Review by Miga (PR #3213).

* feat(core): carve against every voice over a bed, always (#3212)

* feat(core): carve against every voice over a bed, always dynamically

A bed usually runs under a whole sequence — a narrator, an interview answer, a
second presenter — and carving against one of them left the others fighting it.
`source` becomes `sources`, and `mixCarveSources` sums every voice onto the BED's
clock before anything is measured. That is what keeps one analysis sufficient: the
chain is fixed, so there is no per-voice filter to switch between, and bands drawn
from all the speech there is with envelopes that rise wherever any of it happens
answer the actual question — where and when is speech masking this bed.

Summed rather than averaged: two people talking at once mask more than either
alone. Audio before the bed starts is dropped rather than folded in at zero, since
it plays over nothing and shifting it would put a cut where there is no voice.

`dynamic` is gone. A fixed depth thins the bed through every pause, and once both
have been heard there is no reason to want it, so every carve follows the speech.

Two helpers the panel and the headless script now share instead of each carrying a
copy — two definitions of "what does this name suggest" drift, and then the two
disagree about which track is the voice:

- `classifyAudioName` reads a track's kind from its id and filename together.
  `unknown` is deliberately common: treating an unrecognised name as "not a voice"
  would hide the one track somebody needs to pick.
- `clipsOverlap` keeps out a voice that never plays while the bed does. An unwritten
  duration counts as unbounded, not zero — refusing a clip whose length the
  composition leaves to the media would drop the commonest case there is.

Files written before this still load: a single `source` reads as a one-voice list,
a stored `dynamic` is ignored, and an absent attribute means the defaults whole.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(core): stop \b from missing underscore-separated names, guard clipsOverlap's negative duration

\b treats `_` as a word character, so \bbed\b never matched bed_01,
music_bed_loop, or theme_song, and \bvo\b/\bvox\b/\btts\b had the same gap —
an underscore-separated bed classified as "unknown" and could end up offered
as its own carve source. Replaced the short hints with a boundary that
actually excludes letters and digits on both sides.

clipsOverlap computed end = start + duration without guarding sign, so a
negative duration put end before start — an interval that does not describe
anything, and one specific case showed it silently dropping a real overlap
(a shorter, earlier broken end rejected a clip that genuinely contained the
point). Duration clamps to zero instead: a clip cannot un-play time, and a
zero-length clip at its start is the sane reading of "duration nobody wrote
down as positive."

Review by Miga (PR #3212).

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(studio): port the carve UI off the removed source/dynamic fields

#3212 (accidentally squash-merged into this branch instead of main) changed
HfCarveSettings from a single `source` + `dynamic` toggle to a `sources`
list with dynamic mode removed outright — the multi-voice UI consumer that
goes with that shape lands in the very next PR, so this branch was left with
a type that no longer matched its own code.

Minimal port, not the multi-voice redesign that PR does properly: the
"Listen to" picker and analyse() treat sources[0] as the one voice this UI
still understands, and every dynamic-mode branch (the automated envelope
lanes, the toggle, the checkbox) is gone along with the field — a carve is
now always the static value the analysis computes, matching what the type
change made permanent. Test suite trimmed the same way: the automation-lane
and toggle tests covered behavior that no longer exists.

* refactor(studio): break up the FX rack's largest functions and files

Fallow flagged 9 complexity findings and 2 file-size violations after the
telemetry stack landed. Extracts FxPresetRun, FxAddMenu, FxRackChain,
FxNodeOpenBody, FxNodeParams, and useFxAudition/useFxCarve/useFxLevelling/
useFxChainObserved out of propertyPanelFxSection.tsx and
propertyPanelAudioFxGroup.tsx, splits propertyPanelFxNodeRow.tsx's open-face
rendering into its own component, and dedupes a clone in studioTelemetry.ts.
Pure structural move — no behavior change; full test suite still green.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-13 15:05:51 -07:00

231 lines
8.9 KiB
TypeScript

/**
* What the audio FX rack reports about itself.
*
* One module rather than `trackStudioEvent` calls scattered through six
* components, for two reasons. The event names and property shapes have to
* agree across the panel or a dashboard cannot join them — and everything here
* is subject to one rule that is easy to break a callsite at a time:
*
* **Nothing user-authored leaves the browser.** Not element ids, not media
* filenames, not composition paths, not chain JSON. Every property below is
* either a fixed identifier from our own catalogue (a preset id, an effect
* type, a parameter key), a number, or a boolean. `studioTelemetry.ts` already
* strips the query string off `url_hash` for exactly this reason — the ids in
* it are the author's own. The rack sees the same class of data and must hold
* the same line.
*
* The second rule is about volume: **commit, not preview.** Every control in
* the rack has a preview path that fires continuously while a slider moves and
* a commit path that fires once when it is released. Only the commit path
* belongs here. Wiring a param event to the preview would emit tens of events
* per drag, which is both a cost and a lie — an author who nudges a knob and
* puts it back did not make thirty decisions.
*/
import { trackStudioEvent } from "../../utils/studioTelemetry";
import type { HfAudioFxChain, HfAudioFxNode } from "@hyperframes/core/audio-fx";
/** Kept narrow deliberately — see the "nothing user-authored" rule above. */
type FxEventProperties = Record<string, string | number | boolean | null | undefined>;
function track(event: string, properties: FxEventProperties = {}): void {
trackStudioEvent(`audio_fx_${event}`, properties);
}
/** Where a node in the chain came from, as one word. */
export function nodeOrigin(node: HfAudioFxNode): string {
if (node.fromPreset) return "preset";
if (node.fromCarve) return "carve";
if (node.fromEq) return "eq";
if (node.fromLeveller) return "leveller";
return "hand";
}
/**
* A chain reduced to counts.
*
* Counts rather than contents: "four nodes, two of them from a preset" answers
* how the rack is used without shipping what the author built. The origin mix
* is the interesting half — it separates a chain somebody assembled by hand
* from one a preset wrote from one an analysis wrote.
*/
export function chainShape(chain: HfAudioFxChain | null): FxEventProperties {
const nodes = chain?.nodes ?? [];
const byOrigin = new Map<string, number>();
for (const node of nodes) {
const origin = nodeOrigin(node);
byOrigin.set(origin, (byOrigin.get(origin) ?? 0) + 1);
}
return {
node_count: nodes.length,
nodes_from_preset: byOrigin.get("preset") ?? 0,
nodes_from_carve: byOrigin.get("carve") ?? 0,
nodes_from_eq: byOrigin.get("eq") ?? 0,
nodes_from_leveller: byOrigin.get("leveller") ?? 0,
nodes_by_hand: byOrigin.get("hand") ?? 0,
// How many distinct presets are live on this track. Stacking a character
// preset onto a cleaned voice is a supported thing to want, and this is the
// only way to find out whether anybody does it.
preset_count: new Set(nodes.map((n) => n.fromPreset).filter(Boolean)).size,
bypassed_count: nodes.filter((n) => n.enabled === false).length,
};
}
export interface FxTrackContext {
/** What the track reads as — `voice` / `music` / `sfx` / `unknown`. */
trackKind?: string;
}
const ctx = (c: FxTrackContext): FxEventProperties => ({ track_kind: c.trackKind ?? "unknown" });
// --- presets ---------------------------------------------------------------
export function trackPresetApplied(
presetId: string,
family: string,
nodeCount: number,
mode: "append" | "replace" | "reapply",
c: FxTrackContext,
): void {
track("preset_applied", { preset: presetId, family, node_count: nodeCount, mode, ...ctx(c) });
}
export function trackPresetRemoved(presetId: string, c: FxTrackContext): void {
track("preset_removed", { preset: presetId, ...ctx(c) });
}
/** The whole-preset wet/dry knob, on release. `amount` is 0..1. */
export function trackPresetAmount(presetId: string, amount: number, c: FxTrackContext): void {
track("preset_amount", { preset: presetId, amount, ...ctx(c) });
}
export function trackPresetAutomated(presetId: string, on: boolean, c: FxTrackContext): void {
track("preset_automated", { preset: presetId, enabled: on, ...ctx(c) });
}
/**
* Hover-auditioning a preset from the shelf.
*
* Fired once per preset per time the shelf is opened, not once per hover: a
* pointer crossing the shelf passes over a dozen items in a second, and
* counting those would drown every other event in the feature and describe
* mouse travel rather than interest.
*/
export function trackPresetAuditioned(presetId: string, c: FxTrackContext): void {
track("preset_auditioned", { preset: presetId, ...ctx(c) });
}
// --- nodes -----------------------------------------------------------------
/**
* `via` separates the two doors onto the same effect: a named job arrives
* already aimed at a frequency, a bare effect does not. Which one authors
* actually reach for is the question the jobs were built to answer.
*/
export function trackNodeAdded(
type: string,
via: "job" | "effect" | "eq" | "leveller",
jobId: string | null,
c: FxTrackContext,
): void {
track("node_added", { effect: type, via, job: jobId ?? "none", ...ctx(c) });
}
export function trackNodeRemoved(type: string, origin: string, c: FxTrackContext): void {
track("node_removed", { effect: type, origin, ...ctx(c) });
}
export function trackNodeBypassed(type: string, bypassed: boolean, c: FxTrackContext): void {
track("node_bypassed", { effect: type, bypassed, ...ctx(c) });
}
export function trackNodeMoved(type: string, direction: "up" | "down", c: FxTrackContext): void {
track("node_moved", { effect: type, direction, ...ctx(c) });
}
// --- parameters ------------------------------------------------------------
/**
* A committed parameter edit.
*
* `surface` is the point of the event. Every effect with a one-knob profile can
* be driven either by that derived knob or by opening Details and setting the
* mechanism directly, and the whole one-knob design rests on a claim about
* which one people use. Without this property the two are indistinguishable.
*
* The value goes too — a parameter key with no value tells you somebody touched
* "frequency" and not that every author lands on 80 Hz.
*/
export function trackParamCommitted(
type: string,
param: string,
value: number | string,
surface: "knob" | "details",
c: FxTrackContext,
): void {
track("param_committed", { effect: type, param, value, surface, ...ctx(c) });
}
/** The derived one-knob control, on release. `strength` is 0..1. */
export function trackProfileCommitted(type: string, strength: number, c: FxTrackContext): void {
track("profile_committed", { effect: type, strength, ...ctx(c) });
}
// --- the measuring modules -------------------------------------------------
export function trackCarveChanged(
action: "enabled" | "disabled" | "strength" | "sources",
props: { strength?: number; sourceCount?: number },
): void {
track("carve_changed", {
action,
strength: props.strength,
source_count: props.sourceCount,
});
}
export function trackLeveller(action: "run" | "removed" | "auditioned"): void {
track("leveller", { action });
}
export function trackEqChanged(band: string, value: number): void {
track("eq_changed", { band, value });
}
// --- provenance ------------------------------------------------------------
/**
* What arrived on a composition that this session did not put there.
*
* This is how agent-applied effects become visible at all. An agent asked to
* fix a mix does not drive the panel — it edits the composition HTML, or runs
* `scripts/carve.mjs`, and the rack simply finds the result already present.
* None of the events above will ever fire for that work.
*
* So the panel reports the shape of what it was handed, and how many edits this
* session had made when it appeared. Fx that changed while the studio was open
* with `panel_edits` unmoved was written by something else — which, combined
* with `agent_runtime` on the same event, is as close to "an agent did this" as
* the browser can honestly get.
*
* `first_sight` distinguishes opening a composition that already had effects
* from watching effects appear in one that did not.
*/
export function trackChainObserved(
chain: HfAudioFxChain | null,
props: { firstSight: boolean; panelEdits: number; hasCarve: boolean; hasAutomation: boolean },
c: FxTrackContext,
): void {
track("chain_observed", {
...chainShape(chain),
first_sight: props.firstSight,
panel_edits: props.panelEdits,
// The whole point: no panel edits behind a chain that is present or that
// just changed means the chain came from outside the studio.
authored_outside: props.panelEdits === 0,
has_carve: props.hasCarve,
has_automation: props.hasAutomation,
...ctx(c),
});
}