mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-03 12:54:29 +00:00
Vance IngallsandClaude Fable 5
17f3e5beb0
Review round on PR #2442: - miguel (blocker): the cross-file eligibility rule only guarded the dom-edit tripwire; recordResolverParity and recordAnimationResolverParity ran before wrongCompositionFile at every cutover surface, so cross-file ops still emitted false element_not_found (id present in the OTHER file's source passes the runtime-node filter) and polluted the attempt denominator. The rule now lives in one shared isCrossFileEdit guard applied by all three entry points, wired with { targetPath, compositionPath } at all six sdkCutover call sites (timing, timing-batch, gsap add/set/remove, keyframe chokepoint, delete). - Rames (race): the disk-truth read is now dispatched SYNCHRONOUSLY in the same prologue as the miss check, before control returns to the caller whose cutover persist writes the same file moments later — a post-write read would see a remove op's target legitimately gone and misclassify it as a genuine divergence. Sync reader throws become rejections (IIFE), not exceptions into the swallow-all catch. - Rames (parse failure): openComposition failure inside the disk check now fails open as sourceReadFailed (unparseable source is not ground truth), instead of the outer catch dropping the divergence event entirely. recordResolverParity's source check extracted to checkHfIdInSource (complexity gate), mirroring checkAnimationIdOnDisk's error discipline. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>