Files
hyperframes/packages/cli/src/utils/hostAnswers.test.ts
T
Miguel Ángel 1289734770 fix(cli): a finished capture exits even when a site's DNS never answers (#5983)
* fix(cli): a finished capture exits even when a site's DNS never answers

Capture resolved every page request with the system lookup and gave up after
10 s, but a system lookup cannot be cancelled: the abandoned one kept the
process alive until the OS resolver timed out, so a capture that had printed
its result could run past the app's 5-minute cap and lose its folder.
Resolve through c-ares instead, as hostAnswers does, and cancel it at the
same 10 s deadline.

* test(cli): a capture lookup that answers must exit right after too

Dropping the timer cleanup kept every successful lookup alive 10 s and no test noticed.

* fix(cli): capture falls back to the system lookup and exits once its result is out

c-ares answers first. When it has no answer, the system lookup (hosts file, OS-only DNS)
runs in a child process killed at the 10 s deadline, cached per host, because Node waits
for an in-process system lookup even in process.exit. Capture then asks the CLI to exit
100 ms after printing its result, as render does.

* fix(cli): capture reads the hosts file first and kills its lookup child on exit

The hosts file answers before DNS, as the system lookup does (overrides and 0.0.0.0
blocks keep working). A host whose system answer is cached skips c-ares, a caller that
joins a running lookup keeps its own deadline, and a pending lookup child is killed when
the CLI exits.

* fix(cli): capture's forced exit waits until a slow reader has the whole result

The root exit now waits for stdout and stderr to hand over what is already
written before it calls process.exit, so a large JSON result on a slow pipe
arrives complete. A hostname listed several times in the hosts file now has
every address checked, not only the first.

* fix(cli): keep process exit in the CLI root and let test fixtures exit

The output wait is now a helper that only waits; cli.ts still owns the
process.exit. The process-ownership check treats test fixtures like tests,
since each one runs as its own process.

* chore(cli): run the process-ownership check before every commit

A process.exit outside a process root used to pass the local hooks and fail
only in CI's Preflight.
2026-10-21 02:46:17 +00:00

61 lines
2.2 KiB
TypeScript

import { afterEach, describe, expect, it, vi } from "vitest";
import { startTestDnsServer, type TestDnsServer } from "./dnsTestServer.js";
// Point every Resolver hostAnswers creates at a local UDP server this test controls.
const dnsServer = vi.hoisted(() => ({ address: "" }));
vi.mock("node:dns", async (importOriginal) => {
const real = await importOriginal<typeof import("node:dns")>();
class Resolver extends real.promises.Resolver {
constructor(options?: ConstructorParameters<typeof real.promises.Resolver>[0]) {
super(options);
this.setServers([dnsServer.address]);
}
}
return { ...real, promises: { ...real.promises, Resolver } };
});
let server: TestDnsServer | undefined;
async function startServer(mode: "silent" | "answer" | "no-aaaa"): Promise<void> {
server = await startTestDnsServer(mode);
dnsServer.address = server.address;
}
describe("hostAnswers", () => {
afterEach(() => {
server?.close();
server = undefined;
});
it("says no, within its short timeout, when DNS never replies", async () => {
await startServer("silent");
const { hostAnswers } = await import("./hostAnswers.js");
const started = Date.now();
expect(await hostAnswers("registry.npmjs.org")).toBe(false);
expect(Date.now() - started).toBeLessThan(3500);
});
it("says yes when DNS answers", async () => {
await startServer("answer");
const { hostAnswers } = await import("./hostAnswers.js");
expect(await hostAnswers("registry.npmjs.org")).toBe(true);
});
it("says yes without asking DNS when fetch goes through an env proxy", async () => {
await startServer("silent");
vi.stubEnv("HTTPS_PROXY", "http://127.0.0.1:9");
vi.stubEnv("NODE_USE_ENV_PROXY", "1");
try {
const { hostAnswers } = await import("./hostAnswers.js");
expect(await hostAnswers("registry.npmjs.org")).toBe(true);
} finally {
vi.unstubAllEnvs();
}
});
it("says no when A answers but AAAA never does, since the system lookup waits for both", async () => {
await startServer("no-aaaa");
const { hostAnswers } = await import("./hostAnswers.js");
expect(await hostAnswers("registry.npmjs.org")).toBe(false);
});
});