Files
hyperframes/packages/studio/src/hooks/useFileManager.ts
T
James Russo 2417293dab fix(studio): enforce optimistic file concurrency (#2156)
* fix(studio): enforce optimistic file concurrency

* fix(studio): harden conditional file writes

* fix(studio): honor explicit file preconditions

* test(producer): allow zero-ms encode timing
2026-07-15 18:07:04 -04:00

527 lines
17 KiB
TypeScript

import { useState, useCallback, useMemo, useRef } from "react";
import type { EditingFile } from "../utils/studioHelpers";
import { FONT_EXT, isMediaFile } from "../utils/mediaTypes";
import { fontFamilyFromAssetPath, type ImportedFontAsset } from "../components/editor/fontAssets";
import type { EditHistoryKind } from "../utils/editHistory";
import { findTagByTarget, type PatchTarget } from "../utils/sourcePatcher";
import {
createStudioSaveHttpError,
retryStudioSave,
StudioFileConflictError,
StudioSaveNetworkError,
} from "../utils/studioSaveDiagnostics";
import { createStudioWriteToken, studioExpectedFileVersion } from "../utils/studioFileVersion";
import { useFileTree } from "./useFileTree";
import { useEditorSave } from "./useEditorSave";
// ── Types ──
interface RecordEditInput {
label: string;
kind: EditHistoryKind;
coalesceKey?: string;
files: Record<string, { before: string; after: string }>;
}
interface UseFileManagerOptions {
projectId: string | null;
showToast: (message: string, tone?: "error" | "info") => void;
recordEdit: (input: RecordEditInput) => Promise<void>;
domEditSaveTimestampRef: React.MutableRefObject<number>;
setRefreshKey: React.Dispatch<React.SetStateAction<number>>;
}
// ── Hook ──
export function useFileManager({
projectId,
showToast,
recordEdit,
domEditSaveTimestampRef,
setRefreshKey,
}: UseFileManagerOptions) {
// ── Shared refs ──
const [editingFile, setEditingFile] = useState<EditingFile | null>(null);
const [revealSourceOffset, setRevealSourceOffset] = useState<number | null>(null);
const editingPathRef = useRef(editingFile?.path);
editingPathRef.current = editingFile?.path;
const projectIdRef = useRef(projectId);
projectIdRef.current = projectId;
const importedFontAssetsRef = useRef<ImportedFontAsset[]>([]);
const fileVersionScope = useMemo(
() => ({ projectId, versions: new Map<string, string | null>() }),
[projectId],
);
const fileVersions = fileVersionScope.versions;
const observeProjectFileVersion = useCallback(
(path: string, version: string | null) => {
fileVersions.set(path, version);
},
[fileVersions],
);
// ── File tree ──
const {
projectDir,
fileTree,
setFileTree,
fileTreeLoaded,
refreshFileTree,
compositions,
assets,
fontAssets,
} = useFileTree({ projectId, projectIdRef });
// ── Core file I/O ──
const readProjectFile = useCallback(
async (path: string): Promise<string> => {
if (!projectId) throw new Error("No active project");
const response = await fetch(
`/api/projects/${encodeURIComponent(projectId)}/files/${encodeURIComponent(path)}`,
);
if (!response.ok) throw new Error(`Failed to read ${path}`);
const data = (await response.json()) as { content?: string; version?: string };
if (typeof data.content !== "string") throw new Error(`Missing file contents for ${path}`);
fileVersions.set(path, data.version ?? response.headers.get("etag"));
return data.content;
},
[fileVersions, projectId],
);
const writeProjectFile = useCallback(
async (path: string, content: string, expectedContent?: string): Promise<void> => {
if (!projectId) throw new Error("No active project");
const writeProjectId = projectId;
let expectedVersion = await studioExpectedFileVersion(fileVersions, path, expectedContent);
if (expectedVersion === undefined) {
const preflight = await fetch(
`/api/projects/${encodeURIComponent(writeProjectId)}/files/${encodeURIComponent(path)}`,
);
if (preflight.ok) {
const data = (await preflight.json()) as { content?: string; version?: string };
throw new StudioFileConflictError({
filePath: path,
currentVersion: data.version ?? preflight.headers.get("etag"),
currentContent: data.content ?? null,
attemptedContent: content,
});
} else if (preflight.status === 404) {
expectedVersion = null;
} else {
throw await createStudioSaveHttpError(preflight, `Failed to read ${path} before save`);
}
}
const writeToken = createStudioWriteToken();
await retryStudioSave(async () => {
let response: Response;
try {
response = await fetch(
`/api/projects/${encodeURIComponent(writeProjectId)}/files/${encodeURIComponent(path)}`,
{
method: "PUT",
headers: {
"Content-Type": "text/plain",
"X-Hyperframes-Write-Token": writeToken,
...(expectedVersion ? { "If-Match": expectedVersion } : { "If-None-Match": "*" }),
},
body: content,
},
);
} catch (error) {
throw new StudioSaveNetworkError(`Failed to save ${path}: network error`, {
cause: error,
});
}
if (response.status === 409) {
const conflict = (await response.json().catch(() => null)) as {
currentVersion?: string | null;
currentContent?: string | null;
} | null;
const currentVersion = conflict?.currentVersion ?? null;
if (currentVersion && conflict?.currentContent === content) {
fileVersions.set(path, currentVersion);
return;
}
throw new StudioFileConflictError({
filePath: path,
currentVersion,
currentContent: conflict?.currentContent ?? null,
attemptedContent: content,
});
}
if (!response.ok) throw await createStudioSaveHttpError(response, `Failed to save ${path}`);
const result = (await response.json()) as { version?: string };
const version = result.version ?? response.headers.get("etag");
if (!version)
throw new Error(`Save response for ${path} did not include a content version`);
fileVersions.set(path, version);
});
if (projectIdRef.current === writeProjectId && editingPathRef.current === path) {
setEditingFile({ path, content });
}
},
[fileVersions, projectId],
);
const updateEditingFileContent = useCallback((path: string, content: string) => {
if (editingPathRef.current === path) {
setEditingFile({ path, content });
}
}, []);
const readOptionalProjectFile = useCallback(
async (path: string): Promise<string> => {
if (!projectId) throw new Error("No active project");
const response = await fetch(
`/api/projects/${encodeURIComponent(projectId)}/files/${encodeURIComponent(path)}?optional=1`,
);
if (!response.ok) throw new Error(`Failed to read ${path}`);
const data = (await response.json()) as { content?: string; version?: string };
fileVersions.set(path, data.version ?? response.headers.get("etag"));
return typeof data.content === "string" ? data.content : "";
},
[fileVersions, projectId],
);
// ── Editor save (debounced content change) ──
const { saveRafRef, handleContentChange } = useEditorSave({
editingPathRef,
projectIdRef,
readProjectFile,
writeProjectFile,
recordEdit,
domEditSaveTimestampRef,
setRefreshKey,
showToast,
});
// ── File select ──
const revealRequestIdRef = useRef(0);
const revealAbortRef = useRef<AbortController | null>(null);
const handleFileSelect = useCallback(
(path: string) => {
const pid = projectIdRef.current;
if (!pid) return;
revealAbortRef.current?.abort();
revealAbortRef.current = null;
revealRequestIdRef.current++;
// Skip fetching binary content for media files — just set the path for preview
if (isMediaFile(path)) {
setEditingFile({ path, content: null });
return;
}
fetch(`/api/projects/${encodeURIComponent(pid)}/files/${encodeURIComponent(path)}`)
.then((r) => {
if (!r.ok) throw new Error(`Failed to load ${path} (${r.status})`);
return r.json();
})
.then((data: { content?: string; version?: string }) => {
if (data.content != null) {
fileVersions.set(path, data.version ?? null);
setEditingFile({ path, content: data.content });
}
})
.catch((err: unknown) => {
showToast(err instanceof Error ? err.message : `Failed to load ${path}`, "error");
});
},
[fileVersions, showToast],
);
// ── Click-to-source ──
const openSourceForSelection = useCallback(
(sourceFile: string, target: PatchTarget) => {
const pid = projectIdRef.current;
if (!pid || !sourceFile) return;
revealAbortRef.current?.abort();
revealAbortRef.current = null;
if (editingPathRef.current === sourceFile && editingFile?.content != null) {
const match = findTagByTarget(editingFile.content, target);
setRevealSourceOffset(match ? match.start : null);
return;
}
const requestId = ++revealRequestIdRef.current;
const controller = new AbortController();
revealAbortRef.current = controller;
fetch(`/api/projects/${encodeURIComponent(pid)}/files/${encodeURIComponent(sourceFile)}`, {
signal: controller.signal,
})
.then((r) => r.json())
.then((data: { content?: string; version?: string }) => {
if (requestId !== revealRequestIdRef.current) return;
if (data.content != null) {
fileVersions.set(sourceFile, data.version ?? null);
setEditingFile({ path: sourceFile, content: data.content });
const match = findTagByTarget(data.content, target);
setRevealSourceOffset(match ? match.start : null);
}
})
.catch(() => {});
},
[editingFile?.content, fileVersions],
);
// ── Upload ──
const uploadProjectFiles = useCallback(
async (files: Iterable<File>, dir?: string): Promise<string[]> => {
const pid = projectIdRef.current;
const fileList = Array.from(files);
if (!pid || fileList.length === 0) return [];
const formData = new FormData();
for (const file of fileList) {
formData.append("file", file);
}
const qs = dir ? `?dir=${encodeURIComponent(dir)}` : "";
try {
const res = await fetch(`/api/projects/${encodeURIComponent(pid)}/upload${qs}`, {
method: "POST",
body: formData,
});
if (res.ok) {
const data = await res.json();
if (data.skipped?.length) {
showToast(`Skipped (too large): ${data.skipped.join(", ")}`);
}
if (data.invalid?.length) {
const names = data.invalid.map((entry: { name: string }) => entry.name).join(", ");
showToast(`Unsupported media skipped: ${names}`);
}
await refreshFileTree();
setRefreshKey((k) => k + 1);
return Array.isArray(data.files) ? data.files : [];
} else if (res.status === 413) {
showToast("Upload rejected: payload too large");
} else {
showToast(`Upload failed (${res.status})`);
}
} catch {
showToast("Upload failed: network error");
}
return [];
},
[refreshFileTree, setRefreshKey, showToast],
);
// ── File CRUD ──
const handleCreateFile = useCallback(
async (path: string) => {
const pid = projectIdRef.current;
if (!pid) return;
let content = "";
if (path.endsWith(".html")) {
content =
'<!DOCTYPE html>\n<html>\n<head>\n <meta charset="UTF-8">\n</head>\n<body>\n\n</body>\n</html>\n';
}
const res = await fetch(
`/api/projects/${encodeURIComponent(pid)}/files/${encodeURIComponent(path)}`,
{
method: "POST",
headers: { "Content-Type": "text/plain" },
body: content,
},
);
if (res.ok) {
await refreshFileTree();
handleFileSelect(path);
} else {
const err = await res.json().catch(() => ({ error: "unknown" }));
console.error(`Create file failed: ${err.error}`);
showToast(`Couldn't create ${path}: ${err.error}`, "error");
}
},
[refreshFileTree, handleFileSelect, showToast],
);
const handleCreateFolder = useCallback(
async (path: string) => {
const pid = projectIdRef.current;
if (!pid) return;
const res = await fetch(
`/api/projects/${encodeURIComponent(pid)}/files/${encodeURIComponent(path + "/.gitkeep")}`,
{
method: "POST",
headers: { "Content-Type": "text/plain" },
body: "",
},
);
if (res.ok) {
await refreshFileTree();
} else {
const err = await res.json().catch(() => ({ error: "unknown" }));
console.error(`Create folder failed: ${err.error}`);
showToast(`Couldn't create folder ${path}: ${err.error}`, "error");
}
},
[refreshFileTree, showToast],
);
const handleDeleteFile = useCallback(
async (path: string) => {
const pid = projectIdRef.current;
if (!pid) return;
const res = await fetch(
`/api/projects/${encodeURIComponent(pid)}/files/${encodeURIComponent(path)}`,
{
method: "DELETE",
},
);
if (res.ok) {
if (editingPathRef.current === path) setEditingFile(null);
await refreshFileTree();
} else {
const err = await res.json().catch(() => ({ error: "unknown" }));
console.error(`Delete failed: ${err.error}`);
showToast(`Couldn't delete ${path}: ${err.error}`, "error");
}
},
[refreshFileTree, showToast],
);
const handleRenameFile = useCallback(
async (oldPath: string, newPath: string) => {
const pid = projectIdRef.current;
if (!pid) return;
const res = await fetch(
`/api/projects/${encodeURIComponent(pid)}/files/${encodeURIComponent(oldPath)}`,
{
method: "PATCH",
headers: { "Content-Type": "application/json" },
body: JSON.stringify({ newPath }),
},
);
if (res.ok) {
if (editingPathRef.current === oldPath) {
handleFileSelect(newPath);
}
await refreshFileTree();
setRefreshKey((k) => k + 1);
} else {
const err = await res.json().catch(() => ({ error: "unknown" }));
console.error(`Rename failed: ${err.error}`);
showToast(`Couldn't rename ${oldPath}: ${err.error}`, "error");
}
},
[refreshFileTree, handleFileSelect, setRefreshKey, showToast],
);
const handleDuplicateFile = useCallback(
async (path: string) => {
const pid = projectIdRef.current;
if (!pid) return;
const res = await fetch(`/api/projects/${encodeURIComponent(pid)}/duplicate-file`, {
method: "POST",
headers: { "Content-Type": "application/json" },
body: JSON.stringify({ path }),
});
if (res.ok) {
const data = await res.json();
await refreshFileTree();
if (data.path) handleFileSelect(data.path);
} else {
const err = await res.json().catch(() => ({ error: "unknown" }));
console.error(`Duplicate failed: ${err.error}`);
showToast(`Couldn't duplicate ${path}: ${err.error}`, "error");
}
},
[refreshFileTree, handleFileSelect, showToast],
);
const handleMoveFile = handleRenameFile;
const handleImportFiles = useCallback(
async (files: FileList | File[], dir?: string) => {
return uploadProjectFiles(Array.from(files), dir);
},
[uploadProjectFiles],
);
const handleImportFonts = useCallback(
async (files: FileList | File[]): Promise<ImportedFontAsset[]> => {
const pid = projectIdRef.current;
if (!pid) return [];
const uploaded = await uploadProjectFiles(
Array.from(files).filter((file) => FONT_EXT.test(file.name)),
"assets/fonts",
);
const imported = uploaded
.filter((asset) => FONT_EXT.test(asset))
.map((asset) => ({
family: fontFamilyFromAssetPath(asset),
path: asset,
url: `/api/projects/${encodeURIComponent(pid)}/preview/${asset}`,
}));
importedFontAssetsRef.current = [
...imported,
...importedFontAssetsRef.current.filter(
(existing) =>
!imported.some((font) => font.family.toLowerCase() === existing.family.toLowerCase()),
),
];
return imported;
},
[uploadProjectFiles],
);
// ── Return ──
return {
// State
editingFile,
setEditingFile,
projectDir,
fileTree,
fileTreeLoaded,
setFileTree,
// Refs
editingPathRef,
projectIdRef,
saveRafRef,
importedFontAssetsRef,
// Core I/O
readProjectFile,
writeProjectFile,
readOptionalProjectFile,
observeProjectFileVersion,
updateEditingFileContent,
// Click-to-source
revealSourceOffset,
openSourceForSelection,
// Callbacks
handleFileSelect,
handleContentChange,
refreshFileTree,
uploadProjectFiles,
handleCreateFile,
handleCreateFolder,
handleDeleteFile,
handleRenameFile,
handleDuplicateFile,
handleMoveFile,
handleImportFiles,
handleImportFonts,
// Derived
compositions,
assets,
fontAssets,
};
}