mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-10-30 17:27:09 +00:00
miga-heygenandMiguel Ángel
e23b3a3e31
* fix(engine): copy border-width/style/color onto the replacement video frame
injectVideoFramesBatch substitutes each <video> with a sibling <img> holding
an extracted still frame, copying an allow-listed set of CSS properties from
the video's computed style onto the img. border-width/border-style/
border-color were absent from that allow-list, so any border authored
directly on a <video> never reached the replacement image and disappeared
from render/snapshot output. border-radius and clip-path were already on the
list and already clip a replaced element's content correctly without
needing overflow:hidden, confirmed by a real-Chromium test that exercises
the actual capture path and reads real screenshot pixels.
Also corrected a stale comment in frameCapture.ts claiming
detectCssEffectRisk can return "clip-path" as a risk value -- it can't; that
string only ever comes from a separate, animation-only at-risk-props gate
further down the same file.
Co-Authored-By: Miguel Ángel <miguel.sierra@heygen.com>
* test(producer): regenerate style-9-prod golden for the border fix
style-9-prod's video has an authored 8px border + 16px border-radius
(design_review.md calls out the "floating" look) that never rendered before
this fix, so its committed golden baked in the pre-fix (borderless) output.
Regenerated via `tsx src/regression-harness.ts style-9-prod --update`;
verified the diff is exactly the border/radius becoming visible (extracted
frames before/after) and the fixture passes its own visual/audio checks
again (100/100 checkpoints, correlation 1.000).
Co-Authored-By: Miguel Ángel <miguel.sierra@heygen.com>
* fix(engine): measure the video's box before styling its replacement frame
injectVideoFramesBatch measured the video's used box (offsetLeft/Top/
Width/Height) after creating, inserting, and styling the replacement
<img> sibling -- once that copy loop started carrying border-width
(added for the border-visibility fix), the freshly-inserted, still
in-flow, now-bordered <img> competed for space in a flex row before
the video's own box was ever read. In a flex-centered layout (video
width:100%, sharing a row with the img sibling), that shrank the
measured video box by the exact width of the border, so the img ended
up sized from the video's post-shrink box instead of its authored one.
Moved the measurement to before the <img> is created/inserted/styled
at all, and set img.style.boxSizing = "border-box" explicitly after
the style-copy loop, since offsetWidth/offsetHeight (and the
getBoundingClientRect fallback) are always a border-box measurement
regardless of what box-sizing value that loop copies from the video's
own computed style.
Added a flex-centered regression test asserting the replacement img's
box stays identical to the video's box; confirmed it fails with the
old measurement order (a 16px border shrinks a 500px box to 484px) and
passes with the fix. Regenerated the one fixture (style-9-prod) whose
committed golden had baked in the shrunk-frame geometry.
Co-Authored-By: Miguel Ángel <miguel.sierra@heygen.com>
* refactor(engine): consolidate video-box measurement into one object
Follow-up to c88890357: group the four measurement locals into a
single videoBox object instead of four loose consts, and trim the
surrounding comments down to their load-bearing content. No behavior
change -- same measurement order, same fallback conditions, same
applied style values; re-verified red (reverting the measurement order
still reproduces the 500px -> 484px shrink) and green.
Co-Authored-By: Miguel Ángel <miguel.sierra@heygen.com>
* refactor(engine): trim the border-fix comments to the invariant
* test(producer): keep main's style-9-prod compiled.html; timings are unchanged
* test(producer): repin the classification source hash for test reachability
* fix(core): a color-graded bordered source keeps its canvas inside its border box
* fix(core): a graded source with an empty content box still shows its border
* fix(core): a border-only graded canvas stays hidden until the source has drawn
* fix(core): border-only graded canvas shows only while grading hides the source
* test(core): pin the border-only canvas hide after a context loss
* fix(core): grading canvas carries no border, so a graded source never paints it twice
* fix(core): graded injected frame drops its border once grading draws over it
* fix(core): a released grading entry gives the injected frame its border back
* fix(core): a released injected frame takes the video's current border style
---------
Co-authored-by: Miguel Ángel <miguel.sierra@heygen.com>
76 lines
4.0 KiB
JSON
76 lines
4.0 KiB
JSON
{
|
|
"guards": {
|
|
"scripts/check-media-use-copy-parity.test.mjs": [
|
|
"skills/media-use/scripts/lib/**",
|
|
"packages/cli/src/media-use/lib/**",
|
|
"scripts/generate-skill-module-copies.mjs",
|
|
"skills/hyperframes/scripts/lib/frame-packets-core.mjs",
|
|
"skills/media-use/audio/scripts/lib/bgm-volume.mjs"
|
|
],
|
|
"scripts/check-test-reachability.test.mjs": [
|
|
".github/workflows/ci.yml",
|
|
"**/package.json",
|
|
"**/*.test.{mjs,ts,tsx}"
|
|
],
|
|
"scripts/creator-editing-capabilities.test.mjs": [
|
|
"skills/**",
|
|
"packages/core/**",
|
|
"packages/engine/**"
|
|
],
|
|
"scripts/registry-primitive-payloads.test.ts": ["registry/**"],
|
|
"scripts/generate-catalog-previews.test.ts": [
|
|
"registry/**",
|
|
"scripts/**",
|
|
"packages/producer/**"
|
|
],
|
|
"scripts/generate-catalog-payloads.test.ts": ["registry/**", "scripts/**"],
|
|
"skills/product-launch-video/scripts/build-frame-subsets.test.mjs": [
|
|
"scripts/generate-captured-font-copies.mjs",
|
|
"skills/product-launch-video/scripts/build-frame.mjs",
|
|
"skills/product-launch-video/scripts/captions.mjs",
|
|
"skills/product-launch-video/scripts/lib/captured-fonts.mjs",
|
|
"skills/faceless-explainer/scripts/build-frame.mjs",
|
|
"skills/faceless-explainer/scripts/captions.mjs",
|
|
"skills/faceless-explainer/scripts/lib/captured-fonts.mjs",
|
|
"skills/pr-to-video/scripts/build-frame.mjs",
|
|
"skills/pr-to-video/scripts/captions.mjs",
|
|
"skills/pr-to-video/scripts/lib/captured-fonts.mjs"
|
|
],
|
|
"scripts/check-skill-import-boundaries.test.mjs": ["skills/**"]
|
|
},
|
|
"runners": [
|
|
{
|
|
"cwd": ".",
|
|
"command": "set -euo pipefail\nmapfile -t SKILLS_TESTS < <(find skills packages/cli/src/media-use -type f -name \"*.test.mjs\" | sort)\nif [ \"${#SKILLS_TESTS[@]}\" -eq 0 ]; then\necho \"::error::No skills/**/*.test.mjs files found. Did the layout change?\"\nexit 1\nfi\nSKILLS_TESTS+=(scripts/check-media-use-copy-parity.test.mjs scripts/creator-editing-capabilities.test.mjs)\nprintf 'Running %d skills test file(s):\\n' \"${#SKILLS_TESTS[@]}\"\nprintf ' * %s\\n' \"${SKILLS_TESTS[@]}\"\nnode --import ./packages/cli/scripts/test-home.mjs --test \"${SKILLS_TESTS[@]}\"",
|
|
"tests": [
|
|
"skills/**/*.test.mjs",
|
|
"packages/cli/src/media-use/**/*.test.mjs",
|
|
"scripts/check-media-use-copy-parity.test.mjs",
|
|
"scripts/creator-editing-capabilities.test.mjs"
|
|
],
|
|
"sources": {},
|
|
"reason": "Shell find plus an explicit parity file; exact command match invalidates this mapping on edits."
|
|
},
|
|
{
|
|
"cwd": ".",
|
|
"command": "bun run producer:test:${{ matrix.lane }}",
|
|
"tests": [
|
|
"packages/producer/src/**/*.test.ts",
|
|
"packages/producer/scripts/test-classification.test.mjs",
|
|
"packages/producer/tests/**/*.test.ts"
|
|
],
|
|
"sources": {
|
|
"packages/producer/scripts/run-test-lane.mjs": "638885e14480d03290803389325a655f3749442167d784e07bb3af3404598af7",
|
|
"packages/producer/scripts/test-classification.mjs": "5cf0848da08f0fd2c40521d1556cfdb00b5a072cbd0ea0bc54945990abb709e4",
|
|
".github/workflows/ci.yml#job#producer-source-tests": "45da72aa6cf08cdfd5bcf5311e89f12af4842f9eebc6735df19da8c02f4d4864",
|
|
"packages/producer/package.json#script#test:unit": "ae6beda8319d166774be958ea5593cd27dbf7f6c9bce1d787a3fe28dfc3477b1",
|
|
"packages/producer/package.json#script#test:integration": "008589f37d026877595a13501cbb66abd5cbe50e21fdcac6904f45466c3f475d",
|
|
"packages/producer/package.json#script#test:classification": "4ad50d88c81de374dd6ef8a53d702a4b1901483837ecd3d833b1cb0c9a29a058",
|
|
"package.json#script#producer:test:unit": "ded6d4183d455d1f414e41d15794c1aef5323e53b5ea5e2ff349e3bb049c18db",
|
|
"package.json#script#producer:test:integration": "8bb545947f4f8fef3bd5c6c9b1bcb394c7c942d7a3ab90cf4540c662572a278e"
|
|
},
|
|
"reason": "Both unit and integration matrix lanes discover tests under src and tests; workflow and runner sources are pinned to invalidate changed selection."
|
|
}
|
|
]
|
|
}
|