mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-04 07:19:52 +00:00
WaterrrForever
7d21cc9b8a
* fix(cli): invalidate the skills nudge cache after a successful install/update/check The passive "N skills out of date or missing" nudge reads a 24h config cache that only the background check (on non-skills commands) ever wrote. The skills commands themselves are excluded from the nudge pipeline, so a successful `skills update`/install/check never refreshed or dropped the cached verdict — the pre-install count kept printing on every other command for up to 24h. Reconcile commands now drop the cached verdict (counts + timestamp) so the next command's background check re-runs for real. The offline presence-only path deliberately keeps the cache: that run learned nothing about freshness. * fix(skills): win32-safe npx spawns in media-use + accurate whisper wording The Whisper transcribe fallback and the Kokoro local-TTS delegation both spawned a bare "npx" via execFileSync — on Windows npx is npx.cmd, which spawn cannot exec, so both paths died with `spawnSync npx ENOENT`. Route them through the skill's existing resolveSpawnCommand (node + npx-cli.js on win32, no shell:true), same as the audio engine's TTS spawns. Also corrects the "bundled with the hyperframes CLI" claim about whisper.cpp: it is resolved from PATH / installed via Homebrew / built from source with git+cmake on first use, and models download from HuggingFace — nothing whisper is shipped in the package. * feat(skills): canonical fully-silent marker + auth status exit-code docs product-launch's Step 3.1 gate said "or the project is marked silent" but nothing defined how to mark one, and audio.mjs unconditionally retrieved BGM. Define the canonical marker — `music: none` in the storyboard's top YAML block, plus no SCRIPT.md — and honor it: audio generate produces nothing (removing stale audio_meta.json, since absence is what assemble treats as silent), and `music: none` with narration keeps TTS while turning BGM off. Also documents the `auth status` exit-code contract (exit 1 while signed out is the normal offline state, not a failure) in the product-launch Step 0 note and the CLI skill's cloud reference. * fix(skills): transient-init retry for standalone animation-map and contrast-report The standalone helpers called initializeSession exactly once, so a valid modular project — whose sub-composition timelines register asynchronously — could hit the readiness deadline and die with the transient "zero duration / Runtime ready: false" diagnostic the render pipeline retries (probeStage). Add initializeSessionWithRetry to the shared package-loader (both byte-identical copies): close the crashed session and retry once with a fresh browser, gated by the engine's canonical isTransientBrowserError — now re-exported from @hyperframes/producer, with a frozen fallback pattern list for older published packages. The "Runtime ready: true" fast-fail (a genuine authoring bug) still fails without a retry. * feat(skills): extend the fully-silent marker to faceless-explainer and pr-to-video Both workflows reuse product-launch's audio model — their Step 3.1 gates carried the same undefined "marked silent" phrase, and their (intentionally identical) audio.mjs copies had the same unconditional BGM retrieve. Port the `music: none` marker handling into both copies, define the marker in their SKILL.md Step 3.1 and story-design references, and turn the copies' "intentionally identical" header claim into a byte-identity pin test so the next fix can't silently miss one of them. * test(cli): reset the prune mock explicitly instead of relying on restoreAllMocks The converge test's toHaveBeenCalledTimes(1) held only because vitest 3's vi.restoreAllMocks() clears vi.fn() call state; vitest 4 restores spies only, so the count would accumulate across tests and fail. Reset pruneOrphanedLockEntries in beforeEach like the other manifest mocks — passes under both vitest 3.2.4 (pinned) and vitest 4. * test(skills): close review findings — package-loader pin, whisper win32 parity, quoted-none Review follow-ups on #2476: - package-loader.mjs byte-identity pin (the elevated concern): the two copies now carry initializeSessionWithRetry + FALLBACK_TRANSIENT_PATTERNS, exactly the shared-logic shape a future fix could land in one copy and miss in the other — same enforcement as the audio.mjs pin. - whisper win32 call-site parity: runWhisper's npx resolution lifted into lib/npx-sync.mjs (resolveNpxInvocation, injectable params matching the localTtsGenerate idiom) with the same three-branch coverage as the Kokoro site — plus the hard-fail contract (throws actionably, since the whisper fallback has no next provider to fall through to). - quoted music: "none" pin: the vendored storyboard parser strips matching quotes at parse time (stripQuotes), so the silent marker already accepts the quoted spelling — pinned so that stays true.
73 lines
2.6 KiB
JavaScript
73 lines
2.6 KiB
JavaScript
import { test } from "node:test";
|
|
import assert from "node:assert/strict";
|
|
import { localTtsGenerate } from "./tts-local-provider.mjs";
|
|
|
|
// Regression: on Windows, a bare "npx" is npx.cmd, which execFileSync cannot
|
|
// exec — the Kokoro delegation failed with `spawnSync npx ENOENT` instead of
|
|
// synthesizing (or cleanly falling through to the next provider). The spawn
|
|
// must route through node + npx-cli.js on win32, same as the audio engine's
|
|
// TTS spawns (see ../../audio/scripts/lib/tts.spawn.test.mjs).
|
|
|
|
const envWithNpxCli = {
|
|
npm_execpath: "C:/Program Files/nodejs/node_modules/npm/bin/npm-cli.js",
|
|
npm_node_execpath: "C:/Program Files/nodejs/node.exe",
|
|
};
|
|
const npxCliPath = "C:/Program Files/nodejs/node_modules/npm/bin/npx-cli.js";
|
|
const pathExists = (path) => path === npxCliPath;
|
|
|
|
test("win32: routes the hyperframes tts call through node + npx-cli, never bare npx", async () => {
|
|
const captured = [];
|
|
const fakeExec = (cmd, args, opts) => {
|
|
captured.push({ cmd, args, opts });
|
|
// Synthesize nothing — the provider then returns null via the
|
|
// missing-output check, which is fine: we only assert the spawn shape.
|
|
};
|
|
|
|
await localTtsGenerate(
|
|
"hello there",
|
|
{ voice: "am_michael" },
|
|
"win32",
|
|
fakeExec,
|
|
envWithNpxCli,
|
|
pathExists,
|
|
);
|
|
|
|
assert.equal(captured.length, 1);
|
|
assert.equal(captured[0].cmd, envWithNpxCli.npm_node_execpath);
|
|
assert.equal(captured[0].args[0], npxCliPath);
|
|
assert.deepEqual(captured[0].args.slice(1, 4), ["hyperframes", "tts", "hello there"]);
|
|
assert.ok(captured[0].args.includes("--voice"));
|
|
// execFileSync options survive the rerouting (pipes are what let the caller
|
|
// read the "kokoro-onnx not installed" hint back out).
|
|
assert.deepEqual(captured[0].opts.stdio, ["ignore", "pipe", "pipe"]);
|
|
});
|
|
|
|
test("win32 without a resolvable npx-cli: falls through to the next provider (null), no spawn", async () => {
|
|
const captured = [];
|
|
const fakeExec = (...call) => captured.push(call);
|
|
|
|
const result = await localTtsGenerate(
|
|
"hello",
|
|
{},
|
|
"win32",
|
|
fakeExec,
|
|
{}, // no npm_execpath, and pathExists finds nothing
|
|
() => false,
|
|
);
|
|
|
|
assert.equal(result, null);
|
|
assert.equal(captured.length, 0);
|
|
});
|
|
|
|
test("non-win32: spawns plain npx unchanged", async () => {
|
|
const captured = [];
|
|
const fakeExec = (cmd, args) => captured.push({ cmd, args });
|
|
|
|
await localTtsGenerate("hola", { lang: "es" }, "darwin", fakeExec, {}, () => false);
|
|
|
|
assert.equal(captured.length, 1);
|
|
assert.equal(captured[0].cmd, "npx");
|
|
assert.deepEqual(captured[0].args.slice(0, 3), ["hyperframes", "tts", "hola"]);
|
|
assert.ok(captured[0].args.includes("--lang"));
|
|
});
|