Files
hyperframes/packages/studio-server/src/helpers/encoderOptions.test.ts
T
James RussoandClaude Opus 5.5 ab8a4da53f feat(studio-server): accept crf, videoBitrate, videoFrameFormat and hdrMode on the render route (#5549)
* feat(studio-server): accept a crf override on the render route

The Studio render route only forwarded draft/standard/high, so a Studio or
desktop export could not ask for a specific CRF the way `hyperframes render
--crf` can. Film-grain finishing passes need CRF 12 to keep the grain.

The route now takes an optional integer `crf` (0-51 for mp4, 0-63 for webm),
rejects an out-of-range value with 400 instead of dropping it, ignores it for
mov, and both Studio adapters pass it to the render job.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* chore(studio-server): keep the crf change free of new comment lines

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* feat(studio-server): accept videoBitrate, videoFrameFormat and hdrMode on the render route

Same options `hyperframes render` already takes (--video-bitrate,
--video-frame-format, --sdr/--hdr), so Studio callers are not limited to
the quality presets. crf and videoBitrate are an either/or, matching the CLI;
an invalid value is a 400. Parsing moves to helpers/encoderOptions.ts.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
2026-10-13 20:09:58 +00:00

44 lines
1.6 KiB
TypeScript

import { describe, expect, it } from "vitest";
import { parseEncoderOptions } from "./encoderOptions";
describe("parseEncoderOptions", () => {
it("returns no overrides for an empty request", () => {
expect(parseEncoderOptions({}, "mp4")).toEqual({ ok: true, options: {} });
});
it("accepts a bitrate for mp4 and webm and ignores rate control for mov", () => {
expect(parseEncoderOptions({ videoBitrate: "10M" }, "mp4")).toEqual({
ok: true,
options: { videoBitrate: "10M" },
});
expect(parseEncoderOptions({ videoBitrate: "2500k" }, "webm").ok).toBe(true);
expect(parseEncoderOptions({ videoBitrate: "10M", crf: 12 }, "mov")).toEqual({
ok: true,
options: {},
});
});
it("rejects crf and videoBitrate together", () => {
expect(parseEncoderOptions({ crf: 12, videoBitrate: "10M" }, "mp4")).toEqual({
ok: false,
error: "use either crf or videoBitrate, not both",
});
});
it.each(["", "10 M", "-5M", "10M; rm", 10])("rejects bitrate %j", (videoBitrate) => {
expect(parseEncoderOptions({ videoBitrate }, "mp4").ok).toBe(false);
});
it("passes frame format and HDR mode through for every format", () => {
expect(parseEncoderOptions({ videoFrameFormat: "png", hdrMode: "force-sdr" }, "mov")).toEqual({
ok: true,
options: { videoFrameFormat: "png", hdrMode: "force-sdr" },
});
});
it("rejects an unknown frame format or HDR mode", () => {
expect(parseEncoderOptions({ videoFrameFormat: "webp" }, "mp4").ok).toBe(false);
expect(parseEncoderOptions({ hdrMode: "on" }, "mp4").ok).toBe(false);
});
});