mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-03 04:38:33 +00:00
* feat(media-use): color grading — grade/lut resolve, smart-grade, grade-compare CLI Add color grading to media-use as first-class resolve types plus a faithful comparison command. All local, offline, deterministic — no model, no GPU. - resolve -t grade / -t lut: produce a data-color-grading block (or a frozen .cube). Look cascade: core preset (no file) -> bundled .cube library -> parametric buildCube. Emitted .cube is Rec.709 and validated against core's colorLuts constraints (LUT_3D_SIZE <= 64) before it is frozen. - smart grade (grade --for <media>): ffmpeg signalstats -> adjust suggestion (exposure / contrast / white balance), surfaced with the measured evidence on stderr as a starting point; never auto-applied. - hyperframes grade-compare: renders N candidate grades onto a reference frame through the real runtime shader into one labeled comparison PNG, so an agent picks a look without opening Studio. Prepends an "original" baseline cell by default (--no-baseline to omit). Shares the headless-capture pipeline with snapshot via capture/captureCompositionFrame. - media-use SKILL: proactive "media opportunity pass" guidance (grounded signal -> offer, ask once, surface don't mutate). Verified: media-use 116/116, grade-compare 7/7, snapshot 9/9, lint + format clean, full build green, comparison renders end to end. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * test(cli): narrow grade-compare baseline assertion off unknown-typed grading Assert the whole cell via toEqual instead of reaching into .grading.preset / .grading.lut on the unknown-typed field, keeping the test typecheck-clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * feat(media-use): agent-authored LUTs via --params + validate --from cube; never-read-.cube guardrail - resolve -t lut / -t grade --params '<json>': build a parametric .cube from explicit params (bypassing the intent cascade), validate, and freeze in one step. --intent becomes the optional description. Lets an agent commit a look it computed itself. - --from <file.cube> now validates the ingested LUT for lut/grade types and rejects an invalid/oversized cube (no partial write) — the escape hatch for a LUT the agent generated with its own code. - SKILL.md: hard rule to never read a .cube body into context (~size^3 lines, zero legible signal) — inspect via grade-compare (see it) or cube-validate (ok/size), read the manifest description for meaning; plus both authoring paths and the parametric-vs-film-stock ceiling note. Verified: media-use 116/116, lint + format clean; smokes — --params builds a valid frozen cube, grade --params returns a lut block, bad JSON and an oversized --from cube are both rejected with no stray file. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * fix(cli): grade-compare validates referenced LUTs, warns on no-op cells, caps candidates Bug-bash follow-ups — grade-compare silently accepted bad input: - Validate LUT *content*, not just existence: each referenced .cube is parsed with core's parseCubeLut (now exported from @hyperframes/core) and rejected with a per-cell error ("LUT for \"<label>\" is not a valid .cube: ..."). A file that exists but isn't a valid cube no longer renders a silent no-op cell. - Warn on inactive cells: a grading that normalizes to inactive (e.g. a malformed {lut:12345}) emits a stderr warning naming the cell; the auto-prepended "original" baseline is intentionally inactive and stays silent. stdout remains valid JSON. - Cap candidates at 16 (excluding baseline): over-cap input renders the first N and reports {truncated:true, total:M} on stdout + a stderr note — no silent drop, no unbounded giant sheet. Verified: grade-compare 10/10; non-cube LUT → clear error; {lut:12345} → warning + ok; 20 cells → cells=17 truncated total=20; valid runs unchanged. Lint/format clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * feat(cli): general `hyperframes compare` visual-variant primitive Generalize grade-compare's "render N variants → one labeled sheet → the agent looks and picks" loop into a standalone command that works on ANY variation (font, layout, motion, grade, whole compositions) — the tool never needs to know what differs. - `hyperframes compare <path...> [--at <sec>] [--labels a,b,c] [--out] [--cols] [--json]`: renders each agent-authored composition variant through the real runtime (captureCompositionFrame) and stitches one labeled comparison sheet + JSON ({ok, sheet, rendered, variants, truncated?/total?}). 2+ paths required; caps at 16 with loud truncation. It presents, it does not judge — choosing is the caller's job. - Factored the shared "render a labeled set → contact sheet" path so compare, grade-compare, and snapshot all sit on it (no duplication). grade-compare is now the first color-specific specialization of this primitive. - New pathArgs util + contactSheet test; hyperframes-cli SKILL documents compare as the agent's "see your own renders and choose" primitive. Verified: 26/26 across compare + grade-compare + snapshot + contactSheet (no regressions); compare renders 3 variants into one visibly-distinct labeled sheet; 2+-path error path clean; lint/format clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * fix(ci): green the skills CI — skip ffmpeg tests when absent, oxfmt markdown The "Test: skills" CI job runs bare `node --test` with no ffmpeg on PATH (by design — skills tests are meant to be node-builtin-only). The grade-analyzer + smart-grade tests shell to ffmpeg and were failing there with ENOENT. Guard them to skip when ffmpeg isn't on PATH; they still run locally / where it is. Also oxfmt README.md + hyperframes/media-use SKILL.md (the whole-repo `oxfmt --check .` Format job caught markdown left unformatted by the rebase conflict resolution). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * fix(ci): skip core-conformance test when tsx is unavailable The "Test: skills" CI job installs no deps, so the normalizeHfColorGrading conformance test (which imports core's TS via `node --import tsx`) failed there. Guard it to skip when tsx can't resolve; runs locally / in the deps-installed Test job. Completes the skills-CI greening (the ffmpeg guards handled the rest). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * fix(cli): escape grade-compare src double-quotes (CodeQL XSS) + Windows-safe compare test - grade-compare built `<img src="...">` (double-quoted) with the single-quote escaper, leaving `"` unescaped — a `"` in the frame path could break out (CodeQL: incomplete HTML attribute sanitization). Use escapeXml for src. - compare label test hard-coded POSIX paths that can't match on Windows; assert the derived labels (the subject); path resolution is covered elsewhere. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * refactor(media-use): generate LUT library from params (drop committed .cube files) The 3 bundled .cube files were 733 lines each (2,199 total) and were themselves buildCube output — pure repo bloat. Replace with compact per-look params in luts/index.json, generated on resolve; add an optional `url` for future scanned LUTs to be CDN-hosted + downloaded on demand (freezeUrl) instead of committed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * feat(media-use): serve library LUTs from CDN on-demand (static.heygen.ai/luts), params fallback Looks now carry a CDN `url` (hosted at s3://heygen-public/luts → static.heygen.ai/luts/<id>.cube); resolve downloads + validates + freezes on demand, like bgm/image. `params` stays as the deterministic offline fallback (--local-only, or if the download fails), so resolution is never blocked on the network. Provider prefers url, falls back to params. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv * fix(media-use): address #2041 review — atomic LUT writes, compare telemetry, follow-ups - Atomic .cube writes: library provider (url + params) and the parametric generator now write to a .tmp path, validate, then rename, so a crash can never orphan an invalid .cube at the final path (was validate-after-write). - track("media_use_resolve") now emits provenance.via (url/params-fallback/params). - grade-compare + compare: --timeout flag (was hardcoded 5000) and a media_use_compare event (cells, truncated, total, render_ready_timed_out); openSettledCompositionPage now surfaces the render-ready timeout. - compare staging skips node_modules/.git; --for gets an upfront existence check. - Rec.709 luma comment; HYPERFRAMES_ANALYZE_TIMEOUT_MS override; measured note uses basename; LUT s3 hosting moved from index.json into luts/README.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01H5k87mPZ4d6yiFwcWSb8Vv --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
166 lines
5.2 KiB
JavaScript
166 lines
5.2 KiB
JavaScript
import { execFileSync } from "node:child_process";
|
|
import { basename, extname } from "node:path";
|
|
|
|
const IMAGE_EXT = new Set([".jpg", ".jpeg", ".png", ".webp", ".gif", ".bmp", ".tif", ".tiff"]);
|
|
const SAMPLE_FRAMES = 5;
|
|
// A long HD clip on slow storage can exceed the default 15s signalstats window;
|
|
// override without a code change via HYPERFRAMES_ANALYZE_TIMEOUT_MS.
|
|
const SIGNALSTATS_TIMEOUT_MS = Number(process.env.HYPERFRAMES_ANALYZE_TIMEOUT_MS) || 15000;
|
|
|
|
const ADJUST_LIMITS = {
|
|
exposure: { min: -2, max: 2 },
|
|
contrast: { min: -1, max: 1 },
|
|
highlights: { min: -1, max: 1 },
|
|
shadows: { min: -1, max: 1 },
|
|
whites: { min: -1, max: 1 },
|
|
blacks: { min: -1, max: 1 },
|
|
temperature: { min: -1, max: 1 },
|
|
tint: { min: -1, max: 1 },
|
|
vibrance: { min: -1, max: 1 },
|
|
saturation: { min: -1, max: 1 },
|
|
};
|
|
|
|
function clamp(value, key) {
|
|
const limit = ADJUST_LIMITS[key];
|
|
if (!Number.isFinite(value)) return 0;
|
|
return Math.min(limit.max, Math.max(limit.min, value));
|
|
}
|
|
|
|
function round(value) {
|
|
return Math.round(value * 1000) / 1000;
|
|
}
|
|
|
|
function avg(values) {
|
|
if (values.length === 0) return 0;
|
|
return values.reduce((sum, value) => sum + value, 0) / values.length;
|
|
}
|
|
|
|
function probeDuration(mediaPath) {
|
|
try {
|
|
const raw = execFileSync(
|
|
"ffprobe",
|
|
["-v", "quiet", "-print_format", "json", "-show_format", mediaPath],
|
|
{ encoding: "utf8", timeout: 5000 },
|
|
);
|
|
const parsed = JSON.parse(raw);
|
|
const duration = Number(parsed.format?.duration);
|
|
return Number.isFinite(duration) && duration > 0 ? duration : null;
|
|
} catch {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
function filterFor(mediaPath) {
|
|
const ext = extname(mediaPath).toLowerCase();
|
|
if (IMAGE_EXT.has(ext)) return "signalstats,metadata=print:file=-";
|
|
const duration = probeDuration(mediaPath);
|
|
if (!duration || duration <= 1) return "signalstats,metadata=print:file=-";
|
|
const fps = Math.max(0.1, Math.min(2, SAMPLE_FRAMES / duration));
|
|
return `fps=${fps.toFixed(4)},signalstats,metadata=print:file=-`;
|
|
}
|
|
|
|
function parseSignalStats(raw) {
|
|
const frames = [];
|
|
let current = null;
|
|
for (const line of String(raw).split(/\r?\n/)) {
|
|
const frameMatch = line.match(/^frame:/);
|
|
if (frameMatch) {
|
|
if (current) frames.push(current);
|
|
current = {};
|
|
continue;
|
|
}
|
|
const match = line.match(/lavfi\.signalstats\.([A-Z]+)=([+-]?(?:\d+(?:\.\d+)?|\.\d+))/);
|
|
if (!match) continue;
|
|
if (!current) current = {};
|
|
current[match[1]] = Number(match[2]);
|
|
}
|
|
if (current) frames.push(current);
|
|
const complete = frames.filter(
|
|
(frame) =>
|
|
Number.isFinite(frame.YMIN) &&
|
|
Number.isFinite(frame.YMAX) &&
|
|
Number.isFinite(frame.YAVG) &&
|
|
Number.isFinite(frame.UAVG) &&
|
|
Number.isFinite(frame.VAVG),
|
|
);
|
|
if (complete.length === 0) {
|
|
throw new Error("no signalstats frames found");
|
|
}
|
|
return {
|
|
frames: complete.length,
|
|
yMin: Math.min(...complete.map((frame) => frame.YMIN)),
|
|
yMax: Math.max(...complete.map((frame) => frame.YMAX)),
|
|
yAvg: avg(complete.map((frame) => frame.YAVG)),
|
|
uAvg: avg(complete.map((frame) => frame.UAVG)),
|
|
vAvg: avg(complete.map((frame) => frame.VAVG)),
|
|
};
|
|
}
|
|
|
|
export function statsToAdjust(stats) {
|
|
const yMin = Number(stats.yMin);
|
|
const yMax = Number(stats.yMax);
|
|
const yAvg = Number(stats.yAvg);
|
|
const uAvg = Number(stats.uAvg);
|
|
const vAvg = Number(stats.vAvg);
|
|
const spread = (yMax - yMin) / 255;
|
|
const normalizedAvg = yAvg / 255;
|
|
const exposure = clamp((0.45 - normalizedAvg) * 1.8, "exposure");
|
|
const contrast = clamp((0.42 - spread) * 0.9, "contrast");
|
|
const whites =
|
|
yMax > 230 ? clamp(-((yMax - 230) / 40 + Math.max(0, normalizedAvg - 0.74)), "whites") : 0;
|
|
const blacks = yMin < 12 ? clamp((12 - yMin) / 80, "blacks") : 0;
|
|
const chromaWarmth = (vAvg - 128 + (128 - uAvg)) / 128;
|
|
const temperature = clamp(-chromaWarmth * 0.7, "temperature");
|
|
const tint = clamp(-(uAvg - 128 + (vAvg - 128)) / 256, "tint");
|
|
|
|
return {
|
|
adjust: {
|
|
exposure: round(exposure),
|
|
contrast: round(contrast),
|
|
blacks: round(blacks),
|
|
whites: round(whites),
|
|
temperature: round(temperature),
|
|
tint: round(tint),
|
|
},
|
|
measured: {
|
|
frames: Number(stats.frames ?? 1),
|
|
yMin: round(yMin),
|
|
yMax: round(yMax),
|
|
yAvg: round(yAvg),
|
|
uAvg: round(uAvg),
|
|
vAvg: round(vAvg),
|
|
},
|
|
};
|
|
}
|
|
|
|
export function analyzeMediaGrade(mediaPath) {
|
|
try {
|
|
const raw = execFileSync(
|
|
"ffmpeg",
|
|
[
|
|
"-hide_banner",
|
|
"-nostdin",
|
|
"-v",
|
|
"error",
|
|
"-i",
|
|
mediaPath,
|
|
"-vf",
|
|
filterFor(mediaPath),
|
|
"-frames:v",
|
|
String(SAMPLE_FRAMES),
|
|
"-f",
|
|
"null",
|
|
"-",
|
|
],
|
|
{ encoding: "utf8", timeout: SIGNALSTATS_TIMEOUT_MS, stdio: ["ignore", "pipe", "pipe"] },
|
|
);
|
|
return statsToAdjust(parseSignalStats(raw));
|
|
} catch (err) {
|
|
throw new Error(`grade analysis failed for ${mediaPath}: ${err.message}`);
|
|
}
|
|
}
|
|
|
|
export function formatMeasuredNote(mediaPath, measured) {
|
|
return `media-use: measured ${basename(mediaPath)}: frames=${measured.frames}, YMIN=${measured.yMin}, YMAX=${measured.yMax}, YAVG=${measured.yAvg}, UAVG=${measured.uAvg}, VAVG=${measured.vAvg}; adjust is a starting suggestion`;
|
|
}
|