mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-04 07:19:52 +00:00
* feat(core): add pure resolveEditingAffordances (edit capabilities + section applicability) * fix(core): replace prohibited as-cast and !-assertions in isIdentityTransform * refactor(studio): consume core resolveEditingAffordances; drop duplicated capability + section logic - affordances.ts: add matrix3d identity-transform branch (was missing, caused test regression) - domEditingLayers: add domEditSelectionToFacts mapper; resolveDomEditCapabilities is now a thin wrapper over core (kept for backward-compat — tests + barrel import it); isTextEditableSelection delegates to core sections.text; drop parsePx + isIdentityTransform imports (now in core) - PropertyPanel: import resolveEditingAffordances + domEditSelectionToFacts; compute sections once; replace isMediaElement/isColorGradingCapableElement/timing inline check with sections.* - propertyPanelMediaSection: delete isMediaElement (no remaining callers) - propertyPanelColorGradingSection: delete isColorGradingCapableElement (no remaining callers) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * feat(sdk): add browser-only resolveElementAffordances adapter over core * fix(sdk): add position to inlineStyles, replace ! assertion with guard in test - Add missing 'position' key to inlineStyles in affordances.ts to match computedStyles - Replace non-null assertion (doc.defaultView!) with proper null guard in test Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com> * fix(editing): resolve code-review findings on affordances feature Max-effort review (8 verified findings) fixes: Correctness regressions (studio behavior): - SVG selection crash: dropped `classNames` from EditableElementFacts entirely (it was never read by the resolver), which removes the `.className.split()` calls that throw on SVGElement (className is an SVGAnimatedString, not a string). Masked in tests by happy-dom. - Timing panel hidden for GSAP-only layers: domEditSelectionToFacts now takes animationCount from the caller; PropertyPanel feeds the live gsapAnimations prop (selection.gsapAnimations is never populated). Cleanups: - Removed dead inline `position` key from SDK adapter (core reads position only from computedStyles). - Added sections-only `resolveEditingSections` export; PropertyPanel uses it so panel re-renders no longer re-run the capability geometry parse. - Declared happy-dom in packages/sdk devDependencies (was root-hoist only). - Deduped the two capability fact-construction sites behind a shared capabilityFacts() helper. - parsePx now has a single source of truth in core; studio domEditingDom re-exports it so the copies can't drift. isIdentityTransform is now core-internal (studio's only consumer moved to core in the prior task). bun.lock also reconciles stale 0.7.17->0.7.21 package versions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
225 lines
7.5 KiB
TypeScript
225 lines
7.5 KiB
TypeScript
import { useState } from "react";
|
|
import { Check, ClipboardList, Film, Music } from "../../icons/SystemIcons";
|
|
import type { DomEditSelection } from "./domEditing";
|
|
import {
|
|
formatNumericValue,
|
|
formatTimingValue,
|
|
LABEL,
|
|
parseNumericValue,
|
|
RESPONSIVE_GRID,
|
|
} from "./propertyPanelHelpers";
|
|
import { Section, SegmentedControl, SelectField, SliderControl } from "./propertyPanelPrimitives";
|
|
|
|
export function MediaSection({
|
|
projectDir,
|
|
element,
|
|
styles,
|
|
onSetStyle,
|
|
onSetAttribute,
|
|
onSetHtmlAttribute,
|
|
}: {
|
|
projectDir: string | null;
|
|
element: DomEditSelection;
|
|
styles: Record<string, string>;
|
|
onSetStyle: (prop: string, value: string) => void | Promise<void>;
|
|
onSetAttribute: (attr: string, value: string) => void | Promise<void>;
|
|
onSetHtmlAttribute: (attr: string, value: string | null) => void | Promise<void>;
|
|
}) {
|
|
const isVideo = element.tagName === "video";
|
|
const el = element.element;
|
|
|
|
const volume = parseNumericValue(element.dataAttributes.volume ?? "") ?? 1;
|
|
const volumePercent = Math.round(volume * 100);
|
|
|
|
const mediaStart =
|
|
Number.parseFloat(
|
|
element.dataAttributes["media-start"] ?? element.dataAttributes["playback-start"] ?? "0",
|
|
) || 0;
|
|
|
|
const hasLoop = el.hasAttribute("loop");
|
|
const hasMuted = el.hasAttribute("muted");
|
|
const hasAudio = element.dataAttributes["has-audio"] === "true";
|
|
|
|
const playbackRate = Number.parseFloat(element.dataAttributes["playback-rate"] ?? "1") || 1;
|
|
|
|
const objectFit = styles["object-fit"] || "contain";
|
|
const objectPosition = styles["object-position"] || "center";
|
|
|
|
const sourceDuration =
|
|
Number.parseFloat(element.dataAttributes["source-duration"] ?? "") ||
|
|
(el as HTMLMediaElement).duration ||
|
|
0;
|
|
const mediaStartMax = Math.max(30, Math.ceil(sourceDuration || mediaStart + 10));
|
|
|
|
const srcAttr = el.getAttribute("src") ?? "";
|
|
const [copied, setCopied] = useState(false);
|
|
|
|
const absoluteSrc =
|
|
projectDir && srcAttr && !srcAttr.startsWith("http") ? `${projectDir}/${srcAttr}` : srcAttr;
|
|
|
|
return (
|
|
<Section
|
|
title={isVideo ? "Video" : "Audio"}
|
|
icon={isVideo ? <Film size={15} /> : <Music size={15} />}
|
|
>
|
|
<div className="space-y-4">
|
|
{srcAttr && (
|
|
<div className="min-w-0">
|
|
<div className="flex items-center justify-between gap-2">
|
|
<div className="text-[11px] font-medium text-neutral-500">Source</div>
|
|
<button
|
|
type="button"
|
|
onClick={() => {
|
|
void navigator.clipboard.writeText(absoluteSrc).then(() => {
|
|
setCopied(true);
|
|
setTimeout(() => setCopied(false), 1500);
|
|
});
|
|
}}
|
|
className="flex h-6 items-center gap-1 rounded-lg border border-neutral-700 bg-neutral-950 px-2 text-[10px] font-medium text-neutral-400 transition-colors hover:border-neutral-600 hover:text-neutral-200"
|
|
>
|
|
{copied ? <Check size={11} /> : <ClipboardList size={11} />}
|
|
<span>{copied ? "Copied" : "Copy"}</span>
|
|
</button>
|
|
</div>
|
|
<div
|
|
className="mt-1 truncate text-[11px] font-medium text-neutral-300"
|
|
title={absoluteSrc}
|
|
>
|
|
{absoluteSrc}
|
|
</div>
|
|
</div>
|
|
)}
|
|
|
|
<div className="grid min-w-0 gap-1.5">
|
|
<span className={LABEL}>Volume</span>
|
|
<SliderControl
|
|
value={volumePercent}
|
|
min={0}
|
|
max={100}
|
|
step={1}
|
|
displayValue={`${volumePercent}%`}
|
|
formatDisplayValue={(next) => `${Math.round(next)}%`}
|
|
onCommit={(next) => {
|
|
void onSetAttribute("volume", formatNumericValue(next / 100));
|
|
}}
|
|
/>
|
|
</div>
|
|
|
|
<div className="grid min-w-0 gap-1.5">
|
|
<span className={LABEL}>Playback rate</span>
|
|
<SliderControl
|
|
value={playbackRate * 100}
|
|
min={25}
|
|
max={300}
|
|
step={5}
|
|
displayValue={`${formatNumericValue(playbackRate)}x`}
|
|
formatDisplayValue={(next) => `${formatNumericValue(next / 100)}x`}
|
|
onCommit={(next) => {
|
|
void onSetAttribute("playback-rate", formatNumericValue(next / 100));
|
|
}}
|
|
/>
|
|
</div>
|
|
|
|
<div className="grid min-w-0 gap-1.5">
|
|
<span className={LABEL}>Media start</span>
|
|
<SliderControl
|
|
value={Math.round(mediaStart * 100)}
|
|
min={0}
|
|
max={mediaStartMax * 100}
|
|
step={10}
|
|
displayValue={formatTimingValue(mediaStart)}
|
|
formatDisplayValue={(next) => formatTimingValue(next / 100)}
|
|
onCommit={(next) => {
|
|
void onSetAttribute("media-start", (next / 100).toFixed(2));
|
|
}}
|
|
/>
|
|
</div>
|
|
|
|
<div className={RESPONSIVE_GRID}>
|
|
<div className="grid min-w-0 gap-1.5">
|
|
<span className={LABEL}>Loop</span>
|
|
<SegmentedControl
|
|
value={hasLoop ? "on" : "off"}
|
|
onChange={(next) => {
|
|
void onSetHtmlAttribute("loop", next === "on" ? "true" : null);
|
|
}}
|
|
options={[
|
|
{ label: "On", value: "on" },
|
|
{ label: "Off", value: "off" },
|
|
]}
|
|
/>
|
|
</div>
|
|
<div className="grid min-w-0 gap-1.5">
|
|
<span className={LABEL}>Muted</span>
|
|
<SegmentedControl
|
|
value={hasMuted ? "on" : "off"}
|
|
onChange={(next) => {
|
|
void onSetHtmlAttribute("muted", next === "on" ? "true" : null);
|
|
}}
|
|
options={[
|
|
{ label: "On", value: "on" },
|
|
{ label: "Off", value: "off" },
|
|
]}
|
|
/>
|
|
</div>
|
|
</div>
|
|
|
|
{isVideo && (
|
|
<div className="grid min-w-0 gap-1.5">
|
|
<span className={LABEL}>Has audio track</span>
|
|
<SegmentedControl
|
|
value={hasAudio ? "yes" : "no"}
|
|
onChange={(next) => {
|
|
if (next === "yes") {
|
|
void onSetAttribute("has-audio", "true");
|
|
void onSetHtmlAttribute("muted", null);
|
|
} else {
|
|
void onSetAttribute("has-audio", "");
|
|
void onSetHtmlAttribute("muted", "true");
|
|
}
|
|
}}
|
|
options={[
|
|
{ label: "Yes", value: "yes" },
|
|
{ label: "No", value: "no" },
|
|
]}
|
|
/>
|
|
</div>
|
|
)}
|
|
|
|
{isVideo && (
|
|
<>
|
|
<div className={RESPONSIVE_GRID}>
|
|
<SelectField
|
|
label="Fit"
|
|
value={objectFit}
|
|
onChange={(next) => {
|
|
void onSetStyle("object-fit", next);
|
|
}}
|
|
options={["contain", "cover", "fill", "none", "scale-down"]}
|
|
/>
|
|
<SelectField
|
|
label="Position"
|
|
value={objectPosition}
|
|
onChange={(next) => {
|
|
void onSetStyle("object-position", next);
|
|
}}
|
|
options={[
|
|
"center",
|
|
"top",
|
|
"bottom",
|
|
"left",
|
|
"right",
|
|
"left top",
|
|
"right top",
|
|
"left bottom",
|
|
"right bottom",
|
|
]}
|
|
/>
|
|
</div>
|
|
</>
|
|
)}
|
|
</div>
|
|
</Section>
|
|
);
|
|
}
|