mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-19 11:26:02 +00:00
* fix(parsers): find helper programs by walking PATH in-process The trusted lookup ran `which` by name through the full PATH before applying the trusted-folder rule, so a relative or project-local PATH entry could supply the lookup program itself. Walk the trusted PATH folders in-process on every platform, as Windows already did, for findTrustedExecutable, findFfBinary and the doctor's unzip check. The walk keeps what `which` did for valid installs: first match in PATH order, regular files only, and a leading `~` in a PATH entry read as the home folder. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cli): start the media-use engine with the Windows working-directory lookup off mediaUseEngineEnv now sets NoDefaultCurrentDirectoryInExePath for the engine on Windows itself instead of relying on the CLI's own environment, and keeps a value the person set. When no PATH folder passes the trusted rule, PATH names a folder that is never created rather than an empty value, which a shell or execvp reads as the working directory. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(skills): helper scripts skip the Windows working-directory program lookup On Windows a program started by name is looked up in the working directory before PATH. The plugin launcher and the media-use, hyperframes and figma helper scripts run inside project folders and start ffmpeg, ffprobe, Python and other tools by name, either through the launcher or directly from a standalone skill install. Each skill now ships a small module that sets NoDefaultCurrentDirectoryInExePath for the process (keeping a value the person set), and every script that starts programs imports it first, so the helpers and every program they start skip the working directory. Tools installed on PATH resolve as before; macOS and Linux are unaffected. A test checks that each such script loads the module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(cli): ship the Windows lookup guard with the CLI's media-use scripts The CLI build replaces the published media-use scripts/lib folder with packages/cli/src/media-use/lib. That folder had no windows-exe-search.mjs, so every bundled media-use script that imports it, including the engine behind `hyperframes media-use`, failed to load on every platform. The guard is now a generated copy in the CLI lib, next to the skill copies. A parity test checks that each scripts/lib module a published media-use script imports exists in the CLI lib. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(skills): load the win32 stub by file URL so the launcher test runs on Windows On Windows, `node --import D:\...` reads the drive letter as a URL scheme and fails before the launcher starts. The test now passes a file URL and reports the child's stderr when it exits non-zero. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * fix(skills): resolve the Python helper's ffmpeg and drop relative PATH entries extract-audio-data.py ran ffmpeg by bare name, which Windows looks up in the working directory first. It now runs the absolute path that trusted_program.find_program finds in absolute PATH folders outside the working directory. A miss raises the same FileNotFoundError as before. On macOS and Linux the shared guard now drops relative and empty PATH entries, which point into the project folder, and leaves absolute ones in order. If none is absolute, PATH is unset rather than left empty. The guard census now also requires every skill Python script that imports subprocess to resolve programs through trusted_program. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * test(skills): satisfy the Python UTF-8 and ffprobe argv sweeps trusted_program.py carries the same UTF-8 stdio pin as every skill Python script. The guard test's planted-program probe uses a literal-only argv, which the ffprobe argv contract test reads as a capability check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
166 lines
6.5 KiB
TypeScript
166 lines
6.5 KiB
TypeScript
import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs";
|
|
import { tmpdir } from "node:os";
|
|
import { dirname, join } from "node:path";
|
|
import { afterEach, expect, it, vi } from "vitest";
|
|
import { ensureWhisper, findWhisper, WhisperUnavailableError } from "./manager.js";
|
|
const calls = vi.hoisted(() => ({ exec: vi.fn() }));
|
|
vi.mock("node:child_process", () => ({ execFileSync: calls.exec }));
|
|
vi.mock("node:os", async (original) => ({
|
|
...(await original<typeof import("node:os")>()),
|
|
platform: () => "darwin",
|
|
}));
|
|
const isTool = (command: string, name: string) =>
|
|
new RegExp(`(^|[\\\\/])${name}(\\.exe)?$`, "i").test(command);
|
|
const temps: string[] = [];
|
|
afterEach(() => {
|
|
vi.unstubAllEnvs();
|
|
calls.exec.mockReset();
|
|
for (const dir of temps.splice(0)) rmSync(dir, { recursive: true, force: true });
|
|
});
|
|
|
|
// The lookup walks PATH in-process, so PATH holds only the tools a test wants found.
|
|
function pathWith(...tools: string[]): string {
|
|
const bin = mkdtempSync(join(tmpdir(), "hf-whisper-path-"));
|
|
temps.push(bin);
|
|
for (const tool of tools) {
|
|
const file = join(bin, process.platform === "win32" ? `${tool}.exe` : tool);
|
|
writeFileSync(file, "", { mode: 0o755 });
|
|
}
|
|
vi.stubEnv("PATH", bin);
|
|
return bin;
|
|
}
|
|
it("never installs when the runtime vanishes after discovery and installation is disabled", async () => {
|
|
const dir = mkdtempSync(join(tmpdir(), "hf-missing-runtime-"));
|
|
const binary = join(dir, "whisper-cli");
|
|
writeFileSync(binary, "runtime");
|
|
vi.stubEnv("HYPERFRAMES_WHISPER_PATH", binary);
|
|
pathWith("brew", "git", "cmake");
|
|
calls.exec.mockImplementation(() => {
|
|
throw new Error("not available");
|
|
});
|
|
try {
|
|
expect(findWhisper()?.executablePath).toBe(binary);
|
|
rmSync(binary);
|
|
await expect(ensureWhisper({ installRuntime: false })).rejects.toBeInstanceOf(
|
|
WhisperUnavailableError,
|
|
);
|
|
expect(
|
|
calls.exec.mock.calls.filter(([command]) =>
|
|
["brew", "git", "cmake"].some((name) => isTool(command, name)),
|
|
),
|
|
).toEqual([]);
|
|
} finally {
|
|
rmSync(dir, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
it("clones whisper.cpp inside its build dir, with no cache path on the command line", async () => {
|
|
const cache = mkdtempSync(join(tmpdir(), "hf-whisper-cache-"));
|
|
vi.stubEnv("HYPERFRAMES_CACHE_DIR", cache);
|
|
vi.resetModules();
|
|
const { ensureWhisper: ensure, WhisperUnavailableError: Unavailable } =
|
|
await import("./manager.js");
|
|
pathWith("git", "cmake");
|
|
calls.exec.mockImplementation((command: string, args: string[]) => {
|
|
if (isTool(command, "git") && args[0] === "clone") throw new Error("stop after the clone");
|
|
return "";
|
|
});
|
|
try {
|
|
await expect(ensure()).rejects.toBeInstanceOf(Unavailable);
|
|
const clone = calls.exec.mock.calls.find(([c, a]) => isTool(c, "git") && a[0] === "clone");
|
|
const [, args, options] = clone as [string, string[], { cwd?: string }];
|
|
expect(args.some((arg) => arg.includes(cache))).toBe(false);
|
|
expect(options.cwd).toBe(join(cache, "whisper", "whisper.cpp"));
|
|
} finally {
|
|
rmSync(cache, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
it("builds only the reviewed whisper.cpp commit", async () => {
|
|
const cache = mkdtempSync(join(tmpdir(), "hf-whisper-cache-"));
|
|
vi.stubEnv("HYPERFRAMES_CACHE_DIR", cache);
|
|
vi.resetModules();
|
|
const { ensureWhisper: ensure } = await import("./manager.js");
|
|
pathWith("git", "cmake");
|
|
calls.exec.mockImplementation((command: string, args: string[]) => {
|
|
if (isTool(command, "git") && args[0] === "rev-parse") return "0123456789abcdef\n";
|
|
return "";
|
|
});
|
|
try {
|
|
await expect(ensure()).rejects.toThrow();
|
|
const clone = calls.exec.mock.calls.find(([c, a]) => isTool(c, "git") && a[0] === "clone");
|
|
expect((clone as [string, string[]])[1]).toEqual(expect.arrayContaining(["--branch"]));
|
|
expect(calls.exec.mock.calls.some(([command]) => isTool(command, "cmake"))).toBe(false);
|
|
} finally {
|
|
rmSync(cache, { recursive: true, force: true });
|
|
}
|
|
});
|
|
|
|
it.skipIf(process.platform === "win32")(
|
|
"installs with the brew the trusted lookup approved, by its path",
|
|
async () => {
|
|
const cache = mkdtempSync(join(tmpdir(), "hf-whisper-cache-"));
|
|
vi.stubEnv("HYPERFRAMES_CACHE_DIR", cache);
|
|
vi.stubEnv("HYPERFRAMES_WHISPER_PATH", "");
|
|
vi.resetModules();
|
|
const { ensureWhisper: ensure } = await import("./manager.js");
|
|
const bin = pathWith("brew");
|
|
calls.exec.mockImplementation(() => {
|
|
throw new Error("not available");
|
|
});
|
|
try {
|
|
await expect(ensure()).rejects.toThrow();
|
|
const runs = calls.exec.mock.calls.map(([command]) => command as string);
|
|
expect(runs).toContain(join(bin, "brew"));
|
|
expect(runs).not.toContain("brew");
|
|
} finally {
|
|
rmSync(cache, { recursive: true, force: true });
|
|
}
|
|
},
|
|
);
|
|
|
|
it("names the missing build tool when whisper.cpp cannot be built", async () => {
|
|
vi.stubEnv("HYPERFRAMES_CACHE_DIR", mkdtempSync(join(tmpdir(), "hf-whisper-cache-")));
|
|
pathWith("git");
|
|
vi.resetModules();
|
|
const { ensureWhisper: ensure } = await import("./manager.js");
|
|
calls.exec.mockImplementation(() => "");
|
|
await expect(ensure()).rejects.toThrow(/cannot build whisper\.cpp: cmake not found on PATH/);
|
|
});
|
|
|
|
it("gives a Linux user one runnable line to get a working engine", async () => {
|
|
vi.resetModules();
|
|
vi.doMock("node:os", async (original) => ({
|
|
...(await original<typeof import("node:os")>()),
|
|
platform: () => "linux",
|
|
}));
|
|
const { getInstallInstructions } = await import("./manager.js");
|
|
expect(getInstallInstructions()).toContain("sudo apt-get install -y git cmake build-essential");
|
|
vi.doUnmock("node:os");
|
|
});
|
|
|
|
it("gives a Windows user one runnable winget line, and finds a Release-built whisper-cli.exe", async () => {
|
|
const cache = mkdtempSync(join(tmpdir(), "hf-whisper-cache-"));
|
|
vi.stubEnv("HYPERFRAMES_CACHE_DIR", cache);
|
|
vi.resetModules();
|
|
vi.doMock("node:os", async (original) => ({
|
|
...(await original<typeof import("node:os")>()),
|
|
platform: () => "win32",
|
|
}));
|
|
try {
|
|
const { getInstallInstructions, findWhisper } = await import("./manager.js");
|
|
expect(getInstallInstructions()).toContain("winget install -e --id Kitware.CMake");
|
|
pathWith();
|
|
calls.exec.mockImplementation(() => {
|
|
throw new Error("not available");
|
|
});
|
|
const exe = join(cache, "whisper", "whisper.cpp", "build", "bin", "Release", "whisper-cli.exe");
|
|
mkdirSync(dirname(exe), { recursive: true });
|
|
writeFileSync(exe, "binary");
|
|
expect(findWhisper()?.executablePath).toBe(exe);
|
|
} finally {
|
|
vi.doUnmock("node:os");
|
|
rmSync(cache, { recursive: true, force: true });
|
|
}
|
|
});
|