Files
hyperframes/packages/gcp-cloud-run/src/sdk/validateConfig.test.ts
T
James RussoandClaude Opus 4.8 4da567df22 feat(gcp-cloud-run): Google Cloud Run + Workflows distributed render adapter (#1253)
* feat(gcp-cloud-run): add Google Cloud Run + Workflows distributed render adapter

Adds @hyperframes/gcp-cloud-run, the GCP counterpart to @hyperframes/aws-lambda
(issue #932). The OSS distributed primitives (plan, renderChunk x N, assemble)
are unchanged; this package is the storage/compute/orchestration glue.

Package: Cloud Run handler (one image, three actions), runs under bun; GCS
transport; in-image chrome-headless-shell resolver; client SDK
(renderToCloudRun, getRenderProgress, deploySite, computeRenderCost); Dockerfile;
Cloud Workflows definition; Terraform module; CLI cloudrun
deploy|sites|render|render-batch|progress|destroy with --output-resolution and
--strict-variables; 62 unit tests + docs + live smoke script.

Shared extraction (removes ~640 lines of adapter duplication): move the
cloud-agnostic config validator + content-hash into producer/distributed; both
adapters import them. Validated end-to-end on GCP at 37.4 dB PSNR vs baseline.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(cli): resolve @hyperframes/gcp-cloud-run in the CLI build + root build

The CLI bundle (esbuild) couldn't resolve `@hyperframes/gcp-cloud-run/sdk`,
failing Build/Typecheck/CLI-smoke (and the perf/windows/regression jobs that
build first). Mirror the aws-lambda handling: mark the gcp adapter + its /sdk
subpath external in tsup.config.ts with a source alias, and add gcp-cloud-run
to the root `build` filter so its dist exists for publish + runtime.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(ci): copy gcp-cloud-run manifest in Dockerfile.test for frozen install

The regression test image runs `bun install --frozen-lockfile` after copying
each workspace package.json individually. The CLI now depends on
@hyperframes/gcp-cloud-run (workspace:*), so the frozen install fails to
resolve it unless its manifest is present. Add the COPY line.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* feat(cli): add machine-sizing flags to `cloudrun deploy`

Closes the parity gap with `lambda deploy` (which exposes --memory etc.).
`cloudrun deploy` now threads --cpu, --memory, --max-instances, and --timeout
into the Terraform apply; omitted flags keep the module defaults
(4 vCPU / 16Gi / 100 instances / 3600s). For finer control, apply the module
directly.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(gcp-cloud-run): address PR review (security, waste, limits, alerts)

- server.ts: bucket-allowlist guard no longer fails open silently. Unset env
  logs a one-time WARNING; "*" is an explicit opt-out; otherwise it enforces.
- server.ts: stop double-shipping audio.aac. It already rides in the plan
  tarball every consumer downloads, so drop the redundant standalone upload
  (plan) + re-download/overwrite (assemble); assemble reads it from the untar,
  falling back to a supplied AudioGcsUri for compat.
- server.ts: chunk extension via path.extname() instead of slice(lastIndexOf).
- workflow.yaml: clamp parallel concurrency_limit to math.min(chunkCount, 20)
  — Cloud Workflows hard-caps concurrent iterations at 20.
- Dockerfile: pin bun (bun-v1.3.9) so an interop change can't silently break
  the image rebuild.
- terraform: add min_instances var (default 0); add a workflow-failure alert
  (finished_execution_count status=FAILED) alongside the request-count one.
- costAccounting: document that displayCost excludes GCS storage/egress.

Verified against the actual APIs: @google-cloud/workflows@4.4.0
ICreateExecutionRequest has no executionId (so the idempotency-token suggestion
isn't available in this client); Workflows concurrency cap is 20; failure
metric is workflows.googleapis.com/finished_execution_count (status label).
174 adapter tests pass, fallow/oxlint/oxfmt/terraform clean.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(gcp-cloud-run): address round-2 review — error code + CFR forwarding

- workflow.yaml: rename the zero-chunk failure code PLAN_TOO_LARGE →
  PLAN_PRODUCED_ZERO_CHUNKS. The old code implied a size-ceiling breach (the
  opposite cause), misleading anyone triaging the alert.
- workflow.yaml: forward Config.cfr to the assemble step
  (`Cfr: ${("cfr" in config) and config.cfr}`). It was read by the handler
  but never sent, so exact-CFR was silently off for every Cloud Run render.
  Uses the same `in`-operator guard already proven in the retryable predicate.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(release): include gcp-cloud-run in set-version PACKAGES list

set-version.ts (driven by release:prepare) bumps an explicit package list to
the shared version on each release. gcp-cloud-run was wired into the build +
publish.yml but missing here, so a release would leave it at a stale version
and publish.yml would push the wrong version. Add it so the new package
version-bumps + publishes in lockstep with the others.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-07 14:43:38 -07:00

120 lines
3.6 KiB
TypeScript

/**
* `validateDistributedRenderConfig` + `validateWorkflowsInputSize` unit
* tests. Pins the shape rejections the SDK surfaces synchronously before a
* Cloud Workflows execution starts.
*/
import { describe, expect, it } from "bun:test";
import type { SerializableDistributedRenderConfig } from "../events.js";
import {
InvalidConfigError,
MAX_WORKFLOWS_INPUT_BYTES,
validateDistributedRenderConfig,
validateVariablesPayload,
validateWorkflowsInputSize,
} from "./validateConfig.js";
function base(): SerializableDistributedRenderConfig {
return {
fps: 30,
width: 1920,
height: 1080,
format: "mp4",
} as SerializableDistributedRenderConfig;
}
describe("validateDistributedRenderConfig", () => {
it("accepts a minimal valid config", () => {
expect(validateDistributedRenderConfig(base())).toBeDefined();
});
it("rejects a bad fps", () => {
expect(() => validateDistributedRenderConfig({ ...base(), fps: 25 } as never)).toThrow(
/config\.fps/,
);
});
it("rejects odd dimensions (yuv420p)", () => {
expect(() => validateDistributedRenderConfig({ ...base(), width: 1921 })).toThrow(/even/);
});
it("rejects an out-of-range dimension", () => {
expect(() => validateDistributedRenderConfig({ ...base(), height: 8 })).toThrow(/\[16, 7680\]/);
});
it("rejects an unknown format", () => {
expect(() => validateDistributedRenderConfig({ ...base(), format: "gif" as never })).toThrow(
/config\.format/,
);
});
it("rejects codec with a non-mp4 format", () => {
expect(() =>
validateDistributedRenderConfig({ ...base(), format: "webm", codec: "h264" } as never),
).toThrow(/only valid with format="mp4"/);
});
it("rejects crf + bitrate together", () => {
expect(() =>
validateDistributedRenderConfig({ ...base(), crf: 20, bitrate: "10M" } as never),
).toThrow(/mutually exclusive/);
});
it("rejects force-hdr", () => {
expect(() =>
validateDistributedRenderConfig({ ...base(), hdrMode: "force-hdr" as never }),
).toThrow(/force-sdr/);
});
it("rejects an over-cap chunkSize", () => {
expect(() => validateDistributedRenderConfig({ ...base(), chunkSize: 5000 } as never)).toThrow(
/<= 3600/,
);
});
it("throws InvalidConfigError with a field pointer", () => {
try {
validateDistributedRenderConfig({ ...base(), fps: 1 } as never);
throw new Error("should have thrown");
} catch (err) {
expect(err).toBeInstanceOf(InvalidConfigError);
expect((err as InvalidConfigError).field).toBe("config.fps");
}
});
});
describe("validateVariablesPayload", () => {
it("accepts a plain JSON object", () => {
expect(() =>
validateVariablesPayload({ title: "Hi", count: 3, nested: { ok: true } }),
).not.toThrow();
});
it("rejects undefined leaves", () => {
expect(() => validateVariablesPayload({ a: undefined })).toThrow(/undefined leaves/);
});
it("rejects a top-level array", () => {
expect(() => validateVariablesPayload([1, 2])).toThrow(/plain JSON object/);
});
it("rejects NaN", () => {
expect(() => validateVariablesPayload({ x: NaN })).toThrow(/non-finite/);
});
it("rejects a Date (non-plain object)", () => {
expect(() => validateVariablesPayload({ when: new Date(0) })).toThrow(/non-plain objects/);
});
});
describe("validateWorkflowsInputSize", () => {
it("accepts a small payload", () => {
expect(() => validateWorkflowsInputSize({ a: "b" })).not.toThrow();
});
it("rejects a payload over the 512 KiB cap", () => {
const big = { blob: "x".repeat(MAX_WORKFLOWS_INPUT_BYTES + 1) };
expect(() => validateWorkflowsInputSize(big)).toThrow(/512 KiB/);
});
});