mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-11 23:00:03 +00:00
* refactor(core): retire recast/babel, route all GSAP mutations to acorn (WS-E/3.F) - Delete gsapParser.ts (2595-line recast-based parser/writer) - Delete gsapParser.test.ts, gsapParser.stress.test.ts, gsapParser.test-helpers.ts - Add gsapParserExports.ts: re-export umbrella for gsap-parser subpath - Move SplitAnimationsOptions/SplitAnimationsResult to gsapSerialize.ts - executeGsapMutation: async->sync, static acorn imports replace loadGsapParser() - Fix 3 function name mismatches in files.ts switch cases - generators/hyperframes.ts: imports from gsapSerialize (blocker resolved) - gsapWriterAcorn.ts: SplitAnimationsOptions from gsapSerialize - Parity tests: recast oracle removed; acorn-only regression (14 pass) - Remove recast and @babel/parser from core/package.json Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(sdk): harden mutation handlers + widen variable API (code-review) Self-contained review fixes for the SDK-hotspot stack (#1569–#1573). The dispatch path (_dispatch → applyOp) never runs validateOp, so the new WS-D/WS-3.C guards were advisory-only; re-enforce them in the handlers. - addElement: null-guard the resolved parent (no more `as Element` masking a null → crash on unknown parent id); reject <script> and multi-root fragments via parseInsertableFragment instead of inserting raw markup / silently dropping extra roots. - addWithKeyframes / replaceWithKeyframes: bail on empty keyframes (no degenerate `keyframes: {}` tween) and when the animationId resolves to nothing (no silent degrade-to-add leaving a duplicate tween). - isObjectVariableValue: exclude arrays so an array override value can't be misclassified as a font/image object and written into the variable model. - Composition.setVariableValue: widen the public interface signature to `… | FontValue | ImageValue` to match the impl + EditOp (B2 object-valued variables were unreachable via the typed API). - mutate.gsap.test.ts: import addKeyframeToScript from gsap-writer-acorn — the gsap-parser subpath no longer re-exports write fns after recast retire, so the test threw at runtime (red suite). - Dedup: export EXCLUDED_TAGS from hfIds.ts and drop the verbatim HF_EXCLUDED_TAGS copy in mutate.ts. Adds guard regression tests. SDK 340/340, core hfIds 13/13, build green, fallow --gate new-only clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(sdk): variable-model dedup + undo/scoped-parent correctness; test honesty (code-review) Second batch of review fixes for the SDK-hotspot stack. - Variable model (#7, #13): extract readVariableDefault/writeVariableDefault into a shared engine/variableModel.ts used by both mutate.ts (forward) and apply-patches.ts (replay), so the model shape can't diverge. Add clearVariableDefault and make a `variable` remove patch DELETE the decl's `default` key — the exact inverse of a first-set on a default-less variable. Previously undo of such a set no-op'd and stranded the value. - addElement scoped parent (#8): record the caller's id verbatim (scoped "hf-host/hf-leaf" path or composition id) as the patch parentId instead of the bare data-hf-id, so redo/replay re-resolves the SAME parent via resolveScoped rather than the canonical top-level dup (or document.body). - resolveTimings honesty (#5): correct the header + test that claimed a live "preview == render" parity — neither path consumes the resolver yet (anchor inputs are Pacific/backend-deferred). It's a pure-function property, not a current guarantee. - GSAP writer parity (#12): the recast oracle was deleted in WS-3.F, leaving the WS-3.C keyframe ops comparing acorn output to itself. Pin them as golden inline snapshots and drop the now-dead recast scaffolding (replaceWithKfRecast, removeAnimRecast alias). Remaining pre-WS-3.C parity blocks noted as follow-up. Adds regression tests (undo of default-less variable; scoped-parent redo). SDK 342/342, core timingResolver+parity green, build + fallow --gate new-only clean. Not changed (need design / out of scope): #9 pre-#1569 persisted-override CSS replay (moot for unreleased data; proper fix is render-time CSS derivation), #11 replaceWithKeyframes stale positional id (mitigated by the missing-id no-op guard + type doc; full fix needs non-positional ids). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(sdk): replay CSS-prop derivation for legacy var overrides; stale-id selector guard (code-review) Final review-fix batch — the two items deferred from the prior pass. - #9 legacy variable-override CSS: applyOverrideSet now derives the `--{id}` CSS custom prop from any scalar `var.{id}` override on replay (and removes it for a null override). Sets written before the model/CSS split carried only `var.{id}`; without this, replaying them updated the JSON model but left `var(--{id})` bindings rendering the schema default. Replay-path only — the undo path (applyOne) is untouched, so #1569's separate-patch undo correctness is preserved. Object (font/image) values are never CSS, so they are skipped. - #11 stale positional id: replaceWithKeyframes now requires the located animation to still target the caller's `targetSelector`. Position-derived ids re-point after structural edits; a stale id resolving to a DIFFERENT element's tween previously got silently replaced. It now bails (no-op) unless the id still points at the expected selector. Adds regression tests (legacy var.{id}-only override restores CSS; object override writes no CSS; stale-id-wrong-selector replace is a no-op). SDK 345/345, build + fallow --gate new-only clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(core): gate acorn GSAP writer behind cutover flag; keep recast default (WS-3F) Product decision pivot: acorn no longer replaces recast as the GSAP writer. Recast remains the default server writer; acorn runs only when STUDIO_SDK_CUTOVER_ENABLED=true (or =1) is set server-side — the same env flag name as the client Vite var, so a single switch flips both sides. Changes: - Restore gsapParser.ts (recast writer) + test/stress/helper files deleted by 3F - Restore @babel/parser + recast deps in packages/core/package.json - Add isAcornGsapWriterEnabled() + loadGsapParser() to files.ts (lines 59-82) - Split executeGsapMutation into async dispatcher + executeGsapMutationRecast (recast, async via loadGsapParser) + executeGsapMutationAcorn (acorn, sync) - Dispatcher defaults to recast; acorn branch taken only when flag is on - Restore gsapWriter.parity.test.ts, gsapWriterParity.acorn.test.ts, and gsapWriterParity.corpus.test.ts to true recast-vs-acorn differential suites (not acorn-vs-itself) - Exempt gsapParser.ts in .fallowrc.jsonc health.ignore + ignoreExports (pre-existing complexity + barrel re-exports consumed outside diff scope) - Add fallow-ignore-file code-duplication to files.ts (intentional parallel switch bodies for two writers) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
153 lines
6.5 KiB
TypeScript
153 lines
6.5 KiB
TypeScript
/**
|
|
* T6a — GSAP parser golden tests (baseline for the Recast → Meriyah swap).
|
|
*
|
|
* These snapshots capture the exact output of parseGsapScript +
|
|
* serializeGsapAnimations under Recast/Babel before any parser change.
|
|
* When the Meriyah swap lands, run `vitest --update-snapshots` to regenerate
|
|
* and diff the goldens — any change is a regression candidate.
|
|
*
|
|
* Three representative scripts:
|
|
* minimal — 2 tl.to calls, simple numeric selectors (macos-notification)
|
|
* moderate — 6 tl.to calls, multiple selectors (yt-lower-third)
|
|
* complex — stagger, chained .from()/.to(), const/defaults (vpn-youtube-spot)
|
|
*/
|
|
import { beforeAll, describe, expect, it } from "vitest";
|
|
import { join } from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
import { parseGsapScriptAcorn as parseGsapScript } from "./gsapParserAcorn.js";
|
|
import { serializeGsapAnimations } from "./gsapSerialize.js";
|
|
|
|
const __goldens__ = join(fileURLToPath(import.meta.url), "..", "__goldens__");
|
|
const g = (name: string) => join(__goldens__, name);
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Corpus scripts (inline so goldens are not coupled to registry file changes)
|
|
// ---------------------------------------------------------------------------
|
|
|
|
const MINIMAL_SCRIPT = `\
|
|
var tl = gsap.timeline({ paused: true });
|
|
var notification = document.getElementById("notification");
|
|
gsap.set(notification, { x: 420, opacity: 0 });
|
|
tl.to(notification, { x: 0, opacity: 1, duration: 0.5, ease: "power3.out" }, 0.2);
|
|
tl.to(notification, { x: 420, opacity: 0, duration: 0.3, ease: "power3.in" }, 4.2);
|
|
window.__timelines["macos-notification"] = tl;`;
|
|
|
|
const MODERATE_SCRIPT = `\
|
|
window.__timelines = window.__timelines || {};
|
|
var tl = gsap.timeline({ paused: true });
|
|
var card = document.getElementById("card");
|
|
var btn = document.getElementById("subscribe-btn");
|
|
var textSub = document.getElementById("btn-subscribe");
|
|
var textSubd = document.getElementById("btn-subscribed");
|
|
gsap.set(card, { y: 300, opacity: 0 });
|
|
tl.to(card, { y: 0, opacity: 1, duration: 0.5, ease: "power3.out" }, 0.1);
|
|
tl.to(btn, { scale: 0.92, duration: 0.15, ease: "power2.out" }, 1.0);
|
|
tl.to(btn, { scale: 1, duration: 0.4, ease: "elastic.out(1, 0.4)" }, 1.15);
|
|
tl.to(textSub, { opacity: 0, duration: 0.08, ease: "none" }, 1.15);
|
|
tl.to(textSubd, { opacity: 1, duration: 0.08, ease: "none" }, 1.18);
|
|
tl.to(card, { y: 300, opacity: 0, duration: 0.25, ease: "power3.in" }, 3.8);
|
|
window.__timelines["yt-lower-third"] = tl;`;
|
|
|
|
const COMPLEX_SCRIPT = `\
|
|
window.__timelines = window.__timelines || {};
|
|
gsap.defaults({ force3D: true });
|
|
const tl = gsap.timeline({ paused: true, defaults: { duration: 0.45, ease: "power3.out" } });
|
|
tl.from(".headline span", { y: 46, opacity: 0, stagger: 0.055, duration: 0.38, ease: "back.out(1.35)" }, 0.05)
|
|
.from(".headline .sub", { y: 20, opacity: 0, duration: 0.28 }, 0.2)
|
|
.from(".ambient-word", { scale: 0.92, opacity: 0, duration: 0.5 }, 0.08)
|
|
.from(".ambient-line", { scaleX: 0, opacity: 0, stagger: 0.08, duration: 0.42 }, 0.16);
|
|
window.__timelines["vpn-youtube-spot"] = tl;`;
|
|
|
|
// fromTo: exercises the three-argument (fromArg, toArg, position) AST path and
|
|
// negative numeric literals (UnaryExpression arm in resolveNode).
|
|
const FROMTO_SCRIPT = `\
|
|
var tl = gsap.timeline({ paused: true });
|
|
var hero = document.getElementById("hero");
|
|
var caption = document.getElementById("caption");
|
|
tl.fromTo(hero, { x: -200, opacity: 0 }, { x: 0, opacity: 1, duration: 0.6, ease: "power3.out" }, 0.1);
|
|
tl.fromTo(caption, { y: -30, opacity: 0 }, { y: 0, opacity: 1, duration: 0.45 }, 0.5);
|
|
window.__timelines["hero-reveal"] = tl;`;
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Helpers
|
|
// ---------------------------------------------------------------------------
|
|
|
|
function parseAndSerialize(script: string): { parsed: string; serialized: string } {
|
|
const result = parseGsapScript(script);
|
|
const serialized = serializeGsapAnimations(result.animations, result.timelineVar, {
|
|
preamble: result.preamble,
|
|
postamble: result.postamble,
|
|
});
|
|
return { parsed: JSON.stringify(result, null, 2), serialized };
|
|
}
|
|
|
|
// ---------------------------------------------------------------------------
|
|
// Golden tests
|
|
// ---------------------------------------------------------------------------
|
|
|
|
describe("T6a — GSAP parser golden tests (Recast/Babel baseline)", () => {
|
|
describe("minimal — 2 tl.to calls (macos-notification)", () => {
|
|
let parsed: string;
|
|
let serialized: string;
|
|
beforeAll(() => {
|
|
({ parsed, serialized } = parseAndSerialize(MINIMAL_SCRIPT));
|
|
});
|
|
|
|
it("parseGsapScript output matches golden", async () => {
|
|
await expect(parsed).toMatchFileSnapshot(g("minimal.parsed.json"));
|
|
});
|
|
|
|
it("serializeGsapAnimations output matches golden", async () => {
|
|
await expect(serialized).toMatchFileSnapshot(g("minimal.serialized.js"));
|
|
});
|
|
});
|
|
|
|
describe("moderate — 6 tl.to calls, multiple selectors (yt-lower-third)", () => {
|
|
let parsed: string;
|
|
let serialized: string;
|
|
beforeAll(() => {
|
|
({ parsed, serialized } = parseAndSerialize(MODERATE_SCRIPT));
|
|
});
|
|
|
|
it("parseGsapScript output matches golden", async () => {
|
|
await expect(parsed).toMatchFileSnapshot(g("moderate.parsed.json"));
|
|
});
|
|
|
|
it("serializeGsapAnimations output matches golden", async () => {
|
|
await expect(serialized).toMatchFileSnapshot(g("moderate.serialized.js"));
|
|
});
|
|
});
|
|
|
|
describe("complex — stagger + chained .from() calls (vpn-youtube-spot)", () => {
|
|
let parsed: string;
|
|
let serialized: string;
|
|
beforeAll(() => {
|
|
({ parsed, serialized } = parseAndSerialize(COMPLEX_SCRIPT));
|
|
});
|
|
|
|
it("parseGsapScript output matches golden", async () => {
|
|
await expect(parsed).toMatchFileSnapshot(g("complex.parsed.json"));
|
|
});
|
|
|
|
it("serializeGsapAnimations output matches golden", async () => {
|
|
await expect(serialized).toMatchFileSnapshot(g("complex.serialized.js"));
|
|
});
|
|
});
|
|
|
|
describe("fromTo — two tl.fromTo calls with negative positions (hero-reveal)", () => {
|
|
let parsed: string;
|
|
let serialized: string;
|
|
beforeAll(() => {
|
|
({ parsed, serialized } = parseAndSerialize(FROMTO_SCRIPT));
|
|
});
|
|
|
|
it("parseGsapScript output matches golden", async () => {
|
|
await expect(parsed).toMatchFileSnapshot(g("fromto.parsed.json"));
|
|
});
|
|
|
|
it("serializeGsapAnimations output matches golden", async () => {
|
|
await expect(serialized).toMatchFileSnapshot(g("fromto.serialized.js"));
|
|
});
|
|
});
|
|
});
|