mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-09-08 19:06:04 +00:00
Vance IngallsandClaude Sonnet 4.6
8d6b7cf515
* feat(core): clip-model hf- ids minted at parse, emitted as data-hf-id (R1) * docs(core): document legacy-id round-trip in clip-model readback (R1 review) Addresses Rames' review on #1270: clarifies that a pre-R1 clip authored with id="my-title" round-trips as data-hf-id="my-title" (non-hf-shaped but stable, exact-match) by design — targeting uses exact [data-hf-id="…"] match and does not require the hf- shape; legacy values re-mint only at the R7 write-back. Not a bug. Comment-only. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs(core): fix misleading legacy-id migration comment in htmlParser.ts The original comment said legacy data-hf-id values "are re-minted only once the R7 write-back persists freshly-minted ids to source" — which is incorrect. ensureHfIds skips elements that already carry data-hf-id, so legacy values (e.g. data-hf-id="my-title") persist indefinitely and are NOT automatically re-minted. Exact-match targeting still works correctly. Update comment to reflect actual behaviour. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test(core): update htmlParser tests for R1 hf- id minting Pre-R1 tests expected clip ids to reflect legacy `id=` attributes. After R1, ensureHfIds runs first and mints data-hf-id — so clip.id reflects the minted hf- value unless the element already has data-hf-id. Fix: add explicit data-hf-id to test HTML elements where tests assert specific id values. Update no-id test to expect hf- format (/^hf-[a-z0-9]{4}$/) instead of the pre-R1 generated-id fallback (/^element-\d+$/). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
119 lines
5.3 KiB
TypeScript
119 lines
5.3 KiB
TypeScript
/**
|
|
* @vitest-environment jsdom
|
|
*
|
|
* T2 — Stable id spec (spec for R1).
|
|
*
|
|
* These tests define what "stable hf- id" means BEFORE R1 implements it.
|
|
* They are intentionally red until R1 lands.
|
|
*
|
|
* Currently failing (spec): tests 1, 2, 3 — parser assigns `element-N` not `hf-xxxx`.
|
|
* Currently passing (baseline): tests 4, 5, 6, 7 — these already hold and must not regress.
|
|
*
|
|
* Scope: id assignment and stability only. Round-trip fidelity is T1 territory.
|
|
*/
|
|
import { describe, expect, it } from "vitest";
|
|
import { parseHtml } from "./htmlParser.js";
|
|
import { serialize } from "./test-utils.js";
|
|
|
|
describe("T2 — stable element ids (spec for R1)", () => {
|
|
// --- Spec (red until R1) ---
|
|
|
|
it("[spec] elements without an id get a hf- prefixed id at parse", () => {
|
|
const html = `<html><body><div id="stage">
|
|
<img src="logo.svg" data-start="0" data-end="5" data-name="Logo" />
|
|
<div data-start="0" data-end="5" data-name="Card"><div>Text</div></div>
|
|
</div></body></html>`;
|
|
const { elements } = parseHtml(html);
|
|
for (const el of elements) {
|
|
expect(el.id).toMatch(/^hf-/);
|
|
}
|
|
});
|
|
|
|
it("[spec] generated hf- ids match /^hf-[a-z0-9]{4}$/", () => {
|
|
const html = `<html><body><div id="stage">
|
|
<div data-start="0" data-end="5" data-name="Unnamed"><div>X</div></div>
|
|
<video data-start="1" data-end="6" src="v.mp4" data-name="Clip"></video>
|
|
</div></body></html>`;
|
|
const { elements } = parseHtml(html);
|
|
const noPreExistingId = elements.filter((e) => e.id !== "stage");
|
|
for (const el of noPreExistingId) {
|
|
expect(el.id).toMatch(/^hf-[a-z0-9]{4}$/);
|
|
}
|
|
});
|
|
|
|
it("[spec] adding an element before existing ones does not change existing ids", () => {
|
|
const base = `<html><body><div id="stage">
|
|
<div data-start="0" data-end="5" data-name="AlphaEl"><div>A</div></div>
|
|
<div data-start="1" data-end="6" data-name="BetaEl"><div>B</div></div>
|
|
</div></body></html>`;
|
|
const withPrepend = `<html><body><div id="stage">
|
|
<div data-start="0" data-end="4" data-name="NewEl"><div>New</div></div>
|
|
<div data-start="0" data-end="5" data-name="AlphaEl"><div>A</div></div>
|
|
<div data-start="1" data-end="6" data-name="BetaEl"><div>B</div></div>
|
|
</div></body></html>`;
|
|
const baseAlpha = parseHtml(base).elements.find((e) => e.name === "AlphaEl");
|
|
const extendedAlpha = parseHtml(withPrepend).elements.find((e) => e.name === "AlphaEl");
|
|
expect(baseAlpha).toBeDefined();
|
|
expect(extendedAlpha).toBeDefined();
|
|
// With counter-based ids: base AlphaEl = element-1, extended AlphaEl = element-2 — FAILS.
|
|
// With hf- stable ids: both = same hf-xxxx — PASSES (R1 target).
|
|
expect(extendedAlpha?.id).toBe(baseAlpha?.id);
|
|
});
|
|
|
|
// --- Baseline (already pass, must not regress) ---
|
|
|
|
it("existing data-hf-id is pinned and becomes the clip id (never re-minted)", () => {
|
|
const html = `<html><body><div id="stage">
|
|
<div data-hf-id="hf-anch" data-start="0" data-end="5" data-name="Title"><div>Hi</div></div>
|
|
</div></body></html>`;
|
|
const { elements } = parseHtml(html);
|
|
expect(elements.some((e) => e.id === "hf-anch")).toBe(true);
|
|
});
|
|
|
|
it("ids are deterministic: same input produces same ids on re-parse", () => {
|
|
const html = `<html><body><div id="stage">
|
|
<div data-start="0" data-end="5" data-name="A"><div>A</div></div>
|
|
<div data-start="0" data-end="5" data-name="B"><div>B</div></div>
|
|
</div></body></html>`;
|
|
const first = parseHtml(html).elements.map((e) => e.id);
|
|
const second = parseHtml(html).elements.map((e) => e.id);
|
|
expect(first).toEqual(second);
|
|
});
|
|
|
|
it("ids are unique within a document", () => {
|
|
const html = `<html><body><div id="stage">
|
|
<div data-start="0" data-end="3" data-name="A"><div>A</div></div>
|
|
<div data-start="1" data-end="4" data-name="B"><div>B</div></div>
|
|
<div data-start="2" data-end="5" data-name="C"><div>C</div></div>
|
|
</div></body></html>`;
|
|
const ids = parseHtml(html).elements.map((e) => e.id);
|
|
expect(new Set(ids).size).toBe(ids.length);
|
|
});
|
|
|
|
it("two elements with identical markup get distinct ids (no content-hash collision)", () => {
|
|
// Ensures R1's id derivation includes position or a sibling counter,
|
|
// not just content — two structurally identical elements must not collide.
|
|
const html = `<html><body><div id="stage">
|
|
<div data-start="0" data-end="5" data-name="X"><div>Same</div></div>
|
|
<div data-start="0" data-end="5" data-name="X"><div>Same</div></div>
|
|
</div></body></html>`;
|
|
const { elements } = parseHtml(html);
|
|
const ids = elements.map((e) => e.id);
|
|
expect(new Set(ids).size).toBe(ids.length);
|
|
});
|
|
|
|
it("ids survive a serialize → re-parse round-trip", () => {
|
|
const html = `<html><body><div id="stage">
|
|
<div id="my-anchor" data-start="0" data-end="5" data-name="Anchor"><div>Content</div></div>
|
|
<img src="photo.jpg" data-start="1" data-end="8" data-name="Photo" />
|
|
</div></body></html>`;
|
|
const original = parseHtml(html);
|
|
const reparsed = parseHtml(serialize(original));
|
|
const origIds = original.elements.map((e) => e.id).sort();
|
|
const roundIds = reparsed.elements.map((e) => e.id).sort();
|
|
expect(roundIds).toEqual(origIds);
|
|
});
|
|
|
|
it.todo("sub-composition instances get scoped ids (compositionId/hf-x) — requires SDK session");
|
|
});
|