mirror of
https://github.com/heygen-com/hyperframes.git
synced 2026-11-15 13:58:20 +00:00
Miguel Ángel
a5c2636e8c
* fix(cli): use normalizeErrorMessage so validate/inspect never print "[object Object]" The validate and inspect (layout) commands formatted thrown values with `err instanceof Error ? err.message : String(err)`. When a browser/CDP/ Puppeteer protocol error or a structured page error reaches the formatter as a plain object without a string `message`, `String(obj)` yields the useless literal "[object Object]", hiding the real cause. Route those paths through the existing shared `normalizeErrorMessage` helper, which returns an Error's message, a string as-is, an object's `.message` when present, or a compact JSON serialization otherwise (with a key-list and String fallback for circular/opaque objects). Also fold the duplicated local `errorMessage` helpers in batchRender and preview into the same shared helper. Covered by added assertions in errorMessage.test.ts for the no-message object and Puppeteer-style protocol-error object cases. * fix(cli): route remaining browser/process error sites through normalizeErrorMessage The validate/inspect fix routed only those two commands through the shared normalizeErrorMessage helper. The same err instanceof Error ? err.message : String(err) pattern survived in the other commands that drive a headless browser or an external process (ffmpeg, Docker, CDP) or surface a network API error, so a thrown structured object without a string message would still render as the useless literal [object Object]. Route those sites through the shared helper: snapshot.ts (the closest sibling to validate/inspect, same bug class), render.ts (Chrome launch + Docker build), capture/index.ts and commands/capture.ts (page-driven extraction), auth/browser.ts, browser/manager.ts (Puppeteer browser resolution), and the cloud/lambda paths (cloud/render.ts, cloudrun.ts, lambda/render-batch.ts, lambda/policies.ts, cloud/detectAspectRatio.ts) that surface API/network error objects. Only the message-deriving expression changes; control flow and error propagation are untouched. capture/index.ts keeps appending the stack for real Errors and only routes the non-Error branch. Adds a helper test for a structured CDP-style error object (code + nested data, no message).
38 lines
1.2 KiB
TypeScript
38 lines
1.2 KiB
TypeScript
/**
|
|
* Open a URL in the user's default browser. Falls back to printing the
|
|
* URL when no browser is openable (SSH session, CI, `BROWSER=none`,
|
|
* or `open` rejects).
|
|
*/
|
|
|
|
import { c } from "../ui/colors.js";
|
|
import { normalizeErrorMessage } from "../utils/errorMessage.js";
|
|
|
|
export interface OpenBrowserResult {
|
|
/** True when we successfully invoked the platform "open" command. */
|
|
opened: boolean;
|
|
}
|
|
|
|
export async function openBrowser(url: string): Promise<OpenBrowserResult> {
|
|
if (process.env["BROWSER"] === "none" || process.env["HF_NO_BROWSER"] === "1") {
|
|
printManualInstructions(url);
|
|
return { opened: false };
|
|
}
|
|
try {
|
|
const open = (await import("open")).default;
|
|
await open(url);
|
|
return { opened: true };
|
|
} catch (err) {
|
|
printManualInstructions(url, normalizeErrorMessage(err));
|
|
return { opened: false };
|
|
}
|
|
}
|
|
|
|
function printManualInstructions(url: string, detail?: string): void {
|
|
if (detail) {
|
|
console.error(c.warn(`Could not open browser automatically (${detail}).`));
|
|
} else {
|
|
console.error(c.warn("Browser auto-open is disabled."));
|
|
}
|
|
console.error(`Open this URL manually to continue:\n ${c.accent(url)}`);
|
|
}
|