Files
hyperframes/scripts/check-no-main-deletions.mjs
T
Miguel Ángel 68b61675ed feat(studio): upgrade Studio to Tailwind CSS v4 (#3618)
* chore(studio): upgrade Tailwind CSS to v4 through the Vite plugin

Studio moves from Tailwind 3.4 to 4.3.3, loaded by @tailwindcss/vite instead
of PostCSS. The JS config becomes an @theme block in studio.css carrying the
same studio.* and panel.* colors, with explicit @source globs so the gitignored
data/projects tree is never scanned.

The official upgrade tool renamed the utilities, but it rewrites bare words
inside any string, so its edits to event names, CSS property names, filter
function names, status enum values and prose were reverted by hand.

Nothing in Studio relied on the v3 default border color, ring width or ring
color, so the tool's compatibility shim was dropped rather than kept.

* chore(studio): note the duplicated palette between theme css and preset

* fix(studio): keep the pointer cursor on buttons after the Tailwind v4 upgrade

v4 preflight dropped the pointer cursor on enabled buttons, so add it back in
one base rule. Also migrate the last outline-none to outline-hidden.

* fix(studio): keep the Renders Export button at its shipped 14px size

* chore(studio): allow the tailwind v4 config deletions in the deletion guard
2026-09-19 03:07:19 -04:00

305 lines
13 KiB
JavaScript

#!/usr/bin/env node
/**
* Fail if this branch would delete files that exist on the base.
*
* Written after a scare that turned out to be a measurement error, which is
* the reason it uses the three-dot form. Comparing tip to tip (two dots) on a
* branch that is a month behind reports every file main added since the merge
* base as a deletion: 1,284 of them, including an entire skills tree. None of
* that is real. A merge keeps main's side, and a pull request shows the
* three-dot diff, which reported zero.
*
* So this exists to catch deletions a branch genuinely proposes, and to make
* the distinction hard to get wrong again. If it ever disagrees with a manual
* git diff, check which form the manual one used before believing it.
*
* Renames are reported separately. In a name-only diff a rename is
* indistinguishable from a deletion, so treating them alike would either mask
* real loss or block every legitimate move.
*
* node scripts/check-no-main-deletions.mjs [--base origin/main]
*/
import { execFileSync } from "node:child_process";
const BASE_FLAG = "--base";
/**
* Deletions this repository has already agreed to, each with the reason.
*
* A blanket escape hatch (a flag, an env var, `--force`) would turn the guard
* off exactly when it matters, because the branch deleting something by
* accident is also the branch that would reach for it. Naming each path here
* instead keeps the default absolute and makes every intentional removal a
* reviewable line in a diff.
*
* Entries are for deletions that are NOT renames — git already pairs those on
* its own. Remove an entry once its deletion has landed on the base.
*/
const STORYBOARD_VIEW_REASON =
"owner-directed removal of the Studio storyboard view; its only readers were deleted with it";
export const ALLOWED_DELETIONS = new Map([
[
"packages/studio/src/components/StudioGlobalDragOverlay.tsx",
"the full-screen drop-to-add box is replaced by a landing preview on the timeline; no remaining references",
],
[
"packages/studio/postcss.config.js",
"Tailwind v4 migration: postcss replaced by @tailwindcss/vite",
],
[
"packages/studio/tailwind.config.js",
"Tailwind v4 migration: config moves into styles/studio.css via @theme",
],
[
"docs/snippets/catalog-overview-player.jsx",
"#4051 removes the Catalog overview's only consumer of this snippet (replaced by the browse-grid mount); confirmed unreferenced repo-wide before deleting",
],
[
"packages/studio/src/hooks/useSdkSession.test.ts",
"tests only shouldReloadSdkSession, a function with no production callers removed with the preview reload fix",
],
[
"docs/catalog/components/ai-generation-canvas.mdx",
"owner-directed removal of the AI Generation Canvas catalog item and its generated documentation",
],
[
"docs/catalog/components/ai-prompt-flow.mdx",
"owner-directed removal of the AI Prompt Flow catalog item and its generated documentation",
],
[
"docs/catalog/components/checkout-flow.mdx",
"owner-directed removal of the Checkout Flow catalog item and its generated documentation",
],
[
"docs/public/catalog/components/ai-generation-canvas.json",
"owner-directed removal of the AI Generation Canvas catalog item and its generated public payload",
],
[
"docs/public/catalog/components/ai-prompt-flow.json",
"owner-directed removal of the AI Prompt Flow catalog item and its generated public payload",
],
[
"docs/public/catalog/components/checkout-flow.json",
"owner-directed removal of the Checkout Flow catalog item and its generated public payload",
],
[
"registry/components/ai-generation-canvas/ai-generation-canvas.html",
"owner-directed removal of the AI Generation Canvas catalog source component",
],
[
"registry/components/ai-generation-canvas/demo.html",
"owner-directed removal of the AI Generation Canvas catalog preview source",
],
[
"registry/components/ai-generation-canvas/registry-item.json",
"owner-directed removal of the AI Generation Canvas catalog registry entry",
],
[
"registry/components/ai-prompt-flow/ai-prompt-flow.html",
"owner-directed removal of the AI Prompt Flow catalog source component",
],
[
"registry/components/ai-prompt-flow/demo.html",
"owner-directed removal of the AI Prompt Flow catalog preview source",
],
[
"registry/components/ai-prompt-flow/registry-item.json",
"owner-directed removal of the AI Prompt Flow catalog registry entry",
],
[
"registry/components/checkout-flow/checkout-flow.html",
"owner-directed removal of the Checkout Flow catalog source component",
],
[
"registry/components/checkout-flow/demo.html",
"owner-directed removal of the Checkout Flow catalog preview source",
],
[
"registry/components/checkout-flow/registry-item.json",
"owner-directed removal of the Checkout Flow catalog registry entry",
],
[
"packages/studio/src/components/StudioFeedbackBar.tsx",
"replaced by components/feedback/StudioFeedbackCard.tsx; too little shared content for git to pair as a rename",
],
[
"skills/embedded-captions/references/test-set.md",
"#3219: orphaned in the shipped skill (zero inbound references across all 140 files) and its corpus lives only at ~/Downloads/heygen_relevant_videos/, so it was neither reachable nor runnable on any install",
],
[
"skills/embedded-captions/themes/PORTING.md",
"#3219: same, zero inbound references; a theme-authoring procedure whose inputs (cap_fx3 demos, frame corpora, CONTRACT.md) are not distributed with the skill",
],
[
"packages/core/scripts/build-audio-fx-runtime.ts",
"merged into build-inline-artifact.ts: this and build-position-edits-render.ts were a byte-for-byte clone differing only in five names, which fallow's duplication check kept re-flagging on every unrelated line shift",
],
[
"packages/core/scripts/build-position-edits-render.ts",
"merged into build-inline-artifact.ts, same reason as build-audio-fx-runtime.ts above",
],
[
"packages/core/scripts/build-inline-artifact.ts",
"a later branch in this stack (wa-20b2-lfo-fixes) independently deduped the same two build scripts a different way — buildInjectedArtifact.ts plus two thin per-target files — before this consolidation and that one had merged; this branch's tree keeps that shape instead, so build-inline-artifact.ts is the one that goes.",
],
[
"packages/studio/src/hooks/useAudioSoloBridge.ts",
"#3453 removes the obsolete solo bridge after its last consumer leaves",
],
[
"packages/studio/src/hooks/useGroupLevel.ts",
"#3454 deliberately removes the group level meter with the group volume strip",
],
[
"packages/studio/src/player/components/TimelineGroupBusStrip.test.tsx",
"#3454 deliberately removes the group volume and level-meter strip and its tests",
],
[
"packages/studio/src/player/components/TimelineGroupBusStrip.tsx",
"#3454 deliberately removes the group volume and level-meter strip",
],
[
"packages/studio/src/player/components/TimelineSoloButton.tsx",
"#3454 deliberately removes track and group solo controls",
],
[
"packages/studio/src/player/store/audioSoloSlice.test.ts",
"#3454 deliberately removes session solo state and its tests",
],
[
"packages/studio/src/player/store/audioSoloSlice.ts",
"#3454 deliberately removes session solo state",
],
[
"packages/studio/src/player/store/groupLevels.ts",
"#3454 deliberately removes group level-meter state",
],
[
"docs/public/catalog/components/texture-mask-text.json",
"the item's directory exceeds the host budget and now falls back to its recorded video; the stale payload had no <base href> and dead relative asset references, so removing it is the fix, not the regression",
],
[
"packages/studio/src/player/hooks/useExpandedTimelineElements.ts",
"the timeline shows top-level rows only, so the child-row expansion hook is replaced by useTimelineRowElements",
],
[
"packages/studio/src/player/hooks/useExpandedTimelineElements.test.ts",
"tests for the removed child-row expansion hook",
],
...[
"docs/studio/storyboard.mdx",
"packages/studio-server/src/routes/storyboard.test.ts",
"packages/studio-server/src/routes/storyboard.ts",
"packages/studio/fixtures/storyboard-sample/README.md",
"packages/studio/fixtures/storyboard-sample/SCRIPT.md",
"packages/studio/fixtures/storyboard-sample/STORYBOARD.md",
"packages/studio/fixtures/storyboard-sample/compositions/frames/01-hook.html",
"packages/studio/fixtures/storyboard-sample/compositions/frames/02-problem.html",
"packages/studio/fixtures/storyboard-sample/compositions/frames/03-feature.html",
"packages/studio/fixtures/storyboard-sample/compositions/frames/04-proof.html",
"packages/studio/fixtures/storyboard-sample/index.html",
"packages/studio/src/components/storyboard/AgentChatMessageButton.test.tsx",
"packages/studio/src/components/storyboard/AgentChatMessageButton.tsx",
"packages/studio/src/components/storyboard/FramePoster.test.tsx",
"packages/studio/src/components/storyboard/FramePoster.tsx",
"packages/studio/src/components/storyboard/StoryboardDirection.tsx",
"packages/studio/src/components/storyboard/StoryboardFrameFocus.tsx",
"packages/studio/src/components/storyboard/StoryboardFrameTile.tsx",
"packages/studio/src/components/storyboard/StoryboardGrid.tsx",
"packages/studio/src/components/storyboard/StoryboardLoaded.tsx",
"packages/studio/src/components/storyboard/StoryboardReviewGuide.tsx",
"packages/studio/src/components/storyboard/StoryboardScriptPanel.tsx",
"packages/studio/src/components/storyboard/StoryboardSourceEditor.tsx",
"packages/studio/src/components/storyboard/StoryboardStatusLegend.tsx",
"packages/studio/src/components/storyboard/StoryboardView.tsx",
"packages/studio/src/components/storyboard/StoryboardViewModeGuard.test.tsx",
"packages/studio/src/components/storyboard/frameComments.test.ts",
"packages/studio/src/components/storyboard/frameComments.ts",
"packages/studio/src/components/storyboard/frameStatus.ts",
"packages/studio/src/components/storyboard/storyboardReviewStage.test.ts",
"packages/studio/src/components/storyboard/storyboardReviewStage.ts",
"packages/studio/src/components/storyboard/useFrameComments.ts",
"packages/studio/src/contexts/ViewModeContext.tsx",
"packages/studio/src/hooks/useProjectSignaturePoll.test.tsx",
"packages/studio/src/hooks/useProjectSignaturePoll.ts",
"packages/studio/src/hooks/useStoryboard.ts",
].map((path) => [path, STORYBOARD_VIEW_REASON]),
]);
export function parseBase(argv, fallback = "origin/main") {
const index = argv.indexOf(BASE_FLAG);
if (index === -1) return fallback;
const value = argv[index + 1];
if (!value || value.startsWith("-")) {
throw new Error(`${BASE_FLAG} needs a ref, for example ${BASE_FLAG} origin/main`);
}
return value;
}
/**
* Split a `--name-status` diff into deletions and renames.
*
* Git reports a rename as `R<score>\told\tnew`. Reading only the first column
* would file that under "deleted", which is the false alarm this guards
* against being noisy enough to ignore.
*/
// one branch per git status code
// fallow-ignore-next-line complexity
export function classify(nameStatus) {
const deleted = [];
const renamed = [];
for (const line of nameStatus.split("\n")) {
if (!line.trim()) continue;
const [status, ...paths] = line.split("\t");
if (status.startsWith("R")) renamed.push({ from: paths[0], to: paths[1] });
else if (status === "D") deleted.push(paths[0]);
}
return { deleted, renamed };
}
// a script entry point
// fallow-ignore-next-line complexity
function main() {
const base = parseBase(process.argv.slice(2));
let diff;
try {
diff = execFileSync("git", ["diff", "--name-status", "-M", `${base}...HEAD`], {
encoding: "utf8",
});
} catch (error) {
// An unreachable base is not a pass. Reporting "no deletions" because the
// ref was misspelled is the exact failure this exists to prevent.
console.error(`cannot diff against ${base}: ${error.message.trim()}`);
process.exit(2);
}
const { deleted: allDeleted, renamed } = classify(diff);
const agreed = allDeleted.filter((path) => ALLOWED_DELETIONS.has(path));
const deleted = allDeleted.filter((path) => !ALLOWED_DELETIONS.has(path));
if (agreed.length > 0) {
console.log(`${agreed.length} deletion(s) agreed in ALLOWED_DELETIONS:`);
for (const path of agreed) console.log(` ${path} — ${ALLOWED_DELETIONS.get(path)}`);
}
if (renamed.length > 0) {
console.log(`${renamed.length} renamed (allowed):`);
for (const { from, to } of renamed.slice(0, 10)) console.log(` ${from} -> ${to}`);
if (renamed.length > 10) console.log(` … and ${renamed.length - 10} more`);
}
if (deleted.length === 0) {
console.log(`No files from ${base} are deleted by this branch.`);
return;
}
console.error(`This branch deletes ${deleted.length} files that exist on ${base}:`);
for (const path of deleted.slice(0, 25)) console.error(` ${path}`);
if (deleted.length > 25) console.error(` … and ${deleted.length - 25} more`);
console.error("\nIf a deletion is intended, remove this check for that path deliberately.");
process.exit(1);
}
if (import.meta.url === `file://${process.argv[1]}`) main();